Re: [Xen-devel] [PATCH v5 04/28] vmap: Add vmalloc_cb and vfree_cb

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 18:44, wrote: > On Wed, Mar 30, 2016 at 10:24:41AM -0600, Jan Beulich wrote: >> >>> On 24.03.16 at 21:00, wrote: >> > @@ -266,16 +275,15 @@ void *vzalloc(size_t size) >> > return p; >> > } >> > >> > -void vfree(void *va) >> > +void vfree_cb(void *va, unsigned int pages,

Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 17:43, wrote: > Since they're all cosmetic, if you take care of all of them, feel free > to stick my ack on the result. Actually - no, please don't. While the patch is fine content wise then from my perspective, I'm still lacking a convincing argument of why this new hypercall

[Xen-devel] [PATCH v6 3/6] libxl: add query function for backend support by device model

2016-03-30 Thread Juergen Gross
Add a function to query whether the device model is supporting a specific backend type. The device model is writing the supported backend types to Xenstore on startup. The new query function checks for the appropriate entry to be present. As not all versions of qemu are capable to indicate support

[Xen-devel] [PATCH v6 4/6] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-30 Thread Juergen Gross
Add a new pvusb backend type "qusb" which is provided by qemu. It can be selected either by specifying the type directly in the configuration or it is selected automatically by libxl in case there is no "usbback" driver loaded. The "qusb" backend is a full replacement for the kernel based backend

[Xen-devel] [PATCH v6 5/6] libxl: add service function to check whether device model is running

2016-03-30 Thread Juergen Gross
Add an internal service function to check for a running device model. This can be used later when adding devices to a domain requiring a device model for either printing an error message or starting the device model in case it is not already running. Signed-off-by: Juergen Gross Acked-by: Wei Liu

[Xen-devel] [PATCH v6 2/6] libxl: make libxl__need_xenpv_qemu() operate on domain config

2016-03-30 Thread Juergen Gross
libxl__need_xenpv_qemu() is called with configuration data for console, vfbs, disks and channels today in order to evaluate the need for starting a device model for a pv domain. The console data is local to the caller and setup in a way to never require a device model. All other data is taken from

[Xen-devel] [PATCH v6 1/6] libxl: handle error from libxl__need_xenpv_qemu() correctly

2016-03-30 Thread Juergen Gross
In case libxl__need_xenpv_qemu() returns an error let domain creation fail. Signed-off-by: Juergen Gross --- V6: Add comment regarding return values of libxl__need_xenpv_qemu() as requested by Wei Liu --- tools/libxl/libxl_create.c | 7 --- tools/libxl/libxl_dm.c | 1 + 2 files chang

[Xen-devel] [PATCH v6 0/6] libxl: add support for qemu base pvusb backend

2016-03-30 Thread Juergen Gross
This patch series is meant to be applied on top of Chunyan's series to support pvusb in libxl. It is adding support for an alternative pvusb backend "qusb" via qemu. Changes in V6: - split patch 1 into 2 patches as requested by Wei Liu - patch 1: Add comment regarding return values of libxl__need

[Xen-devel] [PATCH v6 6/6] libxl: check for dynamic device model start required

2016-03-30 Thread Juergen Gross
Add a service routine checking whether a device model must be started after adding a device to a domain. Signed-off-by: Juergen Gross Acked-by: Ian Jackson --- tools/libxl/libxl.c | 12 tools/libxl/libxl_dm.c | 22 ++ tools/libxl/libxl_internal.h

[Xen-devel] [linux-mingo-tip-master test] 87975: regressions - FAIL

2016-03-30 Thread osstest service owner
flight 87975 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/87975/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 6 xen-build fail REGR. vs. 60684 test-amd64

Re: [Xen-devel] [PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service

2016-03-30 Thread Changlong Xie
I've checked all patches in this thread after Ian's comments, it seems we can give A-B to p12, p14, p20, p23, p25, p26 now. All in all, *all patches are acked-by*. Thanks -Xie On 03/25/2016 02:44 PM, Changlong Xie wrote: This patchset implemented the COLO feature for Xen. For detail/in

Re: [Xen-devel] [PATCH v13 25/26] setup and control colo proxy on secondary side

2016-03-30 Thread Changlong Xie
On 03/30/2016 10:24 PM, Ian Jackson wrote: Changlong Xie writes ("[PATCH v13 25/26] setup and control colo proxy on secondary side"): From: Wen Congyang Signed-off-by: Yang Hongyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie I think I acked this in v12. I guess you probabl

Re: [Xen-devel] [PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service

2016-03-30 Thread Wen Congyang
On 03/30/2016 10:50 PM, Ian Jackson wrote: > Changlong Xie writes ("[PATCH v13 00/26] COarse-grain LOck-stepping Virtual > Machines for Non-stop Service"): >> This patchset implemented the COLO feature for Xen. >> For detail/install/use of COLO feature, refer to: >> http://wiki.xen.org/wiki/COLO_-

[Xen-devel] [linux-4.1 test] 87967: regressions - trouble: blocked/broken/fail/pass

2016-03-30 Thread osstest service owner
flight 87967 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/87967/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 3 host-install(3) broken in 87395 REGR. vs. 66399 build-amd64-rumpuserxen

[Xen-devel] [libvirt test] 87976: tolerable FAIL - PUSHED

2016-03-30 Thread osstest service owner
flight 87976 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/87976/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-qcow2 13 guest-sav

[Xen-devel] [xen-unstable-smoke test] 88046: tolerable all pass - PUSHED

2016-03-30 Thread osstest service owner
flight 88046 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/88046/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

[Xen-devel] [xen-unstable test] 87908: regressions - FAIL

2016-03-30 Thread osstest service owner
flight 87908 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/87908/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 21 guest-migrate/src_host/dst_host fail REGR. vs. 86491 test-amd64-am

Re: [Xen-devel] [LKP] [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes

2016-03-30 Thread Luis R. Rodriguez
On Wed, Mar 30, 2016 at 1:29 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 30, 2016 at 01:10:29PM -0700, Luis R. Rodriguez wrote: > > Are you saying that you expect Xen maintainers to _NOT_ test Xen related > patches? Especially ones they have been involved with? Of course not, I'm saying we hav

Re: [Xen-devel] [LKP] [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes

2016-03-30 Thread Konrad Rzeszutek Wilk
On Wed, Mar 30, 2016 at 01:10:29PM -0700, Luis R. Rodriguez wrote: > On Wed, Mar 30, 2016 at 11:58 AM, Konrad Rzeszutek Wilk > wrote: > > On Wed, Mar 30, 2016 at 11:02:13AM -0700, Luis R. Rodriguez wrote: > >> On Tue, Mar 29, 2016 at 8:49 AM, Toshi Kani wrote: > >> > On Tue, 2016-03-29 at 10:46 -

Re: [Xen-devel] [LKP] [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes

2016-03-30 Thread Luis R. Rodriguez
On Wed, Mar 30, 2016 at 11:58 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 30, 2016 at 11:02:13AM -0700, Luis R. Rodriguez wrote: >> On Tue, Mar 29, 2016 at 8:49 AM, Toshi Kani wrote: >> > On Tue, 2016-03-29 at 10:46 -0400, Boris Ostrovsky wrote: >> >> On 03/29/2016 10:19 AM, Toshi Kani wrote:

[Xen-devel] [xen-unstable-smoke test] 88027: tolerable all pass - PUSHED

2016-03-30 Thread osstest service owner
flight 88027 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/88027/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

[Xen-devel] [PATCH] Extending XL console command to take -e option.

2016-03-30 Thread sabiya
By default, Character 0x1d i.e '^]' is used as escape character to terminate logging. Now,escape character can be passed with -escape option. It can be any printable character. As valid range for control character is first 32 characters(0-31d) lower 5 bits of given character will be used as escape

Re: [Xen-devel] [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes

2016-03-30 Thread Konrad Rzeszutek Wilk
On Wed, Mar 30, 2016 at 11:02:13AM -0700, Luis R. Rodriguez wrote: > On Tue, Mar 29, 2016 at 8:49 AM, Toshi Kani wrote: > > On Tue, 2016-03-29 at 10:46 -0400, Boris Ostrovsky wrote: > >> On 03/29/2016 10:19 AM, Toshi Kani wrote: > >> > On Tue, 2016-03-29 at 12:34 +0200, Ingo Molnar wrote: > >> > >

[Xen-devel] [ovmf test] 87936: regressions - FAIL

2016-03-30 Thread osstest service owner
flight 87936 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/87936/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 65543 test-amd64-amd64-xl-qemuu-ov

[Xen-devel] [xen-4.3-testing baseline-only test] 44285: regressions - trouble: blocked/broken/fail/pass

2016-03-30 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 44285 xen-4.3-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/44285/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-winxpsp3 15 guest-

Re: [Xen-devel] [PATCH 3/6] xentrace: P2M lookup suport for ARM platform

2016-03-30 Thread Julien Grall
On 28/03/16 19:55, Ben Sanda wrote: Julien and George, Hi Ben, Sorry for the late answer. Thank you for the comments. I had one question I wanted to ask. A DOMID_XEN page could be read only too. For instance, the meta-data of the trace buffer is read-only (see t_info), we don't want a doma

Re: [Xen-devel] [PATCH v3 0/7] Enhance PAT init to fix Xorg crashes

2016-03-30 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 8:49 AM, Toshi Kani wrote: > On Tue, 2016-03-29 at 10:46 -0400, Boris Ostrovsky wrote: >> On 03/29/2016 10:19 AM, Toshi Kani wrote: >> > On Tue, 2016-03-29 at 12:34 +0200, Ingo Molnar wrote: >> > >> > > > I'd appreciate if someone can test this patch-set on Xen to verify >>

Re: [Xen-devel] [PATCH v4 00/14] Load BIOS via toolstack instead of been embedded in hvmloader.

2016-03-30 Thread Jim Fehlig
Anthony PERARD wrote: > Hi all, > > Few changes in V4: > I leave the ACPI alone and only load the BIOS via libxl now. > > Detail of changes in each patches. > > I've look at loading the BIOS via the toolstack instead of having them > embedded > in the hvmloader binary. After this patch seri

Re: [Xen-devel] [PATCH 00/11] Return failure on failure for more xl commands

2016-03-30 Thread Paulina Szubarczyk
Yes, I was looking at wrong branch, I am sorry. The patches * {01-04,08,11} were not attached in the previous patch [0]. * {05,06} are applied in the version made by George Dunlap. I added the changes to return 0/1 in internal functions and EXIT_{SUCCESS/FAILURE} according to [2]. It certainl

[Xen-devel] [xen-unstable-smoke test] 88009: tolerable all pass - PUSHED

2016-03-30 Thread osstest service owner
flight 88009 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/88009/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

2016-03-30 Thread Fu Wei
Hi Julien, I have posted the v3 , please check http://lists.xen.org/archives/html/xen-devel/2016-03/msg03564.html And I hope GRUB patch can be merged :-) On 30 March 2016 at 23:52, Julien Grall wrote: > Hello, > > Ping? > > Regards, > > > On 19/02/16 16:28, Julien Grall wrote: >> >> Xen is curr

Re: [Xen-devel] [PATCH v5 3/5] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-30 Thread Juergen Gross
On 30/03/16 18:16, Wei Liu wrote: > On Wed, Mar 30, 2016 at 04:34:20PM +0200, Juergen Gross wrote: >> On 30/03/16 16:19, Wei Liu wrote: >>> On Wed, Mar 30, 2016 at 02:05:56PM +0200, Juergen Gross wrote: Add a new pvusb backend type "qusb" which is provided by qemu. It can be selected eith

Re: [Xen-devel] [PATCH v8 for Xen 4.7 3/4] libxl: enable per-VCPU parameter for RTDS

2016-03-30 Thread Dario Faggioli
On Fri, 2016-03-18 at 16:26 -0500, Chong Li wrote: > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > functions to support per-VCPU settings. > > Signed-off-by: Chong Li > Signed-off-by: Meng Xu > Signed-off-by: Sisu Xi > > --- > Changes on PATCH v7: > 1) Fix a mistake in sche

Re: [Xen-devel] [PATCH v8 20/21] xen/arm: Add a hypercall for device mmio mapping

2016-03-30 Thread Julien Grall
Hi, On 30/03/16 17:11, Konrad Rzeszutek Wilk wrote: On Wed, Mar 30, 2016 at 06:08:13PM +0800, Shannon Zhao wrote: From: Shannon Zhao It needs to map platform or amba device mmio to Dom0 on ARM. But when booting with ACPI, it can't get the mmio region in Xen due to lack of AML interpreter to p

Re: [Xen-devel] [PATCH v5 04/28] vmap: Add vmalloc_cb and vfree_cb

2016-03-30 Thread Konrad Rzeszutek Wilk
On Wed, Mar 30, 2016 at 10:24:41AM -0600, Jan Beulich wrote: > >>> On 24.03.16 at 21:00, wrote: > > @@ -266,16 +275,15 @@ void *vzalloc(size_t size) > > return p; > > } > > > > -void vfree(void *va) > > +void vfree_cb(void *va, unsigned int pages, vfree_cb_t *vfree_cb_fnc) > > Just to rep

Re: [Xen-devel] [Xen-users] different number of cpus

2016-03-30 Thread Dario Faggioli
On Tue, 2016-03-29 at 22:14 +, tutu sky wrote: > menuentry 'Ubuntu GNU/Linux, with Xen hypervisor' --class ubuntu -- > class gnu-linux --class gnu --class os --class xen > $menuentry_id_option 'xen-gnulinux-simple-d9e946b3-a4cf-4a90-8cdf- > 689d19a2b869' { > insmod part_msdos > insmod e

[Xen-devel] [linux-3.16 test] 87897: regressions - FAIL

2016-03-30 Thread osstest service owner
flight 87897 linux-3.16 real [real] http://logs.test-lab.xenproject.org/osstest/logs/87897/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 7 host-ping-check-xen fail REGR. vs. 85048 test-amd64-i386-libvir

Re: [Xen-devel] [PATCH v2 1/6] public/xen.h: add flags field to vcpu_time_info

2016-03-30 Thread Joao Martins
On 03/30/2016 04:49 PM, Ian Jackson wrote: > Joao Martins writes ("[PATCH v2 1/6] public/xen.h: add flags field to > vcpu_time_info"): >> This field has two possible flags (as of latest pvclock ABI >> shared with KVM). >> >> flags: bits in this field indicate extended capabilities >> coordinated b

Re: [Xen-devel] [PATCH] libxc: Document xc_domain_resume

2016-03-30 Thread Dario Faggioli
On Wed, 2016-03-30 at 11:10 -0400, Konrad Rzeszutek Wilk wrote: >  > --- a/tools/libxc/include/xenctrl.h > +++ b/tools/libxc/include/xenctrl.h > @@ -565,6 +565,58 @@ int xc_domain_destroy(xc_interface *xch, >  > + * HVM guest are the simplest - they suspend via S3 and resume from > + * S3. Upon res

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 2/2] tools: detect appropriate debug optimization level"): > My initial reaction is that I any actual problems are bugs either in > the compiler or in Xen, which should be fixed. > > There should be nothing wrong with lack of inlining or dead code > elimination. I

Re: [Xen-devel] [PATCH v5 04/28] vmap: Add vmalloc_cb and vfree_cb

2016-03-30 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > @@ -266,16 +275,15 @@ void *vzalloc(size_t size) > return p; > } > > -void vfree(void *va) > +void vfree_cb(void *va, unsigned int pages, vfree_cb_t *vfree_cb_fnc) Just to repeat: This "caller provides size" worries me, the more that this doesn't mirror

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread Doug Goldstein
On 3/30/16 11:00 AM, Ian Jackson wrote: > Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug > optimization level"): >> On 3/8/16 9:38 AM, Wei Liu wrote: >>> On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: The build should not use -O0 as that results in mi

Re: [Xen-devel] [PATCH v2] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Konrad Rzeszutek Wilk
On Wed, Mar 30, 2016 at 04:06:39PM +, Jonathan Davies wrote: > Commit 363ae55c8 used an OCaml feature called record field punning. This broke > the build on compilers prior to OCaml 3.12.0. > > This patch makes no semantic change but now uses backwards-compatible syntax. > > Signed-off-by: Jo

Re: [Xen-devel] [PATCH v5 3/5] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-30 Thread Wei Liu
On Wed, Mar 30, 2016 at 04:34:20PM +0200, Juergen Gross wrote: > On 30/03/16 16:19, Wei Liu wrote: > > On Wed, Mar 30, 2016 at 02:05:56PM +0200, Juergen Gross wrote: > >> Add a new pvusb backend type "qusb" which is provided by qemu. It can > >> be selected either by specifying the type directly in

[Xen-devel] [PATCH v4] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
Commit 57844631 "save APIC assist vector" added an extra field to the viridian vcpu context save record. This field was only a uint8_t and so an extra __pad field was also added to pad up to the next 64-bit boundary. This patch makes sure that __pad field is zeroed on save and checked for zero on

Re: [Xen-devel] [PATCH] libxc: Document xc_domain_resume

2016-03-30 Thread Konrad Rzeszutek Wilk
On Wed, Mar 30, 2016 at 05:01:34PM +0100, Wei Liu wrote: > On Wed, Mar 30, 2016 at 11:10:23AM -0400, Konrad Rzeszutek Wilk wrote: > > Document the save and suspend mechanism. > > > > Signed-off-by: Konrad Rzeszutek Wilk > > --- > > v2: Wei update on wording. > > I think you haven't addressed And

Re: [Xen-devel] [PATCH v8 20/21] xen/arm: Add a hypercall for device mmio mapping

2016-03-30 Thread Konrad Rzeszutek Wilk
On Wed, Mar 30, 2016 at 06:08:13PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > It needs to map platform or amba device mmio to Dom0 on ARM. But when > booting with ACPI, it can't get the mmio region in Xen due to lack of > AML interpreter to parse DSDT table. Therefore, let Dom0 call a >

Re: [Xen-devel] [PATCH v5 2/5] libxl: add query function for backend support by device model

2016-03-30 Thread Anthony PERARD
On Wed, Mar 30, 2016 at 03:26:23PM +0100, Wei Liu wrote: > On Wed, Mar 30, 2016 at 04:11:39PM +0200, Juergen Gross wrote: > > On 30/03/16 16:09, Wei Liu wrote: > > > On Wed, Mar 30, 2016 at 04:02:20PM +0200, Juergen Gross wrote: > > >> On 30/03/16 15:53, Wei Liu wrote: > > >>> On Wed, Mar 30, 2016

Re: [Xen-devel] [PATCH v5 03/28] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables lookup.

2016-03-30 Thread Jan Beulich
>>> On 24.03.16 at 21:00, wrote: > @@ -1077,27 +1080,33 @@ void do_unexpected_trap(const char *msg, struct > cpu_user_regs *regs) > > int do_bug_frame(struct cpu_user_regs *regs, vaddr_t pc) > { > -const struct bug_frame *bug; > +const struct bug_frame *bug = NULL; > const char *

Re: [Xen-devel] [PATCH] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Wei Liu
On Wed, Mar 30, 2016 at 03:47:34PM +, Jonathan Davies wrote: > Commit 363ae55c8 used an OCaml feature called record field punning. This broke > the build on compilers prior to OCaml 3.12.0. > > This patch makes no semantic change but now uses backwards-compatible syntax. > > Signed-off-by: Jo

Re: [Xen-devel] [PATCH 2/2] tools: detect appropriate debug optimization level

2016-03-30 Thread Ian Jackson
Doug Goldstein writes ("Re: [PATCH 2/2] tools: detect appropriate debug optimization level"): > On 3/8/16 9:38 AM, Wei Liu wrote: > > On Mon, Mar 07, 2016 at 08:23:40PM -0600, Doug Goldstein wrote: > >> The build should not use -O0 as that results in miscompilations. There > > > > This needs some

Re: [Xen-devel] [PATCH v5 2/5] libxl: add query function for backend support by device model

2016-03-30 Thread Anthony PERARD
On Wed, Mar 30, 2016 at 04:59:22PM +0100, Wei Liu wrote: > On Wed, Mar 30, 2016 at 04:55:42PM +0100, Anthony PERARD wrote: > > On Wed, Mar 30, 2016 at 03:26:23PM +0100, Wei Liu wrote: > > > On Wed, Mar 30, 2016 at 04:11:39PM +0200, Juergen Gross wrote: > > > > On 30/03/16 16:09, Wei Liu wrote: > >

Re: [Xen-devel] [PATCH v7 21/22] xen/arm: Add a hypercall for device mmio mapping

2016-03-30 Thread Konrad Rzeszutek Wilk
> +int map_dev_mmio_region(struct domain *d, > +unsigned long start_gfn, > +unsigned long nr, > +unsigned long mfn) > +{ > +int res; > + > +if ( !(nr && iomem_access_permitted(d, start_gfn, start_gfn + nr - 1)) ) > +

[Xen-devel] [PATCH v2] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Jonathan Davies
Commit 363ae55c8 used an OCaml feature called record field punning. This broke the build on compilers prior to OCaml 3.12.0. This patch makes no semantic change but now uses backwards-compatible syntax. Signed-off-by: Jonathan Davies Reported-by: Boris Ostrovsky Tested-by: Boris Ostrovsky ---

Re: [Xen-devel] [PATCH] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Jonathan Davies
On 30/03/2016 4:54 PM, Boris Ostrovsky wrote: > On 03/30/2016 11:47 AM, Jonathan Davies wrote: > > Commit 363ae55c8 used an OCaml feature called record field punning. > > This broke the build on compilers prior to OCaml 3.12.0. > > > > This patch makes no semantic change but now uses backwards-com

Re: [Xen-devel] [PATCH v7 21/22] xen/arm: Add a hypercall for device mmio mapping

2016-03-30 Thread Konrad Rzeszutek Wilk
On Fri, Mar 25, 2016 at 09:48:54PM +0800, Shannon Zhao wrote: > It needs to map platform or amba device mmio to Dom0 on ARM. But when > booting with ACPI, it can't get the mmio region in Xen due to lack of > AML interpreter to parse DSDT table. Therefore, let Dom0 call a > hypercall to map mmio reg

Re: [Xen-devel] [PATCH] libxc: Document xc_domain_resume

2016-03-30 Thread Wei Liu
On Wed, Mar 30, 2016 at 11:10:23AM -0400, Konrad Rzeszutek Wilk wrote: > Document the save and suspend mechanism. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > v2: Wei update on wording. I think you haven't addressed Andrew's comments. Maybe you missed it. I will take over this patch and addr

Re: [Xen-devel] [PATCH v2 1/6] public/xen.h: add flags field to vcpu_time_info

2016-03-30 Thread Ian Jackson
Joao Martins writes ("[PATCH v2 1/6] public/xen.h: add flags field to vcpu_time_info"): > This field has two possible flags (as of latest pvclock ABI > shared with KVM). > > flags: bits in this field indicate extended capabilities > coordinated between the guest and the hypervisor. Specifically

Re: [Xen-devel] [PATCH v5 2/5] libxl: add query function for backend support by device model

2016-03-30 Thread Wei Liu
On Wed, Mar 30, 2016 at 04:55:42PM +0100, Anthony PERARD wrote: > On Wed, Mar 30, 2016 at 03:26:23PM +0100, Wei Liu wrote: > > On Wed, Mar 30, 2016 at 04:11:39PM +0200, Juergen Gross wrote: > > > On 30/03/16 16:09, Wei Liu wrote: > > > > On Wed, Mar 30, 2016 at 04:02:20PM +0200, Juergen Gross wrote

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-30 Thread Jonathan Davies
On Tue, Mar 29, 2016 at 08:41:54PM +0100, David Scott wrote: > > > On 29 Mar 2016, at 17:38, Wei Liu wrote: > > > > On Tue, Mar 29, 2016 at 10:08:30AM +0100, Jonathan Davies wrote: > >> On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: > >>> On 03/24/2016 06:49 PM, Andrew Cooper w

Re: [Xen-devel] [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

2016-03-30 Thread Julien Grall
Hello, Ping? Regards, On 19/02/16 16:28, Julien Grall wrote: Xen is currently crashing because of malformed compatible property for the boot module. This is because the property string is not null-terminated as requested by the ePAR spec. --- grub-core/loader/arm64/xen_boot.c | 2 +- 1 file

Re: [Xen-devel] [PATCH] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Boris Ostrovsky
On 03/30/2016 11:47 AM, Jonathan Davies wrote: Commit 363ae55c8 used an OCaml feature called record field punning. This broke the build on compilers prior to OCaml 3.12.0. This patch makes no semantic change but now uses backwards-compatible syntax. Signed-off-by: Jonathan Davies Reviewed-by:

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-30 Thread Wei Liu
On Wed, Mar 30, 2016 at 04:46:58PM +0100, Jonathan Davies wrote: [...] > > >> Andrew's guess was close, but the wrong way around -- please could you > > >> try the > > >> following with the older compiler? > > >> > > >> let req = {Packet.tid=tid; Packet.rid=rid; Packet.ty=ty; > > >> Packet.data=

[Xen-devel] [PATCH] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Jonathan Davies
Commit 363ae55c8 used an OCaml feature called record field punning. This broke the build on compilers prior to OCaml 3.12.0. This patch makes no semantic change but now uses backwards-compatible syntax. Signed-off-by: Jonathan Davies Reviewed-by: Boris Ostrovsky --- tools/ocaml/xenstored/proce

Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-30 Thread Jan Beulich
>>> On 24.03.16 at 22:30, wrote: > From: Konrad Rzeszutek Wilk > Date: Tue, 22 Mar 2016 16:53:19 -0400 > Subject: [PATCH] HYPERCALL_version_op. New hypercall mirroring XENVER_ but > sane. > > This hypercall mirrors the XENVER_ in that it has similar functionality. > However it is designed diffe

Re: [Xen-devel] [RFC PATCH 2/2] build: convert crash_debug to Kconfig

2016-03-30 Thread Doug Goldstein
On 3/29/16 3:50 AM, Jan Beulich wrote: On 25.03.16 at 22:02, wrote: >> On 3/25/16 2:49 PM, Konrad Rzeszutek Wilk wrote: >>> On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote: --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -4,3 +4,14 @@ menuconfig DEBUG

Re: [Xen-devel] XEN 4.6.0 on arm64 Ubuntu Xenial 16.04: unable to start domU

2016-03-30 Thread Dario Faggioli
Adding some ARM folks. Please, do not use HTML when posting to this mailing list. Regards, Dario On Mon, 2016-03-28 at 00:48 -0500, Jiandi An wrote: > Hi guys,  >   > I built xen 4.6.0 from source on an arm64 system with Ubuntu 16.04 as > rootfs.  After booting to xen 4.6.0 dom0 with 4.2 kernel,

[Xen-devel] [TESTDAY] Test report of ARM CubieTruck with Xen 4.7 (staging)

2016-03-30 Thread Konrad Rzeszutek Wilk
*Hardware: ARM CubieTruck A20 (2GB). *Software: Linaro 14.04 with - Xen 4.7 (829e03c acpi: drop CONFIG_ACPI_BOOT and use CONFIG_ACPI instead + xsplice.v5) - Linux v4.5 (with revert of 88f8b1bb41c6208f81b6a480244533ded7b59493 " stmmac: Fix 'eth0: No PHY found' regression") - Linux v4.4 - L

Re: [Xen-devel] [RFC PATCH 1/2] build: add debug menu to Kconfig

2016-03-30 Thread Dario Faggioli
On Fri, 2016-03-25 at 15:59 -0500, Doug Goldstein wrote: > On 3/25/16 2:42 PM, Konrad Rzeszutek Wilk wrote: > >  > > > This is more of an RFC than a merge request. If this seems > > > reasonable I'll > > > add all the other debugging options under this menu as well. > > > Obviously if > > > this se

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 17:16, wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 30 March 2016 15:22 >> To: Paul Durrant >> Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) >> Subject: RE: [PATCH] x86/hvm/viridian: zero and check vcpu contex

Re: [Xen-devel] [PATCH v3] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan > Beulich > Sent: 30 March 2016 15:23 > To: Paul Durrant > Cc: Andrew Cooper; Keir (Xen.org); xen-de...@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH v3] x86/hvm/viridian: zero and chec

Re: [Xen-devel] [PATCH] x86/hvm/viridian: zero and check vcpu context __pad field

2016-03-30 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 30 March 2016 15:22 > To: Paul Durrant > Cc: Andrew Cooper; xen-de...@lists.xenproject.org; Keir (Xen.org) > Subject: RE: [PATCH] x86/hvm/viridian: zero and check vcpu context __pad > field > > >>> On 30.03.16 at 1

Re: [Xen-devel] [PATCH 00/11] Return failure on failure for more xl commands

2016-03-30 Thread Wei Liu
On Wed, Mar 30, 2016 at 05:02:39PM +0200, Paulina Szubarczyk wrote: > This patch includes the changes from a patch prepared by George Dunlap > [0] and expands them to more xl commands. > Hello, Did you perhaps make a mistake? As far as I can tell some patches were already applied. Don't worry, w

[Xen-devel] [GRUB2 PATCH v6 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-30 Thread Daniel Kiper
Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms when multiboot2 compatible image requests MULTIBOOT_TAG_TYPE_EFI_BS. Relocator will set lower parts of %rax and %rbx accordingly to multiboot2 specification. On the other hand processor mode, just before jumping into loaded

[Xen-devel] [PATCH] libxc: Document xc_domain_resume

2016-03-30 Thread Konrad Rzeszutek Wilk
Document the save and suspend mechanism. Signed-off-by: Konrad Rzeszutek Wilk --- v2: Wei update on wording. --- tools/libxc/include/xenctrl.h | 52 +++ 1 file changed, 52 insertions(+) diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenc

[Xen-devel] [PATCH 02/11] libxl_pci: clean an unused return variable

2016-03-30 Thread Paulina Szubarczyk
libxl_device_pci_assignable_list returns: - list of the libxl_device_pci - NULL in case of error or lack of devices the rc variable is unused as return code. Signed-off-by: Paulina Szubarczyk CC: Wei Liu CC: Ian Jackson CC: Dario Faggioli CC: Ian Campbell --- tools/libxl/libxl_pci.

[Xen-devel] [GRUB2 PATCH v6 4/4] multiboot2: Add support for relocatable images

2016-03-30 Thread Daniel Kiper
Currently multiboot2 protocol loads image exactly at address specified in ELF or multiboot2 header. This solution works quite well on legacy BIOS platforms. It is possible because memory regions are placed at predictable addresses (though I was not able to find any spec which says that it is strong

[Xen-devel] [GRUB2 PATCH v6 3/4 - FOR COMMIT] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-30 Thread Daniel Kiper
If image requested EFI boot services then skip multiboot2 memory maps. Main reason for not providing maps is because they will likely be invalid. We do a few allocations after filling them, e.g. for relocator needs. Usually we do not care as we would have finished boot services. If we keep boot ser

[Xen-devel] [GRUB2 PATCH v6 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-30 Thread Daniel Kiper
Add tags used to pass ImageHandle to loaded image if requested. It is used by at least ExitBootServices() function. Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk --- v4 - suggestions/fixes: - reduce number of #ifdefs in grub_multiboot_get_mbi_size() (suggested by Vladimi

[Xen-devel] [GRUB2 PATCH v6 0/4] multiboot2: Add two extensions

2016-03-30 Thread Daniel Kiper
Hi, This patch series: - enables EFI boot services usage in loaded images by multiboot2 protocol, - add support for multiboot2 protocol compatible relocatable images. Daniel grub-core/Makefile.core.def |1 + grub-core/lib/i386/relocator64.S | 11 grub-core/

[Xen-devel] [GRUB2 PATCH v6 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-30 Thread Daniel Kiper
If image requested EFI boot services then skip multiboot2 memory maps. Main reason for not providing maps is because they will likely be invalid. We do a few allocations after filling them, e.g. for relocator needs. Usually we do not care as we would have finished boot services. If we keep boot ser

[Xen-devel] [PATCH 11/11] libxl: libxl_tmem functions improving coding style

2016-03-30 Thread Paulina Szubarczyk
In accordance with CODING_SYTLE: - Use 'r' for return values to functions whose return values are a different error space (like xc_tmem_control, xc_tmem_auth) Signed-off-by: Paulina Szubarczyk CC: Wei Liu CC: Ian Jackson CC: Dario Faggioli CC: Ian Campbell --- tools/libxl/libxl.c | 58 +

[Xen-devel] [PATCH 09/11] libxl: Remove pointless hypercall from libxl_set_memory_target

2016-03-30 Thread Paulina Szubarczyk
There's no obvious reason for the call to xc_domain_getinfolist -- all it seems to be doing is checking that the domain exists; but if it doesn't exist, it will have already failed by this point. NB that this will change the return value for libxl_set_memory_target: now it will return 0 on success

[Xen-devel] [PATCH 07/11] xl: Return error codes for pci* commands

2016-03-30 Thread Paulina Szubarczyk
Add return codes for pci-detach, pci-attach, pci-asssignable-add, and pci-assignable-remove. Returning error codes makes it easier for shell scripts to tell if a command has failed or succeeded. NB this violates the CODING_STYLE preference for not initializing the return-value variable at declara

[Xen-devel] [PATCH 08/11] xl: improve main_tmem_* return codes

2016-03-30 Thread Paulina Szubarczyk
Functions libxl_tmem_freeze(), libxl_tmem_thaw(), libxl_tmem_set() and libxl_tmem_shared_auth() located in libxl.c file return ERROR_FAIL/ERROR_INVAL or internal error codes from libxc library * improve main_tmem_* return codes by returning EXIT_{SUCCESS/FAILURE} accordingly to return codes of th

[Xen-devel] [PATCH 05/11] xl: Make set_memory_target return an error code on failure

2016-03-30 Thread Paulina Szubarczyk
Change a 'long long' to "int64_t" while we're at it. Signed-off-by: George Dunlap Signed-off-by: Paulina Szubarczyk - Move rc -> shell return code translation into set_memory_{max,target} - Use EXIT_{SUCCESS,FAILURE} for main_mem*() function - Use 0/1 as return values of set_memory_{max,targ

[Xen-devel] [PATCH 06/11] xl: Return an error on failed cd-insert

2016-03-30 Thread Paulina Szubarczyk
This makes xl more useful in scripts. The strange thing about this is that the internal cd_insert function *already* returned something appropriate, and cd-eject was using it, but cd-insert wasn't. Also: * Rework cd_insert to return 0 or 1 as an internal function * Use EXIT_{SUCCESS,FAILURE} for

[Xen-devel] [PATCH 10/11] libxl: Fix libxl_set_memory_target return value

2016-03-30 Thread Paulina Szubarczyk
libxl_set_memory_target seems to have the following return values: * 1 on failure, if the failure happens because of a xenstore error *or* * invalid target * -1 if the setmaxmem hypercall * -errno if the set_pod_target hypercall target fails * 0 on success Make it consistently return ERROR_FAI

[Xen-devel] [PATCH 01/11] libxl_pci: improve return codes for more xl commands

2016-03-30 Thread Paulina Szubarczyk
Return error code instead of always 0. Remove assigned-only ret variable in libxl__create_pci_backend. Signed-off-by: Paulina Szubarczyk CC: Wei Liu CC: Ian Jackson CC: Dario Faggioli CC: Ian Campbell --- tools/libxl/libxl_pci.c | 8 ++-- 1 file changed, 2 insertions(+), 6 delet

[Xen-devel] [PATCH 04/11] xl: improve return code for freemem function

2016-03-30 Thread Paulina Szubarczyk
- Return 0 or 1 for freemem function - Correct the condition of checking return values of freemem. Signed-off-by: Paulina Szubarczyk CC: Wei Liu CC: Ian Jackson CC: Dario Faggioli CC: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 26 +++--- 1 file changed, 11 inser

[Xen-devel] [PATCH 03/11] libxl_pci: Return error code for more pci-* functions

2016-03-30 Thread Paulina Szubarczyk
Return rc value instead of always 0. Signed-off-by: Paulina Szubarczyk CC: Wei Liu CC: Ian Jackson CC: Dario Faggioli CC: Ian Campbell --- tools/libxl/libxl_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c in

[Xen-devel] [PATCH 00/11] Return failure on failure for more xl commands

2016-03-30 Thread Paulina Szubarczyk
This patch includes the changes from a patch prepared by George Dunlap [0] and expands them to more xl commands. This is my bite-sized outreachy project [1][2]. Return failure when the command failed for more xl commands: - mem-set - cd-insert - pci-* -- freemem -- tmem-* This makes xl more usef

Re: [Xen-devel] compilation fail, xen staging-4.6, vnc.c, qemu-tradintional issues under ubuntu 16.04

2016-03-30 Thread Dario Faggioli
Cc-ing some tools, Qemu, and Stubdom/MiniOS people, and dropping xen- users (Bcc-ed)... On Fri, 2016-03-25 at 18:53 +0100, Éliás Tamás wrote: > Hi. > > Previously I was using debian 8 to compile my xen 4.6 with hvm > stubdomain support. We recently switched to ubuntu servers, thus I > needed to c

Re: [Xen-devel] [PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service

2016-03-30 Thread Ian Jackson
Changlong Xie writes ("Re: [PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service"): > On 03/25/2016 11:51 PM, Wei Liu wrote: > > I went over those unacked patches. The major thing I found is that you > > didn't add in the warning text as Ian suggested. I've pointed out

Re: [Xen-devel] [PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service

2016-03-30 Thread Ian Jackson
Changlong Xie writes ("[PATCH v13 00/26] COarse-grain LOck-stepping Virtual Machines for Non-stop Service"): > This patchset implemented the COLO feature for Xen. > For detail/install/use of COLO feature, refer to: > http://wiki.xen.org/wiki/COLO_-_Coarse_Grain_Lock_Stepping > > You can get the c

Re: [Xen-devel] [PATCH] blktap2: Invalid logic detecting unaligned buffers in vhd_write_block

2016-03-30 Thread Ross Philipson
On 03/29/2016 07:26 AM, George Dunlap wrote: > On Fri, Mar 25, 2016 at 4:34 PM, Ross Philipson > wrote: >> On 03/25/2016 12:11 PM, Wei Liu wrote: >>> On Thu, Mar 17, 2016 at 06:10:59PM -0400, Ross Philipson wrote: It seems the logic is meant to detect sector unaligned buffers for block w

Re: [Xen-devel] [PATCH v13.1 23/26] COLO nic: implement COLO nic subkind

2016-03-30 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH v13.1 23/26] COLO nic: implement COLO nic subkind"): Sorry, this mail was unclear. I meant to refer to this: > Changlong Xie writes ("[PATCH v13.1 23/26] COLO nic: implement COLO nic > subkind"): > > From 699f20d46fcce0bcce8fd7f7063551088a425254 Mon Sep 17 00:0

Re: [Xen-devel] [PATCH v13.1 20/26] Support colo mode for qemu disk

2016-03-30 Thread Ian Jackson
Changlong Xie writes ("[PATCH v13.1 20/26] Support colo mode for qemu disk"): > From 468ff9fb2f6699314c28f30a7d7d09eac9aa6756 Mon Sep 17 00:00:00 2001 > From: Wen Congyang > Date: Mon, 21 Mar 2016 15:38:30 +0800 > Subject: [PATCH v13.1 20/26] Support colo mode for qemu disk I found a proper copy

Re: [Xen-devel] [PATCH v3 5/4] x86: reduce code size of struct cpu_info member accesses

2016-03-30 Thread Jan Beulich
>>> On 30.03.16 at 16:28, wrote: > On Tue, Mar 29, 2016 at 12:59:24AM -0600, Jan Beulich wrote: >> >>> On 25.03.16 at 19:47, wrote: >> > On Thu, Mar 17, 2016 at 10:14:22AM -0600, Jan Beulich wrote: >> > >> > Something is off with your patch. This is 5/4 :-) >> >> Well, yes - this got added late

Re: [Xen-devel] [PATCH v13.1 26/26] cmdline switches and config vars to control colo-proxy

2016-03-30 Thread Ian Jackson
Changlong Xie writes ("[PATCH v13.1 26/26] cmdline switches and config vars to control colo-proxy"): > From 1bfd14622455635c6cae6130396250996e49facc Mon Sep 17 00:00:00 2001 > From: Wen Congyang > Date: Wed, 15 Jul 2015 17:18:56 +0800 > Subject: [PATCH v13.1 26/26] cmdline switches and config va

  1   2   >