Re: [Xen-devel] [PATCH v8.1 19/27] xsplice: Add support for alternatives

2016-04-20 Thread Jan Beulich
>>> On 21.04.16 at 02:31, wrote: >> >--- a/xen/common/xsplice.c >> >+++ b/xen/common/xsplice.c >> >@@ -533,6 +533,39 @@ static int prepare_payload(struct payload *payload, >> >} >> > >> >#ifndef CONFIG_ARM >> >+sec = xsplice_elf_sec_by_name(elf, ".altinstructions"); >> >+if ( sec )

Re: [Xen-devel] [PATCH v8.1 19/27] xsplice: Add support for alternatives

2016-04-20 Thread Jan Beulich
>>> On 21.04.16 at 02:30, wrote: > On Wed, Apr 20, 2016 at 12:28:02AM -0600, Jan Beulich wrote: >> >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> >> >--- a/xen/arch/x86/Makefile >> >+++ b/xen/arch/x86/Makefile >> >@@ -6,7 +6,11 @@ subdir-y += mm >> >subdir-$(CONFIG_XENOPROF) += oprofile >> >su

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-20 Thread Jan Beulich
>>> On 21.04.16 at 02:29, wrote: > On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote: >> >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> >> >+bool_t is_patch(const void *ptr) >> >+{ >> >+struct payload *data; >> >> You guess it: const. >> >> >+/* >> >+ * No locking since t

Re: [Xen-devel] [PATCH v8.1 14/27] xsplice, symbols: Implement symbol name resolution on address.

2016-04-20 Thread Jan Beulich
>>> On 21.04.16 at 02:26, wrote: >> >+unsigned long xsplice_symbols_lookup_by_name(const char *symname) >> >+{ >> >+struct payload *data; >> >> Do you need symbols other than those marked "new_symbol" past the loading >> of the module? If not, wouldn't it be worthwhile to shrink the symbol ta

Re: [Xen-devel] [PATCH v8.1 12/27] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-20 Thread Jan Beulich
>>> On 21.04.16 at 02:28, wrote: >> >+ASSERT(sec); >> >+if ( sec->sec->sh_size % sizeof(*payload->funcs) ) >> >+{ >> >+dprintk(XENLOG_ERR, XSPLICE "%s: Wrong size of .xsplice.funcs!\n", >> >+elf->name); >> >+return -EINVAL; >> >+} >> >+ >> >+payl

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Jan Beulich
>>> On 20.04.16 at 19:36, wrote: > On Apr 20, 2016 6:05 PM, "Jan Beulich" wrote: >> >> >>> Konrad Rzeszutek Wilk 04/20/16 6:00 PM >>> >> >> >+ size_t pages; /* Total pages for [text,rw,ro]_addr */ >> >> >> >> Why size_t and not just unsigned int? >> > >> >Oh. I was somehow under the impression y

[Xen-devel] [PATCH] x86/xen: suppress hugetlbfs in PV guests

2016-04-20 Thread Jan Beulich
Huge pages are not normally available to PV guests. Not suppressing hugetlbfs use results in an endless loop of page faults when user mode code tries to access a hugetlbfs mapped area (since the hypervisor denies such PTEs to be created, but error indications can't be propagated out of xen_set_pte_

Re: [Xen-devel] [PATCH v2] x86/HVM: fix forwarding of internally cached requests

2016-04-20 Thread Jan Beulich
>>> On 30.03.16 at 09:28, wrote: > 2016-03-29 18:39 GMT+08:00 Jan Beulich : >> Forwarding entire batches to the device model when an individual >> iteration of them got rejected by internal device emulation handlers >> with X86EMUL_UNHANDLEABLE is wrong: The device model would then handle >> all i

[Xen-devel] [PATCH v2] xen/arm: domain_build: Add PSCI 1.0 compatibility

2016-04-20 Thread Dirk Behme
Xen needs to blacklist any PSCI node as it will be recreated for DOM0. Up to now, this was done only for arm,psci and arm,psci-0.2 compatible nodes. Add PSCI 1.0 compatibility to make device tree nodes with compatible = "arm,psci-1.0"; blacklisted, too Signed-off-by: Dirk Behme --- xen/arch/ar

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-04-20 Thread Haozhong Zhang
On 04/12/16 16:45, Haozhong Zhang wrote: > On 04/08/16 09:52, Jan Beulich wrote: > > >>> On 08.04.16 at 07:02, wrote: > > > On 03/29/16 04:49, Jan Beulich wrote: > > >> >>> On 29.03.16 at 12:10, wrote: > > >> > On 03/29/16 03:11, Jan Beulich wrote: > > >> >> >>> On 29.03.16 at 10:47, wrote: > >

Re: [Xen-devel] [PATCH] xenaccess: minor fixes and extra printouts

2016-04-20 Thread Razvan Cojocaru
On 04/21/16 03:39, Tamas K Lengyel wrote: > Without specifying the altp2m flag on the response the view never got > switched. > Also, add extra information printouts that can be useful during debugging. > > Signed-off-by: Tamas K Lengyel > --- > Cc: Razvan Cojocaru > Cc: Ian Jackson > Cc: Wei

[Xen-devel] [qemu-mainline test] 92167: regressions - trouble: broken/fail/pass

2016-04-20 Thread osstest service owner
flight 92167 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/92167/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 3 host-install(3) broken REGR. vs. 92071 test-armhf-armh

[Xen-devel] [xen-4.3-testing test] 92180: trouble: blocked/broken/pass

2016-04-20 Thread osstest service owner
flight 92180 xen-4.3-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/92180/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 3 host-install(3) broken REGR. vs. 878

Re: [Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-20 Thread Peng Fan
Hi Julien, On Wed, Apr 20, 2016 at 03:44:09PM +0100, Julien Grall wrote: >Hello Peng, > >On 20/04/16 14:54, Peng Fan wrote: >>Use shift operator, but not muliplication. >>No function change. > >Why? The compiler will calculate the address at compilation time. Yeah. The compiler will do this. I ju

[Xen-devel] [PATCH] xenaccess: minor fixes and extra printouts

2016-04-20 Thread Tamas K Lengyel
Without specifying the altp2m flag on the response the view never got switched. Also, add extra information printouts that can be useful during debugging. Signed-off-by: Tamas K Lengyel --- Cc: Razvan Cojocaru Cc: Ian Jackson Cc: Wei Liu --- tools/tests/xen-access/xen-access.c | 10 ++

[Xen-devel] [linux-4.1 test] 92143: tolerable FAIL - PUSHED

2016-04-20 Thread osstest service owner
flight 92143 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/92143/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds15 guest-start/debian.repeat fail blocked in 91350 test-armhf-armhf-xl-xsm 15

Re: [Xen-devel] [PATCH v8.1 20/27] build_id: Provide ld-embedded build-ids

2016-04-20 Thread Konrad Rzeszutek Wilk
On Wed, Apr 20, 2016 at 01:14:17AM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 04/14/16 12:03 AM >>> > >--- a/Config.mk > >+++ b/Config.mk > >@@ -126,6 +126,17 @@ endef > >check-$(gcc) = $(call cc-ver-check,CC,0x040100,"Xen requires at least > gcc-4.1") > >$(eval $(check-y)) > > > >+

Re: [Xen-devel] [PATCH v8.1 19/27] xsplice: Add support for alternatives

2016-04-20 Thread Konrad Rzeszutek Wilk
> >--- a/xen/common/xsplice.c > >+++ b/xen/common/xsplice.c > >@@ -533,6 +533,39 @@ static int prepare_payload(struct payload *payload, > >} > > > >#ifndef CONFIG_ARM > >+sec = xsplice_elf_sec_by_name(elf, ".altinstructions"); > >+if ( sec ) > >+{ > >+struct alt_instr *a,

Re: [Xen-devel] [PATCH v8.1 19/27] xsplice: Add support for alternatives

2016-04-20 Thread Konrad Rzeszutek Wilk
On Wed, Apr 20, 2016 at 12:28:02AM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> > >--- a/xen/arch/x86/Makefile > >+++ b/xen/arch/x86/Makefile > >@@ -6,7 +6,11 @@ subdir-y += mm > >subdir-$(CONFIG_XENOPROF) += oprofile > >subdir-y += x86_64 > > > >+ifdef CONFIG_XSP

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.

2016-04-20 Thread Konrad Rzeszutek Wilk
On Tue, Apr 19, 2016 at 02:17:35PM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 04/14/16 12:02 AM >>> > >+bool_t is_patch(const void *ptr) > >+{ > >+struct payload *data; > > You guess it: const. > > >+/* > >+ * No locking since this list is only ever changed during apply or

Re: [Xen-devel] [PATCH v8.1 12/27] xsplice: Implement support for applying/reverting/replacing patches.

2016-04-20 Thread Konrad Rzeszutek Wilk
> >+static int prepare_payload(struct payload *payload, > >+ struct xsplice_elf *elf) > >+{ > >+const struct xsplice_elf_sec *sec; > >+unsigned int i; > >+struct xsplice_patch_func_internal *f; > > Why is there a second ("internal") variant of this structure n

Re: [Xen-devel] [PATCH v8.1 14/27] xsplice, symbols: Implement symbol name resolution on address.

2016-04-20 Thread Konrad Rzeszutek Wilk
> >+unsigned long xsplice_symbols_lookup_by_name(const char *symname) > >+{ > >+struct payload *data; > > Do you need symbols other than those marked "new_symbol" past the loading > of the module? If not, wouldn't it be worthwhile to shrink the symbol table > to just > those, likely speeding

[Xen-devel] [ovmf test] 92168: regressions - FAIL

2016-04-20 Thread osstest service owner
flight 92168 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/92168/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 65543 test-amd64-i386-xl-qemuu-ovm

[Xen-devel] [xen-unstable-smoke test] 92192: tolerable all pass - PUSHED

2016-04-20 Thread osstest service owner
flight 92192 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/92192/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13

[Xen-devel] [linux-3.14 test] 92141: trouble: blocked/broken/fail/pass

2016-04-20 Thread osstest service owner
flight 92141 linux-3.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/92141/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-raw3 host-install(3) broken REGR. vs. 91148 R

Re: [Xen-devel] [PATCH v3 7/7] libxl: libxl_tmem functions improving coding style

2016-04-20 Thread Olaf Hering
On Wed, Apr 20, Paulina Szubarczyk wrote: > In accordance with CODING_SYTLE: > - Use 'r' for return values to functions whose return values are a >different error space (like xc_tmem_control, xc_tmem_auth) > > libxc functions are supposed to, on failure, set errno and alwas return -1 > whic

Re: [Xen-devel] [PATCH v3 6/7] libxl: Fix libxl_set_memory_target return value

2016-04-20 Thread Olaf Hering
On Wed, Apr 20, Paulina Szubarczyk wrote: > libxl_set_memory_target seems to have the following return values: > > * 1 on failure, if the failure happens because of a xenstore error *or* > * invalid target > > * -1 if the setmaxmem hypercall > > * -errno if the set_pod_target hypercall target f

Re: [Xen-devel] [PATCH v3 3/7] xl_cmdimpl: improve return codes for cd-insert commands

2016-04-20 Thread Olaf Hering
On Wed, Apr 20, Paulina Szubarczyk wrote: > - Use EXIT_{SUCCESS,FAILURE} for main_cd*() function > - Use 0/1 as return values of cd_insert function > > Signed-off-by: Paulina Szubarczyk > Acked-by: Roger Pau Monné Reviewed-by: Olaf Hering ___ Xe

Re: [Xen-devel] [PATCH v3 1/7] libxl: improve return codes for some pci related functions

2016-04-20 Thread Olaf Hering
On Wed, Apr 20, Paulina Szubarczyk wrote: > *libxl__device_from_pcidev() initialize the values of libxl__device > struct and can be void. > -static int libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid, > +static void libxl__device_from_pcidev(libxl__gc *gc, uint32_t domid, >

Re: [Xen-devel] [PATCH v3 2/7] libxl: style cleanups in libxl_device_pci_assignable_list()

2016-04-20 Thread Olaf Hering
On Wed, Apr 20, Paulina Szubarczyk wrote: > @@ -398,34 +398,34 @@ libxl_device_pci > *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num) > dir = opendir(SYSFS_PCIBACK_DRIVER); > +while((de = readdir(dir))) { > -closedir(dir); This change seems to leak 'dir' in success case

[Xen-devel] [xen-unstable-smoke test] 92184: tolerable all pass - PUSHED

2016-04-20 Thread osstest service owner
flight 92184 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/92184/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13

Re: [Xen-devel] Xen Memory de-duplication

2016-04-20 Thread Tamas K Lengyel
On Apr 20, 2016 12:34, "Dario Faggioli" wrote: > > On Wed, 2016-04-20 at 10:25 -0600, Tamas K Lengyel wrote: > > > > > > On Wed, Apr 20, 2016 at 7:24 AM, Wei Liu wrote: > > > On Tue, Apr 19, 2016 at 07:07:01AM -0400, Maryam Masoudian wrote: > > > > Thanks. > > > > One more thing, is it possible t

Re: [Xen-devel] Xen Memory de-duplication

2016-04-20 Thread Dario Faggioli
On Wed, 2016-04-20 at 10:25 -0600, Tamas K Lengyel wrote: > > > On Wed, Apr 20, 2016 at 7:24 AM, Wei Liu wrote: > > On Tue, Apr 19, 2016 at 07:07:01AM -0400, Maryam Masoudian wrote: > > > Thanks. > > > One more thing, is it possible to see the percentage of shared > > memory among > > > VMs by x

[Xen-devel] [linux-3.18 test] 92139: regressions - FAIL

2016-04-20 Thread osstest service owner
flight 92139 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/92139/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 15 guest-localmigrate/x10 fail REGR. vs. 91757 Regressions

[Xen-devel] [HACKATHON] Toolstack session

2016-04-20 Thread Roger Pau Monné
Toolstack session = Topics: - Build system - Stubdom - Testing - {o/c}xenstored Wei: what downstream consumers expect from the build system. Xen has a top level makefile that builds everything, by pulling other projects source code. Trying to make it cleaner. George: someo

Re: [Xen-devel] [PATCH v2] docs: add misc/qemu-backends.txt

2016-04-20 Thread Wei Liu
On Wed, Apr 20, 2016 at 03:02:25PM +0100, Wei Liu wrote: > On Tue, Apr 12, 2016 at 03:03:15PM +0100, Wei Liu wrote: > > On Mon, Apr 11, 2016 at 03:04:09PM +0200, Juergen Gross wrote: > > > Document the interface between qemu and libxl regarding backends > > > supported by qemu. > > > > > > Signed-

Re: [Xen-devel] [PATCH] tools/xenstat: handle network interface name in uppercase.

2016-04-20 Thread Wei Liu
On Wed, Apr 20, 2016 at 04:12:59PM +0100, Wei Liu wrote: > On Wed, Apr 20, 2016 at 10:16:35AM -0400, Zhigang Wang wrote: > > xentop will segmentation fault in this case: > > > > # ip link set eth1 down > > # ip link set eth1 name ETH > > # xentop > > > > This patch will let xentop to handle

[Xen-devel] [xen-unstable-smoke test] 92171: tolerable all pass - PUSHED

2016-04-20 Thread osstest service owner
flight 92171 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/92171/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl 12 migrate-support-checkfail never pass test-armhf-armhf-xl 13

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Konrad Rzeszutek Wilk
On Apr 20, 2016 6:05 PM, "Jan Beulich" wrote: > > >>> Konrad Rzeszutek Wilk 04/20/16 6:00 PM >>> > >> >+ size_t pages; /* Total pages for [text,rw,ro]_addr */ > >> > >> Why size_t and not just unsigned int? > > > >Oh. I was somehow under the impression you liked size_t more than > >unsignged int!

[Xen-devel] [HACKATHON] PVH session note

2016-04-20 Thread Wei Liu
* HVMlite domu support, some emulation in hypervisor, some modes to consider: | lapic | ioapic | pit | pic | hpet | pm timer | rtc | comments | |---++-+-+--+--+-+--| | n | n | n | n | n| n| n |0 | | y | n | n

[Xen-devel] [HACKATHON] libxl refactoring session note

2016-04-20 Thread Wei Liu
* Auto generate device handling routines Libxl has a lot of PV drivers. And the number is increasing at the moment. GlobalLogic has some customised drivers. The code plumbing is painful. Libxl already has IDL to describe the device interface and uses scripts to generate a lot of files. Propose

[Xen-devel] [HACKATHON] libxl storage plugin session note

2016-04-20 Thread Wei Liu
* Background Jon: XenServer has had plugin storage architecture / model for some time. Try to invent new plugin model to not deeply embedded in XenServer. It needs to work on standard Xen installation. Early in the process, need to define APIs. Look into integrate with libxl. * Data path plugi

[Xen-devel] [HACKATHON] xSplice session note

2016-04-20 Thread Wei Liu
* Signature verification Code bloat to verify all sort of sigs. Limit to two types of sigs Verify in hypervisor seems to be the only way. What extra security provides? It ensure binaries you get is from the vendor. Can do in userspace in Dom0? Questionable, even Linux doesn't trust modul

[Xen-devel] [HACKATHON] Data path and tapdisk3 session note

2016-04-20 Thread Wei Liu
Data path and tapdisk 3 * Stop using block protocol for Windows, status of pvscsi Windows 8 (10?) scsi only -- PV driver fakes a scsi device and translates. Propose to use pvscsi in the data path. Juergen: pvscsi is on track, no script provided in tree. but there is script available. planning t

Re: [Xen-devel] Reducing the Number of Context-Sensitive Macros in x86_emulate.c

2016-04-20 Thread Andrew Cooper
On 20/04/16 17:42, John McDermott wrote: > Xen Developers, > > Would there be any interest in replacing some of the > context-sensitive macros in x86_emulate.c, to make it more > maintainable? > > I work on the Xenon project, which researches ways to transform > Xen into a higher-security hyperviso

[Xen-devel] [linux-linus test] 92125: regressions - FAIL

2016-04-20 Thread osstest service owner
flight 92125 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/92125/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-rumpuserxen6 xen-build fail REGR. vs. 59254 test-amd64-amd64-xl-c

Re: [Xen-devel] [PATCH for-4.7 1/5] build: make HOSTCC conditional on the value of clang

2016-04-20 Thread Jan Beulich
>>> Roger Pau Monné 04/20/16 4:51 PM >>> >On Sun, Apr 17, 2016 at 02:03:28PM -0600, Jan Beulich wrote: >> >>> Roger Pau Monne 04/15/16 8:27 PM >>> >> >@@ -50,8 +49,10 @@ DESTDIR ?= / >> >clang ?= n >> >ifeq ($(clang),n) >> >gcc := y >> >+HOSTCC = gcc >> >else >> >gcc := n >> >+HOSTCC = c

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread Paul Durrant
> -Original Message- > From: George Dunlap [mailto:george.dun...@citrix.com] > Sent: 20 April 2016 18:07 > To: Paul Durrant; Jan Beulich; Wei Liu; yu.c.zh...@linux.intel.com > Cc: Kevin Tian; Keir (Xen.org); Andrew Cooper; Tim (Xen.org); xen- > de...@lists.xen.org; zhiyuan...@intel.com; jun

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread George Dunlap
On Wed, Apr 20, 2016 at 5:52 PM, Jan Beulich wrote: >>If it's the case that the only code that uses this is in XenServer, >>then I'd say the answer to #1 can be simply, "Don't compile" and >>"Don't do that" respectively; and the answer to #2 can be either >>"Leave it be" or "Remove the enum from t

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread George Dunlap
On 20/04/16 17:58, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan >> Beulich >> Sent: 20 April 2016 17:53 >> To: George Dunlap; Paul Durrant; Wei Liu; yu.c.zh...@linux.intel.com >> Cc: Kevin Tian; Keir (Xen.org); Andrew

Re: [Xen-devel] [PATCH v8.1 13/27] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

2016-04-20 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/20/16 6:10 PM >>> >> >+.PHONY: xsplice >> >+xsplice: config.h >> >+ # Need to have these done in sequential order >> >+ $(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world_func.o >> >+ $(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world.o >> >> Why do these two need doing

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/20/16 6:00 PM >>> >> >+ size_t pages; /* Total pages for [text,rw,ro]_addr */ >> >> Why size_t and not just unsigned int? > >Oh. I was somehow under the impression you liked size_t more than >unsignged int! I will change it over. When used where actually talking abou

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-20 Thread George Dunlap
On Wed, Apr 20, 2016 at 5:30 PM, Paul Durrant wrote: >> In any case, is it really not the case that the devicemodels on the >> far side have to re-register which IO ranges they're interested in? >> Shouldn't the devicemodel on the far side re-register the pfns it >> wants to watch as well? That a

Re: [Xen-devel] [PATCH v8.1 10/27] xsplice: Add helper elf routines

2016-04-20 Thread Jan Beulich
>>> Konrad Rzeszutek Wilk 04/20/16 6:09 PM >>> >On Mon, Apr 18, 2016 at 12:23:26AM -0600, Jan Beulich wrote: >> >>> Konrad Rzeszutek Wilk 04/18/16 7:55 AM >>> >> >> >+ if ( delta > elf->len ) >> >> >+ { >> >> >+ dprintk(XENLOG_ERR, XSPLICE "%s: Section table is past end of >> >> >payload!\n", >>

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan > Beulich > Sent: 20 April 2016 17:53 > To: George Dunlap; Paul Durrant; Wei Liu; yu.c.zh...@linux.intel.com > Cc: Kevin Tian; Keir (Xen.org); Andrew Cooper; Tim (Xen.org); xen- > de...@lists.xe

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread Jan Beulich
>>> George Dunlap 04/20/16 6:30 PM >>> >On Wed, Apr 20, 2016 at 4:02 PM, George Dunlap >wrote: >> On 19/04/16 12:02, Yu, Zhang wrote: >>> So I suppose the only place we need change for this patch is >>> for hvmmem_type_t, which should be defined like this? >>> >>> typedef enum { >>> HVMMEM_r

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-20 Thread Jan Beulich
>>> Julien Grall 04/20/16 2:35 PM >>> >It is a matter of taste. Indeed. > Is there any reason to not allow different way to create a mask? I dislike it, but not so much to stand in the way to get it in. I.e. I'm not going to NAK it, but I'm also not currently planning to ACK it. Jan ___

[Xen-devel] Reducing the Number of Context-Sensitive Macros in x86_emulate.c

2016-04-20 Thread John McDermott
Xen Developers, Would there be any interest in replacing some of the context-sensitive macros in x86_emulate.c, to make it more maintainable? I work on the Xenon project, which researches ways to transform Xen into a higher-security hypervisor. One of the things we do is modify Xen code to make i

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread George Dunlap
On Wed, Apr 20, 2016 at 4:02 PM, George Dunlap wrote: > On 19/04/16 12:02, Yu, Zhang wrote: >> >> >> On 4/19/2016 12:58 AM, Paul Durrant wrote: -Original Message- From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan Beulich Sent: 18 April 2016

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-20 Thread Paul Durrant
> -Original Message- > From: George Dunlap > Sent: 20 April 2016 16:38 > To: Paul Durrant > Cc: Yu, Zhang; Kevin Tian; jun.nakaj...@intel.com; Andrew Cooper; Tim > (Xen.org); xen-devel@lists.xen.org; Lv, Zhiyuan; Jan Beulich > Subject: Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HV

Re: [Xen-devel] Xen Memory de-duplication

2016-04-20 Thread Tamas K Lengyel
On Wed, Apr 20, 2016 at 7:24 AM, Wei Liu wrote: > On Tue, Apr 19, 2016 at 07:07:01AM -0400, Maryam Masoudian wrote: > > Thanks. > > One more thing, is it possible to see the percentage of shared memory > among > > VMs by xl tool? > > As there is a xl sharing and I want to know whether this provid

Re: [Xen-devel] [PATCH v8.1 13/27] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

2016-04-20 Thread Konrad Rzeszutek Wilk
> >+.PHONY: xsplice > >+xsplice: config.h > >+# Need to have these done in sequential order > >+$(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world_func.o > >+$(MAKE) -f $(BASEDIR)/Rules.mk xen_hello_world.o > > Why do these two need doing in order? And why can't $(XSPLICE) not just depend

Re: [Xen-devel] [PATCH v8.1 10/27] xsplice: Add helper elf routines

2016-04-20 Thread Konrad Rzeszutek Wilk
On Mon, Apr 18, 2016 at 12:23:26AM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 04/18/16 7:55 AM >>> > >> >+ if ( delta > elf->len ) > >> >+ { > >> >+ dprintk(XENLOG_ERR, XSPLICE "%s: Section table is past end of > >> >payload!\n", > >> >+ elf->name); > >> >+ return -EINVAL; > >> >+ } >

Re: [Xen-devel] [PATCH v8.1 11/27] xsplice: Implement payload loading

2016-04-20 Thread Konrad Rzeszutek Wilk
> >+void arch_xsplice_free_payload(void *va) > >+{ > >+vfree_xen(va); > >+} > > What is the idea behind having this hook (instead of generic code just calling > vfree_xen() [or really just vfree()])? To have an symmetry with the allocation one. I don't know enough about ARM to know whether th

Re: [Xen-devel] [PULL for-2.6 0/1] tags/xen-2016-04-20

2016-04-20 Thread Peter Maydell
On 20 April 2016 at 12:14, Stefano Stabellini wrote: > The following changes since commit 42bb626f7ebc9197d2943b897a99e127315275ab: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2016-04-12 09:34:52 +0100) > > are available in the git repository at:

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-20 Thread George Dunlap
On Wed, Apr 20, 2016 at 3:57 PM, Paul Durrant wrote: >> -Original Message- >> From: George Dunlap >> Sent: 20 April 2016 15:50 >> To: Yu, Zhang >> Cc: Paul Durrant; xen-devel@lists.xen.org; Kevin Tian; Jan Beulich; Andrew >> Cooper; Tim (Xen.org); Lv, Zhiyuan; jun.nakaj...@intel.com >> Sub

Re: [Xen-devel] [PATCH] tools/xenstat: handle network interface name in uppercase.

2016-04-20 Thread Wei Liu
On Wed, Apr 20, 2016 at 10:16:35AM -0400, Zhigang Wang wrote: > xentop will segmentation fault in this case: > > # ip link set eth1 down > # ip link set eth1 name ETH > # xentop > > This patch will let xentop to handle all uppercase network interface name. > > Signed-off-by: Zhigang Wang

Re: [Xen-devel] [PATCH for-4.7 0/5] build: fixes for building Xen with clang

2016-04-20 Thread Roger Pau Monné
On Sun, Apr 17, 2016 at 04:02:02AM -0600, Jan Beulich wrote: > >>> Roger Pau Monne 04/15/16 8:29 PM >>> > >I've also noticed that Xen always sets "-no-integrated-as" when using clang, > >because previous versions (<3.8.0) didn't support .code16/.code32/.code64 > >in inline asm. This is solved at l

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread Wei Liu
On Tue, Apr 19, 2016 at 10:51:14AM -0600, Jan Beulich wrote: > >>> "Yu, Zhang" 04/19/16 1:46 PM >>> > >On 4/19/2016 7:15 PM, Paul Durrant wrote: > >> I talked to Wei earlier and he is happy to give a freeze exception to this > >> change. > > > >Great! I really obliged. :) > >BTW, Does some form o

Re: [Xen-devel] [PATCH v2 2/3] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server

2016-04-20 Thread George Dunlap
On 19/04/16 12:02, Yu, Zhang wrote: > > > On 4/19/2016 12:58 AM, Paul Durrant wrote: >>> -Original Message- >>> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of >>> Jan >>> Beulich >>> Sent: 18 April 2016 17:47 >>> To: Paul Durrant >>> Cc: Kevin Tian; Keir (Xen.org);

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-20 Thread Paul Durrant
> -Original Message- > From: George Dunlap > Sent: 20 April 2016 15:50 > To: Yu, Zhang > Cc: Paul Durrant; xen-devel@lists.xen.org; Kevin Tian; Jan Beulich; Andrew > Cooper; Tim (Xen.org); Lv, Zhiyuan; jun.nakaj...@intel.com > Subject: Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HV

Re: [Xen-devel] [PATCH v2 3/3] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server

2016-04-20 Thread George Dunlap
On Tue, Apr 19, 2016 at 12:59 PM, Yu, Zhang wrote: >>> So what about the VM suspend case you mentioned above? Will that trigger >>> the unmapping of ioreq server? Could the device model also take the role >>> to change the p2m type back in such case? >> >> >> Yes. The device model has to be told b

Re: [Xen-devel] [PATCH for-4.7 1/5] build: make HOSTCC conditional on the value of clang

2016-04-20 Thread Roger Pau Monné
On Sun, Apr 17, 2016 at 02:03:28PM -0600, Jan Beulich wrote: > >>> Roger Pau Monne 04/15/16 8:27 PM >>> > >Previously HOSTCC was always hardcoded to gcc > > So what is the goal here? Be able to build on a gcc-free system? Or else, how > does it matter what compiler build elements get built with?

Re: [Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-20 Thread Julien Grall
Hello Peng, On 20/04/16 14:54, Peng Fan wrote: Use shift operator, but not muliplication. No function change. Why? The compiler will calculate the address at compilation time. Regards, Signed-off-by: Peng Fan Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/arm64/head.S | 2 +-

Re: [Xen-devel] [PATCH] Fix cpumap setting before passing to XEN

2016-04-20 Thread Wei Liu
Sorry I was at the Xen hackathon in the last two days. On Tue, Apr 12, 2016 at 11:35:20AM +0800, Zhenzhong Duan wrote: > 在 2016/4/11 19:27, Wei Liu 写道: > >On Mon, Apr 11, 2016 at 09:42:57AM +0800, Zhenzhong Duan wrote: > >>It's tool's duty to pass a correct cpumap to XEN. On a host with less than

[Xen-devel] [PATCH] tools/xenstat: handle network interface name in uppercase.

2016-04-20 Thread Zhigang Wang
xentop will segmentation fault in this case: # ip link set eth1 down # ip link set eth1 name ETH # xentop This patch will let xentop to handle all uppercase network interface name. Signed-off-by: Zhigang Wang --- tools/xenstat/libxenstat/src/xenstat_linux.c | 7 +-- 1 file changed, 5

[Xen-devel] [ovmf test] 92128: regressions - FAIL

2016-04-20 Thread osstest service owner
flight 92128 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/92128/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 65543 test-amd64-i386-xl-qemuu-ovm

Re: [Xen-devel] [PATCH v2] docs: add misc/qemu-backends.txt

2016-04-20 Thread Wei Liu
On Tue, Apr 12, 2016 at 03:03:15PM +0100, Wei Liu wrote: > On Mon, Apr 11, 2016 at 03:04:09PM +0200, Juergen Gross wrote: > > Document the interface between qemu and libxl regarding backends > > supported by qemu. > > > > Signed-off-by: Juergen Gross > > Reviewed-by: Wei Liu > Release-acked-b

[Xen-devel] [PATCH 1/2] xen/arm64: correct comments

2016-04-20 Thread Peng Fan
The 'Base address for 4K mapping' is '(x19 >> THIRD_SHIFT) << THIRD_SHIFT'. Also we are building 4K page mapping, not section mapping. Signed-off-by: Peng Fan Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/arm64/head.S | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

[Xen-devel] [PATCH 2/2] xen/arm64: use shift operator

2016-04-20 Thread Peng Fan
Use shift operator, but not muliplication. No function change. Signed-off-by: Peng Fan Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/arm64/head.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 05e3db0..

Re: [Xen-devel] [PATCH v2] docs: add misc/qemu-backends.txt

2016-04-20 Thread Juergen Gross
On 11/04/16 15:04, Juergen Gross wrote: > Document the interface between qemu and libxl regarding backends > supported by qemu. > > Signed-off-by: Juergen Gross Anyone to commit this, please? Juergen > --- > v2: - replace variable Xenstore path parts () with bash-like syntax > ($XYZ) as

Re: [Xen-devel] [PATCH 0/3] adjust error return values for cpupool operations

2016-04-20 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 0/3] adjust error return values for cpupool operations"): > In principle I agree we need better semantics and documentation of this > hypercall, and because this is new code so it's risk free, so: > > Release-acked-by: Wei Liu > > I will leave this series for Ian t

Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread David Vrabel
On 20/04/16 13:08, Bob Liu wrote: > > > The "feature-data-integrity" could be extended to "unsigned int" instead of > "bool", > so as to report all DIX formats backend supports. I think it would be preferable to have something string based. I think Linux reports the formats using a string enco

Re: [Xen-devel] [PATCH] tools/libxc: Correct use of X86_XSS_MASK in guest xstate generation

2016-04-20 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH] tools/libxc: Correct use of X86_XSS_MASK in guest xstate generation"): > On Tue, Apr 19, 2016 at 06:27:05PM +0100, Andrew Cooper wrote: > > Submitted-from: A punt, on the Cam, during the the hackathon, because. > > Acked-by: Wei Liu > Release-acked-by: Wei Liu > >

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Add PSCI 1.0 compatibility

2016-04-20 Thread Julien Grall
Hello Dirk, On 20/04/16 14:32, Dirk Behme wrote: Add PSCI 1.0 compatibility strings to make Xen behave correctly with device trees having compatible = "arm,psci-1.0"; You need to explain in the commit message what is the correct behavior. I.e Xen needs to blacklist any PSCI 1.0 node as it wi

Re: [Xen-devel] [PATCH] [[for-4.7]] libxl: fix old style declarations

2016-04-20 Thread Ian Jackson
Wei Liu writes ("[PATCH] [[for-4.7]] libxl: fix old style declarations"): > Fix errors like: > > /local/work/xen.git/dist/install/usr/local/include/libxl_uuid.h:59:1: error: > 'static' is not at beginning of declaration [-Werror=old-style-declaration] > void static inline libxl_uuid_copy_0x04040

[Xen-devel] [PATCH] xen/arm: domain_build: Add PSCI 1.0 compatibility

2016-04-20 Thread Dirk Behme
Add PSCI 1.0 compatibility strings to make Xen behave correctly with device trees having compatible = "arm,psci-1.0"; Signed-off-by: Dirk Behme --- xen/arch/arm/domain_build.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index a

Re: [Xen-devel] [libvirt test] 91597: regressions - FAIL

2016-04-20 Thread Wei Liu
On Mon, Apr 18, 2016 at 11:04:39AM -0600, Jim Fehlig wrote: > On 04/16/2016 05:54 AM, osstest service owner wrote: > > flight 91597 libvirt real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/91597/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > > inclu

Re: [Xen-devel] [PATCH 2/2] xen: arm64: doc: Add some details about interrupt handling

2016-04-20 Thread Julien Grall
Hello Dirk, On 19/04/16 06:59, Dirk Behme wrote: In some mailing list discussion http://lists.xen.org/archives/html/xen-devel/2016-04/msg00214.html some details about the interrupt handling of Xen were given. Add that so it's not forgotten. For your information, this is described on the wiki

Re: [Xen-devel] Xen Memory de-duplication

2016-04-20 Thread Wei Liu
On Tue, Apr 19, 2016 at 07:07:01AM -0400, Maryam Masoudian wrote: > Thanks. > One more thing, is it possible to see the percentage of shared memory among > VMs by xl tool? > As there is a xl sharing and I want to know whether this provides this > facility ... > Not sure. You can check xl manpage

Re: [Xen-devel] [PATCH 1/2] xen: arm64: doc: Add the requirement that SCR_EL3.HCE is enabled

2016-04-20 Thread Julien Grall
(CC REST maintainers) Hello Dirk, Please CC the relevant maintainers for this patch. You can use scripts/get_maintainers.pl for this purpose. On 19/04/16 06:59, Dirk Behme wrote: On ARM64 Linux the HVC instruction is used to trap into Xen. As this can be set only at EL3, i.e. outside from Xe

Re: [Xen-devel] [PATCH v8 02/25] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op

2016-04-20 Thread Ross Lagerwall
On 04/13/2016 10:09 PM, Konrad Rzeszutek Wilk wrote: snip +static int xsplice_action(xen_sysctl_xsplice_action_t *action) +{ +struct payload *data; +char n[XEN_XSPLICE_NAME_SIZE]; +int rc; + +rc = verify_name(&action->name, n); +if ( rc ) +return rc; + +spin_lock(&

[Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-20 Thread Stefano Stabellini
b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of legacy interrupts when actually nr_legacy_irqs() returns 0 after probe_8259A(). Use NR_IRQS_LEGACY instead. Signed-off-by: Stefano Stabellini diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index beac4df..349b8ce 10

Re: [Xen-devel] [PATCH v8.1 14/27] xsplice, symbols: Implement symbol name resolution on address.

2016-04-20 Thread Ross Lagerwall
On 04/19/2016 08:31 PM, Jan Beulich wrote: snip +ASSERT(spin_is_locked(&payload_lock)); +list_for_each_entry ( data, &payload_list, list ) +{ +unsigned int i; + +for ( i = 0; i < data->nsyms; i++ ) +{ +if ( !data->symtab[i].new_symbol ) +

Re: [Xen-devel] [PATCH v3 2/5] xentrace: Memory/Page Mapping support for DOMID_XEN on ARM

2016-04-20 Thread Julien Grall
On 14/04/16 20:52, Ben Sanda wrote: Julien, George, Andrew, and Stefano, Hello Ben, Sorry for the late answer, we were at the Xen hackathon. Thank you for the explanation. The ARM implementation of share_xen_page_with_guest is nearly the same as the x86 one. However, the type is never use

[Xen-devel] [linux-mingo-tip-master test] 92124: regressions - FAIL

2016-04-20 Thread osstest service owner
flight 92124 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/92124/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-xsm 15 guest-localmigratefail REGR. vs. 60684 build-i386

Re: [Xen-devel] [for-4.7 1/2] xen/bitops: Introduce macros to generate mask

2016-04-20 Thread Julien Grall
Hi Jan, On 14/04/16 16:23, Jan Beulich wrote: Julien Grall 04/14/16 5:08 PM >>> On 14/04/16 15:56, Jan Beulich wrote: Julien Grall 04/14/16 10:55 AM >>> On 14/04/2016 05:01, Jan Beulich wrote: Julien Grall 04/13/16 6:01 PM >>> --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h

Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread Bob Liu
On 04/20/2016 04:59 PM, David Vrabel wrote: > On 20/04/16 08:26, Bob Liu wrote: >> >> /* >> + * Recognized only if "feature-data-integrity" is present in backend xenbus >> info. >> + * A request with BLKIF_OP_DIX_FLAG indicates the following request is a >> special >> + * request which only con

Re: [Xen-devel] [PATCH] tools/xenstat: handle network interface name in uppercase.

2016-04-20 Thread Wei Liu
I wasn't CC'ed so this fled my attention. On Fri, Mar 11, 2016 at 03:18:01PM -0500, Zhigang Wang wrote: > xentop will segmentation fault in this case: > > # ip link set eth1 down > # ip link set eth1 name ETH > # xentop > > This patch will let xentop to handle all uppercase network interfa

Re: [Xen-devel] [PATCH] monitor: Rename vm_event_monitor_get_capabilities to arch_monitor_get_capabilities

2016-04-20 Thread Julien Grall
Hi Jan, On 20/04/16 12:26, Jan Beulich wrote: Tamas K Lengyel 04/14/16 6:34 PM >>> +static inline uint32_t arch_monitor_get_capabilities(struct domain *d) +{ +uint32_t capabilities = 0; Pointless initializer. +capabilities = (1U << XEN_DOMCTL_MONITOR_EVENT_GUEST_REQUEST); + +re

  1   2   >