The function flush_tlb_domain is not used outside of the file where it
has been declared.
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
Changes in v2:
- Add Stefano's reviewed-by
---
xen/arch/arm/p2m.c | 2 +-
xen/include/asm-arm/flushtlb.h | 3 ---
2
The function to flush the TLBs for a given p2m does not need to know about
the domain. So pass directly the p2m in parameter.
At the same time rename the function to p2m_flush_tlb to match the
parameter change.
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
Changes in v2:
Some p2m functions do not care about the domain except to get the
associate p2m.
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
Changes in v2:
- Add Stefano's reviewed-by
---
xen/arch/arm/p2m.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
Hello all,
This patch series contains a bunch of clean-up and fixes for the P2M code on
ARM. The major changes are:
- Deduce the memory attributes from the p2m type
- Switch to read-write lock to improve performance
- Simplify the TLB flush for a give p2m
For all the changes see in ea
The function p2m_restore_state could be called with an idle vCPU in
arguments (when called by construct_dom0). However, we will never return
to EL0/EL1 in this case, so it is not necessary to restore the p2m
registers.
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
Changes
The field vttbr holds the base address of the translation table for
guest. Its value will depends on how the p2m has been initialized and
will only be used by the P2M code.
So move the field from arch_domain to p2m_domain. This will also ease
the implementation of altp2m.
Signed-off-by: Julien Gr
Currently, mfn_to_p2m_entry is relying on the caller to provide the
correct memory attribute and will deduce the sharability based on it.
Some of the callers, such as p2m_create_table, are using same memory
attribute regardless the underlying p2m type. For instance, this will
lead to use change th
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
Changes in v2:
- Compute the mfn at every loop rather than incrementing
- Add Stefano's reviewed-by
---
xen/arch/arm/p2m.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/xen/a
Some functions in the p2m code do not require to modify the P2M code.
Document it by introducing separate helpers to lock the p2m.
This patch does not change the lock. This will be done in a subsequent
patch.
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
Changes in v2:
p2m_restore_state is the last caller of p2m_load_VTTBR and already check
if the vCPU does not belong to the idle domain.
Note that it is likely possible to remove some isb in the function
p2m_restore_state, however this is not the purpose of this patch. So the
numerous isb have been left.
Signed-
The p2m root table does not need to be allocate separately.
Also remove unnecessary fields initialization as the structure is already
memset to 0 and the fields will be overridden by p2m_alloc_table.
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
Changes in v2:
- R
The current implementation of flush_tlb_domain is relying on the domain
to have a single p2m. With the upcoming feature altp2m, a single domain
may have different p2m. So we would need to switch to the correct p2m in
order to flush the TLBs.
Rather than checking whether the domain is not the curre
Currently, the check in get_page_from_gfn is using a blacklist. This is
very fragile because we may forgot to update the check when a new p2m
type is added.
To avoid any possible issue, use a whitelist. All type backed by a RAM
page can could potential be valid. The check is borrowed from x86.
No
P2M reads do not require to be serialized. This will add contention
when PV drivers are using multi-queue because parallel grant
map/unmaps/copies will happen on DomU's p2m.
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
---
I have not done benchark to verify the performance, h
li...@ssl-mail.com writes:
> On Wed, Jul 27, 2016, at 11:36 AM, li...@ssl-mail.com wrote:
>> On Wed, Jul 27, 2016, at 11:28 AM, Andrew Cooper wrote:
>> > > I'm not sure if that's good enough.
>> >
>> > Sadly not. The debug symbols need to be specific to the exact binary
>> > you booted.
>> >
>>
On 28/07/16 11:50, Anthony PERARD wrote:
> ... and do not include the OVMF ROM into hvmloader anymore.
>
> Signed-off-by: Anthony PERARD
> Acked-by: Jan Beulich
Reviewed-by: Andrew Cooper
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lis
On 28/07/16 11:50, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD
> Reviewed-by: Konrad Rzeszutek Wilk
> Acked-by: Jan Beulich
Reviewed-by: Andrew Cooper
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 28/07/16 11:50, Anthony PERARD wrote:
> ... and do not include the SeaBIOS ROM into hvmloader anymore.
>
> This also fix the dependency on roms.inc, hvmloader.o does not include it.
>
> Signed-off-by: Anthony PERARD
> Acked-by: Jan Beulich
Reviewed-by: Andrew Cooper
On 28/07/16 11:50, Anthony PERARD wrote:
> As perform_tests() is going to clear memory past 4MB, we check that the
> memory can be use or we skip the tests.
>
> Signed-off-by: Anthony PERARD
This is a loosing battle of overlap checks, and they are far less useful
than they used to be if they are
flight 99713 xen-4.7-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/99713/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemut-debianhvm-amd64-xsm 3 host-install(3) broken REGR.
vs. 96660
test-amd6
On 28/07/16 11:50, Anthony PERARD wrote:
> @@ -293,8 +340,17 @@ int main(void)
> }
>
> printf("Loading %s ...\n", bios->name);
> -if ( bios->bios_load )
> -bios->bios_load(bios);
> +bios_module = get_module_entry(hvm_start_info, "firmware");
> +if ( bios_module && bi
libxl_set_memory_target() and several other interface functions of
libxl use a 32 bit sized parameter for a memory size value in kBytes.
This limits the maximum size to be passed in such a parameter
depending on signedness of the parameter to 2TB or 4TB.
Correct this by using 64 bit types.
Signed
On 28/07/16 11:50, Anthony PERARD wrote:
> Instead of having several representation of hvm_start_info in C, define
> it in public/arch-x86/hvm/start_info.h so both libxc and hvmloader can
> use it.
>
> Also move the comment describing the binary format to be alongside the
> C struct.
>
> Signed-off
On Thu, 2016-07-28 at 14:48 +0200, Juergen Gross wrote:
> On 28/07/16 14:11, Dario Faggioli wrote:
> >
> > > +static int libxl__memkb_32to64(libxl_ctx *ctx, int rc,
> > > + uint64_t val64, uint32_t *ptr32)
> > > +{
> > > +GC_INIT(ctx);
> > > +
> > > +if (rc)
On 28/07/16 14:11, Dario Faggioli wrote:
> On Fri, 2016-07-22 at 08:53 +0200, Juergen Gross wrote:
>> libxl_set_memory_target() and several other interface functions of
>> libxl use a 32 bit sized parameter for a memory size value in kBytes.
>> This limits the maximum size to be passed in such a pa
On 2016年07月28日 19:06, Julien Grall wrote:
> On 26/07/16 02:17, Boris Ostrovsky wrote:
>> On 07/25/2016 07:40 PM, Stefano Stabellini wrote:
>>> On Mon, 25 Jul 2016, Boris Ostrovsky wrote:
On 07/25/2016 06:06 PM, Stefano Stabellini wrote:
> On Mon, 25 Jul 2016, George Dunlap wrote:
>> On
flight 99712 xen-4.5-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/99712/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemuu-win7-amd64 3 host-install(3) broken REGR. vs. 96516
test-amd64-amd64-
On Fri, 2016-07-22 at 08:53 +0200, Juergen Gross wrote:
> libxl_set_memory_target() and several other interface functions of
> libxl use a 32 bit sized parameter for a memory size value in kBytes.
> This limits the maximum size to be passed in such a parameter
> depending on signedness of the param
On Thu, Jul 28, 2016 at 11:54:27AM +0100, Andrew Cooper wrote:
> On 28/07/16 11:43, George Dunlap wrote:
> > On Thu, Jul 28, 2016 at 11:18 AM, Anthony PERARD
> > wrote:
> >> On Wed, Jul 27, 2016 at 03:45:23PM -0400, Boris Ostrovsky wrote:
> >>> On 07/27/2016 07:35 AM, Anthony PERARD wrote:
>
flight 99745 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/99745/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-debianhvm-i386 12 guest-saverestore fail REGR. vs.
99707
Tests whi
Hi Dirk,
On 27/07/16 06:05, Dirk Behme wrote:
Hi Michael, Stefano and Julien,
On 22.07.2016 03:16, Stefano Stabellini wrote:
On Thu, 21 Jul 2016, Michael Turquette wrote:
Quoting Stefano Stabellini (2016-07-14 03:38:04)
On Thu, 14 Jul 2016, Dirk Behme wrote:
On 13.07.2016 23:03, Michael Tur
... to compile SeaBIOS and OVMF. Only depend on CONFIG_*.
If --with-system-* configure option is used, then set *_CONFIG=n to not
compile SEABIOS and OVMF.
Signed-off-by: Anthony PERARD
Reviewed-by: Konrad Rzeszutek Wilk
Acked-by: Wei Liu
---
Please, run ./autogen.sh on this patch.
No change
Signed-off-by: Anthony PERARD
Acked-by: Jan Beulich
---
tools/firmware/hvmloader/Makefile| 11 +--
tools/firmware/hvmloader/hvmloader.c | 4
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/tools/firmware/hvmloader/Makefile
b/tools/firmware/hvmloader/Makefile
ind
... and do not include the OVMF ROM into hvmloader anymore.
Signed-off-by: Anthony PERARD
Acked-by: Jan Beulich
---
Change in V5:
- define OVMF_END macro
- fix some cast coding style
Change in V4:
- check if source and dest of ovmf binary does not overlaps
Change in V3:
- change makefile to n
All BIOSes but ROMBIOS needs to be loaded via modules.
ROMBIOS is handled as a special case.
Signed-off-by: Anthony PERARD
Acked-by: Jan Beulich
---
Change in V5:
- rename patch, was:
"hvmloader: Specific bios_load function required"
No change in V4.
Change in V3:
- reprint Main BIOS in bi
The C struct in the document is no more in sync with the actual
definition of the PVHv2 boot start info.
Signed-off-by: Anthony PERARD
---
CC: Roger Pau Monne
New patch in V7.
---
docs/misc/hvmlite.markdown | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git
... and do not include the SeaBIOS ROM into hvmloader anymore.
This also fix the dependency on roms.inc, hvmloader.o does not include it.
Signed-off-by: Anthony PERARD
Acked-by: Jan Beulich
---
Change in V6:
acked
Change in V5:
- update BUG_ON in seabios_setup_e820().
Change in V4:
- check
Hi Shannon,
Sorry for the late answer.
On 25/07/16 08:56, Shannon Zhao wrote:
On 2016/7/20 17:32, Wei Liu wrote:
On Wed, Jul 20, 2016 at 02:52:05PM +0800, Shannon Zhao wrote:
On 2016/7/19 18:38, Wei Liu wrote:
On Fri, Jul 15, 2016 at 05:39:32PM +0800, Shannon Zhao wrote:
[...]
It would
Hi,
On 26/07/16 02:17, Boris Ostrovsky wrote:
On 07/25/2016 07:40 PM, Stefano Stabellini wrote:
On Mon, 25 Jul 2016, Boris Ostrovsky wrote:
On 07/25/2016 06:06 PM, Stefano Stabellini wrote:
On Mon, 25 Jul 2016, George Dunlap wrote:
On Thu, Jul 21, 2016 at 10:15 PM, Stefano Stabellini
wrote:
On 28/07/16 11:43, George Dunlap wrote:
> On Thu, Jul 28, 2016 at 11:18 AM, Anthony PERARD
> wrote:
>> On Wed, Jul 27, 2016 at 03:45:23PM -0400, Boris Ostrovsky wrote:
>>> On 07/27/2016 07:35 AM, Anthony PERARD wrote:
On Wed, Jul 27, 2016 at 12:08:04PM +0100, Anthony PERARD wrote:
> I can
This patch use xc_dom_alloc_segment() to allocate the memory space for the
ACPI modules and the SMBIOS modules. This is to replace the arbitrary
placement of 1MB (+ extra for MB alignement) after the hvmloader image.
This patch can help if one add extra ACPI table and hvmloader contain
OVMF (OVMF
Hi all,
Changes in V7:
- There is one new patch at the end to fix the doc.
- Patch 6 as been change.
that's it.
There is just a few missing ackes:
6 xen: Move the hvm_start_info C representation from libxc to public/xen.h
8 hvmloader: Locate the BIOS blob
9 hvmloader: Check mo
Signed-off-by: Anthony PERARD
Reviewed-by: Konrad Rzeszutek Wilk
Acked-by: Jan Beulich
---
Changes in V6:
- include xen/arch-x86/hvm/start_info.h
Change in V4:
- remove struct hvm_info_start redefinition, as it's moved to
public/xen.h in a previous patch.
Change in V3:
- remove cmdline pars
Instead of having several representation of hvm_start_info in C, define
it in public/arch-x86/hvm/start_info.h so both libxc and hvmloader can
use it.
Also move the comment describing the binary format to be alongside the
C struct.
Signed-off-by: Anthony PERARD
---
Changes in V7:
- also move th
The BIOS blob can be found an entry called "firmware" of the modlist of
the hvm_start_info struct.
The found BIOS blob is not loaded by this patch, but only passed as
argument to bios_load() function.
Signed-off-by: Anthony PERARD
---
Changes in V6:
- cast addresses to uintptr_t instead of uint
The path to the BIOS blob can be overriden by the xl's
bios_path_override option, or provided by u.hvm.bios_firmware in the
domain_build_info struct by other libxl user.
Signed-off-by: Anthony PERARD
Acked-by: Wei Liu
---
Changes in V6:
- use goto for error handling of libxl__load_hvm_firmware_
... and load BIOS/UEFI firmware into guest memory.
This adds a new firmware module, system_firmware_module. It is loaded in
the guest memory and final location is provided to hvmloader via the
hvm_start_info struct.
This patch create the hvm_start_info struct for HVM guest that have a
device mode
Those paths are to be used by libxl, in order to load the firmware in
memory. If a system path is not defined via --with-system-seabios or
--with-system-ovmf, then default to the Xen firmware directory.
Signed-off-by: Anthony PERARD
Reviewed-by: Konrad Rzeszutek Wilk
Acked-by: Wei Liu
---
Plea
... into the firmware directory, along with hvmloader.
Signed-off-by: Anthony PERARD
Acked-by: Wei Liu
---
No change in V6.
- acked
Change in V5:
- remove use of "variable" for SEABIOS_ROM and OVMF_ROM location
there are static location
- install seabios as bios.bin instead of seabios.bin
Ch
As perform_tests() is going to clear memory past 4MB, we check that the
memory can be use or we skip the tests.
Signed-off-by: Anthony PERARD
---
Changes in V6:
- define and use TEST_START and PT_END.
- cast addresses to uintptr_t instead of uint32_t.
- use UINTPTR_MAX for upper limit checks, in
On Thu, Jul 28, 2016 at 11:18 AM, Anthony PERARD
wrote:
> On Wed, Jul 27, 2016 at 03:45:23PM -0400, Boris Ostrovsky wrote:
>> On 07/27/2016 07:35 AM, Anthony PERARD wrote:
>> > On Wed, Jul 27, 2016 at 12:08:04PM +0100, Anthony PERARD wrote:
>> >> I can try to describe how OVMF is setting up the me
On Wed, Jul 27, 2016 at 03:45:23PM -0400, Boris Ostrovsky wrote:
> On 07/27/2016 07:35 AM, Anthony PERARD wrote:
> > On Wed, Jul 27, 2016 at 12:08:04PM +0100, Anthony PERARD wrote:
> >> I can try to describe how OVMF is setting up the memory.
> > From the start of the day:
> > setup gdt
> > cr0 = 0
FYI:
The Xen Project Security Team is aware of the talk scheduled at the
Black Hat conference, titled "Ouroboros: Tearing Xen Hypervisor with
the Snake".
We have received enquiries, asking whether there is an outstanding
vulnerability.
Our understanding is that this talk describes the problem wh
On Wed, Jul 27, 2016 at 04:01:26PM -0400, Chris Patterson wrote:
> From: Chris Patterson
>
> GCC 6 will warn on unused static const variables in c modules:
> https://gcc.gnu.org/ml/gcc-patches/2015-09/msg00847.html
>
> When compiling with LIBXL_HAVE_NO_SUSPEND_RESUME set (arm & aarch64),
> the c
On Thu, Jul 28, 2016 at 09:21:43AM +0200, Juergen Gross wrote:
> Commit d2412fd63b14c6c21d0a3d4367afa448425dfb8a ("libxl: move common
> nic stuff into one source") introduced a double free error in libxl
> which occurred during "xl save".
>
> Correct this error.
>
> Signed-off-by: Juergen Gross
On 27/07/16 04:21, Bob Liu wrote:
> The current VBD layer reserves buffer space for each attached device based on
> three statically configured settings which are read at boot time.
> * max_indirect_segs: Maximum amount of segments.
> * max_ring_page_order: Maximum order of pages to be used for t
On 07/28/2016 09:19 AM, Konrad Rzeszutek Wilk wrote:
> On Tue, Jul 26, 2016 at 01:19:35PM +0800, Bob Liu wrote:
>> Two places didn't get updated when 64KB page granularity was introduced, this
>> patch fix them.
>>
>> Signed-off-by: Bob Liu
>> Acked-by: Roger Pau Monné
>
> Could you rebase this
Current code forgets to free resources in the failure path of
xlvbd_alloc_gendisk(), this patch fix it.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
Two places didn't get updated when 64KB page granularity was introduced,
this patch fix them.
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's
not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset
limits with initial correct values.
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c | 87
flight 66850 distros-debian-wheezy real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/66850/
Perfect :-)
All tests in this flight passed as required
baseline version:
flight 66624
jobs:
build-amd64 pass
build-armh
flight 99716 linux-3.14 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/99716/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail
REGR. vs. 96226
test-
flight 99715 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/99715/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-xl-multivcpu 11 guest-start fail REGR. vs. 99672
Regressions which a
On Thu, Jul 28, 2016 at 07:05:05AM +0800, Bob Liu wrote:
>
> On 07/27/2016 10:24 PM, Roger Pau Monné wrote:
> > On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote:
> >>
> >> On 07/27/2016 06:59 PM, Roger Pau Monné wrote:
> >>> On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote:
> >>> [..
flight 99740 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/99740/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-debianhvm-i386 12 guest-saverestore fail REGR. vs.
99707
Tests whi
On 27/07/16 22:06, Andrew Cooper wrote:
> On 27/07/2016 20:51, osstest service owner wrote:
>> flight 99722 xen-unstable-smoke real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/99722/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which co
Commit d2412fd63b14c6c21d0a3d4367afa448425dfb8a ("libxl: move common
nic stuff into one source") introduced a double free error in libxl
which occurred during "xl save".
Correct this error.
Signed-off-by: Juergen Gross
---
tools/libxl/libxl.c | 2 +-
tools/libxl/libxl_nic.c | 8
2
101 - 167 of 167 matches
Mail list logo
