Re: [Xen-devel] [edk2] [PATCH RFC 10/14] UefiCpuPkg/BaseXApicX2ApicLib: Fix initialisation on my system and ...

2016-12-08 Thread Kinney, Michael D
Hi Anthony, Can you provide more details on why you want to expose internal APIs in the library class? What is the specific issue? Is the Local APIC in your environment not behaving the same as real HW? Thanks, Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...

[Xen-devel] [libvirt test] 103065: tolerable all pass - PUSHED

2016-12-08 Thread osstest service owner
flight 103065 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/103065/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt-xsm 13 saverestore-support-checkfail like 102983 test-armhf-armhf-libvirt 13

Re: [Xen-devel] [PATCH 1/3] Don't create default ioreq server

2016-12-08 Thread Zhang Chen
On 12/01/2016 09:19 PM, Wei Liu wrote: On Wed, Nov 30, 2016 at 05:47:50PM +0800, Zhang Chen wrote: The ioreq server make colo run failed. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- xen/arch/x86/hvm/hvm.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/xen/a

[Xen-devel] [xen-4.5-testing test] 103051: regressions - FAIL

2016-12-08 Thread osstest service owner
flight 103051 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103051/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 5 xen-install fail REGR. vs. 102721 test-xtf-amd64-

Re: [Xen-devel] Future support of 5-level paging in Xen:wq

2016-12-08 Thread Juergen Gross
On 09/12/16 00:50, Stefano Stabellini wrote: > On Thu, 8 Dec 2016, Andrew Cooper wrote: >> On 08/12/2016 19:18, Stefano Stabellini wrote: >>> On Thu, 8 Dec 2016, Andrew Cooper wrote: On 08/12/16 16:46, Juergen Gross wrote: > The first round of (very preliminary) patches for supporting the

Re: [Xen-devel] [PATCH] x86/head: Refactor 32-bit pgtable setup

2016-12-08 Thread Ingo Molnar
* Boris Ostrovsky wrote: > The new Xen PVH entry point requires page tables to be setup by the > kernel since it is entered with paging disabled. > > Pull the common code out of head_32.S so that mk_early_pgtbl_32 can be > invoked from both the new Xen entry point and the existing startup_32 >

Re: [Xen-devel] [RFC PATCH v3] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-12-08 Thread Ingo Molnar
* Juergen Gross wrote: > On 05/12/16 18:49, Alex Thorlton wrote: > > This is the third pass at my patchset to fix up our problems with > > XENMEM_machine_memory_map on large systems. The only changes on this > > pass were to flesh out the comment above the E820_X_MAX definition, and > > to add

[Xen-devel] [ovmf baseline-only test] 68178: all pass

2016-12-08 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68178 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68178/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 854c6b80dc3f1d4a151322b21c5fb6952b159ca9 baseline v

[Xen-devel] [PATCH] X86/VPMU: mask off uncore overflow bit on xeon phi knights landing

2016-12-08 Thread Luwei Kang
IA32_PERF_GLOBAL_STATUS.OvfUncore (MSR 38EH, bit[61]) is always 0 and writing 1 to IA32_PERF_GLOBAL_OVF_CTRL.ClrOvfUncore (MSR 390H, bit[61]) signals #GP. Reference "Intel Xeon Phi Procssor x200 Product Family", document number 334646-008. Signed-off-by: Luwei Kang --- xen/arch/x86/cpu/vpmu_inte

Re: [Xen-devel] [PATCH] fix potential pa_range_info out of bound access

2016-12-08 Thread Stefano Stabellini
On Thu, 8 Dec 2016, Stefano Stabellini wrote: > pa_range_info has only 8 elements and is accessed using pa_range as > index. pa_range is initialized to 16, potentially causing out of bound > access errors. Fix the issue by initializing pa_range to the effective > number of pa_range_info elements. >

[Xen-devel] [PATCH] fix potential int overflow in efi/boot

2016-12-08 Thread Stefano Stabellini
HorizontalResolution and VerticalResolution are 32bit, while size is 64bit. As it stands the multiplication is evaluated with 32bit arithmetic, which could overflow. Cast HorizontalResolution to 64bit to avoid that. Coverity-ID: 1381858 Signed-off-by: Stefano Stabellini diff --git a/xen/common/

[Xen-devel] [PATCH] fix out of bound access to mode_strings

2016-12-08 Thread Stefano Stabellini
mode == ARRAY_SIZE(mode_strings) causes an out of bound access to the mode_strings array. Coverity-ID: 1381859 Signed-off-by: Stefano Stabellini diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index eb85d92..35d8e8b 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -643,7

[Xen-devel] [PATCH] fix potential pa_range_info out of bound access

2016-12-08 Thread Stefano Stabellini
pa_range_info has only 8 elements and is accessed using pa_range as index. pa_range is initialized to 16, potentially causing out of bound access errors. Fix the issue by initializing pa_range to the effective number of pa_range_info elements. CID 1381865 Signed-off-by: Stefano Stabellini diff

[Xen-devel] [PATCH] missing vgic_unlock_rank in gic_remove_irq_from_guest

2016-12-08 Thread Stefano Stabellini
Add missing vgic_unlock_rank on the error path in gic_remove_irq_from_guest. CID: 1381843 Signed-off-by: Stefano Stabellini diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 63c744a..a5348f2 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -205,7 +205,10 @@ int gic_remove_ir

Re: [Xen-devel] [BUG] Xen-4.8.0 efi/buildid.o: file not recognized/Ambiguous

2016-12-08 Thread Håkon Alstadheim
Den 08. des. 2016 20:35, skrev John L. Poole: > > > On 12/7/2016 8:51 AM, Jan Beulich wrote: > On 07.12.16 at 16:57, wrote: >>> I did the the following: >>> >>> wget https://downloads.xenproject.org/release/xen/4.8.0/xen-4.8.0.tar.gz >>> tar -xvzf xen-4.8.0.tar.gz >>> cd /usr/local/src/xe

[Xen-devel] [xen-4.7-testing test] 103038: regressions - trouble: broken/fail/pass

2016-12-08 Thread osstest service owner
flight 103038 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103038/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair 4 host-install/dst_host(4) broken REGR. vs. 102744 test-amd64-i38

Re: [Xen-devel] Future support of 5-level paging in Xen

2016-12-08 Thread Boris Ostrovsky
On 12/08/2016 07:20 PM, Andrew Cooper wrote: On 08/12/2016 23:40, Boris Ostrovsky wrote: Of course even the largest virtual machine today (2TB on Amazon AFAIK) is not close to reaching the current memory limit, but it's just a matter of time. /me things Oracle will have something to say

Re: [Xen-devel] Future support of 5-level paging in Xen

2016-12-08 Thread Andrew Cooper
On 08/12/2016 23:40, Boris Ostrovsky wrote: > > >> >>> Of course even the largest virtual machine today (2TB on Amazon AFAIK) >>> is not close to reaching the current memory limit, but it's just a >>> matter of time. >> >> /me things Oracle will have something to say about this. I'm sure there >>

Re: [Xen-devel] Future support of 5-level paging in Xen:wq

2016-12-08 Thread Stefano Stabellini
On Thu, 8 Dec 2016, Andrew Cooper wrote: > On 08/12/2016 19:18, Stefano Stabellini wrote: > > On Thu, 8 Dec 2016, Andrew Cooper wrote: > >> On 08/12/16 16:46, Juergen Gross wrote: > >>> The first round of (very preliminary) patches for supporting the new > >>> 5-level paging of future Intel x86 pro

Re: [Xen-devel] Future support of 5-level paging in Xen

2016-12-08 Thread Boris Ostrovsky
On 12/08/2016 05:21 PM, Andrew Cooper wrote: On 08/12/2016 19:18, Stefano Stabellini wrote: Of course even the largest virtual machine today (2TB on Amazon AFAIK) is not close to reaching the current memory limit, but it's just a matter of time. /me things Oracle will have something to s

Re: [Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

2016-12-08 Thread Daniel Kiper
On Wed, Dec 07, 2016 at 06:27:58PM +0100, Daniel Kiper wrote: > On Wed, Dec 07, 2016 at 06:43:40AM -0700, Jan Beulich wrote: > > >>> On 05.12.16 at 23:25, wrote: > > > Current early command line parser implementation in assembler > > > is very difficult to change to relocatable stuff using segment

[Xen-devel] [PATCH] p2m: split mem_access into separate files

2016-12-08 Thread Tamas K Lengyel
This patch relocates mem_access components that are currently mixed with p2m code into separate files. This better aligns the code with similar subsystems, such as mem_sharing and mem_paging, which are already in separate files. There are no code-changes introduced, the patch is mechanical code mov

[Xen-devel] [xen-4.6-testing test] 103039: regressions - trouble: broken/fail/pass

2016-12-08 Thread osstest service owner
flight 103039 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103039/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-xsm 3 host-install(3)broken REGR. vs. 102816 test-amd64-amd6

Re: [Xen-devel] Future support of 5-level paging in Xen

2016-12-08 Thread Andrew Cooper
On 08/12/2016 19:18, Stefano Stabellini wrote: > On Thu, 8 Dec 2016, Andrew Cooper wrote: >> On 08/12/16 16:46, Juergen Gross wrote: >>> The first round of (very preliminary) patches for supporting the new >>> 5-level paging of future Intel x86 processors [1] has been posted to >>> lkml: >>> >>> ht

Re: [Xen-devel] Xen 4.9 Development Update

2016-12-08 Thread Stefano Stabellini
On Thu, 8 Dec 2016, Julien Grall wrote: > This email only tracks big items for xen.git tree. Please reply for items you > woulk like to see in 4.9 so that people have an idea what is going on and > prioritise accordingly. > > You're welcome to provide description and use cases of the feature you'r

Re: [Xen-devel] [DOC RFC] Heterogeneous Multi Processing Support in Xen

2016-12-08 Thread Dario Faggioli
On Thu, 2016-12-08 at 03:14 -0700, Jan Beulich wrote: > > > > On 07.12.16 at 19:29, wrote: > > The list of classes is kept ordered from the more powerful to the > > less > > powerful. > > **TODO:** this has been [proposed by  > > George](https://lists.xenproject.org/archives/html/xen-devel/2016-0

Re: [Xen-devel] [DOC RFC] Heterogeneous Multi Processing Support in Xen

2016-12-08 Thread Dario Faggioli
On Thu, 2016-12-08 at 11:38 +0100, Juergen Gross wrote: > On 08/12/16 11:27, Dario Faggioli wrote: > > On Thu, 2016-12-08 at 07:12 +0100, Juergen Gross wrote: > > > Any idea how to avoid problems in the schedulers related to vcpus > > > with > > > different weights?  > > > > > Sure: use Credit2! :

Re: [Xen-devel] Question about porting IPMMU-VMSA Linux driver to XEN

2016-12-08 Thread Oleksandr Tyshchenko
On Thu, Dec 8, 2016 at 9:39 PM, Julien Grall wrote: > > > On 08/12/16 17:06, Oleksandr Tyshchenko wrote: >> >> Hi Julien, > > > Hi Oleksandr, Hi Julien, thank you for sharing your opinion. > > As discussed on IRC, I CCed xen-devel and Stefano. > >> We would like to hear your opinion about the pr

[Xen-devel] [xen-4.5-testing bisection] complete test-xtf-amd64-amd64-3

2016-12-08 Thread osstest service owner
branch xen-4.5-testing xenbranch xen-4.5-testing job test-xtf-amd64-amd64-3 testid leak-check/check Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xen

Re: [Xen-devel] Question about porting IPMMU-VMSA Linux driver to XEN

2016-12-08 Thread Julien Grall
On 08/12/16 17:06, Oleksandr Tyshchenko wrote: Hi Julien, Hi Oleksandr, As discussed on IRC, I CCed xen-devel and Stefano. We would like to hear your opinion about the proper way of porting kernel driver to XEN. There is a Linux iommu driver "IPMMU VMSA" for supporting VMSA-compatible IPMM

Re: [Xen-devel] [BUG] Xen-4.8.0 efi/buildid.o: file not recognized/Ambiguous

2016-12-08 Thread John L. Poole
On 12/7/2016 8:51 AM, Jan Beulich wrote: On 07.12.16 at 16:57, wrote: I did the the following: wget https://downloads.xenproject.org/release/xen/4.8.0/xen-4.8.0.tar.gz tar -xvzf xen-4.8.0.tar.gz cd /usr/local/src/xen-4.8.0 ./configure The config.log is available at: http://napadata.net/past

Re: [Xen-devel] Future support of 5-level paging in Xen

2016-12-08 Thread Stefano Stabellini
On Thu, 8 Dec 2016, Andrew Cooper wrote: > On 08/12/16 16:46, Juergen Gross wrote: > > The first round of (very preliminary) patches for supporting the new > > 5-level paging of future Intel x86 processors [1] has been posted to > > lkml: > > > > https://lkml.org/lkml/2016/12/8/378 > > > > An expli

[Xen-devel] [xen-4.8-testing test] 103036: tolerable trouble: broken/fail/pass - PUSHED

2016-12-08 Thread osstest service owner
flight 103036 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/103036/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 3 host-install(3) broken pass in 102998 test-amd64-i386-xl-qemut-s

Re: [Xen-devel] [DOC RFC] Heterogeneous Multi Processing Support in Xen

2016-12-08 Thread Stefano Stabellini
On Thu, 8 Dec 2016, Jan Beulich wrote: > >>> On 07.12.16 at 19:29, wrote: > > ### x86 > > > > There is no HMP platform of relevance, for now, in x86 world. Therefore, > > only one class will exist, and all the CPUs will be set to belong to it. > > **TODO X86:** is this correct? > > What about th

Re: [Xen-devel] [PATCH] xen/pci: Bubble up error and fix description.

2016-12-08 Thread Konrad Rzeszutek Wilk
On Thu, Dec 08, 2016 at 07:58:29AM +0100, Juergen Gross wrote: > On 06/12/16 15:28, Konrad Rzeszutek Wilk wrote: > > The function is never called under PV guests, and only shows up > > when MSI (or MSI-X) cannot be allocated. Convert the message > > to include the error value. > > > > Signed-off-b

[Xen-devel] [xen-unstable-smoke test] 103094: tolerable all pass - PUSHED

2016-12-08 Thread osstest service owner
flight 103094 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/103094/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[Xen-devel] [xen-unstable test] 103010: regressions - trouble: broken/fail/pass

2016-12-08 Thread osstest service owner
flight 103010 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/103010/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-43 host-install(3)broken REGR. vs. 102942 test-amd64-amd64-l

Re: [Xen-devel] [PATCH] docs: turn links to docs/* into absolute path

2016-12-08 Thread Andrew Cooper
On 08/12/16 16:56, Cédric Bosdonnat wrote: > From a user point of view, when reading things like "See > docs/misc/txt" in a man page, it is not obvious to find the > location of that file. Use $docdir to turn these into absolute > paths. > > Signed-off-by: Cédric Bosdonnat Hmm. I can see you

Re: [Xen-devel] [PATCH] docs: turn links to docs/* into absolute path

2016-12-08 Thread Wei Liu
On Thu, Dec 08, 2016 at 05:56:12PM +0100, Cédric Bosdonnat wrote: > From a user point of view, when reading things like "See > docs/misc/txt" in a man page, it is not obvious to find the > location of that file. Use $docdir to turn these into absolute > paths. > > Signed-off-by: Cédric Bosdonn

Re: [Xen-devel] [PATCH VERY RFC 3/5] tools/fuzz: introduce x86 instruction emulator target

2016-12-08 Thread Wei Liu
On Thu, Dec 08, 2016 at 08:03:04AM -0700, Jan Beulich wrote: > >>> On 08.12.16 at 14:54, wrote: > > Instruction emulator fuzzing code is from code previous written by > > Andrew and George. Adapted to llvm fuzzer and hook up the build system. > > With this, how much of the new code could be share

Re: [Xen-devel] [PATCH 3/3] x86: introduce and use scratch CPU mask

2016-12-08 Thread Andrew Cooper
On 08/12/16 16:02, Jan Beulich wrote: > __get_page_type(), so far using an on-stack CPU mask variable, is > involved in the recursion when e.g. pinning page tables. This means "in recursion". > there may be up two five instances of the function active at a time, "up to five". > implying five in

Re: [Xen-devel] [PATCH 2/3] VT-d: correct dma_msi_set_affinity()

2016-12-08 Thread Andrew Cooper
On 08/12/16 16:01, Jan Beulich wrote: > That commit ("VT-d: use msi_compose_msg()) together with 15aa6c6748 Which commit? > ("amd iommu: use base platform MSI implementation") introducing the use > of a per-CPU scratch CPU mask went too far: dma_msi_set_affinity() may, > at least in theory, be ca

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH] libelf: Fix div0 issues in elf_{shdr,phdr}_count()"): > Admittedly the rule about iteration count is not so easy to remember, > and I had failed to anticipate that someone would introduce division. > But both of those kind of bugs are denial of service, rather than

Re: [Xen-devel] [PATCH VERY RFC 3/5] tools/fuzz: introduce x86 instruction emulator target

2016-12-08 Thread Wei Liu
On Thu, Dec 08, 2016 at 08:03:04AM -0700, Jan Beulich wrote: [...] > > > +static int emul_read_cr( > > +unsigned int reg, > > +unsigned long *val, > > +struct x86_emulate_ctxt *ctxt) > > +{ > > +/* Fake just enough state for the emulator's _get_fpu() to be happy. */ > > +switch

Re: [Xen-devel] Future support of 5-level paging in Xen

2016-12-08 Thread Andrew Cooper
On 08/12/16 16:46, Juergen Gross wrote: > The first round of (very preliminary) patches for supporting the new > 5-level paging of future Intel x86 processors [1] has been posted to > lkml: > > https://lkml.org/lkml/2016/12/8/378 > > An explicit note has been added: "CONFIG_XEN is broken." and > "I

[Xen-devel] [PATCH] docs: turn links to docs/* into absolute path

2016-12-08 Thread Cédric Bosdonnat
From a user point of view, when reading things like "See docs/misc/txt" in a man page, it is not obvious to find the location of that file. Use $docdir to turn these into absolute paths. Signed-off-by: Cédric Bosdonnat --- docs/man/xl.cfg.pod.5.in | 16 docs/man/xl.pod.1.in

[Xen-devel] [PATCH] x86/head: Refactor 32-bit pgtable setup

2016-12-08 Thread Boris Ostrovsky
The new Xen PVH entry point requires page tables to be setup by the kernel since it is entered with paging disabled. Pull the common code out of head_32.S so that mk_early_pgtbl_32 can be invoked from both the new Xen entry point and the existing startup_32 code. Convert resulting common code to

[Xen-devel] Future support of 5-level paging in Xen

2016-12-08 Thread Juergen Gross
The first round of (very preliminary) patches for supporting the new 5-level paging of future Intel x86 processors [1] has been posted to lkml: https://lkml.org/lkml/2016/12/8/378 An explicit note has been added: "CONFIG_XEN is broken." and "I would appreciate help with the code." I think we sho

[Xen-devel] [linux-4.1 bisection] complete test-amd64-amd64-xl

2016-12-08 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree:

Re: [Xen-devel] [PATCH 1/3] make tlbflush_filter()'s first parameter a pointer

2016-12-08 Thread Andrew Cooper
On 08/12/16 16:00, Jan Beulich wrote: > This brings it in line with most other functions dealing with CPU > masks. Convert both implementations to inline functions at once. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailin

Re: [Xen-devel] [PATCH 2/2] x86emul: support LAR/LSL/VERR/VERW

2016-12-08 Thread Andrew Cooper
On 08/12/16 11:52, Jan Beulich wrote: > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c > @@ -182,7 +182,7 @@ static const opcode_desc_t opcode_table[ > > static const opcode_desc_t twobyte_table[256] = { > /* 0x00 - 0x07 */ > -ModRM, Implicit

Re: [Xen-devel] [PATCH v4 08/14] xen/x86: allow the emulated APICs to be enabled for the hardware domain

2016-12-08 Thread Jan Beulich
>>> On 30.11.16 at 17:49, wrote: > Allow the use of both the emulated local APIC and IO APIC for the hardware > domain. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich albeit I'm not 100% convinced of ... > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -509,6 +509

Re: [Xen-devel] [PATCH v4 07/14] x86/iommu: add IOMMU entries for p2m_mmio_direct pages

2016-12-08 Thread Jan Beulich
>>> On 30.11.16 at 17:49, wrote: > --- a/xen/include/asm-x86/p2m.h > +++ b/xen/include/asm-x86/p2m.h > @@ -834,6 +834,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t > p2mt) > case p2m_grant_map_rw: > case p2m_ram_logdirty: > case p2m_map_foreign: > +case p2m_mmi

Re: [Xen-devel] [PATCH v4 01/14] xen/x86: remove XENFEAT_hvm_pirqs for PVHv2 guests

2016-12-08 Thread Jan Beulich
>>> On 30.11.16 at 17:49, wrote: > --- a/docs/misc/hvmlite.markdown > +++ b/docs/misc/hvmlite.markdown > @@ -75,3 +75,23 @@ info structure that's passed at boot time (field > rsdp_paddr). > > Description of paravirtualized devices will come from XenStore, just as it's > done for HVM guests. >

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 16:47, wrote: > Andrew Cooper writes ("Re: [PATCH] libelf: Fix div0 issues in > elf_{shdr,phdr}_count()"): >> On 08/12/16 15:17, Jan Beulich wrote: >> > Oh, I see - elf_phdr_count() itself relies on the check that's >> > about to be done. But I think the correct thing then woul

[Xen-devel] [PATCH 3/3] x86: introduce and use scratch CPU mask

2016-12-08 Thread Jan Beulich
__get_page_type(), so far using an on-stack CPU mask variable, is involved in the recursion when e.g. pinning page tables. This means there may be up two five instances of the function active at a time, implying five instances of the (up to 512 bytes large) CPU mask variable. With an IRQ happening

Re: [Xen-devel] Xen 4.9 Development Update

2016-12-08 Thread Wei Liu
On Thu, Dec 08, 2016 at 08:57:21AM -0700, Jan Beulich wrote: > >>> On 08.12.16 at 16:36, wrote: > > On Thu, Dec 08, 2016 at 03:12:12PM +, Julien Grall wrote: > > [...] > >> == Toolstack == > >> > >> * Logging solution for Xen system > >> - Wei Liu > >> > > > > Not enough interest, plea

[Xen-devel] [PATCH 2/3] VT-d: correct dma_msi_set_affinity()

2016-12-08 Thread Jan Beulich
That commit ("VT-d: use msi_compose_msg()) together with 15aa6c6748 ("amd iommu: use base platform MSI implementation") introducing the use of a per-CPU scratch CPU mask went too far: dma_msi_set_affinity() may, at least in theory, be called in interrupt context, and hence the use of that scratch v

[Xen-devel] [PATCH 1/3] make tlbflush_filter()'s first parameter a pointer

2016-12-08 Thread Jan Beulich
This brings it in line with most other functions dealing with CPU masks. Convert both implementations to inline functions at once. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2514,7 +2514,7 @@ static int __get_page_type(struct page_i cpumask_co

Re: [Xen-devel] Xen 4.9 Development Update

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 16:36, wrote: > On Thu, Dec 08, 2016 at 03:12:12PM +, Julien Grall wrote: > [...] >> == Toolstack == >> >> * Logging solution for Xen system >> - Wei Liu >> > > Not enough interest, please drop this for now. Possibly slightly related: What's the situation with the r

[Xen-devel] [PATCH 0/3] misc cpumask adjustments

2016-12-08 Thread Jan Beulich
1: make tlbflush_filter()'s first parameter a pointer 2: VT-d: correct dma_msi_set_affinity() 3: x86: introduce and use scratch CPU mask Signed-off-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH RFC 10/14] UefiCpuPkg/BaseXApicX2ApicLib: Fix initialisation on my system and ...

2016-12-08 Thread Anthony PERARD
declare more exported function, ReadLocalApicReg and WriteLocalApicReg. On my system (running OVMF inside a Xen PVH guest), writing the interrupt information (to XAPIC_LVT_TIMER_OFFSET) would also reset the init-count register, thus disabling the timer. --- UefiCpuPkg/Include/Library/LocalApicLib

[Xen-devel] [PATCH RFC 11/14] OvmfPkg/XenOvmf: Adding XenTimerLocalApic

2016-12-08 Thread Anthony PERARD
And replacing the ACPI Timer by this one based on the local APIC. ACPI Timer does not work in a PVH guest, but local APIC works on both PVH and HVM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc | 18 +-

[Xen-devel] [PATCH RFC 14/14] XenOvmf: Use a different RTC

2016-12-08 Thread Anthony PERARD
--- OvmfPkg/XenOvmf.dsc | 5 - OvmfPkg/XenOvmf.fdf | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/XenOvmf.dsc b/OvmfPkg/XenOvmf.dsc index a7a884e..345157b 100644 --- a/OvmfPkg/XenOvmf.dsc +++ b/OvmfPkg/XenOvmf.dsc @@ -567,7 +567,10 @@ } MdeModulePkg/Univer

[Xen-devel] [PATCH RFC 13/14] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2016-12-08 Thread Anthony PERARD
This "device" use XenIoMmioLib to reserve some space to be use by grant tables. It's use 0xfc00, which might not be a good choice... There is probably a better way that using a device for this. --- OvmfPkg/XenIoPvhDxe/XenIoPvhDxe.c | 263 OvmfPkg/XenIoPv

Re: [Xen-devel] Xen 4.9 Development Update

2016-12-08 Thread Wei Liu
On Thu, Dec 08, 2016 at 03:12:12PM +, Julien Grall wrote: [...] > == Toolstack == > > * Logging solution for Xen system > - Wei Liu > Not enough interest, please drop this for now. > * Remove blktap2 > - Wei Liu > Under discussion with user. > == Mini-OS == > > == GRUB == >

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Ian Jackson
Andrew Cooper writes ("Re: [PATCH] libelf: Fix div0 issues in elf_{shdr,phdr}_count()"): > On 08/12/16 15:17, Jan Beulich wrote: > > Oh, I see - elf_phdr_count() itself relies on the check that's > > about to be done. But I think the correct thing then would be to > > not use elf_phdr_count() here

[Xen-devel] [PATCH RFC 00/14] Specific platform to run OVMF in Xen PVH and HVM guests

2016-12-08 Thread Anthony PERARD
Hi, I've started to create a Xen specifig plaform, in OvmfPkg/XenOvmf.dsc with the goal to make it work on both Xen HVM and Xen PVHv2 The first few patches only create the platform and duplicate some code from OvmfPkg and the later patches (from OvmfPkg/XenPlatformPei: Add xen PVH specific code)

[Xen-devel] [PATCH RFC 12/14] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

2016-12-08 Thread Anthony PERARD
and add OvmfPkg/XenConsoleIo/XenConsoleIo to XenOvmf platform. It actually look for gEfiSerialIoProtocolGuid. --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 33 ++ .../PlatformBootManagerLib.inf | 2 ++ OvmfPkg/XenOvmf.dsc

[Xen-devel] [PATCH RFC 05/14] OvmfPkg/Library: add XenPciHostBridgeLib

2016-12-08 Thread Anthony PERARD
A copy of OvmfPkg/Library/PciHostBridgeLib Removing support for pci bus enumeration, I think, and only use scan of already enumerated pci bus. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- .../Library/XenPciHostBridgeLib/XenPciHostBridge.h | 75

[Xen-devel] [PATCH RFC 04/14] OvmfPkg: Introduce XenPlatformPei

2016-12-08 Thread Anthony PERARD
A copy of OvmfPkg/PlatformPei without some of QEMU specific initialization, Xen does not support QemuFwCfg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc | 2 +- OvmfPkg/XenOvmf.fdf |

[Xen-devel] [PATCH RFC 01/14] OvmfPkg: Create platform XenOvmf

2016-12-08 Thread Anthony PERARD
This is a copy of OvmfX64, removing VirtIO and some SMM. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc | 793 OvmfPkg/XenOvmf.fdf | 504 + 2 files

[Xen-devel] [PATCH RFC 07/14] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2016-12-08 Thread Anthony PERARD
This one enter directly in 32bits Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenResetVector/Ia16/ResetVectorVtf0.asm | 79 + OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm | 23 +++ OvmfPkg/XenResetVector/XenRese

[Xen-devel] [PATCH RFC 02/14] OvmfPkg/XenOvmf: Update debug IO port for Xen

2016-12-08 Thread Anthony PERARD
This is a debug IO port that will output directly to the Xen Hypervisor console. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OvmfPkg/XenOvmf.dsc b/OvmfPkg/XenOvmf.dsc index e4

[Xen-devel] [PATCH RFC 03/14] OvmfPkg/XenOvmf.dsc: Introduce XenResetVector

2016-12-08 Thread Anthony PERARD
Copy of OvmfPkg/ResetVector, with one changes: - default_cr0: enable cache Xen copy the OVMF code to RAM, there is no need for cache. Also, it makes OVMF slow to start on AMD. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenOvmf.dsc

[Xen-devel] [PATCH RFC 09/14] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib

2016-12-08 Thread Anthony PERARD
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf in

[Xen-devel] [PATCH RFC 08/14] OvmfPkg/PlatformBootManagerLib: Workaround missing PCI bus on Xen PVH

2016-12-08 Thread Anthony PERARD
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPl

[Xen-devel] [PATCH RFC 06/14] OvmfPkg/XenPlatformPei: Add xen PVH specific code

2016-12-08 Thread Anthony PERARD
- learn about memory size from the E820 - ignore error if host bridge devid is 0x, PVH does not have PCI and reading from unexisting device return -1. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenPlatformPei/MemDetect.c | 71 +

Re: [Xen-devel] [PATCH VERY RFC 3/5] tools/fuzz: introduce x86 instruction emulator target

2016-12-08 Thread Wei Liu
On Thu, Dec 08, 2016 at 08:03:04AM -0700, Jan Beulich wrote: > >>> On 08.12.16 at 14:54, wrote: > > Instruction emulator fuzzing code is from code previous written by > > Andrew and George. Adapted to llvm fuzzer and hook up the build system. > > With this, how much of the new code could be share

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Andrew Cooper
On 08/12/16 15:17, Jan Beulich wrote: On 08.12.16 at 15:46, wrote: >> On 08/12/16 14:41, Jan Beulich wrote: >> On 08.12.16 at 15:18, wrote: elf_uval() can return zero either because the field itself is zero, or >> because the access is out of bounds. c/s a01b6d4 "lib

Re: [Xen-devel] Xen 4.9 Development Update

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 16:12, wrote: > = Projects = > > == Hypervisor == > > * Boot Xen on EFI platforms using GRUB2 (multiboot2 protocol) > - Daniel Kiper > > * Per-cpu tasklet > - Konrad Rzeszutek Wilk > > === x86 === > > * Allow ioreq server interface to support XenGT > - Yu Zhan

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 15:46, wrote: > On 08/12/16 14:41, Jan Beulich wrote: > On 08.12.16 at 15:18, wrote: >>> elf_uval() can return zero either because the field itself is zero, or > because >>> the access is out of bounds. >>> >>> c/s a01b6d4 "libelf: treat phdr and shdr similarly" introduced

Re: [Xen-devel] [PATCH v15] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.

2016-12-08 Thread Oleksandr Andrushchenko
I'm just wondering if anybody had a chance to look at the patch... ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] Xen 4.9 Development Update

2016-12-08 Thread Julien Grall
This email only tracks big items for xen.git tree. Please reply for items you woulk like to see in 4.9 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the feature you're working on. = Timeline = We now adopt a fixed

Re: [Xen-devel] [PATCH VERY RFC 3/5] tools/fuzz: introduce x86 instruction emulator target

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 14:54, wrote: > Instruction emulator fuzzing code is from code previous written by > Andrew and George. Adapted to llvm fuzzer and hook up the build system. With this, how much of the new code could be shared between Google's fuzzer and AFL, for which George had put this togeth

Re: [Xen-devel] [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-08 Thread Boris Ostrovsky
On 12/02/2016 01:15 AM, Juergen Gross wrote: Instead of requesting a new slot on the ring to the backend early, do so only after all has been setup for the request to be sent. This makes error handling easier as we don't need to undo the request id allocation and ring slot allocation. Suggeste

Re: [Xen-devel] [PATCH VERY RFC 2/5] tools/fuzz: introduce libelf target

2016-12-08 Thread Wei Liu
On Thu, Dec 08, 2016 at 07:47:22AM -0700, Jan Beulich wrote: > >>> On 08.12.16 at 14:54, wrote: > > A simple program and Makefile to fuzz libelf in Google's oss-fuzz > > infrastructure. > > Mind adding some description here on how this is expected to work / > be used? The new Makefile produce an

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] libelf: Fix div0 issues in elf_{shdr,phdr}_count()"): > On 08.12.16 at 15:18, wrote: > > Spotted by Coverity. > > And wrongly so, imo. ... > > @@ -148,11 +154,17 @@ unsigned elf_shdr_count(struct elf_binary *elf) > > unsigned elf_phdr_count(struct elf_binary *el

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Andrew Cooper
On 08/12/16 14:41, Jan Beulich wrote: On 08.12.16 at 15:18, wrote: >> elf_uval() can return zero either because the field itself is zero, or >> because >> the access is out of bounds. >> >> c/s a01b6d4 "libelf: treat phdr and shdr similarly" introduced two div0 >> issues >> as e_{ph,sh}ents

Re: [Xen-devel] [PATCH VERY RFC 2/5] tools/fuzz: introduce libelf target

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 14:54, wrote: > A simple program and Makefile to fuzz libelf in Google's oss-fuzz > infrastructure. Mind adding some description here on how this is expected to work / be used? The new Makefile produce an object file and an archive, but no binary, so it's not clear to me what u

Re: [Xen-devel] [PATCH VERY RFC 1/5] libelf: don't always include libxc headers

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 14:54, wrote: > --- a/xen/common/libelf/libelf-private.h > +++ b/xen/common/libelf/libelf-private.h > @@ -72,8 +72,10 @@ > #include > #include > > +#ifndef FUZZ_NO_LIBXC > #include "xenctrl.h" > #include "xc_private.h" > +#endif If put in together with patch 2 (which I

Re: [Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Jan Beulich
>>> On 08.12.16 at 15:18, wrote: > elf_uval() can return zero either because the field itself is zero, or because > the access is out of bounds. > > c/s a01b6d4 "libelf: treat phdr and shdr similarly" introduced two div0 issues > as e_{ph,sh}entsize are not checked for sanity before being used to

[Xen-devel] schedulers' use of cpumask_scratch

2016-12-08 Thread Jan Beulich
Dario, analyzing a stack overflow I've run into the other day I came across credit1's __runq_tickle() not only itself having two cpumask_t variables on the stack, but then also calling cpumask_raise_softirq() (which uses yet one more). I then recalled you have a scratch mask in the scheduler, and

[Xen-devel] [distros-debian-wheezy test] 68176: all pass

2016-12-08 Thread Platform Team regression test user
flight 68176 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68176/ Perfect :-) All tests in this flight passed as required baseline version: flight 68133 jobs: build-amd64 pass build-armh

[Xen-devel] [linux-4.1 test] 103011: regressions - trouble: broken/fail/pass

2016-12-08 Thread osstest service owner
flight 103011 linux-4.1 real [real] http://logs.test-lab.xenproject.org/osstest/logs/103011/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-winxpsp3 6 xen-boot fail REGR. vs. 101737 test-amd64-amd64-xl

[Xen-devel] [PATCH] libelf: Fix div0 issues in elf_{shdr, phdr}_count()

2016-12-08 Thread Andrew Cooper
elf_uval() can return zero either because the field itself is zero, or because the access is out of bounds. c/s a01b6d4 "libelf: treat phdr and shdr similarly" introduced two div0 issues as e_{ph,sh}entsize are not checked for sanity before being used to divide elf->size. Spotted by Coverity. Si

Re: [Xen-devel] [PATCH] x86emul/test: don't log double % characters

2016-12-08 Thread Andrew Cooper
On 08/12/16 11:54, Jan Beulich wrote: > They're useless and at best confusing. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] x86emul/test: avoid meaningless output

2016-12-08 Thread Andrew Cooper
On 08/12/16 11:53, Jan Beulich wrote: > Unconditionally reporting a skipped test in 64-bit builds is not very > useful, especially when quite a few more tests are about to be added. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-dev

Re: [Xen-devel] [PATCH] x86emul: constify write_segment() register pointer

2016-12-08 Thread Andrew Cooper
On 08/12/16 11:53, Jan Beulich wrote: > Since I stumbled across this while looking for further constification > opportunities, also correct the insn_fetch() related comment. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper , although a suggestion about the wording. > --- > I would have

[Xen-devel] [PATCH VERY RFC 2/5] tools/fuzz: introduce libelf target

2016-12-08 Thread Wei Liu
A simple program and Makefile to fuzz libelf in Google's oss-fuzz infrastructure. Signed-off-by: Wei Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- tools/fuzz/libelf/Makefile

  1   2   >