>>> On 31.01.17 at 12:08, wrote:
> They will be shared between xen and userspace programs.
Please clarify here that this is not strictly necessary, but rather just
a convenience / reduction of overall code size. Otherwise someone
looking back in a couple of years may wonder where the hidden
depen
>>> On 31.01.17 at 12:07, wrote:
> +/*
> + * Trap/fault mnemonics.
> + */
> +#define TRAP_divide_error 0
> +#define TRAP_debug 1
> +#define TRAP_nmi 2
> +#define TRAP_int3 3
> +#define TRAP_overflow 4
> +#define TRAP_bounds5
> +#defi
>>> On 31.01.17 at 12:07, wrote:
> ... to avoid obscuring output.
>
> Signed-off-by: Wei Liu
Reviewed-by: Jan Beulich
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 31/01/17 10:29, Jaggi, Manish wrote:
From: Xen-devel on behalf of Andre Przywara
Sent: Tuesday, January 31, 2017 12:01 AM
To: Stefano Stabellini; Julien Grall
Cc: xen-de...@lists.xenproject.org; Vijay Kilari
Subject: [Xen-devel] [PATCH 09/28] ARM: GICv3 ITS: map device and LPIs to the
I
>>> On 31.01.17 at 13:06, wrote:
> On 31/01/17 11:54, Jan Beulich wrote:
> On 31.01.17 at 12:49, wrote:
>>> On 31/01/17 11:29, Jan Beulich wrote:
>>> On 25.01.17 at 18:26, wrote:
>>>
> @@ -1369,6 +1410,9 @@ int vmx_add_msr(u32 msr, int type)
> msr_area_elem->data = 0
>>> On 31.01.17 at 13:09, wrote:
> Matthias Klose of the Debian Project reports that the Xen package in
> Debian stretch, which is based on a snapshot of xen.git#stable-4.8,
> does not build with GCC-7.
>
> Matthias Klose writes ("Bug#853710: xen: ftbfs with GCC-7"):
>> The package fails to build
>>> On 25.01.17 at 23:49, wrote:
> On Wed, Jan 25, 2017 at 04:20:30PM -0600, Doug Goldstein wrote:
>> This is a huge change and would really be helpful to have the diff of
>> what's changed to work from.
>
> Please look below...
Thanks for providing this - I'll comment this rather than the full
Matthias Klose of the Debian Project reports that the Xen package in
Debian stretch, which is based on a snapshot of xen.git#stable-4.8,
does not build with GCC-7.
Matthias Klose writes ("Bug#853710: xen: ftbfs with GCC-7"):
> The package fails to build in a test rebuild on at least amd64 with
> g
On 31/01/17 11:54, Jan Beulich wrote:
On 31.01.17 at 12:49, wrote:
>> On 31/01/17 11:29, Jan Beulich wrote:
>> On 25.01.17 at 18:26, wrote:
>>
@@ -1369,6 +1410,9 @@ int vmx_add_msr(u32 msr, int type)
msr_area_elem->data = 0;
__vmwrite(VM_EXIT_MSR_STOR
Hi,
On 31/01/17 10:38, Julien Grall wrote:
>
>
> On 31/01/2017 09:10, Andre Przywara wrote:
>> Hi Julien,
>
> Hi Andre,
>
>> On 02/11/16 17:18, Julien Grall wrote:
>>> On 28/09/16 19:24, Andre Przywara wrote:
+return (reg & ~field_mask) | field;
+}
+
+/* We want to avoi
>>> On 31.01.17 at 12:49, wrote:
> On 31/01/17 11:29, Jan Beulich wrote:
> On 25.01.17 at 18:26, wrote:
>
>>> @@ -1369,6 +1410,9 @@ int vmx_add_msr(u32 msr, int type)
>>> msr_area_elem->data = 0;
>>> __vmwrite(VM_EXIT_MSR_STORE_COUNT, *msr_count);
>>> __vmwrite(
>>> On 25.01.17 at 18:26, wrote:
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -2241,6 +2241,25 @@ static void pi_notification_interrupt(struct
> cpu_user_regs *regs)
> raise_softirq(VCPU_KICK_SOFTIRQ);
> }
>
> +static bool __read_mostly vmx_lbr_tsx_fixup_need
On 31/01/17 11:29, Jan Beulich wrote:
On 25.01.17 at 18:26, wrote:
>> @@ -1369,6 +1410,9 @@ int vmx_add_msr(u32 msr, int type)
>> msr_area_elem->data = 0;
>> __vmwrite(VM_EXIT_MSR_STORE_COUNT, *msr_count);
>> __vmwrite(VM_ENTRY_MSR_LOAD_COUNT, *msr_count);
>> +
>>> On 25.01.17 at 18:26, wrote:
> @@ -1283,19 +1284,36 @@ static int construct_vmcs(struct vcpu *v)
> return 0;
> }
>
> -int vmx_read_guest_msr(u32 msr, u64 *val)
> +static int vmx_msr_entry_key_cmp(const void *key, const void *elt)
> {
> -struct vcpu *curr = current;
> -unsigned
On 31/01/17 11:08, Wei Liu wrote:
> And remove duplicates.
>
> No functional change.
>
> Signed-off-by: Wei Liu
> ---
> Cc: Jan Beulich
> Cc: Andrew Cooper
> ---
> xen/arch/x86/x86_emulate/x86_emulate.c | 305
> +++--
> 1 file changed, 142 insertions(+), 163 deletio
Any fail during the original __vmwrite() leads to BUG() which can be
easily exploited from a guest in the nested vmx mode.
The new function returns error code depending on the outcome:
VMsucceed: 0
VMfailValid: VM Instruction Error Number
VMfailInvalid: a new VMX_INSN_FAIL
Currently, emulation of vmread and vmwrite for a guest leads to BUG()
in cases when actual VMREAD or VMWRITE ends up in VMfail due to invalid
arguments. The goal of this patch series is to prevent the BUG() from
happening and report any kind of VMfail back to the guest, just like
it would be done
There is an issue with the original __vmwrite() in nested vmx mode:
emulation of a guest's VMWRITE with invalid arguments leads to BUG().
Fix this by using __vmwrite_safe() and reporting any kind of VMfail
back to the guest.
Signed-off-by: Sergey Dyasli
---
xen/arch/x86/hvm/vmx/vmcs.c|
The original function doesn't distinguish between Valid and Invalid
VMfails. Improved function returns error code depending on the outcome:
VMsucceed: 0
VMfailValid: VM Instruction Error Number
VMfailInvalid: VMX_INSN_FAIL_INVALID (~0UL)
Existing users of __vmread_safe() are up
There is an issue with the original __vmread() in nested vmx mode:
emulation of a guest's VMREAD with invalid arguments leads to BUG().
Fix this by using __vmread_safe() and reporting any kind of VMfail
back to the guest.
A new safe versions of get_vvmcs() macro and related functions are
introduc
Provide the fuzzer with more ops, and more sophisticated input
structure.
Based on a patch originally written by Andrew and George.
Signed-off-by: Andrew Cooper
Signed-off-by: George Dunlap
Signed-off-by: Wei Liu
---
Cc: Ian Jackson
Cc: Jan Beulich
Cc: Andrew Cooper
Cc: George Dunlap
v2:
... so that users can know how big the initial input should be.
Signed-off-by: Wei Liu
---
Cc: Ian Jackson
Cc: Jan Beulich
Cc: Andrew Cooper
Cc: George Dunlap
---
.../fuzz/x86_instruction_emulator/afl-x86-insn-emulator-fuzzer.c | 8
tools/fuzz/x86_instruction_emulator/x86-insn-emul
Signed-off-by: Wei Liu
---
Cc: Ian Jackson
Cc: Jan Beulich
Cc: Andrew Cooper
Cc: George Dunlap
---
tools/fuzz/README.afl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/fuzz/README.afl b/tools/fuzz/README.afl
index 431b4a8cbf..68e0fa396f 100644
--- a/tools/fuzz/
Basically this patch does 's/EFLG_/X86_EFLAGS_/g' and with indentation
fixed up. And remove the duplicates in x86_emualte.c. This in turn
requires userspace test harness to include x86-defns.h. Also remove a
few duplicates in userspace harness program.
No functional change.
Signed-off-by: Wei Li
Change the names used in code according to numeric values. Remove the
now unused macros in x86_emualte.c and fix indentation. This in turns
requires including msr-index.h and removing duplicates in userspace
x86_emulate.c in userspace harness program.
No functional change.
Signed-off-by: Wei Liu
No functional change.
Signed-off-by: Wei Liu
---
Cc: Jan Beulich
Cc: Andrew Cooper
---
tools/tests/x86_emulator/x86_emulate.h | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tools/tests/x86_emulator/x86_emulate.h
b/tools/tests/x86_emulator/x86_emulate.h
index 3a6bad
It will be used later to remove duplicates in x86emul.
Signed-off-by: Wei Liu
---
Cc: Jan Beulich
Cc: Andrew Cooper
---
xen/include/asm-x86/x86-defns.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/include/asm-x86/x86-defns.h b/xen/include/asm-x86/x86-defns.h
index 762938f222..a53080
They will be shared between xen and userspace programs.
No functional change.
Signed-off-by: Wei Liu
---
Cc: Jan Beulich
Cc: Andrew Cooper
---
xen/include/asm-x86/processor.h | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/xen/include/asm-x86/processor.h b/xen/in
And remove duplicates.
No functional change.
Signed-off-by: Wei Liu
---
Cc: Jan Beulich
Cc: Andrew Cooper
---
xen/arch/x86/x86_emulate/x86_emulate.c | 305 +++--
1 file changed, 142 insertions(+), 163 deletions(-)
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.
flight 68502 distros-debian-snapshot real [real]
http://osstest.xs.citrite.net/~osstest/testlogs/logs/68502/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
test-amd64-amd64-amd64-weekly-netinst-pygrub 9 debian-di-install fail blocked
in 68428
test-
The first few patches refactor x86emul code so that more code can be shared
between xen and userspace tools.
I have run XTF suite (tests subject to availability on the testbox I use, and
xsa-195 was skipped because qemu segfault -- a known issue) against this
series, no issue is found.
Wei.
---
C
... to avoid obscuring output.
Signed-off-by: Wei Liu
---
Cc: Ian Jackson
Cc: Jan Beulich
Cc: Andrew Cooper
Cc: George Dunlap
---
tools/fuzz/libelf/afl-libelf-fuzzer.c | 2 ++
tools/fuzz/x86_instruction_emulator/afl-x86-insn-emulator-fuzzer.c | 2 ++
2 files chan
... so that they can be used by userspace x86 instruction emulator test
program and fuzzer as well.
No functional change.
Signed-off-by: Wei Liu
---
Cc: Jan Beulich
Cc: Andrew Cooper
---
xen/include/asm-x86/processor.h | 97 +-
xen/include/asm-x86/x86-defn
And remove the duplicates.
No functional change.
Signed-off-by: Wei Liu
---
Cc: Jan Beulich
Cc: Andrew Cooper
---
xen/arch/x86/x86_emulate/x86_emulate.c | 45 --
1 file changed, 15 insertions(+), 30 deletions(-)
diff --git a/xen/arch/x86/x86_emulate/x86_emulat
>>> On 30.01.17 at 19:26, wrote:
> We can switch ACPI from using fixmap to dynamic mapping as soon as
> the system enters SYS_STATE_boot. This will allow us, for example,
> to map MADT on systems with large number of processors where the
> table might not fit into NUM_FIXMAP_ACPI_PAGES (currently
>>> On 31.01.17 at 11:39, wrote:
> On 31/01/17 10:19, Jan Beulich wrote:
> On 30.01.17 at 17:54, wrote:
>>> This results in rather more readable code. No functional change.
>>>
>>> All fields currently specified are included, but commented out as no support
>>> for their use is present.
>> I
On 31/01/17 02:44, Konrad Rzeszutek Wilk wrote:
> On Thu, Jan 19, 2017 at 02:01:06PM +0800, Yi Sun wrote:
>> This patch implements the CPU init and free flow including L3 CAT
>> initialization and feature list free.
>>
>> Signed-off-by: Yi Sun
>> ---
>> v5:
>> - modify commit message beacuse o
>>> On 30.01.17 at 16:17, wrote:
> Commit 71bb7304e7a7a35ea6df4b0cedebc35028e4c159 added flushing of
> nested p2m tables whenever the host p2m table changed. Unfortunately
> in the process, it added a filter to the generic p2m_flush_table()
> function so that the p2m would only be flushed if it w
On 31/01/17 10:19, Jan Beulich wrote:
On 30.01.17 at 17:54, wrote:
>> This results in rather more readable code. No functional change.
>>
>> All fields currently specified are included, but commented out as no support
>> for their use is present.
> I'd rather not see them be commented out: W
On 31/01/2017 09:10, Andre Przywara wrote:
Hi Julien,
Hi Andre,
On 02/11/16 17:18, Julien Grall wrote:
On 28/09/16 19:24, Andre Przywara wrote:
+return (reg & ~field_mask) | field;
+}
+
+/* We want to avoid outer shareable. */
+static uint64_t vgic_sanitise_shareability(uint64_t field
>>> On 30.01.17 at 18:26, wrote:
> @@ -1680,7 +1688,7 @@ static mfn_t emulate_gva_to_mfn(struct vcpu *v,
> unsigned long vaddr,
> mfn = page_to_mfn(page);
> ASSERT(mfn_valid(mfn));
>
> -v->arch.paging.last_write_was_pt = !!sh_mfn_is_a_page_table(mfn);
> +v->arch.paging.shadow.
Hi Andre,
>
>From: Xen-devel on behalf of Andre Przywara
>
>Sent: Tuesday, January 31, 2017 12:01 AM
>To: Stefano Stabellini; Julien Grall
>Cc: xen-de...@lists.xenproject.org; Vijay Kilari
>Subject: [Xen-devel] [PATCH 09/28] ARM: GICv3 ITS: map device and LPIs to the
>ITS on physdev_op hypercal
>>> On 30.01.17 at 18:26, wrote:
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -384,7 +384,8 @@ int vcpu_initialise(struct vcpu *v)
>
> if ( !is_idle_domain(d) )
> {
> -paging_vcpu_init(v);
> +if ( (rc = paging_vcpu_init(v)) )
> +return rc
On 30/01/17 17:07, Tamas K Lengyel wrote:
> Hi George,
> yeap, this solves old mem_access settings being triggered when I
> recreate altp2m views. Thanks!
>
> On Mon, Jan 30, 2017 at 8:17 AM, George Dunlap
> wrote:
>> Commit 71bb7304e7a7a35ea6df4b0cedebc35028e4c159 added flushing of
>> nested p2
Hi Andre,
On 31/01/2017 09:10, Andre Przywara wrote:
On 02/11/16 15:05, Julien Grall wrote:
On 28/09/16 19:24, Andre Przywara wrote:
+}
+
+static uint64_t encode_rdbase(struct host_its *hw_its, int cpu,
uint64_t reg)
+{
+reg &= ~GENMASK(51, 16);
+
+if ( hw_its->pta )
+reg |= pe
>>> On 30.01.17 at 17:54, wrote:
> The ept_get_*() helpers are not used consistently, and are more verbose than
> the code they wrap. Drop the wrappers and use the internal union names
> consistently.
>
> While making these adjustments, drop the redundant ept_* prefix from mt, wl
> and ad, and r
>>> On 30.01.17 at 17:54, wrote:
> This results in rather more readable code. No functional change.
>
> All fields currently specified are included, but commented out as no support
> for their use is present.
I'd rather not see them be commented out: Why should the first user
of them have to to
>>> On 31.01.17 at 03:44, wrote:
> On Thu, Jan 19, 2017 at 02:01:06PM +0800, Yi Sun wrote:
>> @@ -127,6 +130,13 @@ struct feat_node {
>> struct list_head list;
>> };
>>
>> +struct cpuid_leaf_regs {
>> +unsigned int eax;
>> +unsigned int ebx;
>> +unsigned int ecx;
>> +unsign
>>> On 30.01.17 at 23:20, wrote:
>> --- a/xen/arch/x86/psr.c
>> +++ b/xen/arch/x86/psr.c
>> @@ -17,12 +17,116 @@
>> #include
>> #include
>> #include
>> +#include
>> #include
>>
>> +/*
>> + * Terminology:
>> + * - CAT Cache Allocation Technology
>> + * - CBM Capacity BitM
On Mon, Jan 30, 2017 at 06:21:54PM +0100, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Forward platform specific firmware calls from the hardware
> domain to firmware.
>
> Signed-off-by: Edgar E. Iglesias
> ---
> xen/arch/arm/platforms/xilinx-zynqmp.c | 63
> ++
Hi Julien,
(forgot to hit the Send button yesterday ...)
just going over the review comments again and found some leftovers.
I fixed/addressed all comments of yours that I don't explicitly refer to
here.
...
On 02/11/16 15:05, Julien Grall wrote:
> Hi Andre,
>
> On 28/09/16 19:24, Andre Przywa
Hi Julien,
(forgot to hit the Send button yesterday ...)
On 02/11/16 17:18, Julien Grall wrote:
> Hi Andre,
>
> On 28/09/16 19:24, Andre Przywara wrote:
>> Allow a guest to provide the address and size for the memory regions
>> it has reserved for the GICv3 pending and property tables.
>>
101 - 152 of 152 matches
Mail list logo
