Re: [Xen-devel] [xen-unstable test] 112855: regressions - trouble: blocked/broken/fail/pass

2017-08-28 Thread Jan Beulich
>>> On 25.08.17 at 19:14, wrote: > On 08/25/2017 09:40 AM, Jan Beulich wrote: > On 25.08.17 at 05:15, wrote: >>> flight 112855 xen-unstable real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/112855/ >>> >>> Regressions :-( >>> >>> Tests which did not succeed and are blocking, >

Re: [Xen-devel] [PATCH v3] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics (and 1 more message)

2017-08-28 Thread Jan Beulich
>>> On 25.08.17 at 18:05, wrote: > On Fri, Aug 25, 2017 at 09:54:18AM -0600, Jan Beulich wrote: >> >>> On 25.08.17 at 17:25, wrote: >> > On Wed, Aug 16, 2017 at 06:20:01AM -0600, Jan Beulich wrote: >> >> So far callers of the libxc interface passed in a domain ID which was >> >> then ignored in t

[Xen-devel] [PATCH v5 10/15] xen: add basic support for runtime parameter changing

2017-08-28 Thread Juergen Gross
Add the needed infrastructure for runtime parameter changing similar to that used at boot time via cmdline. We are using the same parsing functions as for cmdline parsing, but with a different array of parameter definitions. Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich C

[Xen-devel] [PATCH v5 02/15] xen: check parameter validity when parsing command line

2017-08-28 Thread Juergen Gross
Where possible check validity of parameters in _cmdline_parse() and issue a warning message in case of an error detected. In order to make sure a custom parameter parsing function really returns a value (error or success), don't use a void pointer for storing the function address, but a proper typ

[Xen-devel] [PATCH v5 06/15] xen/arch/x86/io_apic.c: remove custom_param() error messages

2017-08-28 Thread Juergen Gross
With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by setup_ioapic_ack() can be removed. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- xen/arch/

[Xen-devel] [PATCH v5 11/15] xen: add hypercall for setting parameters at runtime

2017-08-28 Thread Juergen Gross
Add a sysctl hypercall to support setting parameters similar to command line parameters, but at runtime. The parameters to set are specified as a string, just like the boot parameters. Cc: Daniel De Graaf Cc: Ian Jackson Cc: Wei Liu Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Kon

[Xen-devel] [PATCH v5 14/15] xl: add new xl command set-parameters

2017-08-28 Thread Juergen Gross
Add a new xl command "set-parameters" to set hypervisor parameters at runtime similar to boot time parameters via command line. Cc: Ian Jackson Cc: Wei Liu Signed-off-by: Juergen Gross Acked-by: Wei Liu --- docs/man/xl.pod.1.in | 5 + tools/xl/xl.h | 1 + tools/xl/xl_cmdtable

[Xen-devel] [PATCH v5 13/15] libxl: add libxl_set_parameters() function

2017-08-28 Thread Juergen Gross
Add a new libxl function to set hypervisor parameters at runtime similar to boot time parameters via command line. Cc: Ian Jackson Cc: Wei Liu Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V2: - corrected coding style (Wei Liu) - removed superfluous #ifdef (Wei Liu) V3: - use LOGEV() for

[Xen-devel] [PATCH v5 04/15] xen/arch/x86/cpu/mcheck/mce.c: remove custom_param() error messages

2017-08-28 Thread Juergen Gross
With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by mce_set_verbosity() can be removed. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- xen/arch

[Xen-devel] [PATCH v5 12/15] libxc: add function to set hypervisor parameters

2017-08-28 Thread Juergen Gross
Add a new libxc function to set hypervisor parameters at runtime similar to boot time parameters via command line. Cc: Ian Jackson Cc: Wei Liu Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V3: - zero padding fields in sysctl.u.set_parameter --- tools/libxc/include/xenctrl.h | 1 + tools

[Xen-devel] [PATCH v5 01/15] xen/arch/x86/psr.c: let custom parameter parsing routines return errno

2017-08-28 Thread Juergen Gross
Modify the custom parameter parsing routines in: xen/arch/x86/psr.c to indicate whether the parameter value was parsed successfully. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross --- V5: - rename variable (value -> delim, val_str -> val_delim) (Jan Beulich) --- xen/arch/x86/

[Xen-devel] [PATCH v5 09/15] xen: carve out a generic parsing function from _cmdline_parse()

2017-08-28 Thread Juergen Gross
In order to support generic parameter parsing carve out the parser from _cmdline_parse(). As this generic function might be called after boot remove the __init annotations from all called sub-functions. Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wi

[Xen-devel] [PATCH v5 05/15] xen/arch/x86/hvm/viridian.c: remove custom_param() error messages

2017-08-28 Thread Juergen Gross
With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by parse_viridian_version() can be removed. Cc: Paul Durrant Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Reviewed-by:

[Xen-devel] [PATCH v5 03/15] xen/arch/x86/apic.c: remove custom_param() error messages

2017-08-28 Thread Juergen Gross
With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by apic_set_verbosity() can be removed. Cc: Jan Beulich Cc: Andrew Cooper Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- xen/arc

[Xen-devel] [PATCH v5 00/15] Support for modifying parameters at runtime

2017-08-28 Thread Juergen Gross
Currently parameters of the hypervisor (e.g. console log level) can be set via boot command line. Instead of having to reboot the system in case another setting is desired, being able to modify many of those parameters at runtime would be the better option. This patch series addresses this by addi

[Xen-devel] [PATCH v5 07/15] xen/common/kexec.c: remove custom_param() error messages

2017-08-28 Thread Juergen Gross
With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() some messages issued by parse_low_crashinfo() and parse_crashinfo_maxaddr() can be removed. Cc: Andrew Cooper Signed-off-by: Juergen Gross --- xen/common/kex

[Xen-devel] [PATCH v5 15/15] xen: make some console related parameters settable at runtime

2017-08-28 Thread Juergen Gross
Support modifying conswitch, console_timestamps, loglvl and guest_loglvl at runtime. Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu Signed-off-by: Juergen Gross Reviewed-by: Wei Liu Reviewed-

[Xen-devel] [PATCH v5 08/15] xen/common/sched_credit2.c: remove custom_param() error messages

2017-08-28 Thread Juergen Gross
With _cmdline_parse() now issuing error messages in case of illegal parameters signalled by parsing functions specified in custom_param() the message issued by parse_credit2_runqueue() can be removed. Cc: George Dunlap Cc: Dario Faggioli Signed-off-by: Juergen Gross Acked-by: Dario Faggioli --

Re: [Xen-devel] [PATCH v2] x86/apic/x2apic: Share IRQ vector between cluster members only when no cpumask is specified

2017-08-28 Thread Jan Beulich
>>> On 25.08.17 at 18:00, wrote: > On 08/25/2017 10:56 AM, Jan Beulich wrote: > On 08.08.17 at 17:59, wrote: >>> --- a/xen/arch/x86/genapic/delivery.c >>> +++ b/xen/arch/x86/genapic/delivery.c >>> @@ -30,7 +30,8 @@ void __init clustered_apic_check_flat(void) >>> printk("Enabling APIC mode

Re: [Xen-devel] [PATCH] common/gnttab: Introduce command line feature controls

2017-08-28 Thread Jan Beulich
>>> On 25.08.17 at 20:43, wrote: > At the moment, all of our downstreams which followed the embargoed > advise will be using these command line options to mitigate the > vulnerability. The fact that this patch wasn't committed to the stable > trees is bad, because it will cause our downstreams to

[Xen-devel] crashdump on PVM Dom0

2017-08-28 Thread Minjun Hong
Hello~ I'm new to develop Xen and my first work is about its scheduler. After I modified Xen 4.5 source code, my custom Xen has had a problem, which it causes automatic reboot of Dom0 when I execute a micro benchmark program. To debug it, I have tried to use crashdump on Dom0 with the Xen but, I fa

Re: [Xen-devel] crashdump on PVM Dom0

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 10:01, wrote: > I'm new to develop Xen and my first work is about its scheduler. > After I modified Xen 4.5 source code, my custom Xen has had a problem, > which it causes automatic reboot of Dom0 when I execute a micro benchmark > program. > To debug it, I have tried to use cra

Re: [Xen-devel] [PATCH v10] VT-d: use correct BDF for VF to search VT-d unit

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 04:42, wrote: > When SR-IOV is enabled, 'Virtual Functions' of a 'Physical Function' > are under the scope of the same VT-d unit as the 'Physical Function'. > A 'Physical Function' can be a 'Traditional Function' or an ARI > 'Extended Function'. And furthermore, 'Extended Functi

Re: [Xen-devel] [PATCH v2] tools/hvmloader: Use base instead of pci_mem_start for find_next_rmrr()

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 01:09, wrote: > find_next_rmrr(base) is used to find the lowest RMRR ending above base > but below 4G. Current method couldn't cover the following situation: > a. two rmrr exist, small gap between them > b. pci_mem_start and mem_resource.base is below the first rmrr.base > c. fi

[Xen-devel] [PATCH v3] x86: enable RCU based table free

2017-08-28 Thread Vitaly Kuznetsov
On x86 software page-table walkers depend on the fact that remote TLB flush does an IPI: walk is performed lockless but with interrupts disabled and in case the pagetable is freed the freeing CPU will get blocked as remote TLB flush is required. On other architecture which don't require an IPI to d

Re: [Xen-devel] [PATCH v10] VT-d: use correct BDF for VF to search VT-d unit

2017-08-28 Thread Chao Gao
On Mon, Aug 28, 2017 at 02:16:18AM -0600, Jan Beulich wrote: On 28.08.17 at 04:42, wrote: >> When SR-IOV is enabled, 'Virtual Functions' of a 'Physical Function' >> are under the scope of the same VT-d unit as the 'Physical Function'. >> A 'Physical Function' can be a 'Traditional Function' o

Re: [Xen-devel] [PATCH v2 4/6] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-08-28 Thread Jan Beulich
>>> On 27.08.17 at 10:36, wrote: > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1284,7 +1284,7 @@ int xenmem_add_to_physmap_one( > return -EINVAL; > } > > -rc = xsm_map_gmfn_foreign(XSM_TARGET, d, od); > +rc = xsm_map_gmfn_foreign(XSM_TARGET, curr

Re: [Xen-devel] [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

2017-08-28 Thread Alberto Garcia
On Fri 25 Aug 2017 09:39:22 PM CEST, Eduardo Habkost wrote: > CCing maintainers of affected devices (sorry for not CCing you > before). >> diff --git a/hw/ipack/tpci200.c b/hw/ipack/tpci200.c >> index 4dfa6b3..e380378 100644 >> --- a/hw/ipack/tpci200.c >> +++ b/hw/ipack/tpci200.c >> @@ -646,6 +646

Re: [Xen-devel] [PATCH v5 01/15] xen/arch/x86/psr.c: let custom parameter parsing routines return errno

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 09:34, wrote: > Modify the custom parameter parsing routines in: > > xen/arch/x86/psr.c > > to indicate whether the parameter value was parsed successfully. > > Cc: Jan Beulich > Cc: Andrew Cooper > Signed-off-by: Juergen Gross Acked-by: Jan Beulich __

[Xen-devel] [linux-3.18 test] 112897: trouble: blocked/broken/fail/pass

2017-08-28 Thread osstest service owner
flight 112897 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/112897/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 3 capture-logs broken REGR. vs. 112102

Re: [Xen-devel] [RFC PATCH 1/5] xen/hap: Increase hap size for more vcpus support

2017-08-28 Thread Lan, Tianyu
On 8/25/2017 5:14 PM, Wei Liu wrote: On Thu, Aug 24, 2017 at 10:52:16PM -0400, Lan Tianyu wrote: This patch is to increase hap size to support more vcpus in single VM. Signed-off-by: Lan Tianyu Can we maybe derive the number of pages needed from the number of vcpus? Yes, we can add check

[Xen-devel] [PATCH 01/27 v8] xen/arm: vpl011: Define common ring buffer helper functions in console.h

2017-08-28 Thread Bhupinder Thakur
DEFINE_XEN_FLEX_RING(xencons) defines common helper functions such as xencons_queued() to tell the current size of the ring buffer, xencons_mask() to mask off the index, which are useful helper functions. pl011 emulation code will use these helper functions. io/console.h includes io/ring.h which d

[Xen-devel] [PATCH 03/27 v8] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart

2017-08-28 Thread Bhupinder Thakur
Allocate a new gfn to be used as a ring buffer between xenconsole and Xen for sending/receiving pl011 console data. Signed-off-by: Bhupinder Thakur Acked-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v4: - Rem

[Xen-devel] [PATCH 07/27 v8] xen/arm: vpl011: Add a new vuart node in the xenstore

2017-08-28 Thread Bhupinder Thakur
Add a new vuart console node to xenstore. This node is added at /local/domain/$DOMID/vuart/0. The node contains information such as the ring-ref, event channel, buffer limit and type of console. Xenconsole reads the node information to setup the ring buffer and event channel for sending/receivin

[Xen-devel] [PATCH 00/27 v8] SBSA UART emulation support in Xen

2017-08-28 Thread Bhupinder Thakur
SBSA UART emulation for guests in Xen == Linaro has published VM System specification for ARM Processors, which provides a set of guidelines for both guest OS and hypervisor implementations, such that building OS images according to these guidelines guarantees t

[Xen-devel] [PATCH 05/27 v8] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c

2017-08-28 Thread Bhupinder Thakur
Rearrange xen header includes in alphabetical order in domctl.c. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall --- CC: Stefano Stabellini CC: Julien Grall Changes since v5: - Corrected include of in alphabetical order. xen/arch/arm/domctl.c | 6

[Xen-devel] [PATCH 02/27 v8] xen/arm: vpl011: Add SBSA UART emulation in Xen

2017-08-28 Thread Bhupinder Thakur
Add emulation code to emulate read/write access to pl011 registers and pl011 interrupts: - Emulate DR read/write by reading and writing from/to the IN and OUT ring buffers and raising an event to the backend when there is data in the OUT ring buffer and injecting an interrupt

[Xen-devel] [PATCH 06/27 v8] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-28 Thread Bhupinder Thakur
Add a new domctl API to initialize vpl011. It takes the GFN and console backend domid as input and returns an event channel to be used for sending and receiving events from Xen. Xen will communicate with xenconsole using GFN as the ring buffer and the event channel to transmit and receive pl011 da

[Xen-devel] [PATCH 04/27 v8] xen/arm: vpl011: Add support for vuart in libxl

2017-08-28 Thread Bhupinder Thakur
An option is provided in libxl to enable/disable SBSA vuart while creating a guest domain. Libxl now supports a generic vuart console and SBSA uart is a specific type. In future support can be added for multiple vuart of different types. User can enable SBSA vuart by adding the following line in

[Xen-devel] [PATCH 09/27 v8] xen/arm: vpl011: Rename the console structure field conspath to xspath

2017-08-28 Thread Bhupinder Thakur
The console->conspath name is changed to console->xspath as it is clear from the name that it is referring to xenstore path. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes sin

[Xen-devel] [PATCH 10/27 v8] xen/arm: vpl011: Modify xenconsole functions to take console structure as input

2017-08-28 Thread Bhupinder Thakur
Xenconsole functions take domain structure as input. These functions shall be modified to take console structure as input since these functions typically perform console specific operations. Also the console specific functions starting with prefix "domain_" shall be modified to "console_" to ind

[Xen-devel] [PATCH 12/27 v8] xen/arm: vpl011: Add a new buffer_available function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new buffer_available function to check if more data is allowed to be buffered. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v5: - Split this ch

[Xen-devel] [PATCH 08/27 v8] xen/arm: vpl011: Modify xenconsole to define and use a new console structure

2017-08-28 Thread Bhupinder Thakur
Xenconsole uses a domain structure which contains console specific fields. This patch defines a new console structure, which would be used by the xenconsole functions to perform console specific operations like reading/writing data from/to the console ring buffer or reading/writing data from/to co

[Xen-devel] [PATCH 11/27 v8] xen/arm: vpl011: Add a new console_init function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new console_init function. This function initializes the console structure. Signed-off-by: Bhupinder Thakur --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v5: - Split this change in a separate patch. tools/console/daemon/io.c |

[Xen-devel] [PATCH 16/27 v8] xen/arm: vpl011: Add a new handle_console_ring function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new handle_console_ring function. This function reads the data from the ring buffer on receiving an event. The initialization of event channel poll fd to -1 is moved inside the handle_console_ring function as they are related. There should be no change in the behavior as th

[Xen-devel] [PATCH 26/27 v8] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-08-28 Thread Bhupinder Thakur
This patch fixes the issue observed when pl011 patches were tested on the junos hardware by Andre/Julien. It was observed that when large output is generated such as on running 'find /', output was getting truncated intermittently due to OUT ring buffer getting full. This issue was due to the fac

[Xen-devel] [PATCH 25/27 v8] xen/arm: vpl011: Update documentation for vuart console support

2017-08-28 Thread Bhupinder Thakur
1. Update documentation for a new vuart option added. 2. Update documentation about SPI irq reserved for vuart. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper CC: George Dunlap CC: Jan Beulich CC: Konrad R

[Xen-devel] [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch finally adds the support for vuart console. It adds two new fields in the console initialization: - optional - use_gnttab optional flag tells whether the console is optional. use_gnttab tells whether the ring buffer should be allocated using grant table. Signed-off-by: Bhupinder Thak

[Xen-devel] [PATCH 27/27 v8] xen/arm: vpl011: Fix the slow early console SBSA UART output

2017-08-28 Thread Bhupinder Thakur
The early console output uses pl011_early_write() to write data. This function waits for BUSY bit to get cleared before writing the next byte. In the SBSA UART emulation logic, the BUSY bit was set as soon a one byte was written in the FIFO and it remained set until the FIFO was emptied. This mean

[Xen-devel] [PATCH 14/27 v8] xen/arm: vpl011: Add a new maybe_add_console_tty_fd function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new maybe_add_console_tty_fd function. This function adds the tty fd to the list of polled fds. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v6

[Xen-devel] [PATCH 24/27 v8] xen/arm: vpl011: Add a pl011 uart DT node in the guest device tree

2017-08-28 Thread Bhupinder Thakur
The SBSA UART node format is as specified in Documentation/devicetree/bindings/serial/arm_sbsa_uart.txt and given below: ARM SBSA defined generic UART -- This UART uses a subset of the PL011 registers and consequently lives in the PL011 driver. It's baudrate and other c

[Xen-devel] [PATCH 21/27 v8] xen/arm: vpl011: Add support for multiple consoles in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch adds the support for multiple consoles and introduces the iterator functions to operate on multiple consoles. The functions called by the iterators check that they are operating on valid I/O parameters. This ensures that if a particular console is not initialized then the functions will

[Xen-devel] [PATCH 19/27 v8] xen/arm: vpl011: Add a new console_open_log function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a console_open_log console_cleanup function. This function opens the console log file. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v5: - Split t

[Xen-devel] [PATCH 20/27 v8] xen/arm: vpl011: Add a new console_close_evtchn function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a console_close_evtchn function. This function closes the console event channel. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v5: - Split this ch

[Xen-devel] [PATCH 18/27 v8] xen/arm: vpl011: Add a new console_cleanup function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new console_cleanup function. This function frees up the console resources. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v6: - Removed a null p

[Xen-devel] [PATCH 15/27 v8] xen/arm: vpl011: Add a new console_evtchn_unmask function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new console_evtchn_unmask function. This function unmasks the console event channel if it is masked for some timeout period. One optimization that has been done is to merge the two for loops. One for loop was used to iterate through all domains and unmask the domain event

[Xen-devel] [PATCH 23/27 v8] xen/arm: vpl011: Add a new vuart console type to xenconsole client

2017-08-28 Thread Bhupinder Thakur
Add a new console type VUART to connect to guest's emualated vuart console. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v4: - Removed the vuart compile time flag so t

[Xen-devel] [PATCH 17/27 v8] xen/arm: vpl011: Add a new handle_console_tty function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new handle_console_tty function. This function performs read/write from/to console tty. Signed-off-by: Bhupinder Thakur Reviewed-by: Stefano Stabellini Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v5: - Spli

[Xen-devel] [PATCH 13/27 v8] xen/arm: vpl011: Add a new maybe_add_console_evtchn_fd function in xenconsole

2017-08-28 Thread Bhupinder Thakur
This patch introduces a new maybe_add_console_evtchn_fd function. This function adds the console event channel FD to list of polled FDs. Signed-off-by: Bhupinder Thakur Acked-by: Wei Liu --- CC: Ian Jackson CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall Changes since v6: - Renamed add_

[Xen-devel] [ovmf baseline-only test] 72032: all pass

2017-08-28 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72032 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72032/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 714c2603018a99a514c42c2b511c821f30ba9cdf baseline v

Re: [Xen-devel] [PATCH 06/27 v8] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 10:55, wrote: > Add a new domctl API to initialize vpl011. It takes the GFN and console > backend domid as input and returns an event channel to be used for > sending and receiving events from Xen. > > Xen will communicate with xenconsole using GFN as the ring buffer and > the

Re: [Xen-devel] [PATCH 11/14] fuzz/x86_emulate: Make input more compact

2017-08-28 Thread George Dunlap
On 08/25/2017 06:59 PM, Andrew Cooper wrote: > On 25/08/17 17:43, George Dunlap wrote: >> At the moment, AFL reckons that for any given input, 87% of it is >> completely irrelevant: that is, it can change it as much as it wants >> but have no impact on the result of the test; and yet it can't remov

Re: [Xen-devel] [RFC PATCH 2/5] XL: Increase event channels to support more vcpus

2017-08-28 Thread Lan, Tianyu
On 8/25/2017 6:04 PM, Wei Liu wrote: On Fri, Aug 25, 2017 at 10:57:26AM +0100, Roger Pau Monné wrote: On Fri, Aug 25, 2017 at 10:18:24AM +0100, Wei Liu wrote: On Thu, Aug 24, 2017 at 10:52:17PM -0400, Lan Tianyu wrote: This patch is to increase event channels to support more vcpus in single VM

Re: [Xen-devel] [PATCH 22/27 v8] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 10:56, wrote: > --- a/config/arm32.mk > +++ b/config/arm32.mk > @@ -1,5 +1,6 @@ > CONFIG_ARM := y > CONFIG_ARM_32 := y > +CONFIG_VUART_CONSOLE := y > CONFIG_ARM_$(XEN_OS) := y > > CONFIG_XEN_INSTALL_SUFFIX := > diff --git a/config/arm64.mk b/config/arm64.mk > index aa45772

Re: [Xen-devel] [RFC PATCH 3/5] Tool/ACPI: DSDT extension to support more vcpus

2017-08-28 Thread Lan, Tianyu
On 8/25/2017 5:25 PM, Wei Liu wrote: On Thu, Aug 24, 2017 at 10:52:18PM -0400, Lan Tianyu wrote: This patch is to change DSDT table for processor object to support >255 vcpus. Can you provide a link to the spec so people can check if you modification is correct? OK. Will add in the next ve

[Xen-devel] [distros-debian-sid test] 72031: tolerable trouble: blocked/broken/fail/pass

2017-08-28 Thread Platform Team regression test user
flight 72031 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72031/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-armhf-sid-netboot-pygrub 1 build-check(1)blocked n/a build-arm64-pvops

Re: [Xen-devel] [RFC PATCH 2/5] XL: Increase event channels to support more vcpus

2017-08-28 Thread Wei Liu
On Mon, Aug 28, 2017 at 05:11:27PM +0800, Lan, Tianyu wrote: > On 8/25/2017 6:04 PM, Wei Liu wrote: > > On Fri, Aug 25, 2017 at 10:57:26AM +0100, Roger Pau Monné wrote: > > > On Fri, Aug 25, 2017 at 10:18:24AM +0100, Wei Liu wrote: > > > > On Thu, Aug 24, 2017 at 10:52:17PM -0400, Lan Tianyu wrote:

Re: [Xen-devel] [RFC PATCH 2/5] XL: Increase event channels to support more vcpus

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 11:11, wrote: > On 8/25/2017 6:04 PM, Wei Liu wrote: >> On Fri, Aug 25, 2017 at 10:57:26AM +0100, Roger Pau Monné wrote: >>> On Fri, Aug 25, 2017 at 10:18:24AM +0100, Wei Liu wrote: On Thu, Aug 24, 2017 at 10:52:17PM -0400, Lan Tianyu wrote: > This patch is to increase

[Xen-devel] [PATCH v7] x86/hvm: Allow guest_request vm_events coming from userspace

2017-08-28 Thread Alexandru Isaila
In some introspection usecases, an in-guest agent needs to communicate with the external introspection agent. An existing mechanism is HVMOP_guest_request_vm_event, but this is restricted to kernel usecases like all other hypercalls. Introduce a mechanism whereby the introspection agent can white

Re: [Xen-devel] [kernel-hardening] Re: x86: PIE support and option to extend KASLR randomization

2017-08-28 Thread Pavel Machek
Hi! > > + The kernel and modules will generate slightly more assembly (1 to > > 2% > > + increase on the .text sections). The vmlinux binary will be > > + significantly smaller due to less relocations. > > > > ... but describing a 1-2% kernel text size increase as "slightl

Re: [Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-08-28 Thread George Dunlap
On 08/25/2017 06:37 PM, Andrew Cooper wrote: > On 25/08/17 17:43, George Dunlap wrote: >> You don't need __AFL_INIT if you have __AFL_LOOP. >> >> Signed-off-by: George Dunlap > > Really? Is that covered in any documentation? > > I got the contrary impression from whichever version of AFL I was

Re: [Xen-devel] crashdump on PVM Dom0

2017-08-28 Thread Minjun Hong
Oh!! I'm so sorry Jan Beulich. It is my first time to use this mailing list. Please understand my fault, this time only. Anyway, as you mentioned, I added below line in '/etc/default/grub' file and reboot: > GRUB_CMDLINE_XEN="crashkernel=384M-:256M@64M" Then, 1. I cannot see anything when I type "

[Xen-devel] [libvirt test] 112901: tolerable trouble: blocked/broken/pass - PUSHED

2017-08-28 Thread osstest service owner
flight 112901 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/112901/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1)

[Xen-devel] [PATCH v4] common/vm_event: Initialize vm_event lists on domain creation

2017-08-28 Thread Alexandru Isaila
The patch splits the vm_event into three structures:vm_event_share, vm_event_paging, vm_event_monitor. The allocation for the structure is moved to vm_event_enable so that it can be allocated/init when needed and freed in vm_event_disable. Signed-off-by: Alexandru Isaila --- Changes since V3:

Re: [Xen-devel] [PATCH v2 4/6] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-08-28 Thread Zhongze Liu
Hi Jan, Thanks for having a look at the patch. 2017-08-28 16:29 GMT+08:00 Jan Beulich : On 27.08.17 at 10:36, wrote: >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -1284,7 +1284,7 @@ int xenmem_add_to_physmap_one( >> return -EINVAL; >> } >> >> -rc

Re: [Xen-devel] [PATCH v7] x86/hvm: Allow guest_request vm_events coming from userspace

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 11:38, wrote: > In some introspection usecases, an in-guest agent needs to communicate > with the external introspection agent. An existing mechanism is > HVMOP_guest_request_vm_event, but this is restricted to kernel usecases > like all other hypercalls. > > Introduce a mecha

Re: [Xen-devel] crashdump on PVM Dom0

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 12:45, wrote: > Oh!! I'm so sorry Jan Beulich. > It is my first time to use this mailing list. > Please understand my fault, this time only. > > Anyway, as you mentioned, I added below line in '/etc/default/grub' file > and reboot: >> GRUB_CMDLINE_XEN="crashkernel=384M-:256M@64

Re: [Xen-devel] [PATCH v2 4/6] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 13:01, wrote: > 2017-08-28 16:29 GMT+08:00 Jan Beulich : > On 27.08.17 at 10:36, wrote: >>> -static XSM_INLINE int xsm_map_gmfn_foreign(XSM_DEFAULT_ARG struct domain >>> *d, struct domain *t) >>> +static XSM_INLINE int xsm_map_gmfn_foreign(XSM_DEFAULT_ARG struct domain >>

[Xen-devel] [linux-linus test] 112900: regressions - trouble: blocked/broken/fail/pass

2017-08-28 Thread osstest service owner
flight 112900 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/112900/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 112891 test-amd64-i

[Xen-devel] [xen-unstable-smoke test] 112905: tolerable trouble: broken/pass - PUSHED

2017-08-28 Thread osstest service owner
flight 112905 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/112905/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a build-arm64-pvops 2 hos

[Xen-devel] [PATCH v8] x86/hvm: Allow guest_request vm_events coming from userspace

2017-08-28 Thread Alexandru Isaila
In some introspection usecases, an in-guest agent needs to communicate with the external introspection agent. An existing mechanism is HVMOP_guest_request_vm_event, but this is restricted to kernel usecases like all other hypercalls. Introduce a mechanism whereby the introspection agent can white

[Xen-devel] [ovmf test] 112903: all pass - PUSHED

2017-08-28 Thread osstest service owner
flight 112903 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/112903/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ef5e0db22cdd73e9727afcaa5c7fe8e55b7b3671 baseline version: ovmf 714c2603018a99a514c42

Re: [Xen-devel] [PATCH v8] x86/hvm: Allow guest_request vm_events coming from userspace

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 14:51, wrote: > --- a/xen/include/asm-arm/monitor.h > +++ b/xen/include/asm-arm/monitor.h > @@ -26,6 +26,12 @@ > #include > > static inline > +void arch_allow_userspace(struct domain *d, uint8_t allow_userspace) > +{ > +return; > +} I'm sorry for noticing this only now

Re: [Xen-devel] [xen-unstable test] 112855: regressions - trouble: blocked/broken/fail/pass

2017-08-28 Thread Boris Ostrovsky
On 08/28/2017 03:25 AM, Jan Beulich wrote: On 25.08.17 at 19:14, wrote: >> On 08/25/2017 09:40 AM, Jan Beulich wrote: >> On 25.08.17 at 05:15, wrote: flight 112855 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/112855/ Regressions :-(

Re: [Xen-devel] [xen-unstable test] 112855: regressions - trouble: blocked/broken/fail/pass

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 15:57, wrote: > On 08/28/2017 03:25 AM, Jan Beulich wrote: > On 25.08.17 at 19:14, wrote: >>> On 08/25/2017 09:40 AM, Jan Beulich wrote: >>> On 25.08.17 at 05:15, wrote: > flight 112855 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs

Re: [Xen-devel] [PATCH v2 4/6] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-08-28 Thread George Dunlap
On 08/28/2017 09:29 AM, Jan Beulich wrote: On 27.08.17 at 10:36, wrote: >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -1284,7 +1284,7 @@ int xenmem_add_to_physmap_one( >> return -EINVAL; >> } >> >> -rc = xsm_map_gmfn_foreign(XSM_TARGET, d, od); >>

Re: [Xen-devel] [xen-unstable test] 112855: regressions - trouble: blocked/broken/fail/pass

2017-08-28 Thread Boris Ostrovsky
>> As for periodically testing process_pending_softirqs() we may still want >> to do this in alloc_heap_pages(), even without CONFIG_SCRUB_DEBUG. > For my taste, alloc_heap_pages() is the wrong place for such > calls. But the loop is in alloc_heap_pages() --- where else would you be testing? -bo

Re: [Xen-devel] [PATCH v2] x86/apic/x2apic: Share IRQ vector between cluster members only when no cpumask is specified

2017-08-28 Thread Boris Ostrovsky
On 08/28/2017 03:38 AM, Jan Beulich wrote: > >>> And finally I continue to be not really happy about the change as >>> a whole. Despite what was discussed on v1, I'm concerned of the >>> effects of this on hosts _not_ suffering from vector shortage. >>> Could you live with the new behavior requirin

Re: [Xen-devel] [PATCH v2 REPOST 02/12] x86/mm: allow a privileged PV domain to map guest mfns

2017-08-28 Thread Wei Liu
On Fri, Aug 25, 2017 at 11:05:54AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: 24 August 2017 17:33 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; Andrew Cooper > > ; Jan Beulich ; Wei Liu > > > > Subject: Re: [X

Re: [Xen-devel] [PATCH v2 1/6] xen/tools: credit2: soft-affinity awareness in runq_tickle()

2017-08-28 Thread George Dunlap
On 07/27/2017 01:05 PM, Dario Faggioli wrote: > Soft-affinity support is usually implemented by means > of a two step "balancing loop", where: > - during the first step, we consider soft-affinity > (if the vcpu has one); > - during the second (if we get to it), we consider > hard-affinity. > >

[Xen-devel] [PATCH] xen: fix boolean parameter handling

2017-08-28 Thread Juergen Gross
Commit 63e8a1e5ffa7a7fdbde887805f673fea7e8d2e94 ("xen: check parameter validity when parsing command line") introduced a bug for the case when a boolean parameter was specified by its keyword only (no value). It would set just the wrong boolean value for that parameter. Signed-off-by: Juergen Gros

Re: [Xen-devel] [PATCH v2 2/6] xen: credit2: soft-affinity awareness in gat_fallback_cpu()

2017-08-28 Thread George Dunlap
On 07/27/2017 01:05 PM, Dario Faggioli wrote: > By, basically, moving all the logic of the function > inside the usual two steps (soft-affinity step and > hard-affinity step) loop. > > While there, add two performance counters (in cpu_pick > and in get_fallback_cpu() itself), in order to be able >

[Xen-devel] [PATCH] x86/mm: Drop is_guest_l3_slot() and simply callers

2017-08-28 Thread Andrew Cooper
With a 64bit hypervisor there are no conditional l3 slots, and this is unlikely to change moving forwards. No functional change (as confirmed by diffing the disassembly. GCC obviously already optimised this code away.) Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu --- xen/arch

Re: [Xen-devel] [xen-unstable test] 112855: regressions - trouble: blocked/broken/fail/pass

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 16:24, wrote: >>> As for periodically testing process_pending_softirqs() we may still want >>> to do this in alloc_heap_pages(), even without CONFIG_SCRUB_DEBUG. >> For my taste, alloc_heap_pages() is the wrong place for such >> calls. > > But the loop is in alloc_heap_pages()

Re: [Xen-devel] [PATCH v2 4/6] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 16:24, wrote: > On 08/28/2017 09:29 AM, Jan Beulich wrote: > On 27.08.17 at 10:36, wrote: >>> --- a/xen/arch/arm/mm.c >>> +++ b/xen/arch/arm/mm.c >>> @@ -1284,7 +1284,7 @@ int xenmem_add_to_physmap_one( >>> return -EINVAL; >>> } >>> >>> -rc =

[Xen-devel] [ovmf baseline-only test] 72033: all pass

2017-08-28 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72033 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72033/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ef5e0db22cdd73e9727afcaa5c7fe8e55b7b3671 baseline v

Re: [Xen-devel] [PATCH v2 REPOST 03/12] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-08-28 Thread Wei Liu
On Tue, Aug 22, 2017 at 03:50:57PM +0100, Paul Durrant wrote: > + > +/* > + * Get the pages for a particular guest resource, so that they can be > + * mapped directly by a tools domain. > + */ > +#define XENMEM_acquire_resource 28 > +struct xen_mem_acquire_resource { > +/* IN - the domain whose

Re: [Xen-devel] [PATCH v2 REPOST 06/12] x86/hvm/ioreq: rename .*pfn and .*gmfn to .*gfn

2017-08-28 Thread Wei Liu
On Tue, Aug 22, 2017 at 03:51:00PM +0100, Paul Durrant wrote: > Since IOREQ servers are only relevant to HVM guests and all the names in > question unequivocally refer to guest frame numbers, name them all .*gfn > to avoid any confusion. > > This patch is purely cosmetic. No semantic or functional

Re: [Xen-devel] [PATCH] xen: fix boolean parameter handling

2017-08-28 Thread Jan Beulich
>>> On 28.08.17 at 16:49, wrote: > Commit 63e8a1e5ffa7a7fdbde887805f673fea7e8d2e94 ("xen: check parameter > validity when parsing command line") introduced a bug for the case > when a boolean parameter was specified by its keyword only (no value). > It would set just the wrong boolean value for th

Re: [Xen-devel] [PATCH v2 REPOST 05/12] tools/libxenctrl: use new xenforeignmemory API to seed grant table

2017-08-28 Thread Wei Liu
On Thu, Aug 24, 2017 at 05:09:35PM +0100, Paul Durrant wrote: > > > > Could be written as: > > > > return (is_hvm ? compat_gnttab_hvm_seed : compat_gnttab_seed) > >(xch, guest_domid, console_gmfn, xenstore_gmfn, console_domid, > > xenstore_domid); > > Is that preferable? > I do

  1   2   >