Re: [Xen-devel] [PATCH 26/27 v12] arm/xen: vpl011: Fix the slow early console SBSA UART output

2017-10-18 Thread Andre Przywara
Hi, On 18/10/17 11:17, Bhupinder Thakur wrote: > Hi Andre, > > On 17 October 2017 at 15:21, Andre Przywara wrote: >> Hi Bhupinder, >> >> first thing: As the bulk of the series has been merged now, please >> restart your patch and version numbering, so a (potential) next post >> should be prefixe

Re: [Xen-devel] [PATCH 27/27 v12] arm/xen: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-10-18 Thread Andre Przywara
Hi, On 13/10/17 11:40, Bhupinder Thakur wrote: > This patch fixes the issue observed when pl011 patches were tested on > the junos hardware by Andre/Julien. It was observed that when large > output is generated such as on running 'find /', output was getting > truncated intermittently due to OUT r

Re: [Xen-devel] [PATCH] x86/mm: Make PV linear pagetables optional

2017-10-18 Thread George Dunlap
On 10/18/2017 10:39 AM, Jan Beulich wrote: On 17.10.17 at 19:10, wrote: >> --- a/docs/misc/xen-command-line.markdown >> +++ b/docs/misc/xen-command-line.markdown >> @@ -1422,6 +1422,22 @@ The following resources are available: >> CDP, one COS will corespond two CBMs other than one with C

Re: [Xen-devel] [PATCH v2 for-4.10] ubsan: add clang 5.0 support

2017-10-18 Thread Wei Liu
On Wed, Oct 18, 2017 at 08:45:32AM +0100, Roger Pau Monne wrote: > clang 5.0 changed the layout of the type_mismatch_data structure and > introduced __ubsan_handle_type_mismatch_v1 and > __ubsan_handle_pointer_overflow. > > This commit adds support for the new structure layout, adds the > missing

Re: [Xen-devel] [PATCH 26/27 v12] arm/xen: vpl011: Fix the slow early console SBSA UART output

2017-10-18 Thread Bhupinder Thakur
Hi Andre, On 17 October 2017 at 15:21, Andre Przywara wrote: > Hi Bhupinder, > > first thing: As the bulk of the series has been merged now, please > restart your patch and version numbering, so a (potential) next post > should be prefixed [PATCH v3 1/2]. And please have a cover letter giving > a

Re: [Xen-devel] xenconsole: Define and use a macro INVALID_XEN_PFN instead of -1

2017-10-18 Thread Jan Beulich
>>> On 17.10.17 at 18:46, wrote: > --- a/tools/console/daemon/io.c > +++ b/tools/console/daemon/io.c > @@ -658,12 +658,12 @@ static void console_unmap_interface(struct console *con) > { > if (con->interface == NULL) > return; > - if (xgt_handle && con->ring_ref == -1) > +

Re: [Xen-devel] [PATCH] x86/mm: Make PV linear pagetables optional

2017-10-18 Thread Jan Beulich
>>> On 18.10.17 at 11:52, wrote: > On 10/18/2017 10:39 AM, Jan Beulich wrote: > On 17.10.17 at 19:10, wrote: >>> --- a/xen/arch/x86/Kconfig >>> +++ b/xen/arch/x86/Kconfig >>> @@ -97,6 +97,27 @@ config TBOOT >>> Technology (TXT) >>> >>> If unsure, say Y. >>> + >>> +config PV_LINE

Re: [Xen-devel] [PATCH v2 for-4.10] ubsan: add clang 5.0 support

2017-10-18 Thread Roger Pau Monné
On Wed, Oct 18, 2017 at 03:53:37AM -0600, Jan Beulich wrote: > >>> On 18.10.17 at 11:42, wrote: > > On Wed, Oct 18, 2017 at 03:23:20AM -0600, Jan Beulich wrote: > >> >>> On 18.10.17 at 09:45, wrote: > >> > +void __ubsan_handle_pointer_overflow(struct pointer_overflow_data *data, > >> > +

Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

2017-10-18 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0"): > CC'ing Julien for a release ack, as this is a blocker (due to regressing > the xendevicemodel ABI from Xen 4.9) Julien told me that straightforward bugfixes, which this is (indeed, as the

Re: [Xen-devel] [PATCH v2 for-4.10] ubsan: add clang 5.0 support

2017-10-18 Thread Jan Beulich
>>> On 18.10.17 at 11:42, wrote: > On Wed, Oct 18, 2017 at 03:23:20AM -0600, Jan Beulich wrote: >> >>> On 18.10.17 at 09:45, wrote: >> > +void __ubsan_handle_pointer_overflow(struct pointer_overflow_data *data, >> > + unsigned long base, unsigned long result) >> > +{ >> >

Re: [Xen-devel] [PATCH] x86/mm: Make PV linear pagetables optional

2017-10-18 Thread George Dunlap
On 10/18/2017 10:39 AM, Jan Beulich wrote: On 17.10.17 at 19:10, wrote: >> --- a/docs/misc/xen-command-line.markdown >> +++ b/docs/misc/xen-command-line.markdown >> @@ -1422,6 +1422,22 @@ The following resources are available: >> CDP, one COS will corespond two CBMs other than one with C

Re: [Xen-devel] [PATCH v2 2/2] x86/boot: rename send_chr to print_err

2017-10-18 Thread Jan Beulich
>>> On 17.10.17 at 23:41, wrote: > From: David Esler > > The send_chr function sends an entire C-string and not one character and > doesn't necessarily just send it over the serial UART anymore so rename > it to print_err so that its closer in name to what it does. > > Reviewed-by: Doug Goldste

Re: [Xen-devel] [PATCH v2 1/2] x86/boot: fix early error display

2017-10-18 Thread Jan Beulich
>>> On 17.10.17 at 23:41, wrote: > From: David Esler > > In 9180f5365524 a change was made to the send_chr function to take in > C-strings and print out a character at a time until a NULL was > encountered. However there is no code to increment the current character > position resulting in an en

[Xen-devel] [linux-linus test] 114658: regressions - FAIL

2017-10-18 Thread osstest service owner
flight 114658 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/114658/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 15 guest-saverestore.2 fail REGR. vs. 114643 test-amd64-i386-

Re: [Xen-devel] [PATCH v2 for-4.10] ubsan: add clang 5.0 support

2017-10-18 Thread Roger Pau Monné
On Wed, Oct 18, 2017 at 03:23:20AM -0600, Jan Beulich wrote: > >>> On 18.10.17 at 09:45, wrote: > > +void __ubsan_handle_pointer_overflow(struct pointer_overflow_data *data, > > + unsigned long base, unsigned long result) > > +{ > > + unsigned long flags; > > + > > +

Re: [Xen-devel] [PATCH for-next] x86/VT-x: Don't rewrite HOST_TR_SELECTOR on every context switch

2017-10-18 Thread Jan Beulich
>>> On 17.10.17 at 19:16, wrote: > TSS_ENTRY is a compile time constant, so HOST_TR_SELECTOR can be set up during > VMCS construction and left alone thereafter, rather than rewriting it on every > context switch. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

Re: [Xen-devel] [PATCH] x86/mm: Make PV linear pagetables optional

2017-10-18 Thread Jan Beulich
>>> On 17.10.17 at 19:10, wrote: > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -1422,6 +1422,22 @@ The following resources are available: > CDP, one COS will corespond two CBMs other than one with CAT, due to the > sum of CBMs is fixed, that

Re: [Xen-devel] [PATCH v2 for-4.10] ubsan: add clang 5.0 support

2017-10-18 Thread Jan Beulich
>>> On 18.10.17 at 09:45, wrote: > +void __ubsan_handle_pointer_overflow(struct pointer_overflow_data *data, > + unsigned long base, unsigned long result) > +{ > + unsigned long flags; > + > + if (suppress_report(&data->location)) > + return; > + > +

Re: [Xen-devel] [PATCH] x86/mm: Make PV linear pagetables optional

2017-10-18 Thread George Dunlap
On 10/17/2017 07:05 PM, Andrew Cooper wrote: > On 17/10/17 18:10, George Dunlap wrote: >> Allowing pagetables to point to other pagetables of the same level >> (often called 'linear pagetables') has been included in Xen since its >> inception; but recently it has been the source of a number of subt

Re: [Xen-devel] [PATCH] tools: libxendevicemodel: Restore symbol versions for 1.0

2017-10-18 Thread Ross Lagerwall
On 10/17/2017 06:05 PM, Ian Jackson wrote: In 1462f9ea8f4219d520a530787b80c986e050aa98 "tools: libxendevicemodel: Provide xendevicemodel_shutdown" we added a new version 1.1 to the symbol map and simply abolished the old one. That is quite wrong. Instead, we should have left the 1.0 map alone a

Re: [Xen-devel] [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-18 Thread Roger Pau Monné
On Wed, Oct 18, 2017 at 10:46:57AM +0200, Paolo Bonzini wrote: > On 18/10/2017 10:32, Roger Pau Monné wrote: > >> I'll have a try to check how much the differences would affect. If it > >> would not take too much work, I'd like to adapt Xen NVDIMM enabling > >> patches to the all QEMU built ACPI. O

Re: [Xen-devel] [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-18 Thread Paolo Bonzini
On 18/10/2017 10:32, Roger Pau Monné wrote: >> I'll have a try to check how much the differences would affect. If it >> would not take too much work, I'd like to adapt Xen NVDIMM enabling >> patches to the all QEMU built ACPI. Otherwise, I'll fall back to Paolo >> and MST's suggestions. > I don't a

Re: [Xen-devel] [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-18 Thread Roger Pau Monné
On Tue, Oct 17, 2017 at 08:16:47PM +0800, Haozhong Zhang wrote: > On 10/17/17 13:45 +0200, Paolo Bonzini wrote: > > On 14/10/2017 00:46, Stefano Stabellini wrote: > > > On Fri, 13 Oct 2017, Jan Beulich wrote: > > > On 13.10.17 at 13:13, wrote: > > >>> To Jan, Andrew, Stefano and Anthony, > > >

[Xen-devel] [PATCH v4 7/7] x86/msr: handle VMX MSRs with guest_rd/wrmsr()

2017-10-18 Thread Sergey Dyasli
Now that each domain has a correct view of VMX MSRs in it's per-domain MSR policy, it's possible to handle guest's RD/WRMSR with the new handlers. Do it and remove the old nvmx_msr_read_intercept() and associated bits. There is no functional change to what a guest sees in VMX MSRs. Signed-off-by:

[Xen-devel] [PATCH v4 6/7] x86/msr: update domain policy on CPUID policy changes

2017-10-18 Thread Sergey Dyasli
Availability of some MSRs depends on certain CPUID bits. Add function recalculate_domain_msr_policy() which updates availability of per-domain MSRs based on current domain's CPUID policy. This function is called when CPUID policy is changed from a toolstack. Add recalculate_domain_vmx_msr_policy()

[Xen-devel] [PATCH v4 5/7] x86/cpuid: update signature of hvm_cr4_guest_valid_bits()

2017-10-18 Thread Sergey Dyasli
With the new cpuid infrastructure there is a domain-wide struct cpuid policy and there is no need to pass a separate struct vcpu * into hvm_cr4_guest_valid_bits() anymore. Make the function accept struct domain * instead and update callers. Signed-off-by: Sergey Dyasli --- xen/arch/x86/hvm/domai

[Xen-devel] [PATCH v4 1/7] x86/msr: add Raw and Host domain policies

2017-10-18 Thread Sergey Dyasli
Raw policy contains the actual values from H/W MSRs. PLATFORM_INFO msr needs to be read again because probe_intel_cpuid_faulting() records the presence of X86_FEATURE_CPUID_FAULTING but not the presence of msr itself (if cpuid faulting is not available). Host policy might have certain features dis

[Xen-devel] [PATCH v4 4/7] x86/msr: add VMX MSRs into HVM_max domain policy

2017-10-18 Thread Sergey Dyasli
Currently, when nested virt is enabled, the set of L1 VMX features is fixed and calculated by nvmx_msr_read_intercept() as an intersection between the full set of Xen's supported L1 VMX features, the set of actual H/W features and, for MSR_IA32_VMX_EPT_VPID_CAP, the set of features that Xen uses.

[Xen-devel] [PATCH v4 3/7] x86/msr: read VMX MSRs values into Raw policy

2017-10-18 Thread Sergey Dyasli
Add calculate_raw_vmx_policy() which fills Raw policy with H/W values of VMX MSRs. Host policy will contain a copy of these values. Signed-off-by: Sergey Dyasli --- xen/arch/x86/msr.c | 33 + 1 file changed, 33 insertions(+) diff --git a/xen/arch/x86/msr.c b/xen/

[Xen-devel] [PATCH v4 2/7] x86/msr: add VMX MSRs into struct msr_domain_policy

2017-10-18 Thread Sergey Dyasli
New definitions provide a convenient way of accessing contents of VMX MSRs. They are separated into 5 logical blocks: 1. vmx: [VMX_BASIC, VMX_VMCS_ENUM] 2. VMX_PROCBASED_CTLS2 3. VMX_EPT_VPID_CAP 4. vmx_true_ctls: [VMX_TRUE_PINBASED_CTLS, VMX_TRUE_ENTRY_CTLS] 5. VMX_VMFUNC Eve

[Xen-devel] [PATCH v4 0/7] VMX MSRs policy for Nested Virt: part 1

2017-10-18 Thread Sergey Dyasli
The end goal of having VMX MSRs policy is to be able to manage L1 VMX features. This patch series is the first part of this work. There is no functional change to what L1 sees in VMX MSRs at this point. But each domain will have a policy object which allows to sensibly query what VMX features the d

[Xen-devel] [PATCH v2 for-4.10] ubsan: add clang 5.0 support

2017-10-18 Thread Roger Pau Monne
clang 5.0 changed the layout of the type_mismatch_data structure and introduced __ubsan_handle_type_mismatch_v1 and __ubsan_handle_pointer_overflow. This commit adds support for the new structure layout, adds the missing handlers and the new types for type_check_kinds. Signed-off-by: Roger Pau Mo

Re: [Xen-devel] [PATCH v3 2/6] x86/msr: add VMX MSRs into struct msr_domain_policy

2017-10-18 Thread Sergey Dyasli
On Mon, 2017-10-16 at 15:01 +0100, Andrew Cooper wrote: > On 16/10/17 08:42, Sergey Dyasli wrote: > > + > > +secondary_available = > > +dp->vmx_procbased_ctls.u.allowed_1.activate_secondary_controls; > > + > > +switch (msr) > > +{ > > +case MSR_IA32_VMX_BASIC ... MSR_IA32_VM

<    1   2