is slightly simpler.
Signed-off-by: Arnd Bergmann
---
drivers/watchdog/xen_wdt.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/watchdog/xen_wdt.c b/drivers/watchdog/xen_wdt.c
index cf0e650c2015..5dd5c3494d55 100644
--- a/drivers/watchdog/xen_wdt.c
+++ b
to communicate the boot time between host and guest
in a virtual environment. This will work until 2106, but we
should ideally find a replacement anyway. I've added a comment
about it there.
Reviewed-by: Boris Ostrovsky
Signed-off-by: Arnd Bergmann
---
v2 changes:
- move comment block (
On Mon, Oct 16, 2017 at 2:08 PM, Paolo Bonzini wrote:
> On 16/10/2017 10:11, Arnd Bergmann wrote:
>> Thanks!
>>
>> Since you've looked at it overall, do you have an opinion on the question
>> how to fix the PV interface to deal with the pvclock_wall_clock
On Fri, Oct 13, 2017 at 10:45 PM, Boris Ostrovsky
wrote:
> On 10/13/2017 02:37 PM, Arnd Bergmann wrote:
>> The x86 platform operations are fairly isolated, so we can
>> change them from using timespec to timespec64. I checked that
>> All the users and callers are safe,
to communicate the boot time between host and guest
in a virtual environment. This will work until 2106, but we
should ideally find a replacement anyway. I've added a comment
about it there.
Signed-off-by: Arnd Bergmann
---
arch/x86/include/asm/intel_mid_vrtc.h| 4 ++--
arch/x86/in
s]
.mmap = xen_swiotlb_dma_mmap,
^~~~
arm/xen/mm.c:202:10: note: (near initialization for 'xen_swiotlb_dma_ops.mmap')
This adapts the patch to the old calling conventions.
Fixes: 2f0b82b1b830 ("swiotlb-xen: implement xen_swiotlb_dma_mmap callback"
On Wed, Oct 4, 2017 at 10:41 AM, Olof's autobuilder wrote:
>
> Warnings:
>
> 1 arm/xen/mm.c:202:2: warning: initialization from incompatible pointer
> type
> 1 arm/xen/mm.c:202:2: warning: (near initialization for
> 'xen_swiotlb_dma_ops.mmap')
> 1 drivers/xen/swiotlb-xen.c:697:
lacks a __init
annotation or the annotation of m2p is wrong.
Newer compilers inline this function, so it never shows up, but marking
it __init is the right way to avoid the warning.
Fixes: 70e61199559a ("xen: move p2m list if conflicting with e820 map")
Signed-off-by: Arnd Bergmann
---
shall I include this patch in the kbuild/fixes pull request?
> (planned this week)
>
> Please let me know your thought.
Yes, I think it would be good to have in 4.13, since it's a regression
against older kernels.
> 2017-07-26 22:36 GMT+09:00 Arnd Bergmann :
>> A previous pat
literal would be bad here.
Since wchar_t is always defined as u16, independent of the toolchain
default, always passing -fshort-wchar is correct and lets us
remove the Xen specific hack along with fixing the warning.
Signed-off-by: Arnd Bergmann
Fixes: 971a69db7dc0 ("Xen: don't warn ab
_WARN' [-Werror=implicit-function-declaration]
Unfortunately, there is no equivalent of BUG() that takes no
arguments, but WARN_ON(1) is commonly used in other drivers
and works on all configurations.
Fixes: 7160378206b2 ("xen/pvcalls: xenbus state handling")
Signed-off-by: Arnd Berg
On Wed, Jul 12, 2017 at 3:10 PM, Greg Kroah-Hartman
wrote:
> On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote:
>> [ Very random list of maintainers and mailing lists, at least
>> partially by number of warnings generated by gcc-7.1.1 that is then
>> correlated with the get_maintainer
On Wed, Jul 12, 2017 at 5:41 AM, Linus Torvalds
wrote:
>
> We also have about a bazillion
>
> warning: ‘*’ in boolean context, suggest ‘&&’ instead
>
> warnings in drivers/ata/libata-core.c, all due to a single macro that
> uses a pattern that gcc-7.1.1 doesn't like. The warning looks a bit
>
On Tue, Jul 11, 2017 at 6:58 AM, Brian Gerst wrote:
> On Mon, Jul 10, 2017 at 3:50 PM, Tom Lendacky wrote:
>> On 7/8/2017 7:57 AM, Brian Gerst wrote:
>>> On Fri, Jul 7, 2017 at 9:39 AM, Tom Lendacky
>>
>> I originally had a check for SME here in a previous version of the
>> patch. Thomas Gleixn
daa2ac80834d ("kernel.h: handle pointers to arrays better in
container_of()")
Signed-off-by: Arnd Bergmann
---
v2: found the correct warning message and updated the changelog
---
arch/arm/include/asm/xen/events.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arc
kernel.h: handle pointers to arrays better in
container_of()")
Signed-off-by: Arnd Bergmann
---
arch/arm/include/asm/xen/events.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/xen/events.h
b/arch/arm/include/asm/xen/events.h
index 71e473d05fcc..620dc75362e5 10
All Xen frontends need to select this symbol to avoid a link error:
net/built-in.o: In function `p9_trans_xen_init':
:(.text+0x149e9c): undefined reference to `__xenbus_register_frontend'
Fixes: d4b40a02f837 ("xen/9pfs: build 9pfs Xen transport driver")
Signed-off-by: Arnd B
On Friday, January 6, 2017 10:43:52 AM CET Nicolas Dichtel wrote:
> Here is the v2 of this series. The first 5 patches are just cleanup: some
> exported headers were still under a non-uapi directory.
Since this is meant as a cleanup, I commented on this to point out a cleaner
way to do the same.
On Friday, January 6, 2017 10:43:55 AM CET Nicolas Dichtel wrote:
> diff --git a/arch/nios2/include/uapi/asm/setup.h
> b/arch/nios2/include/uapi/asm/setup.h
> new file mode 100644
> index ..8d8285997ba8
> --- /dev/null
> +++ b/arch/nios2/include/uapi/asm/setup.h
> @@ -0,0 +1,6 @@
> +#
On Friday, January 6, 2017 10:43:53 AM CET Nicolas Dichtel wrote:
>
> diff --git a/arch/arm/include/asm/types.h b/arch/arm/include/asm/types.h
> index a53cdb8f068c..c48fee3d7b3b 100644
> --- a/arch/arm/include/asm/types.h
> +++ b/arch/arm/include/asm/types.h
> @@ -1,40 +1,6 @@
> #ifndef _ASM_TYPE
On Tuesday, January 3, 2017 3:35:44 PM CET Nicolas Dichtel wrote:
> Regularly, when a new header is created in include/uapi/, the developer
> forgets to add it in the corresponding Kbuild file. This error is usually
> detected after the release is out.
>
> In fact, all headers under include/uapi/
uld be sufficient.
Fixes: f95842e7a9f2 ("xen: make use of xenbus_read_unsigned() in xen-netback")
Fixes: 8d3d53b3e433 ("xen-netback: Add support for multiple queues")
Signed-off-by: Arnd Bergmann
---
drivers/net/xen-netback/xenbus.c | 2 +-
1 file changed, 1 insertion(+)
/enlighten.c:143:12: warning: ‘xen_cpu_dead’ used but never defined
Fixes: 4d737042d6c4 ("xen/x86: Convert to hotplug state machine")
Signed-off-by: Arnd Bergmann
---
arch/x86/xen/enlighten.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/e
on is that XEN_PAGE_SIZE is not size_t here. There
is no actual bug, and we can easily avoid the warning using the
min_t() macro instead of min().
Fixes: eb1723a29b9a ("xen-netback: refactor guest rx")
Signed-off-by: Arnd Bergmann
---
drivers/net/xen-netback/rx.c | 6 +++---
1 file changed
On Thursday, August 11, 2016 6:51:33 AM CEST Jan Beulich wrote:
> >>> On 11.08.16 at 14:39, wrote:
> > A previous patch added the --no-wchar-size-warning to the Makefile to
> > avoid this harmless warning:
> >
> > arm-linux-gnueabi-ld: warning: drivers/xen/efi.o uses 2-byte wchar_t yet
> > the
s not use wchar_t at all.
Signed-off-by: Arnd Bergmann
Fixes: 971a69db7dc0 ("Xen: don't warn about 2-byte wchar_t in efi")
---
On Thursday, August 11, 2016 8:16:14 PM CEST Nicholas Piggin wrote:
> Hi,
>
> I would like to submit the kbuild changes in patches 1-3 for
> c
On Thursday, May 26, 2016 11:32:40 AM CEST David Vrabel wrote:
> On 11/05/16 14:07, Arnd Bergmann wrote:
> > A bugfix patch for the xen balloon driver introduced a forward
> > declaration for a static function that is conditionally compiled,
> > causing a warning if only th
On Monday 16 May 2016 12:08:17 Stefano Stabellini wrote:
> On Wed, 11 May 2016, Arnd Bergmann wrote:
> > The XEN UEFI code has become available on the ARM architecture
> > recently, but now causes a link-time warning:
> >
> > ld: warning: drivers/xen/efi.o uses 2-byte w
that introduced the warning is marked for stable
backports, so if that gets applied to 4.4, so should this one.
Signed-off-by: Arnd Bergmann
Fixes: dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE")
Cc: sta...@vger.kernel.org
---
drivers/xen/balloon.c | 28 ++
wchar-size-warning to the linker, to avoid the warning.
Signed-off-by: Arnd Bergmann
Fixes: 37060935dc04 ("ARM64: XEN: Add a function to initialize Xen specific
UEFI runtime services")
---
drivers/xen/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/xen/Makefile b/drive
.
Signed-off-by: Arnd Bergmann
Fixes: a4cdb556cae0 ("xen/gntdev: add ioctl for grant copy")
---
drivers/xen/gntdev.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
I sent this in January, Boris sent an almost identical patch
as http://www.gossamer-threads.com
On Tuesday 16 February 2016 12:14:14 Stefano Stabellini wrote:
> > at all.
>
> Please correct me if I am wrong, but the difference is that with this
> change if INPUT=m, then the build system would ask the user whether she
> wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of
> uncondi
es both, and anyone using an old .config file would
keep having both enabled.
Signed-off-by: Arnd Bergmann
Suggested-by: David Vrabel
Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
inde
On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote:
> >
> > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > index 8ea45a5cd806..fd3d6fd290a9 100644
> > --- a/drivers/video/fbdev/Kconfig
> > +++ b/drivers/video/fbdev/Kconfig
> > @@ -2241,6 +2241,7 @@ config FB_V
.
Signed-off-by: Arnd Bergmann
Fixes: a4cdb556cae0 ("xen/gntdev: add ioctl for grant copy")
---
This is a regression against v4.4, found with ARM randconfig testing.
diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
index dc495383ad73..cc753b3a7154 100644
--- a/drivers/xen/gntd
On Wednesday 18 November 2015 15:01:26 Shannon Zhao wrote:
> Hi Arnd,
>
> On 2015/11/17 17:50, Arnd Bergmann wrote:
> > On Tuesday 17 November 2015 17:40:03 shannon.z...@linaro.org wrote:
> >> +/*
> >> + * Emulate x86 io ports for arm.
> >> + */
> >
On Tuesday 17 November 2015 17:40:03 shannon.z...@linaro.org wrote:
> +/*
> + * Emulate x86 io ports for arm.
> + */
> +#define __armio(addr) ( (void __iomem *)addr )
> +
> +#define inb(c) ( readb( __armio(c) ) )
> +#define inw(c) ( readw( __armio(c) ) )
> +#define inl(c) ( readl( __armio(c) ) )
>
On Thursday 12 November 2015 12:16:47 Boris Ostrovsky wrote:
> >>> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> >>> index 663c2ea..3bbd377 100644
> >>> --- a/arch/x86/xen/time.c
> >>> +++ b/arch/x86/xen/time.c
> >>> @@ -134,10 +134,10 @@ static int xen_pvclock_gtod_notify(struct
> >>> n
nt.
>
> Return NOTIFY_BAD in case of errors.
>
> Signed-off-by: Stefano Stabellini
> CC: konrad.w...@oracle.com
> CC: david.vra...@citrix.com
> CC: boris.ostrov...@oracle.com
>
Acked-by: Arnd Bergmann
___
Xen-devel mailing list
Xen-d
On Thursday 12 November 2015 17:30:46 Stefano Stabellini wrote:
> Read the wallclock from the shared info page at boot time.
>
> Signed-off-by: Stefano Stabellini
>
Acked-by: Arnd Bergmann
___
Xen-devel mailing list
Xen-devel@lists.
On Thursday 12 November 2015 10:30:23 Boris Ostrovsky wrote:
> > diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> > index 663c2ea..3bbd377 100644
> > --- a/arch/x86/xen/time.c
> > +++ b/arch/x86/xen/time.c
> > @@ -134,10 +134,10 @@ static int xen_pvclock_gtod_notify(struct
> > notifier_blo
On Wednesday 11 November 2015 16:51:36 Stefano Stabellini wrote:
> If Linux is running as dom0, call XENPF_settime64 to update the system
> time in Xen on pvclock_gtod notifications.
>
> Signed-off-by: Stefano Stabellini
>
Acked-by
On Wednesday 11 November 2015 16:51:35 Stefano Stabellini wrote:
> +static void xen_read_wallclock(struct timespec64 *ts)
> +{
> + u32 version;
> + u64 delta;
> + struct timespec64 now;
> + struct shared_info *s = HYPERVISOR_shared_info;
> + struct pvclock_wall_clock *
On Wednesday 11 November 2015 11:51:26 Stefano Stabellini wrote:
> On Tue, 10 Nov 2015, Thomas Gleixner wrote:
> > On Tue, 10 Nov 2015, John Stultz wrote:
> > > I'm sort of objecting to a different issue, where the
> > > __current_kernel_time() implementation probably shouldn't be grabbing
> > > th
On Tuesday 10 November 2015 14:43:26 Stefano Stabellini wrote:
> On Tue, 10 Nov 2015, Arnd Bergmann wrote:
> > On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote:
> > > Rename the current XENPF_settime hypercall and related struct to
> > > XENPF_settime32.
On Tuesday 10 November 2015 11:57:55 Stefano Stabellini wrote:
> + op.u.settime64.nsecs = now.tv_nsec;
> + op.u.settime64.system_time = arch_timer_read_counter() *
> (u64)NSEC_PER_SEC;
> + do_div(op.u.settime64.system_time, arch_timer_get_rate());
NSEC_PER_SEC is a large number,
On Tuesday 10 November 2015 11:57:54 Stefano Stabellini wrote:
> +static void xen_read_wallclock(struct timespec64 *ts)
> +{
> + u32 version;
> + u64 delta;
> + struct timespec64 now;
> + struct shared_info *s = HYPERVISOR_shared_info;
> + struct pvclock_wall_clock *wa
On Tuesday 10 November 2015 11:57:52 Stefano Stabellini wrote:
> Rename the current XENPF_settime hypercall and related struct to
> XENPF_settime32.
>
> Signed-off-by: Stefano Stabellini
> CC: konrad.w...@oracle.com
> CC: david.vra...@citrix.com
> CC: boris.ostrov...@oracle.com
Looks good.
> --
On Tuesday 10 November 2015 11:57:49 Stefano Stabellini wrote:
> __current_kernel_time64 returns a struct timespec64, without taking the
> xtime lock. Mirrors __current_kernel_time/current_kernel_time.
>
Actually it doesn't mirror __current_kernel_time/current_kernel_time
> diff --git a/include/
On Monday 09 November 2015 17:42:50 Stefano Stabellini wrote:
> On Mon, 9 Nov 2015, Stefano Stabellini wrote:
> > On Mon, 9 Nov 2015, Arnd Bergmann wrote:
> > > On Monday 09 November 2015 14:10:22 Stefano Stabellini wrote:
> > >
> > > Just to make sure that th
On Monday 09 November 2015 17:14:24 Stefano Stabellini wrote:
> On Mon, 9 Nov 2015, Arnd Bergmann wrote:
> > On Monday 09 November 2015 13:53:30 Stefano Stabellini wrote:
> > > On Fri, 6 Nov 2015, Arnd Bergmann wrote:
> > > > I'm not quite sure about how the s
On Monday 09 November 2015 13:53:30 Stefano Stabellini wrote:
> On Fri, 6 Nov 2015, Arnd Bergmann wrote:
> > I'm not quite sure about how the split between pvclock_wall_clock and
> > the delta works. Normally I'd expect that pvclock_wall_clock is the
> > wallc
On Monday 09 November 2015 14:10:22 Stefano Stabellini wrote:
> On Thu, 5 Nov 2015, Arnd Bergmann wrote:
> > On Thursday 05 November 2015 17:09:45 Stefano Stabellini wrote:
> > > + now = __current_kernel_time();
> >
> > We don't have __current_kernel_time64(
On Friday 06 November 2015 15:09:53 Stefano Stabellini wrote:
> > > ---
> > > +static void xen_read_wallclock(struct timespec *ts)
> > > +{
> > > + u32 version;
> > > + u64 delta;
> > > + struct timespec now;
> > > + struct shared_info *s = HYPERVISOR_shared_info;
> > > + struct pvclock_w
On Thursday 05 November 2015 17:09:45 Stefano Stabellini wrote:
> If Linux is running as dom0, call XENPF_settime to update the system
> time in Xen on pvclock_gtod notifications.
>
> Signed-off-by: Stefano Stabellini
> Signed-off-by: Ian Campbell
> ---
> arch/arm/xen/enlighten.c | 52
>
On Thursday 05 November 2015 17:09:43 Stefano Stabellini wrote:
> Read the wallclock from the shared info page at boot time.
>
> Signed-off-by: Stefano Stabellini
Please use the appropriate timespec64 based functions here,
we are in the process of converting all callers of struct timespec.
> --
On Tuesday 15 September 2015 14:14:09 David Vrabel wrote:
> On 14/09/15 12:32, Arnd Bergmann wrote:
> > On Monday 14 September 2015 13:04:59 Roger Pau Monné wrote:
> >>> TBH, I'm expecting a small impact to the performance. It would be hard
> >>> to get the ex
On Monday 14 September 2015 13:04:59 Roger Pau Monné wrote:
> > TBH, I'm expecting a small impact to the performance. It would be hard
> > to get the exactly the same performance as today if we keep the helpers
> > to avoid the backend dealing himself with the splitting and page
> > granularity.
>
On Thursday 25 June 2015 15:01:56 Casey Leedom wrote:
>
> Is there a reference I can read on this so I can understand
> when and where we can use the __raw_*() APIs? Can these
> Raw Read/Write operations be reordered with respect to
> each other or are the use of the various flavors of SYNC
> i
On Friday 19 June 2015 15:08:23 Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez"
>
> Arnd,
>
> After a long-winded conversation with Bjorn over use of
> EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() he's noted he'd
> be OK if this goes through you as an alternative. This series
> goes unmod
rt to remove instances of
> 32-bit timekeeping variables (timeval, time_t and timespec)
> from the kernel.
>
> Signed-off-by: Tina Ruchandani
> Suggested-by: Arnd Bergmann
>
Reviewed-by: Arnd Bergmann
___
Xen-devel mailing lis
On Tuesday 19 May 2015 09:57:19 Boris Ostrovsky wrote:
> On 05/19/2015 08:58 AM, Arnd Bergmann wrote:
> > A recent bug fix for x86 broke Xen on ARM for the case that
> > CONFIG_HIBERNATE_CALLBACKS is enabled:
> >
> > drivers/built-in.o: In function `do_suspend
ference to
`xen_arch_suspend'
It is not clear to me what needs to be done here, but this
patch avoids the build error by adding a stub for the
missing function.
Signed-off-by: Arnd Bergmann
Fixes: 2b953a5e99 ("xen: Suspend ticks on all CPUs during suspend")
---
Please review, and submit a
On Monday 11 May 2015 08:14:48 Tina Ruchandani wrote:
> struct timeval uses a 32-bit field for representing seconds,
> which will overflow in the year 2038 and beyond. This patch replaces
> struct timeval with 64-bit ktime_t which is 2038 safe.
> The patch is part of a larger effort to remove insta
64 matches
Mail list logo
