[Xen-devel] [PATCH] block: xen-blkback: don't get/put blkif ref for each queue

xen_blkif_deferred_free() to free resources anymore. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/xenbus.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 3cc6d1d..2e1bb6d

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

On 08/10/2016 10:54 PM, Evgenii Shatokhin wrote: > On 10.08.2016 15:49, Bob Liu wrote: >> >> On 08/10/2016 08:33 PM, Evgenii Shatokhin wrote: >>> On 14.07.2016 15:04, Bob Liu wrote: >>>> >>>> On 07/14/2016 07:49 PM, Evgenii Shatokhin

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

On 08/10/2016 08:33 PM, Evgenii Shatokhin wrote: > On 14.07.2016 15:04, Bob Liu wrote: >> >> On 07/14/2016 07:49 PM, Evgenii Shatokhin wrote: >>> On 11.07.2016 15:04, Bob Liu wrote: >>>> >>>> >>>> On 07/11/2016 04:50 PM, Evgenii Shat

[Xen-devel] [PATCH v2] libxl: return any serial tty path in libxl_console_get_tty

When specifying a serial list in domain config, users of libxl_console_get_tty cannot get the tty path of a second specified pty serial, since right now it always returns the tty path of serial 0. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: Rename the patch title. --- tools/libxl/l

[Xen-devel] [PATCH] tools:libxl: return tty path for all serials

When specifying a serial list in domain config, users of libxl_console_get_tty cannot get the tty path of a second specified pty serial, since right now it always returns the tty path of serial 0. Signed-off-by: Bob Liu <bob@oracle.com> --- tools/libxl/libxl.c |2 +- 1 file chan

Re: [Xen-devel] [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

On 07/28/2016 09:19 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Jul 26, 2016 at 01:19:35PM +0800, Bob Liu wrote: >> Two places didn't get updated when 64KB page granularity was introduced, this >> patch fix them. >> >> Signed-off-by: Bob Liu <bob@oracle.com> &g

[Xen-devel] [PATCH 3/3] xen-blkfront: free resources if xlvbd_alloc_gendisk fails

Current code forgets to free resources in the failure path of xlvbd_alloc_gendisk(), this patch fix it. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/d

[Xen-devel] [PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits()

blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits with initial correct values. Signed-off-by: Bob Liu <bob@oracle.com> Acked-by: Roger Pau Monné <roger@citrix.com> --- d

[Xen-devel] [PATCH v2 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

Two places didn't get updated when 64KB page granularity was introduced, this patch fix them. Signed-off-by: Bob Liu <bob@oracle.com> Acked-by: Roger Pau Monné <roger@citrix.com> --- drivers/block/xen-blkfront.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Xen-devel] [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/27/2016 10:24 PM, Roger Pau Monné wrote: > On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote: >> >> On 07/27/2016 06:59 PM, Roger Pau Monné wrote: >>> On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: >>> [...] >>>> +static ssize_t

Re: [Xen-devel] [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/27/2016 06:59 PM, Roger Pau Monné wrote: > On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > [...] >> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t >> count) >> +{ >> +/* >> + * Prevent new req

Re: [Xen-devel] [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/27/2016 04:07 PM, Roger Pau Monné wrote: ..[snip].. >> @@ -2443,6 +2674,22 @@ static void blkfront_connect(struct blkfront_info >> *info) >> return; >> } >> >> +err = device_create_file(>xbdev->dev, >> _attr_max_ring_page_order); >> +if (err) >> +

[Xen-devel] [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

s/vbd-xxx/max_queues Signed-off-by: Bob Liu <bob@oracle.com> -- v3: * Remove new_max_indirect_segments. * Fix BUG_ON(). v2: * Rename to max_ring_page_order. * Remove the waiting code suggested by Roger. --- drivers/block/xen-blkfront.c | 277 -- 1 fi

Re: [Xen-devel] [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/26/2016 04:44 PM, Roger Pau Monné wrote: > On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect

[Xen-devel] [PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits()

blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits with initial correct values. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: Move blkif_set_queue_limits()

[Xen-devel] [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

Two places didn't get updated when 64KB page granularity was introduced, this patch fix them. Signed-off-by: Bob Liu <bob@oracle.com> Acked-by: Roger Pau Monné <roger@citrix.com> --- drivers/block/xen-blkfront.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[Xen-devel] [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

s/vbd-xxx/max_queues Signed-off-by: Bob Liu <bob@oracle.com> -- v2: Rename to max_ring_page_order and rm the waiting code suggested by Roger. --- drivers/block/xen-blkfront.c | 275 +- 1 file changed, 269 insertions(+), 6 deletions(-) diff --git a/dr

Re: [Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/25/2016 08:11 PM, Roger Pau Monné wrote: > On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: >> >> On 07/25/2016 06:53 PM, Roger Pau Monné wrote: >> ..[snip..] >>>>>> * We get the device lock and blk_mq_freeze_queue() in >>>>&g

Re: [Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/25/2016 06:53 PM, Roger Pau Monné wrote: ..[snip..] * We get the device lock and blk_mq_freeze_queue() in dynamic_reconfig_device(), and then have to release in blkif_recover() asynchronously which makes the code more difficult to readable. >>> >>> I'm not sure I'm

Re: [Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: >> >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >>>> >>>> On 07/22/2016 05:34

Re: [Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >> >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >>>> >>>> On 07/22/2016 03:45

Re: [Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >> >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: >>> On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >>>> >>>> On 07/21/

Re: [Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >> >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: ..[snip].. >>>> + >>>> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, >&

Re: [Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect

Re: [Xen-devel] [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

On 07/21/2016 04:29 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote: >> blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not >> as xen-blkfront expected, introducing blkif_set_queue_limits() to reset >> limits &g

Re: [Xen-devel] [RFC Design Doc v2] Add vNVDIMM support for Xen

Hey Haozhong, On 07/18/2016 08:29 AM, Haozhong Zhang wrote: > Hi, > > Following is version 2 of the design doc for supporting vNVDIMM in This version is really good, very clear and included almost everything I'd like to know. > Xen. It's basically the summary of discussion on previous v1

[Xen-devel] [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

Two places didn't get updated when 64KB page granularity was introduced, this patch fix them. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/blo

[Xen-devel] [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

s/vbd-xxx/max_queues Signed-off-by: Bob Liu <bob@oracle.com> -- v2: Add device lock and other comments from Konrad. --- drivers/block/xen-blkfront.c | 285 ++- 1 file changed, 283 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/dr

[Xen-devel] [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits with initial correct values. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

On 07/14/2016 07:49 PM, Evgenii Shatokhin wrote: > On 11.07.2016 15:04, Bob Liu wrote: >> >> >> On 07/11/2016 04:50 PM, Evgenii Shatokhin wrote: >>> On 06.06.2016 11:42, Dario Faggioli wrote: >>>> Just Cc-ing some Linux, block, and Xen on CentO

Re: [Xen-devel] [BUG] kernel BUG at drivers/block/xen-blkfront.c:1711

On 07/11/2016 04:50 PM, Evgenii Shatokhin wrote: > On 06.06.2016 11:42, Dario Faggioli wrote: >> Just Cc-ing some Linux, block, and Xen on CentOS people... >> > > Ping. > > Any suggestions how to debug this or what might cause the problem? > > Obviously, we cannot control Xen on the Amazon's

Re: [Xen-devel] [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

On 06/27/2016 04:33 PM, Bob Liu wrote: > Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() > during > migration, but that's too later after multi-queue introduced. > > After a migrate to another host (which may not have multiqueue support), the > numb

[Xen-devel] [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

(). Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 91 +++- 1 file changed, 40 insertions(+), 51 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 2e6d1e9..fcc5b4e 100644 --- a/drivers

Re: [Xen-devel] [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

On 06/07/2016 11:25 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 01, 2016 at 01:49:23PM +0800, Bob Liu wrote: >> >> On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote: >>> On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote: >>>> Sometimes blkfo

Re: [Xen-devel] [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote: > On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote: >> Sometimes blkfont may receive twice blkback_changed() notification after >> migration, then talk_to_blkback() will be called twice too and confused >> xen-bl

[Xen-devel] [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

Sometimes blkfont may receive twice blkback_changed() notification after migration, then talk_to_blkback() will be called twice too and confused xen-blkback. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Xen-devel] [PATCH 2/2] xen-blkfront: fix resume issues

store rinfo pointer to hctx->driver_data, because rinfo may be * reallocated so using hctx->queue_num to get the rinfo structure instead. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 20 1 file changed, 8 insertions(+), 12 deleti

Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

On 04/20/2016 04:59 PM, David Vrabel wrote: > On 20/04/16 08:26, Bob Liu wrote: >> >> /* >> + * Recognized only if "feature-data-integrity" is present in backend xenbus >> info. >> + * A request with BLKIF_OP_DIX_FLAG indicates the following request

[Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

. * Proposal for transmitting integrity-metadata-segment scatterlist. Adding an extra request following the normal data request, this extra request contains integrity-metadata segments only. The xen-blkback will reconstruct the new bio with recevied data and integrity segments. Signed-off-by: Bob Liu

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

On 04/07/2016 06:00 PM, Bob Liu wrote: > * What's data integrity extension and why? > Modern filesystems feature checksumming of data and metadata to protect > against > data corruption. However, the detection of the corruption is done at read > time > which could potential

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

On 04/08/2016 10:32 PM, David Vrabel wrote: > On 08/04/16 15:20, Ian Jackson wrote: >> David Vrabel writes ("Re: [RFC PATCH] Data integrity extension support for >> xen-block"): >>> You need to read the relevant SCSI specification and find out what >>> interfaces and behaviour the hardware has

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

On 04/08/2016 05:44 PM, Roger Pau Monné wrote: > On Fri, 8 Apr 2016, Bob Liu wrote: >> >> On 04/07/2016 11:55 PM, Juergen Gross wrote: >>> On 07/04/16 12:00, Bob Liu wrote: >>>> * What's data integrity extension and why? >>>> Modern filesystems feat

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

On 04/07/2016 11:55 PM, Juergen Gross wrote: > On 07/04/16 12:00, Bob Liu wrote: >> * What's data integrity extension and why? >> Modern filesystems feature checksumming of data and metadata to protect >> against >> data corruption. However, the detection of the

[Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

] http://lwn.net/Articles/280023/ [2] https://www.kernel.org/doc/Documentation/block/data-integrity.txt Signed-off-by: Bob Liu <bob@oracle.com> --- xen/include/public/io/blkif.h | 50 + 1 file changed, 50 insertions(+) diff --git a/xen/include/

Re: [Xen-devel] [PATCH] blkif.h: document scsi/0x12/0x node

On 03/23/2016 08:33 PM, Roger Pau Monné wrote: > On Wed, 23 Mar 2016, Bob Liu wrote: > >> This patch documents a xenstore node which is used by XENVBD Windows PV >> driver. >> >> The use case is that XenServer may have OEM specific storage backends and >> ther

[Xen-devel] [PATCH] blkif.h: document scsi/0x12/0x node

is the easiest way to get this VPD information from the backend into guest where XENVBD Windows PV driver can get INQUIRY VPD data from this node and return to OEM software. Signed-off-by: Bob Liu <bob@oracle.com> --- xen/include/public/io/blkif.h | 24 1 file chang

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

On 03/17/2016 07:12 PM, Ian Jackson wrote: > David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document > scsi/0x12/0x83 node"): >> On 16/03/16 13:59, Bob Liu wrote: >>> But we'd like to get the VPD information(of underlying storage device) also >&

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

On 03/16/2016 10:32 PM, David Vrabel wrote: > On 16/03/16 13:59, Bob Liu wrote: >> >> But we'd like to get the VPD information(of underlying storage device) also >> in Linux blkfront, even blkfront is not a SCSI device. > > Why does blkback/blkfront need to involv

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

On 03/16/2016 10:07 PM, Paul Durrant wrote: >> -Original Message- >> From: Bob Liu [mailto:bob@oracle.com] ..snip.. >>> >> >> But we'd like to get the VPD information(of underlying storage device) also >> in >> Linux blkfront, even blkfro

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

On 03/16/2016 08:36 PM, Ian Jackson wrote: > Bob Liu writes ("[RFC PATCH] blkif.h: document scsi/0x12/0x83 node"): >> Sometimes, we need to query VPD page=0x83 data from underlying >> storage so that vendor supplied software can run inside the VM and >> believe i

[Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

frontends can use the same mechanism. Signed-off-by: Bob Liu <bob@oracle.com> --- xen/include/public/io/blkif.h |8 1 file changed, 8 insertions(+) diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h index 99f0326..30a6e46 100644 --- a/xen/include/p

Re: [Xen-devel] [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands

On 03/02/2016 07:40 PM, Ian Jackson wrote: > Bob Liu writes ("Re: [RFC PATCH] xen-block: introduces extra request to > pass-through SCSI commands"): >> Do you know whether pvscsi can work on top of multipath(the device-mapper >> framework) or LVMs? > > No,

Re: [Xen-devel] [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands

Hi Juergen, On 03/02/2016 03:39 PM, Juergen Gross wrote: > On 01/03/16 19:08, Ian Jackson wrote: >> Bob Liu writes ("Re: [RFC PATCH] xen-block: introduces extra request to >> pass-through SCSI commands"): >>> One thing I'm still not sure about PVSCSI is do we

Re: [Xen-devel] [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands

On 03/01/2016 12:29 AM, Ian Jackson wrote: > Ian Jackson writes ("Re: [RFC PATCH] xen-block: introduces extra request to > pass-through SCSI commands"): >> [stuff suggesting use of PVSCSI instead] > > For the avoidance of doubt: > > 1. Thanks very much for bringing this proposal to us at the

Re: [Xen-devel] [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands

On 03/01/2016 12:29 AM, Ian Jackson wrote: > Ian Jackson writes ("Re: [RFC PATCH] xen-block: introduces extra request to > pass-through SCSI commands"): >> [stuff suggesting use of PVSCSI instead] > > For the avoidance of doubt: > > 1. Thanks very much for bringing this proposal to us at the

[Xen-devel] [RFC PATCH] xen-block: introduces extra request to pass-through SCSI commands

k has been existed for many years, widely used and more stable. Welcome any input, thank you! Signed-off-by: Bob Liu <bob@oracle.com> --- xen/include/public/io/blkif.h | 73 + 1 file changed, 73 insertions(+) diff --git a/xen/include/public/i

Re: [Xen-devel] [PATCH v7 0/2] public/io/netif.h: support for toeplitz hashing

On 02/02/2016 05:33 PM, Paul Durrant wrote: >> -Original Message- >> From: Bob Liu [mailto:bob@oracle.com] >> Sent: 02 February 2016 05:02 >> To: Paul Durrant >> Cc: xen-de...@lists.xenproject.org >> Subject: Re: [Xen-devel] [PATCH v7 0/2] public

Re: [Xen-devel] [PATCH v7 0/2] public/io/netif.h: support for toeplitz hashing

Hi Paul, On 01/12/2016 05:58 PM, Paul Durrant wrote: > This series documents changes needed to support toeplitz hashing in a > backend, configurable by the frontend. > > Patch #1 adds further clarifications to the receive and transmit wire > formats. > > Patch #2 documents a new 'control ring'

Re: [Xen-devel] netfront/netback multiqueue exhausting grants

On 01/22/2016 03:53 PM, Jan Beulich wrote: On 22.01.16 at 04:36, wrote: >> By the way, do you think it's possible to make grant table support bigger >> page e.g 64K? >> One grant-ref per 64KB instead of 4KB, this should able to reduce the grant >> entry consumption

Re: [Xen-devel] [RFC] VirtFS support on Xen

Hi Wei, On 01/21/2016 06:59 PM, Wei Liu wrote: > On Thu, Jan 21, 2016 at 10:50:08AM +, David Vrabel wrote: >> On 21/01/16 10:28, Wei Liu wrote: >>> [RFC] VirtFS support on Xen >>> >>> # Introduction >>> >>> QEMU/KVM supports file system passthrough via an interface called >>> VirtFS [0].

Re: [Xen-devel] netfront/netback multiqueue exhausting grants

On 01/22/2016 07:02 PM, Jan Beulich wrote: On 22.01.16 at 11:40, wrote: >> On 01/22/2016 03:53 PM, Jan Beulich wrote: >> On 22.01.16 at 04:36, wrote: By the way, do you think it's possible to make grant table support bigger page e.g

Re: [Xen-devel] [RFC] VirtFS support on Xen

On 01/22/2016 06:50 PM, Wei Liu wrote: > On Fri, Jan 22, 2016 at 06:45:30PM +0800, Bob Liu wrote: >> Hi Wei, >> >> On 01/21/2016 06:59 PM, Wei Liu wrote: >>> On Thu, Jan 21, 2016 at 10:50:08AM +, David Vrabel wrote: >>>> On 21/01/16 10:28, Wei Li

Re: [Xen-devel] netfront/netback multiqueue exhausting grants

On 01/21/2016 08:19 PM, Ian Campbell wrote: > On Thu, 2016-01-21 at 10:56 +, David Vrabel wrote: >> On 20/01/16 12:23, Ian Campbell wrote: >>> There have been a few reports recently[0] which relate to a failure of >>> netfront to allocate sufficient grant refs for all the queues: >>> >>> [

Re: [Xen-devel] [PATCH 4/4] hvmloader: add support to load extra ACPI tables from qemu

On 01/20/2016 11:41 PM, Konrad Rzeszutek Wilk wrote: > Neither of these are sufficient however. That gets Qemu a mapping of > the NVDIMM, not the guest. Something, one way or another, has to turn > this into appropriate add-to-phymap hypercalls. > Yes, those hypercalls

[Xen-devel] [PATCH] xen-blkback: fix two memleaks

ed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/xenbus.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 44396b8..dabdb18 100644 --- a/drivers/block/xen-blkb

Re: [Xen-devel] blkback feature announcement

On 12/08/2015 07:13 PM, Jan Beulich wrote: On 08.12.15 at 12:06, wrote: > >> On 12/08/2015 04:13 PM, Jan Beulich wrote: >> On 08.12.15 at 02:08, wrote: On 12/07/2015 08:42 PM, Roger Pau Monné wrote: > El 07/12/15 a les 13.00, Jan

Re: [Xen-devel] blkback feature announcement

On 12/08/2015 04:13 PM, Jan Beulich wrote: On 08.12.15 at 02:08, wrote: >> On 12/07/2015 08:42 PM, Roger Pau Monné wrote: >>> El 07/12/15 a les 13.00, Jan Beulich ha escrit: Hello, is there a particular reason why "max-ring-page-order" gets written in

[Xen-devel] [PATCH] xen-blkback: make st_ statistics per ring

Make st_* statistics per ring and the VBD sysfs would iterate over all the rings. Note: xenvbd_sysfs_delif() is called in xen_blkbk_remove() before all rings are torn down, so it's safe. This patch was based on konrad/xen.git/for-jens-4.5. Signed-off-by: Bob Liu <bob@oracle.

Re: [Xen-devel] blkback feature announcement

On 12/07/2015 08:42 PM, Roger Pau Monné wrote: > El 07/12/15 a les 13.00, Jan Beulich ha escrit: >> Hello, >> >> is there a particular reason why "max-ring-page-order" gets written in >> xen_blkbk_probe(), but e.g. "feature-max-indirect-segments" and >> "feature-persistent" get written only in

Re: [Xen-devel] [PATCH v5 00/10] xen-block: multi hardware-queues/rings support

On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote: >> On Wed, Nov 25, 2015 at 02:25:07PM -0500, Konrad Rzeszutek Wilk wrote: xen/blkback: separate ring information out of struct xen_blkif xen/blkback: pseudo

Re: [Xen-devel] [PATCH v5 00/10] xen-block: multi hardware-queues/rings support

On 11/26/2015 10:57 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 26, 2015 at 10:28:10AM +0800, Bob Liu wrote: >> >> On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote: >>> On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote: >>>> On W

Re: [Xen-devel] [PATCH v5 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

On 11/17/2015 05:27 AM, Konrad Rzeszutek Wilk wrote: >> /* Common code used when first setting up, and when resuming. */ >> static int talk_to_blkback(struct xenbus_device *dev, >> @@ -1527,10 +1582,9 @@ static int talk_to_blkback(struct xenbus_device *dev, >> { >> const char *message =

[Xen-devel] [PATCH v5 07/10] xen/blkback: pseudo support for multi hardware queues/rings

y: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/common.h |3 +- drivers/block/xen-blkback/xenbus.c | 277 ++-- 2 files changed, 175 insertions(+), 105 deletions(-) diff --g

[Xen-devel] [PATCH v5 09/10] xen/blkfront: make persistent grants pool per-queue

1230(~20%) 1024(~20%) 850(~20%) Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 110 +- 1 file changed, 43 insertions(+), 67 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index

[Xen-devel] [PATCH v5 02/10] xen/blkfront: separate per ring information out of device info

i hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- v2: Fix build error. --- drivers/block/xen-blkfront.c | 359 +++--- 1 file changed, 197 insertions(+), 162 deletions(-)

[Xen-devel] [PATCH v5 08/10] xen/blkback: get the number of hardware queues/rings from blkfront

Backend advertises "multi-queue-max-queues" to front, also get the negotiated number from "multi-queue-num-queues" written by blkfront. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/c

[Xen-devel] [PATCH v5 03/10] xen/blkfront: pseudo support for multi hardware queues/rings

Preparatory patch for multiple hardware queues (rings). The number of rings is unconditionally set to 1, larger number will be enabled in next patch("xen/blkfront: negotiate number of queues/rings to be used with backend") so as to make every single patch small and readable. Signed-o

[Xen-devel] [PATCH v5 04/10] xen/blkfront: split per device io_lock

h protects the ->grants list and persistent_gnts_c shared by all rings. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: * Introduce kick_pending_request_queues_locked(). * Add comment for 'ring_lock'. * Move locks to more suitable place. --- drivers/block/xe

[Xen-devel] [PATCH v5 00/10] xen-block: multi hardware-queues/rings support

/agrcy2pbzbsvmwv/iops.png?dl=0 --- v5: * Rebase to xen/tip.git tags/for-linus-4.4-rc0-tag. * Comments from Konrad. v4: * Rebase to v4.3-rc7. * Comments from Roger. v3: * Rebased to v4.2-rc8. Bob Liu (10): xen/blkif: document blkif multi-queue/ring extension xen/blkfront: separate per ring

[Xen-devel] [PATCH v5 01/10] xen/blkif: document blkif multi-queue/ring extension

Document the multi-queue/ring feature in terms of XenStore keys to be written by the backend and by the frontend. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: Add descriptions together with multi-page ring buffer. --- include/xen/interface/io/blkif.h

[Xen-devel] [PATCH v5 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

as "multi-queue-num-queues", blkback needs to read this negotiated number. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: * Make 'i' be an unsigned int. * Other comments from Konrad. --- drivers/block/xen-blkfront.c | 160 +++--- 1 f

[Xen-devel] [PATCH v5 10/10] xen/blkback: make pool of persistent grants and free pages per-queue

't drop if incresing queue numbers. Please find the respective chart in this link: https://www.dropbox.com/s/agrcy2pbzbsvmwv/iops.png?dl=0 Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c | 202 --- drivers/block/xe

[Xen-devel] [PATCH v5 06/10] xen/blkback: separate ring information out of struct xen_blkif

reparation for supporting multi hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- v2: * Have an BUG_ON on the holding of the pers_gnts_lock. --- drivers/block/xen-blkback/blkback.c | 235

Re: [Xen-devel] [PATCH 06/32] xen blkback: prepare for bi_rw split

On 11/07/2015 06:17 PM, Christoph Hellwig wrote: > A little offtopic for this patch, but can some explain this whole > mess about bios in Xen blkfront? We can happily do partial completions > at the request later. > > Also since the blk-mq conversion the call to blk_end_request_all is This

Re: [Xen-devel] [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware queues/rings

On 11/05/2015 10:30 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:43PM +0800, Bob Liu wrote: >> Preparatory patch for multiple hardware queues (rings). The number of >> rings is unconditionally set to 1, larger number will be enabled in next >> patch so as

Re: [Xen-devel] [PATCH v4 10/10] xen/blkback: make pool of persistent grants and free pages per-queue

On 11/05/2015 10:43 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:46PM +0800, Bob Liu wrote: >> Make pool of persistent grants and free pages per-queue/ring instead of >> per-device to get better scalability. > > How much better scalability do we get? >

Re: [Xen-devel] [PATCH v4 03/10] xen/blkfront: pseudo support for multi hardware queues/rings

On 11/04/2015 03:44 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:39PM +0800, Bob Liu wrote: >> Preparatory patch for multiple hardware queues (rings). The number of >> rings is unconditionally set to 1, larger number will be enabled in next >> patch so as

Re: [Xen-devel] [PATCH v4 04/10] xen/blkfront: split per device io_lock

On 11/04/2015 04:09 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:40PM +0800, Bob Liu wrote: >> The per device io_lock became a coarser grained lock after multi-queues/rings >> was introduced, this patch introduced a fine-grained ring_lock for each ring. >

Re: [Xen-devel] [PATCH v4 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

On 11/04/2015 04:40 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:41PM +0800, Bob Liu wrote: >> The number of hardware queues for xen/blkfront is set by parameter >> 'max_queues'(default 4), while the max value xen/blkback supported is >> notified >&

[Xen-devel] [PATCH v4 08/10] xen/blkback: get the number of hardware queues/rings from blkfront

Backend advertises "multi-queue-max-queues" to front, then get the negotiated number from "multi-queue-num-queues" wrote by blkfront. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c | 11 +++ drivers/block/xen-blkback/commo

[Xen-devel] [PATCH v4 09/10] xen/blkfront: make persistent grants per-queue

Make persistent grants per-queue/ring instead of per-device, so that we can drop the 'dev_lock' and get better scalability. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 89 +--- 1 file changed, 34 insertions(

[Xen-devel] [PATCH v4 06/10] xen/blkback: separate ring information out of struct xen_blkif

supporting multi hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c | 233 drivers/block/xen-blkback/common.h | 64 ++ dri

[Xen-devel] [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware queues/rings

Preparatory patch for multiple hardware queues (rings). The number of rings is unconditionally set to 1, larger number will be enabled in next patch so as to make every single patch small and readable. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Li

[Xen-devel] [PATCH v4 10/10] xen/blkback: make pool of persistent grants and free pages per-queue

Make pool of persistent grants and free pages per-queue/ring instead of per-device to get better scalability. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c | 212 +--- drivers/block/xen-blkback/common.h | 32 +++--- d

[Xen-devel] [PATCH v4 03/10] xen/blkfront: pseudo support for multi hardware queues/rings

Preparatory patch for multiple hardware queues (rings). The number of rings is unconditionally set to 1, larger number will be enabled in next patch so as to make every single patch small and readable. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c

[Xen-devel] [PATCH v4 02/10] xen/blkfront: separate per ring information out of device info

i hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 321 --- 1 file changed, 178 insertions(+), 143 deletions(-) diff --git a/drivers/

[Xen-devel] [PATCH v4 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

ueue-num-queues", blkback need to read this negotiated number. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 166 +++ 1 file changed, 120 insertions(+), 46 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/dr

[Xen-devel] [PATCH v4 00/10] xen-block: multi hardware-queues/rings support

e and real SSD storage. --- v4: * Rebase to v4.3-rc7 * Comments from Roger v3: * Rebased to v4.2-rc8 Bob Liu (10): xen/blkif: document blkif multi-queue/ring extension xen/blkfront: separate per ring information out of device info xen/blkfront: pseudo support for multi hardware queues/r

[Xen-devel] [PATCH v4 04/10] xen/blkfront: split per device io_lock

The per device io_lock became a coarser grained lock after multi-queues/rings was introduced, this patch introduced a fine-grained ring_lock for each ring. The old io_lock was renamed to dev_lock and only protect the ->grants list which is shared by all rings. Signed-off-by: Bob Liu &

[Xen-devel] [PATCH v4 01/10] xen/blkif: document blkif multi-queue/ring extension

Document the multi-queue/ring feature in terms of XenStore keys to be written by the backend and by the frontend. Signed-off-by: Bob Liu <bob@oracle.com> -- v2: Add descriptions together with multi-page ring buffer. --- include/xen/interface/io/blkif.

  1   2   3   >