Prefer using the character device over the proc file if the character
device exists.
CC: Elena Ufimtseva
CC: Ian Jackson
CC: Stefano Stabellini
CC: Wei Liu
Signed-off-by: Doug Goldstein
---
So this was originally submitted with 9c89dc95201 and 7d418eab3b6 and
was rejected since the goal was
- 14.04
14.04 here would imply he's running some Ubuntu for ARM build. Ubuntu
14.04 shipped with Xen 4.6.
--
Doug Goldstein
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
; That how I did understand it, so I've queued this already, but for
> it to become eligible to applying to 4.9 it first needs to pass the
> push gate on master.
>
> Jan
>
Of course. I didn't mean to imply this should jump any existing process.
I had just real
h VGA the increment does
> happen. Hence "display" in the title is perhaps also at least misleading.
> I would be fine to adjust both while committing (and then adding my
> R-b), but feel free to propose an alternative.
Jan,
Can you queue this for 4.9 a
gt;>>> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote:
>>>>>> The EFI multiboot2 entry point currently requires EFI BootServices to
>>>>>> not have been exited however the header currently tells the boot
>>>>>> loader tha
ging this up at a meet up a while
back and the concern was breaking someone's workflow. Maybe we can put a
warning that the behavior is deprecated for X number of releases before
deleting it.
--
Doug Goldstein
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 10/24/17 3:22 PM, Andrew Cooper wrote:
> On 24/10/17 21:08, Daniel Kiper wrote:
>> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote:
>>> The EFI multiboot2 entry point currently requires EFI BootServices to
>>> not have been exited however the head
On 10/24/17 3:08 PM, Daniel Kiper wrote:
> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote:
>>
>> Unfortunately the spec is a bit vague and how I am reading it is:
>> - no tag = exit boot services in the boot loader
>> - tag present marked optional = boo
On 10/24/17 3:08 PM, Daniel Kiper wrote:
> On Tue, Oct 24, 2017 at 02:40:41PM -0500, Doug Goldstein wrote:
>> The EFI multiboot2 entry point currently requires EFI BootServices to
>> not have been exited however the header currently tells the boot
>> loader that Xen op
loader to report an error that it cannot boot Xen if
it is unable to meet its needs.
Signed-off-by: Doug Goldstein
---
This should likely be applied against Xen 4.9 and Xen 4.10 as well as
staging. I am trying to get multiboot2 support for iPXE and upstream
is concerned that leaving EFI BootServices
h VGA the increment does
> happen. Hence "display" in the title is perhaps also at least misleading.
> I would be fine to adjust both while committing (and then adding my
> R-b), but feel free to propose an alternative.
David and I are both ok with you changing the wording
a simple increment.
Reviewed-by: Doug Goldstein
Signed-off-by: David Esler
---
xen/arch/x86/boot/head.S | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index fd6fc337fe..9cc35da558 100644
--- a/xen/arch/x86/boot
From: David Esler
The send_chr function sends an entire C-string and not one character and
doesn't necessarily just send it over the serial UART anymore so rename
it to print_err so that its closer in name to what it does.
Reviewed-by: Doug Goldstein
Signed-off-by: David Esler
---
xen
On 10/13/17 2:40 AM, Jan Beulich wrote:
>>>> On 12.10.17 at 22:56, wrote:
>> On 12/10/2017 21:50, Doug Goldstein wrote:
>>> From: David Esler
>>>
>>> The send_chr function sends an entire C-string and not one character and
>>> doesn'
> On Oct 12, 2017, at 4:27 PM, Daniel Kiper wrote:
>
>> On Thu, Oct 12, 2017 at 03:50:06PM -0500, Doug Goldstein wrote:
>> From: David Esler
>>
>> In 9180f5365524 a change was made to the send_chr function to take in
>> C-strings and print out a
a simple increment.
Reviewed-by: Doug Goldstein
Signed-off-by: David Esler
---
xen/arch/x86/boot/head.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
index fd6fc337fe..f48bbbd2e5 100644
--- a/xen/arch/x86/boot/head.S
+++ b/xen/arch/x86
From: David Esler
The send_chr function sends an entire C-string and not one character and
doesn't necessarily just send it over the serial UART anymore so rename
it to print_err so that its closer in name to what it does.
Reviewed-by: Doug Goldstein
Signed-off-by: David Esler
---
xen
On 10/10/17 4:15 AM, Wei Liu wrote:
> The stock compiler in travis doesn't support -fsanitize=undefined.
>
> Signed-off-by: Wei Liu
> ---
> Cc: Doug Goldstein
> ---
> xen/tools/kconfig/allrandom.config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a
On 6/27/17 4:53 AM, Wei Liu wrote:
> Signed-off-by: Wei Liu
> ---
> Cc: Doug Goldstein
> ---
> .travis.yml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 9121fcca40..f93dd6868e 100644
> --- a/.travis.yml
> +++ b/.trav
ly nail it down.
Thanks.
--
Doug Goldstein
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Xen. This means that
> you can boot Xen using GRUB2 on EFI platforms.
>
> I would like to thank everybody who helped me to make it happen.
> Especially Jan who patiently reviewed whole series many times
> and replied for my stupid questions.
>
> Daniel
>
Congrats Daniel.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 3/15/17 9:38 AM, Daniel Kiper wrote:
> On Wed, Mar 15, 2017 at 09:27:27AM -0500, Doug Goldstein wrote:
>> On 3/15/17 6:35 AM, Daniel Kiper wrote:
>>> On Thu, Mar 09, 2017 at 02:02:49PM -0600, Doug Goldstein wrote:
>>>
>>> [...]
>>>
>>>&
On 3/15/17 6:35 AM, Daniel Kiper wrote:
> On Thu, Mar 09, 2017 at 02:02:49PM -0600, Doug Goldstein wrote:
>
> [...]
>
>> Still missing 'xl info'.
>
> Got Intel NUC5i3MYHE (internally it is NUC5i3MYBE board) into my hands.
> I have put 8 GiB RAM and 500 G
On 3/7/17 9:44 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 07, 2017 at 12:39:04AM +0100, Daniel Kiper wrote:
>> On Wed, Feb 22, 2017 at 09:04:17AM -0800, Doug Goldstein wrote:
>>
>> [...]
>>
>>> I'm currently at ELC and then on vacation so I don
On 2/24/17 10:14 AM, Juergen Gross wrote:
> On 24/02/17 17:06, Doug Goldstein wrote:
>> On 2/22/17 1:53 AM, Juergen Gross wrote:
>>> On 20/02/17 16:19, Andrew Cooper wrote:
>>>> On 20/02/17 14:43, Juergen Gross wrote:
>>>>> On 20/02/17 15:31, Wei Li
-with-rundir and possibly
>switch over to --runstatedir when a new autoconf version is
>available
>
> I'm in favor of (3.).
>
>
> Juergen
FWIW, many distros have already pulled the patch into their autoconf so
its available so you wouldn
gt;> 1. don't support /run instead of /var/run via configure
>> 2. patch autoconf to support --runstatedir
>> 3. take this patch adding support via --with-rundir and possibly
>>switch over to --runstatedir when a new autoconf version is
>>available
>
> Op
to find the
revision for you. But the command line I use is:
-enable-kvm -M pc-q35-2.8 -device intel-iommu -cpu host -m 2048 -smp 2
-drive if=pflash,format=raw,file=/tmp/tmp.EiR6ixmYzV -global
isa-debugcon.iobase=0x402 -debugcon file:/tmp/tmp.nuvEXUWfnA -monitor
stdio -chardev socket,host=127.0
a candidate for committing.
>
> Jan
>
I'm on travel for the next week and half but when I return I had planned
on tackling the issue.
For anyone else interested its reproducible with QEMU booting smp with 2
CPUs and using OVMF. Xen just never sees more than the boot CPU. I'
sing __efi64_mb2_start
> we are sure that we are running on EFI platform and there is no VGA there.
> It means that we can safely zap vga_text_buffer unconditionally in first steps
> (we do that in second instruction). Then we do not need to take care about
> that in case of error. And one of these errors is lack of
> MULTIBOOT2_TAG_TYPE_EFI_BS
> tag. It means that EFI boot services are shutdown. So, we are in black hole.
> We have to inform user about that and halt the system. And that is why we
Not looking at the code but the words here. If ExitBootServices() has
been called we should be able to still boot if the memory map was passed
along. Are we deferring that use case to a follow on?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
than I was going to originally submit, I
had used runtime.o but while testing this I saw Daniel Kiper's v14 of
his multiboot2 series come along and I modified my patch so that he
would not have to rebase.
Signed-off-by: Doug Goldstein
---
CC: Jan Beulich
CC: Andrew Cooper
Jan,
This nee
> Xen binary which can be loaded by three boot protocols: EFI native loader,
>> multiboot (v1) and multiboot2.
>>
>> Signed-off-by: Daniel Kiper
>> Acked-by: Jan Beulich
>> Reviewed-by: Doug Goldstein
>> ---
>> v14 - suggestions/fixes:
>> - at l
st time? I know Jan and I
appreciated that and it made it easier to review.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
.
Ross,
What happened with this series? Some of these patches still appear
un-applied and they appear relevant still.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
int to "rm" in efi_multiboot2()
> (suggested by Jan Beulich),
> - improve comments
> (suggested by Jan Beulich and Doug Goldstein).
This is a huge change and would really be helpful to have the diff of
what's changed to work from.
--
Doug Goldstein
signature.a
On 1/23/17 9:45 AM, Daniel Kiper wrote:
> On Mon, Jan 23, 2017 at 09:35:55AM -0600, Doug Goldstein wrote:
>> On 1/23/17 7:08 AM, Daniel Kiper wrote:
>>> On Fri, Jan 20, 2017 at 10:54:12PM +0100, Daniel Kiper wrote:
>>>> On Fri, Jan 20, 2017 at 02:42:30PM -0500, Doug
On 1/23/17 8:28 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Jan 23, 2017 at 02:08:58PM +0100, Daniel Kiper wrote:
>> On Fri, Jan 20, 2017 at 10:54:12PM +0100, Daniel Kiper wrote:
>>> On Fri, Jan 20, 2017 at 02:42:30PM -0500, Doug Goldstein wrote:
>>>> On 1/19/
On 1/23/17 7:08 AM, Daniel Kiper wrote:
> On Fri, Jan 20, 2017 at 10:54:12PM +0100, Daniel Kiper wrote:
>> On Fri, Jan 20, 2017 at 02:42:30PM -0500, Doug Goldstein wrote:
>>> On 1/19/17 8:34 PM, Daniel Kiper wrote:
>>>> Hi,
>>>>
>>>> I am send
On 1/20/17 2:42 PM, Doug Goldstein wrote:
> Effectively the fix to efi_multiboot2() gets us back to the same level
> of hardware support that v11 + my v5 was at for 1-5. So I will extend my:
>
> Reviewed-by: Doug Goldstein
> Tested-by: Doug Goldstein
>
> on the cond
(since patch 1 has
already gone in) and apply the fix to efi_multiboot2() then all the
machines I presently have access to boot.
Effectively the fix to efi_multiboot2() gets us back to the same level
of hardware support that v11 + my v5 was at for 1-5. So I will extend my:
Reviewed-by: Doug Golds
was:
return cfg.addr + MBI_SIZE;
I can't see how this booted for you with OVMF because for all the
different versions I've tried with the original code its writing over
reserved memory that QEMU uses for the graphics buffers. Which
immediately results in the trampolines being overwrit
On 1/20/17 12:21 PM, Daniel Kiper wrote:
> On Fri, Jan 20, 2017 at 11:22:21AM -0500, Doug Goldstein wrote:
>> On 1/19/17 8:34 PM, Daniel Kiper wrote:
>>> Hi,
>>>
>>> I am sending twelfth version of multiboot2 protocol support for
>>> legacy BIOS
> (suggested by Andrew Cooper),
Andrew actually asked for __mb2_efi64_start
> +
> +__efi64_mb2_start:
here.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
f-by: Daniel Kiper
> Reviewed-by: Jan Beulich
> Reviewed-by: Doug Goldstein
> ---
> v12 - suggestions/fixes:
> - replace TABs with spaces in xen/include/xen/multiboot2.h
> (suggested by Doug Goldstein).
>
> v9 - suggestions/fixes:
>- use .L label instead of
On 1/20/17 12:21 PM, Daniel Kiper wrote:
> On Fri, Jan 20, 2017 at 11:22:21AM -0500, Doug Goldstein wrote:
>> On 1/19/17 8:34 PM, Daniel Kiper wrote:
>>> Hi,
>>>
>>> I am sending twelfth version of multiboot2 protocol support for
>>> legacy BIOS
On 1/20/17 11:37 AM, Doug Goldstein wrote:
> On 1/19/17 8:34 PM, Daniel Kiper wrote:
>> diff --git a/xen/arch/x86/boot/Makefile b/xen/arch/x86/boot/Makefile
>> index 5fdb5ae..6d20646 100644
>> --- a/xen/arch/x86/boot/Makefile
>> +++ b/xen/arch/x86/boot/Makefile
>&g
So when this was patch 8 this previously had:
+RELOC_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/include/xen/multiboot.h \
+$(BASEDIR)/include/xen/multiboot2.h
Which its now moved to patch 1 so obviously can't include multiboot2.h
but then patch 2 in this series fails to add this and patch 5 fails
t with iPXE
and grub on an Intel NUC and another board I've got. I've also just
tried to apply 1-5 and it fails to boot as well.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-
size = MB_TRAMPOLINE_SIZE + MB_TRAMPOLINE_STACK_SIZE + MBI_SIZE;
Why MBI_SIZE? I don't see that being copied in that region or living there?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
nore it and everything works as usual.
>
> Signed-off-by: Daniel Kiper
> Acked-by: Jan Beulich
> Reviewed-by: Doug Goldstein
FWIW, I can't find where I offered my R-b for this patch. Its part of
the series I've said fails on my hardware.
--
Doug Goldstein
signatur
hysical address.
>
> There is no functional change.
>
> Suggested-by: Jan Beulich
> Signed-off-by: Daniel Kiper
> Acked-by: Jan Beulich
> Reviewed-by: Doug Goldstein
FWIW, I can't find where I offered my R-b for this patch. Its part of
the series I've
On 1/19/17 8:34 PM, Daniel Kiper wrote:
> ..calculating its value during runtime.
>
> Signed-off-by: Daniel Kiper
> Acked-by: Jan Beulich
> Reviewed-by: Doug Goldstein
FWIW, I can't find where I offered my R-b for this patch. Its part of
the series I've said fails
apping.
> It is no longer needed.
>
> Signed-off-by: Daniel Kiper
> Reviewed-by: Jan Beulich
> Reviewed-by: Doug Goldstein
FWIW, I can't find where I offered my R-b for this patch. Its part of
the series I've said fails on my hardware.
--
Doug Goldstei
oot2 support since we've had this series outstanding for
years. I was just trying to help this series move forward and believe we
can do improvements after the fact.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
off of my head. Its about
a dozen machines all together. They fail in two different ways:
- the other CPUs are reported as stuck and the machine boots but 'xl
info' reports 1 available CPU.
- when the non-CPUs are brought up it dies when setting paging back into
cr0.
Every single machin
The only call to have_wrcomb() was always to the generic implementation.
positive_have_wrcomb() was unused.
Signed-off-by: Doug Goldstein
Acked-by: Jan Beulich
---
Retaining ACK from <57b480fd027800106...@prv-mh.provo.novell.com>
---
---
xen/arch/x86/cpu/mtrr/generic.c | 5 -
xe
These weren't used so drop them.
Signed-off-by: Doug Goldstein
Reviewed-by: Jan Beulich
---
Retained R-b from <57b48184027800106...@prv-mh.provo.novell.com>
---
xen/arch/x86/cpu/mtrr/mtrr.h | 15 ---
1 file changed, 15 deletions(-)
diff --git a/xen/arch/x86/cpu/mt
This field is always only 1 currently but may allow 0 in the future so
convert it to a bool to provide proper range checking by the compiler.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/generic.c | 2 +-
xen/arch/x86/cpu/mtrr/mtrr.h| 4 ++--
2 files changed, 3 insertions(+), 3
Retained the parts that were not objected to by plans to disable mtrrs on
PVH containers.
Doug Goldstein (3):
x86/mtrr: drop positive_have_wrcomb()
x86/mtrr: drop unused func prototypes and struct
x86/mtrr: convert use_intel_if u32 to bool
xen/arch/x86/cpu/mtrr/generic.c | 7 +--
xen
ated cpuid data.
> * The toolstack need not worry about setting them appropriately.
> * They can be dropped from the system maximum featuresets.
>
> While editing gen-cpuid.py, reflow some comments which exceeded the expected
> line length.
>
> Signed-off-by: Andrew Cooper
Re
On 1/18/17 2:40 PM, Andrew Cooper wrote:
> Leaves 0x8002 through 0x8004 are plain ASCII text, and require no
> specific recalculation.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digit
cated according to the
> chosen vendor.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 1/18/17 2:40 PM, Andrew Cooper wrote:
> Calculate a domains x86_vendor early in recalculate_cpuid_policy(); subsequent
> patches need to make other recalculation decisions based on it.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Doug Goldstein
--
Doug Goldstein
s
On 1/18/17 2:40 PM, Andrew Cooper wrote:
> Include a min() against the appropriate ARRAY_SIZE(), and ASSERT() that
> max_subleaf is within ARRAY_SIZE().
>
> This is more robust to unexpected problems in a release build of Xen.
>
> Signed-off-by: Andrew Cooper
Reviewed-
ger Pau Monné
> Signed-off-by: Andrew Cooper
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
opy or other tool. This way we will have one
Xen binary which can be loaded by three boot protocols: EFI native loader,
multiboot (v1) and multiboot2.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Reviewed-by: Doug Goldstein
---
v6 - suggestions/fixes:
- improve efi_enable
- add back some ACKs I accidentally dropped
Daniel Kiper (4):
x86: add multiboot2 protocol support
efi: build xen.gz with EFI code
efi: create new early memory allocator
x86: add multiboot2 protocol support for EFI platforms
Doug Goldstein (1):
fix: add multiboot2 pro
is did not
manifest as a crash while on others it did. Reworked the
changes to always reserve 64kb for both the stack and the size
of the trampolines. Added a build time assert to make sure we have
enough room always.
Signed-off-by: Doug Goldstein
Reviewed-by: Jan Beulich
---
Doug v5 - change com
w #2a solution is implemented because it is quite simple and requires
limited number of changes, especially in __start_xen().
The new allocator is quite generic and can be used on ARM platforms too.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Acked-by: Julien Grall
Reviewed-by: Doug Gold
From: Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and
other boot loaders which support multiboot2 protocol.
Signed-off-by: Daniel Kiper
Reviewed-by: Doug Goldstein
Tested-by: Doug Goldstein
---
Doug v2 - dropped all my changes and moved them into their own patch
Doug
: Doug Goldstein
---
v9 - suggestions/fixes:
- use .L label instead of numeric one in multiboot2 data scanning loop;
I hope that this change does not invalidate Jan's Reviewed-by
(suggested by Jan Beulich).
v8 - suggestions/fixes:
- use sizeof(/) instead of sizeof()
if
be easier than folding this into your larger series.
Can you tell me what were the fixes to the relocation code?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 1/18/17 2:51 PM, Andrew Cooper wrote:
> On 18/01/17 14:17, Doug Goldstein wrote:
>> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
>> index d423fd8..ac93df0 100644
>> --- a/xen/arch/x86/boot/head.S
>> +++ b/xen/arch/x86/boot/head.S
>> @@ -89,6
ons used during boot.
>
> ~Andrew
FWIW, some of the clang issues I reported against LTO and FPU bits are
marked as fixed in 3.9 and 4.0. Not sure if things got backported.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
_
w #2a solution is implemented because it is quite simple and requires
limited number of changes, especially in __start_xen().
The new allocator is quite generic and can be used on ARM platforms too.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Acked-by: Julien Grall
Reviewed-by: Doug Gold
From: Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and
other boot loaders which support multiboot2 protocol.
Signed-off-by: Daniel Kiper
Reviewed-by: Doug Goldstein
Tested-by: Doug Goldstein
---
Doug v2 - dropped all my changes and moved them into their own patch
Doug
is did not
manifest as a crash while on others it did. Reworked the
changes to always reserve 64kb for both the stack and the size
of the trampolines. Added a build time assert to make sure we have
enough room always.
Signed-off-by: Doug Goldstein
---
Doug v4 - change wording around &
: Doug Goldstein
---
v9 - suggestions/fixes:
- use .L label instead of numeric one in multiboot2 data scanning loop;
I hope that this change does not invalidate Jan's Reviewed-by
(suggested by Jan Beulich).
v8 - suggestions/fixes:
- use sizeof(/) instead of sizeof()
if
opy or other tool. This way we will have one
Xen binary which can be loaded by three boot protocols: EFI native loader,
multiboot (v1) and multiboot2.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Reviewed-by: Doug Goldstein
---
v6 - suggestions/fixes:
- improve efi_enable
86: add multiboot2 protocol support
efi: build xen.gz with EFI code
efi: create new early memory allocator
x86: add multiboot2 protocol support for EFI platforms
Doug Goldstein (1):
fix: add multiboot2 protocol support for EFI platforms
xen/arch/x86/Makefile | 2 +-
xen/ar
gt; Well, I don't mind the max() (albeit it's not very useful, especially
> if trampoline size would ever get pretty close to 64k). And as said
> in reply to the earlier version - I think this would better be checked
> at build time (see the vario
cfg.size = max_t(UINTN, 64 << 10,
>> +(trampoline_end - trampoline_start) + 4096);
>
> Considering the consuming code further up, I don't understand the
> reason for the addition of 4096 here. And if there is a reason, I'm
> pretty sure you act
is did not
manifest as a crash while on others it did. Reworked the
changes to always reserve 64kb for both the stack and the size
of the trampolines.
Signed-off-by: Doug Goldstein
Reviewed-by: Doug Goldstein
---
Doug v3 - drop ASSERTs since they are runtime only without any output.
This
w #2a solution is implemented because it is quite simple and requires
limited number of changes, especially in __start_xen().
The new allocator is quite generic and can be used on ARM platforms too.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Acked-by: Julien Grall
Reviewed-by: Doug Gold
: Doug Goldstein
---
v9 - suggestions/fixes:
- use .L label instead of numeric one in multiboot2 data scanning loop;
I hope that this change does not invalidate Jan's Reviewed-by
(suggested by Jan Beulich).
v8 - suggestions/fixes:
- use sizeof(/) instead of sizeof()
if
From: Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and
other boot loaders which support multiboot2 protocol.
Signed-off-by: Daniel Kiper
Reviewed-by: Doug Goldstein
Tested-by: Doug Goldstein
---
Doug v2 - dropped all my changes and moved them into their own patch
Doug
ode
efi: create new early memory allocator
x86: add multiboot2 protocol support for EFI platforms
Doug Goldstein (1):
fix: add multiboot2 protocol support for EFI platforms
xen/arch/x86/Makefile | 2 +-
xen/arch/x86/boot/Makefile| 3 +-
xen/arch/x86/boot/head.S |
opy or other tool. This way we will have one
Xen binary which can be loaded by three boot protocols: EFI native loader,
multiboot (v1) and multiboot2.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Reviewed-by: Doug Goldstein
---
v6 - suggestions/fixes:
- improve efi_enable
rodata,
> which allows all users to generate code referencing the data directly.
>
> No functional change, but causes smaller and more efficient compiled code.
>
> Signed-off-by: Andrew Cooper
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Descript
On 1/16/17 9:11 AM, Daniel Kiper wrote:
> On Mon, Jan 16, 2017 at 08:41:08AM -0500, Doug Goldstein wrote:
>> On 1/16/17 7:50 AM, Daniel Kiper wrote:
>>> On Mon, Jan 16, 2017 at 05:02:05AM -0700, Jan Beulich wrote:
>>>>>>> On 13.01.17 at 20:21, wrote:
is did not
manifest as a crash while on others it did. Reworked the
changes to always reserve 64kb for both the stack and the size
of the trampolines. Added an ASSERT to make sure we never blow
through this size.
Signed-off-by: Doug Goldstein
Reviewed-by: Doug Goldstein
---
Doug v2 - new in this
l series
- add back some ACKs I accidentally dropped
Daniel Kiper (4):
x86: add multiboot2 protocol support
efi: build xen.gz with EFI code
efi: create new early memory allocator
x86: add multiboot2 protocol support for EFI platforms
Doug Goldstein (1):
fix: add multiboot2 pro
From: Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and
other boot loaders which support multiboot2 protocol.
Signed-off-by: Daniel Kiper
Reviewed-by: Doug Goldstein
Tested-by: Doug Goldstein
---
Doug v2 - dropped all my changes and moved them into their own patch
Doug
: Doug Goldstein
---
v9 - suggestions/fixes:
- use .L label instead of numeric one in multiboot2 data scanning loop;
I hope that this change does not invalidate Jan's Reviewed-by
(suggested by Jan Beulich).
v8 - suggestions/fixes:
- use sizeof(/) instead of sizeof()
if
opy or other tool. This way we will have one
Xen binary which can be loaded by three boot protocols: EFI native loader,
multiboot (v1) and multiboot2.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Reviewed-by: Doug Goldstein
---
v6 - suggestions/fixes:
- improve efi_enable
w #2a solution is implemented because it is quite simple and requires
limited number of changes, especially in __start_xen().
The new allocator is quite generic and can be used on ARM platforms too.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Acked-by: Julien Grall
Reviewed-by: Doug Gold
can
>> free unused portion of the memory pool as in case of .init.text or
>> .init.data
>> sections. This way we do not need to allocate any space in image file and
>> freeing of unused area in the memory pool is very simple.
>>
>> Now #2a solution is
inter-diff the patches,
> or re-review the whole thing. For a large patch like this it would be
> rather helpful to be quite a bit more specific as to where exactly in the
> patch changes were made.
>
> Jan
>
I'll submit a diff against v11 to help show the difference. I
where exactly in the
>> patch changes were made.
>
> I would prefer to not have this patch series applied because it will make me
> more difficult to prepare v12. I hope that I will post it in about 2 weeks.
> Though I am going to take into account all comments posted by Doug
w #2a solution is implemented because it is quite simple and requires
limited number of changes, especially in __start_xen().
The new allocator is quite generic and can be used on ARM platforms too.
Signed-off-by: Daniel Kiper
Reviewed-by: Doug Goldstein
---
Doug v1 - removed stale paragraph
1 - 100 of 937 matches
Mail list logo
