This is a series based on v11 of Daniel Kiper's
"x86: multiboot2 protocol support" series. It aims to collect up all the
fixes and changes that Andrew Cooper, Jan Beulich and myself discovered in
code review and testing on actual hardware. I've had problems with the
relocation portion of the series
: Doug Goldstein
---
v9 - suggestions/fixes:
- use .L label instead of numeric one in multiboot2 data scanning loop;
I hope that this change does not invalidate Jan's Reviewed-by
(suggested by Jan Beulich).
v8 - suggestions/fixes:
- use sizeof(/) instead of sizeof()
if
opy or other tool. This way we will have one
Xen binary which can be loaded by three boot protocols: EFI native loader,
multiboot (v1) and multiboot2.
Signed-off-by: Daniel Kiper
Acked-by: Jan Beulich
Reviewed-by: Doug Goldstein
---
v6 - suggestions/fixes:
- improve efi_enable
From: Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and
other boot loaders which support multiboot2 protocol.
Signed-off-by: Daniel Kiper
Signed-off-by: Doug Goldstein
Reviewed-by: Doug Goldstein
---
Doug v1 - fix incorrect assembly (identified by Andrew Cooper
glues together. Hence my need for this series. It
includes all the changes we've discussed in this thread. Hopefully it
will help you out to post v12.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 1/12/17 6:04 PM, Daniel Kiper wrote:
> On Thu, Jan 12, 2017 at 04:23:59PM -0600, Doug Goldstein wrote:
>> On 1/12/17 2:28 PM, Daniel Kiper wrote:
>>> On Thu, Jan 12, 2017 at 09:52:15AM -0600, Doug Goldstein wrote:
>>>> On 1/12/17 6:50 AM, Daniel Kiper wrote:
>&
On 1/12/17 6:04 PM, Daniel Kiper wrote:
> On Thu, Jan 12, 2017 at 04:23:59PM -0600, Doug Goldstein wrote:
>> On 1/12/17 2:28 PM, Daniel Kiper wrote:
>>> On Thu, Jan 12, 2017 at 09:52:15AM -0600, Doug Goldstein wrote:
>>>> On 1/12/17 6:50 AM, Daniel Kiper wrote:
>&
On 1/12/17 2:28 PM, Daniel Kiper wrote:
> On Thu, Jan 12, 2017 at 09:52:15AM -0600, Doug Goldstein wrote:
>> On 1/12/17 6:50 AM, Daniel Kiper wrote:
>>> On Wed, Jan 11, 2017 at 02:20:15PM -0600, Doug Goldstein wrote:
>>>> On 1/11/17 1:47 PM, Daniel Kiper wrote:
>&
On 1/12/17 3:45 PM, Daniel Kiper wrote:
> On Thu, Jan 12, 2017 at 01:46:41PM -0600, Doug Goldstein wrote:
>> On 1/12/17 1:30 PM, Daniel Kiper wrote:
>>> On Thu, Jan 12, 2017 at 09:44:59AM -0600, Doug Goldstein wrote:
>>
>>>
>>>> view there's
On 1/12/17 1:30 PM, Daniel Kiper wrote:
> On Thu, Jan 12, 2017 at 09:44:59AM -0600, Doug Goldstein wrote:
>
>> view there's no reason for adding MB2 support for BIOS since it provides
>> no advantage over MB1 when booting from the BIOS. Now MB2 solves a
>
> From you
2 module. There's no entry point advertised in the xen.efi
case.
I think we'd probably just leave off the MB2 header for xen.efi and
leave that as a plain EFI loader case.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
__
On 1/12/17 6:50 AM, Daniel Kiper wrote:
> On Wed, Jan 11, 2017 at 02:20:15PM -0600, Doug Goldstein wrote:
>> On 1/11/17 1:47 PM, Daniel Kiper wrote:
>>> On Tue, Jan 10, 2017 at 02:51:27PM -0600, Doug Goldstein wrote:
>>>> On 1/9/17 7:37 PM, Doug Goldstein wrote:
&g
to memory and set a few pointers in tags.
With BIOS it requires me to build up the memory map into a MB2 structure.
As far as it goes I've got iPXE booting MB2 EFI payloads just fine. The
issues I've explained here happen when I use Grub or iPXE to boot Xen so
its not implementation specific to my iPXE code.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 1/11/17 1:08 PM, Daniel Kiper wrote:
> On Mon, Jan 09, 2017 at 07:37:59PM -0600, Doug Goldstein wrote:
>> On 12/5/16 4:25 PM, Daniel Kiper wrote:
>
>
>>> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
>>> index 0a93e61..70ed836 100644
>>>
On 1/11/17 2:05 PM, Daniel Kiper wrote:
> On Mon, Jan 09, 2017 at 08:05:01PM -0600, Doug Goldstein wrote:
>> On 12/5/16 4:25 PM, Daniel Kiper wrote:
>
> [...]
>
>>> /* Save trampoline address for later use. */
>>> shl $4, %ec
On 1/11/17 1:47 PM, Daniel Kiper wrote:
> On Tue, Jan 10, 2017 at 02:51:27PM -0600, Doug Goldstein wrote:
>> On 1/9/17 7:37 PM, Doug Goldstein wrote:
>>> On 12/5/16 4:25 PM, Daniel Kiper wrote:
>>
>>>> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x
On 1/11/17 1:08 PM, Daniel Kiper wrote:
> On Mon, Jan 09, 2017 at 07:37:59PM -0600, Doug Goldstein wrote:
>> On 12/5/16 4:25 PM, Daniel Kiper wrote:
>
> [...]
>
>>> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
>>> index 62c010e..dc857
Signed-off-by: Doug Goldstein
---
Daniel,
Feel free to fold this in where it needs to go or break this up into
a patch (or patches) part of your series. This is what it took for me to
get it to boot on one of my Intel NUCs and to get into the dom0 kernel
booting on my other machines. There&#
On 1/9/17 7:37 PM, Doug Goldstein wrote:
> On 12/5/16 4:25 PM, Daniel Kiper wrote:
>> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h
>> index 62c010e..dc857d8 100644
>> --- a/xen/arch/x86/efi/efi-boot.h
>> +++ b/xen/arch/x86/efi/efi-boot.h
&g
do line up for me.
>
> Also - please trim your quotes in replies.
>
> Jan
>
Well given that this is a new file and CODING_STYLE says spaces over
tabs and to treat indent level as 4 spaces. That was what my assumption was.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
-1006,7 +1005,8 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> {
> unsigned int flags;
>
> -if ( !(l2e_get_flags(*pl2e) & _PAGE_PRESENT) )
> +if ( !(l2e_get_flags(*pl2e) & _PAGE_PRESENT) ||
> + (l2e_get_pfn(*pl2e) > PFN_DOWN(xen_phys_start)) )
> continue;
>
> if ( !using_2M_mapping() )
> @@ -1060,6 +1060,8 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> : "memory" );
>
> bootstrap_map(NULL);
> +
> +printk("New Xen image base address: %#lx\n", xen_phys_start);
> }
>
> /* Is the region suitable for relocating the multiboot modules? */
> diff --git a/xen/arch/x86/x86_64/asm-offsets.c
> b/xen/arch/x86/x86_64/asm-offsets.c
> index 2a22659..5d7a8e5 100644
> --- a/xen/arch/x86/x86_64/asm-offsets.c
> +++ b/xen/arch/x86/x86_64/asm-offsets.c
> @@ -179,5 +179,8 @@ void __dummy__(void)
> OFFSET(MB2_efi64_ih, multiboot2_tag_efi64_ih_t, pointer);
> BLANK();
>
> +DEFINE(l2_identmap_sizeof, sizeof(l2_identmap));
> +BLANK();
> +
> OFFSET(DOMAIN_vm_assist, struct domain, vm_assist);
> }
> diff --git a/xen/include/asm-x86/page.h b/xen/include/asm-x86/page.h
> index af7d3e8..a54fdd1 100644
> --- a/xen/include/asm-x86/page.h
> +++ b/xen/include/asm-x86/page.h
> @@ -288,7 +288,7 @@ extern root_pgentry_t
> idle_pg_table[ROOT_PAGETABLE_ENTRIES];
> extern l2_pgentry_t *compat_idle_pg_table_l2;
> extern unsigned int m2p_compat_vstart;
> extern l2_pgentry_t l2_xenmap[L2_PAGETABLE_ENTRIES],
> -l2_bootmap[L2_PAGETABLE_ENTRIES];
> +l2_bootmap[4*L2_PAGETABLE_ENTRIES];
> extern l3_pgentry_t l3_bootmap[L3_PAGETABLE_ENTRIES];
> extern l2_pgentry_t l2_identmap[4*L2_PAGETABLE_ENTRIES];
> extern l1_pgentry_t l1_fixmap[L1_PAGETABLE_ENTRIES];
>
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
100644
> --- a/xen/arch/x86/x86_64/asm-offsets.c
> +++ b/xen/arch/x86/x86_64/asm-offsets.c
> @@ -175,6 +175,8 @@ void __dummy__(void)
> OFFSET(MB2_tag_type, multiboot2_tag_t, type);
> OFFSET(MB2_tag_size, multiboot2_tag_t, size);
> OFFSET(MB2_mem_lower, multiboot2_tag_
atives?
"disallow EFI reboot method on EFI platforms without runtime services"
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
11
> +#define MULTIBOOT2_TAG_TYPE_EFI6412
> +#define MULTIBOOT2_TAG_TYPE_SMBIOS 13
> +#define MULTIBOOT2_TAG_TYPE_ACPI_OLD 14
> +#define MULTIBOOT2_TAG_TYPE_ACPI_NEW 15
> +#define MULTIBOOT2_TAG_
xt
>
> The patch also get rid of the warnings, with recent perl:
> Unescaped left brace in regex is deprecated, passed through in regex; marked
> by <-- HERE in m/^docs/misc/kconfig{ <-- HERE ,-language}\.txt/ at
> ./scripts/get_maintainer.pl line 731.
>
> Signed-off-by
en nice to get the stray blanks here and elsewhere
> dropped, as the lines are being touched anyway.
>
> Jan
>
I can do that. I went minimal instead of cleanup.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
__
Instead of using an int and providing a define for TRUE and FALSE,
change the code to use stdbool that Xen provides.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/generic.c | 21 +++--
xen/arch/x86/cpu/mtrr/mtrr.h| 5 -
2 files changed, 11 insertions(+), 15
x27;re saying they need to make changes to binutils. At this point
I'm not able to compile Xen myself without local hackery.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
> Jan
>
That was for the hypervisor bits. Anything that relies on user space
code and headers that will be provided by the distro should be able to
build with -Werror. That's something all distros have to patch out and
is downstream hostile to do since a different toolchain than what
tches here:
>>>>> https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h
>>>>> =r
>>>>> efs/heads/tools-fix-zero-length-records
>>>>
FWIW, this is fixed in Gentoo now with xen-4.8.0-r1 or xen-4.7.1-r5 and
newer.
https://github.
$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig
> ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)"
> HOST_EXTRACFLAGS="$(APPEND_CFLAGS)" silentoldconfig
>
> # Allow people to just run `make` as before and not force them to
> confi
include
> -#include
> #include
> #include
>
>
A bit late to the party but I also confirmed the header was unused.
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 12/20/16 3:37 AM, Anshul Makkar wrote:
> On 20/12/2016 04:03, Doug Goldstein wrote:
>> On 12/19/16 10:02 AM, Doug Goldstein wrote:
>>> On 12/14/16 3:09 PM, Daniel De Graaf wrote:
>>>> On 12/12/2016 09:00 AM, Anshul Makkar wrote:
>>>>> Dur
On 12/20/16 2:16 PM, Andrew Cooper wrote:
> On 20/12/2016 20:06, Doug Goldstein wrote:
>> On 12/20/16 1:46 PM, Alistair Francis wrote:
>>> Signed-off-by: Alistair Francis
>>> ---
>>> Config.mk | 2 +-
>>> tools/blktap2/dri
AGS += $(CFLAGS_libxenevtchn)
> CFLAGS += $(CFLAGS_libxenctrl)
> LDLIBS += $(LDLIBS_libxenevtchn)
>
Can you pass -Wno-error in EXTRA_CFLAGS from 2/5? Wish I could take
credit for the idea but it was all Andrew Cooper's.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
E, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> */
>
> +#include
> +
> /*
> * Ensure all of data on socket comes through. f==read || f==vwrite
> */
>
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
_
@@ vhd_journal_create(vhd_journal_t *j, const char *file,
> const char *jfile)
> int i, err;
> size_t size;
> off_t off;
> - struct stat stats;
>
> memset(j, 0, sizeof(vhd_journal_t));
> j->jfd = -1;
>
Reviewed-by: Doug
config/StdGNU.mk
> @@ -35,6 +35,9 @@ UTIL_LIBS = -lutil
> SONAME_LDFLAG = -soname
> SHLIB_LDFLAGS = -shared
>
> +# Allow users to add extra CFLAGS
> +CFLAGS += $(EXTRA_CFLAGS)
> +
> ifeq ($(lto),y)
> CFLAGS += -flto
> LDFLAGS-$(clang) += -plugin LLVMgol
On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote:
>> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
>>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
>>>> Signed-off-by: Ali
On 12/19/16 10:02 AM, Doug Goldstein wrote:
> On 12/14/16 3:09 PM, Daniel De Graaf wrote:
>> On 12/12/2016 09:00 AM, Anshul Makkar wrote:
>>> During guest migrate allow permission to prevent
>>> spurious page faults.
>>> Prevents these errors:
>>> d73:
recting incorrect #include to
>>> [-Werror=cpp]
>>
>> And what is the 'newer build system' you speak off?
>
> Sorry I should have specified more there.
>
> It's GCC 5 that I am seeing the problem on.
Same as the last patch. This i
GCC 5? 6?
>
> In this case it is GCC 5.
>
No. Its a libc thing. I wonder what libc you're using because glibc 2.24
still has it at sys/pool.h for me.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-d
eir projects. However I know there's
upstream interest to keep it. The compromise would probably be to get my
rear in gear and get a wider range of distros testing with Travis CI /
GitLab CI.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
_
:dom0_t
>> tcontext=system_u:system_r:domU_t tclass=hvm
>>
>> Signed-off-by: Anshul Makkar
>
> Acked-by: Daniel De Graaf
>
Daniel,
Should this be backported to 4.8?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
nstall the proper
dependencies from their distro. The reason you're having an issue with
iPXE is that it was bumped to a newer version to support GCC 6 and part
of the modernizing work of iPXE was to remove old hacks for toolchains
they no longer supported. I don't know of a single dist
9 material.
>
> If you are not interested in this patch series at all please
> drop me a line and I will remove you from distribution list.
>
Feel free to add:
Reviewed-by: Doug Goldstein
I'm running this series (plus Andrew's fix in patch 7) in my 4.8 based
versio
ally get around to making Rust bindings for
Xen, I have no plan to include them in the tree but instead publish them
at crates.io so that they work like every other Rust package.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
_
On 12/5/16 10:45 AM, Wei Liu wrote:
> The file provided contains symbols that must be set to certain values.
> This then prevents random build breakage in travis due to
> known-incompatible symbol selections.
>
> Signed-off-by: Wei Liu
> ---
> Cc: Doug Goldstein
> ---
t; new file mode 100644
> index 000..e49e7d6
> --- /dev/null
> +++ b/xen/tools/kconfig/allrandom.config
> @@ -0,0 +1 @@
> +CONFIG_GCOV_FORMAT_AUTODETECT=y
>
Thank you for doing this Wei. I do agree with Andrew about the explicit
comment.
Reviewed-by: Doug Goldstein
--
Doug
get started with contributing but I've CC'd Wei and
I'm hoping he's got some ideas.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
gt; break;
> }
> +#endif
Not sure if the else case should be something like:
printk("Video information: None\n");
I'll leave it up to others to concur or disagree but if people disagree
then:
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
ased projects when I'm on
travel and only have my Mac with me.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 9/5/16 9:43 AM, Wei Liu wrote:
> Signed-off-by: Wei Liu
> ---
> See:
> https://travis-ci.org/liuw/mini-os/builds/157653746
>
> Cc: Samuel Thibault
> Cc: Juergen Gross
> Cc: Doug Goldstein
>
> IRC notification is not yet set up.
>
> Doug, can we mirror
On 9/5/16 6:19 AM, Lars Kurth wrote:
> == Attendees ==
> Lars Kurth
> George Dunlap
> Doug Goldstein
> Andrew Cooper
> Paul Durrant
>
> There were a few others, which I may have missed
I know Jonathan Creekmore was involved as well.
>
> I tried to transcribe fr
uot;
the project and use that space to push your branches. It's free (as in
beer) hosting for any long series and you can enable
https://travis-ci.org to do some basic build tests on patch series
before you mail them out.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
ee below).
Thanks for doing this Wei. I agree with Jan's reviews. You can toss my
Reviewed-by: Doug Goldstein on there if you'd like as well.
--
Doug
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
ne.
Can you include the logs from xl dmesg around that time frame as well?
Just wondering how much RAM you're domain is defined with as well?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
ially work around the
issue.
I know you and Anthony have gone through 8 revisions but please consider
changing this. I'm sorry for not speaking up sooner.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
kernel release go out the
door where the default behavior with Xen 4.6 and earlier is to deadlock
domUs.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
On 8/19/16 11:54 AM, Andrew Cooper wrote:
> Most of the comments are duplicated from the help text, and those without help
> provide no useful additional input.
>
> Signed-off-by: Andrew Cooper
> ---
> CC: Doug Goldstein
> CC: Jan Beulich
> CC: Stefano Stabellini
>
not need to load a policy to get sane behavior from an
>> + bootloader does not need to load a policy to get sane behaviour from
>> an
>
> Isn't the original spelling valid in American English?
>
> Jan
>
Yes. An American English speaker wrote it originally a
the functionality. Currently, the only user is tboot.
>
> Signed-off-by: Derek Straka
> ---
Reviewed-by: Doug Goldstein
>
> +config CRYPTO
> + bool
> + default n
> +
If a v3 happens (or the committer wants to change it) this can be
"def_bo
rr_if && mtrr_if->vendor == X86_VENDOR_##vnd)
>> -#define use_intel() (mtrr_if && mtrr_if->use_intel_if == 1)
>> +#define is_cpu(vnd) (X86_VENDOR_INTEL == X86_VENDOR_##vnd)
>> +#define use_intel() (1)
>
> Is the latter really useful to keep then?
Would you like me to squash patch 4 into this or make a note in the
commit message that further clean ups are coming?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
gt;
I've added:
Future changes will directly call these functions instead of using the
indirect call through the ops structure.
Does that work?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
These weren't used so drop them.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/mtrr.h | 15 ---
1 file changed, 15 deletions(-)
diff --git a/xen/arch/x86/cpu/mtrr/mtrr.h b/xen/arch/x86/cpu/mtrr/mtrr.h
index 9405cbc..1a3b1e5 100644
--- a/xen/arch/x86/cpu/mtrr/mtrr.h
is_cpu() evaluated to Intel always so just drop it entirely.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/generic.c | 2 +-
xen/arch/x86/cpu/mtrr/mtrr.h| 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr
There are no users of the mtrr_ops struct or any of the callers on it so
drop those.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/generic.c | 12
xen/arch/x86/cpu/mtrr/mtrr.h| 23 ---
2 files changed, 35 deletions(-)
diff --git a/xen/arch/x86/cpu
implementation due to Intel having a
value of 0. The use_intel() macro was always true in the generic
implementation case as well. Removed some extraneous whitespace at
the same time.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/generic.c | 2 +-
xen/arch/x86/cpu/mtrr/main.c | 47
The use_intel() macro always evaluates to true so don't bother using it.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/main.c | 21 -
xen/arch/x86/cpu/mtrr/mtrr.h | 1 -
2 files changed, 4 insertions(+), 18 deletions(-)
diff --git a/xen/arch/x86/cpu/mtrr/mai
Unused function, gone.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/generic.c | 5 -
xen/arch/x86/cpu/mtrr/mtrr.h| 2 --
2 files changed, 7 deletions(-)
diff --git a/xen/arch/x86/cpu/mtrr/generic.c b/xen/arch/x86/cpu/mtrr/generic.c
index 1d67035..012aca4 100644
--- a/xen
For the functions that make up the interface to the MTRR code, drop the
static keyword and prefix them all with mtrr for improved clarity when
they're called outside this file. This also required adjusting or
providing function prototypes to make them callable.
Signed-off-by: Doug Gold
Instead of using an int and providing a define for TRUE and FALSE,
change the code to use stdbool that Xen provides.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/generic.c | 21 +++--
xen/arch/x86/cpu/mtrr/mtrr.h| 5 -
2 files changed, 11 insertions(+), 15
The only call was always to the generic implementation.
Signed-off-by: Doug Goldstein
---
xen/arch/x86/cpu/mtrr/main.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/xen/arch/x86/cpu/mtrr/main.c b/xen/arch/x86/cpu/mtrr/main.c
index ff908ad..5dd1f5d 100644
--- a/xen
.
Doug Goldstein (9):
x86/mtrr: prefix fns with mtrr and drop static
x86/mtrr: drop mtrr_if indirection
x86/mtrr: drop have_wrcomb() wrapper
x86/mtrr: drop unnecessary use_intel() macro
x86/mtrr: drop unused is_cpu() macro
x86/mtrr: drop unused mtrr_ops struct
x86/mtrr: drop unused
range $(DESTDIR)
> and $(prefix) to match expectation.
>
> Reported-by:Wei Liu
> Signed-off-by: Andrew Cooper
Reviewed-by: Doug Goldstein
The conclusion in the commit message is correct. The supplied patch
conforms to that.
--
Doug Goldstein
signature.asc
Description
migrate_t is a domain that must be created via the nomigrate_t_building
> + - nomigrate_t is a domain type that must be created via the
> nomigrate_t_building
> type, and whose memory cannot be read by dom0 once created
"A domain labeled with nomigeate_t is a domain that"
>
> HV
ndyhhp/xen/jobs/144989065
>
> Signed-off-by: Andrew Cooper
Acked-by: Doug Goldstein
(with the change to the commit message in the reply)
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing lis
he Xen tools over their /proc/xen/ counterparts in an attempt
to prevent people from being bitten by that. One of the patches made it
into 4.6 and the other didn't make it in until 4.7.
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
sockets are
> less overhead than the shared memory ring, as no hypercalls are
> involved. There is also the unfortunate problem that one of the two
> linux devices for xenstored *still* causes deadlocks when used; a
> problem which is unresolved from Linux 3.14.
Since Xen 4.7 the broken devices won't be used by default. I understand
that the socket interface is faster and less overhead but I guess my
question is how much data is sent over this interface? Does it really
matter the small performance difference to justify having two different
methods and not trimming the code base down to one method?
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
socket"?
>
> ~Andrew
How about we take this the other way? Let's go away from using the
socket and always go through kernel interface. I understand that its
faster to use sockets than using the interface but does this performance
difference really affect an actual runni
n to disable FLASK under EXPERT.
>
> Signed-off-by: Daniel De Graaf
Thanks for the update Daniel.
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@
had mentioned your tools in the #xen-devel channel. And I
had talked about utilizing them as part of the Travis build process with
the goal of making this data available. Thank you for doing this.
Do you have any advice for us if it would be positive to do some sort of
check on a per-commit basis or
k Xen as tainted when this feature is used.
>
> Add a kconfig option under x86 to configure hvm_fep.
>
> Signed-off-by: Wei Liu
Otherwise the change looks good.
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
On 6/20/16 10:28 AM, Jan Beulich wrote:
>>>> On 20.06.16 at 17:11, wrote:
>> On 06/20/2016 10:46 AM, Doug Goldstein wrote:
>>> On 6/20/16 9:04 AM, Daniel De Graaf wrote:
>>>> Since enabling XSM is required to enable FLASK, place the option for
>>>&g
On 6/20/16 10:07 AM, Daniel De Graaf wrote:
> On 06/20/2016 10:35 AM, Doug Goldstein wrote:
>> On 6/20/16 9:04 AM, Daniel De Graaf wrote:
>>> This operation has no known users, and is primarily useful when an MLS
>>> policy is in use (which has never been shipped with
the primary
> location for installing and configuring the policy.
>
> Signed-off-by: Daniel De Graaf
> Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
_
licy), so an application that needs it could
> compute the results without needing to involve the hypervisor.
>
So if I read this language correctly. Removing this does not affect
someone being able to build a MLS policy at a later date right?
--
Doug Goldstein
signature.asc
Descriptio
On 6/20/16 9:04 AM, Daniel De Graaf wrote:
> Signed-off-by: Daniel De Graaf
Reviewed-by: Doug Goldstein
> ---
> xen/common/Kconfig | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index 6a51fd5..8
On 6/20/16 9:04 AM, Daniel De Graaf wrote:
> The only possible value of original_ops was &dummy_xsm_ops, and
> unregister_xsm was never used.
>
> Signed-off-by: Daniel De Graaf
> Reviewed-by: Andrew Cooper
> Reviewed-by: Konrad Rzeszutek Wilk
Reviewed-by: Doug Goldstei
On 6/20/16 9:04 AM, Daniel De Graaf wrote:
> These functions were only called from __init functions.
>
> Signed-off-by: Daniel De Graaf
> Reviewed-by: Andrew Cooper
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digit
Ok. Here's the real review. I think you want the prompt to be optional
if EXPERT is enabled then I think you need to use "prompt" instead of
"bool". You've already got this set to a bool with the "def_bool" line.
--
Doug Goldstein
signature.asc
Description
On 6/20/16 9:41 AM, Doug Goldstein wrote:
> On 6/20/16 9:04 AM, Daniel De Graaf wrote:
>> Since enabling XSM is required to enable FLASK, place the option for
>> FLASK below the one for XSM. In addition, since it does not make sense
>> to enable XSM without any XSM provid
-
> - If unsure, say N.
> -
>
> +config FLASK
> + def_bool y
> + bool "FLux Advanced Security Kernel support" if EXPERT = "y"
Why did FLASK become dependent on EXPERT? It wasn't previously.
--
Doug Goldstein
signature.asc
D
he future, a switching mechanism will be needed
> regardless, and that can be placed in xsm_core.c.
>
> Signed-off-by: Daniel De Graaf
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
X
not handled by the existing
> hooks only if the policy was compiled with "checkpolicy -U allow". In
> previous releases, this bit did nothing, and the default remains to deny
> the unknown operations.
>
> Signed-off-by: Daniel De Graaf
Reviewed-by: Doug Goldstein
--
On 6/20/16 9:04 AM, Daniel De Graaf wrote:
> These callbacks are not used in Xen.
>
> Signed-off-by: Daniel De Graaf
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital signature
___
Xen-devel mai
On 6/20/16 9:04 AM, Daniel De Graaf wrote:
> This field was originally used in Linux for a default message code for
> network interfaces. It has never been used in Xen, so remove it.
>
> Signed-off-by: Daniel De Graaf
Reviewed-by: Doug Goldstein
--
Doug Goldstein
s
one type of CPU register and also need to be
> prohibited from accessing another type.
>
> Signed-off-by: Daniel De Graaf
> Reviewed-by: Konrad Rzeszutek Wilk
I'm a:
Reviewed-by: Doug Goldstein
But I'd like to see Andrew Cooper's R-b or comments as well.
--
Doug
es will make it easier/better for me) and give it a full
on test Monday morning if there is any concerns.
The other patches in the series can mostly get my R-b as well. I do have
some of the same comments / concerns that have already been brought up
so I'll go through and add my R-b to the clean p
On 6/9/16 9:47 AM, Daniel De Graaf wrote:
> The access vectors defined here have never been used by xenstore.
>
> Signed-off-by: Daniel De Graaf
Reviewed-by: Doug Goldstein
--
Doug Goldstein
signature.asc
Description: OpenPGP digital
101 - 200 of 937 matches
Mail list logo
