Re: [Xen-devel] ARM64 hardware in osstest (WAS: [PATCH 0/2] ocaml: Start on fixing brokenness when no ocamlopt)

2017-03-30 Thread Ian Jackson
Hi. Christian Lindig of Citrix has been looking into our ARM64 ocaml build problem. See attached mail from him. (NB: xen-devel added to CC list.) Christian writes: > My short-term strategy would be to exclude the ocaml xenstored on > architectures that don’t support the native code OCaml > comp

Re: [Xen-devel] [libvirt test] 106952: regressions - FAIL

2017-03-29 Thread Ian Jackson
Jim Fehlig writes ("Re: [Xen-devel] [libvirt test] 106952: regressions - FAIL"): > On 03/28/2017 02:09 AM, osstest service owner wrote: > > Tests which did not succeed and are blocking, > > including tests which could not be run: > > build-i386-libvirt5 libvirt-buildfail RE

Re: [Xen-devel] [Xen-security-issues-discuss] New XSA206 patches

2017-03-28 Thread Ian Jackson
(CCing xen-devel as this issue is no longer embargoed.) Sarah Newman writes ("Re: [Xen-security-issues-discuss] New XSA206 patches"): > On 03/28/2017 06:59 AM, Ian Jackson wrote: > > There is no functional difference compared to the v6 patches for > > unstable.

Re: [Xen-devel] [PATCH RESEND] tools/libxl: add support for emulated NVMe drives

2017-03-22 Thread Ian Jackson
Paul Durrant writes ("RE: [PATCH RESEND] tools/libxl: add support for emulated NVMe drives"): > > I guess that was with xapi rather than libxl ? > > Nope. It was libxl. That's weird. You specify it as xvda in the config file ? > Windows PV drivers treat hd*, sd* and xvd* numbering in the same

Re: [Xen-devel] [PATCH RESEND] tools/libxl: add support for emulated NVMe drives

2017-03-22 Thread Ian Jackson
Paul Durrant writes ("RE: [PATCH RESEND] tools/libxl: add support for emulated NVMe drives"): > This is my VM: > > root@brixham:~# xenstore-ls "/libxl/3" > device = "" > vbd = "" > 51712 = "" ... >params = "qcow2:/root/winrs2-pv1.qcow2" > No problem using xvda... still ends up as IDE prim

Re: [Xen-devel] [PATCH RESEND] tools/libxl: add support for emulated NVMe drives

2017-03-22 Thread Ian Jackson
Paul Durrant writes ("RE: [PATCH RESEND] tools/libxl: add support for emulated NVMe drives"): > > From: Ian Jackson [mailto:ian.jack...@eu.citrix.com] > > That's not my point. The purpose of this table is to advise guests > > what the conventional in-guest devi

Re: [Xen-devel] [PATCH RESEND] tools/libxl: add support for emulated NVMe drives

2017-03-22 Thread Ian Jackson
Paul Durrant writes ("RE: [PATCH RESEND] tools/libxl: add support for emulated NVMe drives"): > > Oh, wait, I have just noticed that you have reused an entry in this > > table! > > > >1 << 28 | disk << 8 | partition xvd, disks or partitions 16 onwards > > ... > > > +1 << 28 | disk <

Re: [Xen-devel] [PATCH RESEND] tools/libxl: add support for emulated NVMe drives

2017-03-22 Thread Ian Jackson
Paul Durrant writes ("RE: [PATCH RESEND] tools/libxl: add support for emulated NVMe drives"): > [Ian:] > > If and when qemu supports multiple namespaces, how will this be > > specified ? > > I'd guess a vdev of the form nvmeXnY would follow convention. Right. Sorry, I was unclear. I meant here

Re: [Xen-devel] [PATCH RESEND] tools/libxl: add support for emulated NVMe drives

2017-03-22 Thread Ian Jackson
Paul Durrant writes ("[PATCH RESEND] tools/libxl: add support for emulated NVMe drives"): > NOTE: QEMU's emulation only supports a single NVMe namespace, so the > vdev syntax does not include specification of a namespace. > Also, current versions of SeaBIOS do not support booting from

Re: [Xen-devel] [PATCH v2 09/12] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP

2017-03-20 Thread Ian Jackson
Haozhong Zhang writes ("[PATCH v2 09/12] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP"): > If LMCE is supported by host and ' mca_caps = [ "lmce" ] ' is > present in xl config, the LMCE capability will be exposed in guest > MSR_IA32_MCG_CAP. By default, LMCE is not expo

Re: [Xen-devel] [PATCH v4 05/14] golang/xenlight: Add tests host related functionality functions

2017-03-20 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH v4 05/14] golang/xenlight: Add tests host related functionality functions"): > I had a chat with Ian Jackson, and we agreed that it would be better > to create a file, maybe "test-common.c", that would contain this > v

[Xen-devel] [PATCH] cs-adjust-flight: Work properly on db transaction retry

2017-03-20 Thread Ian Jackson
The variable @changes is eaten during processing. So on db retry, there would be changes missing. (When creating a new flight, this would often mean a flight with no jobs, which cannot be executed.) CC: Roger Pau Monné Signed-off-by: Ian Jackson --- cs-adjust-flight |5 - 1 file

[Xen-devel] [OSSTEST PATCH] cs-adjust-flight: Remove broken memoisation of queries in for_things

2017-03-20 Thread Ian Jackson
The memo keys failed to include many of the important inputs. CC: Roger Pau Monné Signed-off-by: Ian Jackson --- cs-adjust-flight | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cs-adjust-flight b/cs-adjust-flight index 45c1420..85ced59 100755 --- a/cs-adjust-flight

Re: [Xen-devel] [PATCH 3/4] misc/release-checklist: Split out branching-checklist.txt

2017-03-09 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 3/4] misc/release-checklist: Split out branching-checklist.txt"): > On 09.03.17 at 16:19, wrote: > > +##* tag branchpoint > > +##hg tag $v.0-branched > > +##hg sign -k 'Xen tree' 4.1.0-branched > > Does this Mercurial stuff need keeping? No. But,

Re: [Xen-devel] [PATCH 2/4] misc/release-checklist: Remove pre-4.3 tarball target instructions

2017-03-09 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 2/4] misc/release-checklist: Remove pre-4.3 tarball target instructions"): > On 09.03.17 at 16:19, wrote: > > @@ -232,14 +202,10 @@ GZIP=-9v tar zcf > > /volatile/iwj/website-thing/xen.org/oss-xen/release/$v/xen-$v.t > > -(make -j4 KERNELS='' && ec

[Xen-devel] [PATCH 4/4] misc/branching-checklist: Call mg-branch-setup in Cambridge too

2017-03-09 Thread Ian Jackson
Signed-off-by: Ian Jackson --- misc/branching-checklist.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/misc/branching-checklist.txt b/misc/branching-checklist.txt index c905383..8899432 100644 --- a/misc/branching-checklist.txt +++ b/misc/branching-checklist.txt @@ -54,6 +54,12

[Xen-devel] [PATCH 2/4] misc/release-checklist: Remove pre-4.3 tarball target instructions

2017-03-09 Thread Ian Jackson
4.2 is well out of support and we will never need to make a release of it again. Delete all the stuff for making combined tarballs "by hand". Signed-off-by: Ian Jackson --- misc/release-checklist.txt | 34 -- 1 file changed, 34 deletions(-) diff --

[Xen-devel] [PATCH 1/4] misc/release-checklist: Remove clearly-obsolete stuff

2017-03-09 Thread Ian Jackson
) instruction related to ancient locations within Citrix. Signed-off-by: Ian Jackson --- misc/release-checklist.txt | 64 -- 1 file changed, 64 deletions(-) diff --git a/misc/release-checklist.txt b/misc/release-checklist.txt index 51f9508..dfeb34a 100644

[Xen-devel] [PATCH 3/4] misc/release-checklist: Split out branching-checklist.txt

2017-03-09 Thread Ian Jackson
This is almost all just motion. There is one new paragraph in branching-checklist.txt: + Update both new branches according to release-checklist.txt section re + README etc. Signed-off-by: Ian Jackson --- misc/branching-checklist.txt | 97 misc

[Xen-devel] [PATCH 0/4] misc/release-checklist: Updates prompted by recent release

2017-03-09 Thread Ian Jackson
When doing the recent stable release branches, I tripped over some deficiencies in these checklists. And, now that they are in git, we can much more safely throw away a lot of ancient stuff. Please shout if you have any objections. I hope to push this today. Ian. __

Re: [Xen-devel] [OSSTEST PATCH] ts-xtf-run: Understand ./xtf-runner returning CRASH

2017-03-07 Thread Ian Jackson
Andrew Cooper writes ("[OSSTEST PATCH] ts-xtf-run: Understand ./xtf-runner returning CRASH"): > ./xtf-runner wants to distinguish between a clean and unclean exits of the > test. OSSTest doesn't care, so map unclean exit to failure.

Re: [Xen-devel] [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions

2017-03-03 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions"): > Yes, the plan was to have it off by default at very least until we got > configure to detect the presence of a go compiler. Ronald has already > spent a decent chunk of his time doing Ma

Re: [Xen-devel] [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions

2017-03-03 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions"): > Right. The purpose of hand-crafting the code was to get a feel for what > a good Go-like output would look like before investing in the IDL. That makes sense. > It sounds like you're

Re: [Xen-devel] [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions

2017-03-02 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions"): > On 02/03/17 17:36, Ian Jackson wrote: > > I assume this whole series is RFC still ? > > I think the earlier patches looked pretty close to being checked in.

Re: [Xen-devel] [PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions

2017-03-02 Thread Ian Jackson
Ronald Rojas writes ("[PATCH v2 5/5] golang/xenlight: Add tests host related functionality functions"): > Create tests for the following functions: > - GetVersionInfo > - GetPhysinfo > - GetDominfo > - GetMaxCpus > - GetOnlineCpus > - GetMaxNodes > - GetFreeMemory I assume this whole series is RF

Re: [Xen-devel] [PATCH 0/5] xl cleanup and docs

2017-03-02 Thread Ian Jackson
to xl.h All five Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 2/4] tools: add pkg-config file for libxc

2017-03-02 Thread Ian Jackson
Juergen Gross writes ("[PATCH v2 2/4] tools: add pkg-config file for libxc"): > Instead of a try and error approach needing updates for nearly each > new version of Xen just provide xencontrol.pc to be used via > pkg-config. Acked-by

Re: [Xen-devel] [PATCH v2 1/4] stubdom: set xen interface version for stubdom apps using xenctrl.h

2017-03-02 Thread Ian Jackson
config files where needed. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 1/3] x86: remove PVHv1 code

2017-03-01 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH v2 1/3] x86: remove PVHv1 code"): > On Wed, Mar 01, 2017 at 02:51:33PM +, Ian Jackson wrote: > > But config files are supposed to be written by nonprogrammers (or by > > toolstack or orchestration system programmers). > > OK,

Re: [Xen-devel] [PATCH v2 1/3] x86: remove PVHv1 code

2017-03-01 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH v2 1/3] x86: remove PVHv1 code"): > It's not just the CPU extensions, we are also providing it with a > local APIC and ACPI tables, The host and guest system administrators do not care about any of that. These are implementation details. > and it looks like we

Re: [Xen-devel] [PATCH v2 1/3] x86: remove PVHv1 code

2017-03-01 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH v2 1/3] x86: remove PVHv1 code"): > On Wed, Mar 01, 2017 at 01:53:29PM +, Ian Jackson wrote: > > Well, PVHv2 is in the process of becoming properly supported, so now > > is the time to decide the "official&qu

Re: [Xen-devel] [PATCH v2 1/3] x86: remove PVHv1 code

2017-03-01 Thread Ian Jackson
Roger Pau Monne writes ("Re: [PATCH v2 1/3] x86: remove PVHv1 code"): > On Tue, Feb 28, 2017 at 05:44:51PM +, Ian Jackson wrote: > > Are those explicit settings even a supported way to create a PVHv2 > > domain ? I think they probably shouldn't be. > >

Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-winxpsp3-vcpus1

2017-03-01 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-winxpsp3-vcpus1"): > On 01.03.17 at 06:37, wrote: > > *** Found and reproduced problem changeset *** ...> > > > Bug is in tree: xen git://xenbits.xen.org/xen.git > > Bug introduced: 1a6e3220cc19

Re: [Xen-devel] [PATCH v2 1/3] x86: remove PVHv1 code

2017-02-28 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v2 1/3] x86: remove PVHv1 code"): > This removal applies to both the hypervisor and the toolstack side of PVHv1. > > Note that on the toolstack side there's one hiccup: on xl the "pvh" > configuration option is translated to builder="hvm", > device_model_version="no

Re: [Xen-devel] [PATCH] xl: fix compilation of xl_migrate.c

2017-02-28 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH] xl: fix compilation of xl_migrate.c"): > The usage of signal(3) requires the inclusion of the signal.h header: > > http://pubs.opengroup.org/onlinepubs/9699919799/functions/signal.html > > This fixes the build on FreeBS

Re: [Xen-devel] [PATCH 3/4] tools: use a dedicated build directory for qemu

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH 3/4] tools: use a dedicated build directory for qemu"): > On 28/02/17 12:13, Ian Jackson wrote: > > ... why ? > > Hmm, yes, I should have added the reason to the commit description: > > This way I can use the same source dir

Re: [Xen-devel] [PATCH 1/4] interface: avoid redefinition of __XEN_INTERFACE_VERSION__

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("Re: [Xen-devel] [PATCH 1/4] interface: avoid redefinition of __XEN_INTERFACE_VERSION__"): > Hmm, maybe this is the problem: the value from the command line is > (textually) __XEN_LATEST_INTERFACE_VERSION__ while the value from the > #define is the _value_ of __XEN_LATEST_INT

Re: [Xen-devel] [PATCH 2/4] tools: add pkg-config file for libxc

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH 2/4] tools: add pkg-config file for libxc"): > On 28/02/17 12:13, Ian Jackson wrote: > > I worry though that we're breaking new ground. Did you come up with > > this idea yourself ? > > Yes. How exciting. > > Are you

Re: [Xen-devel] [PATCH 4/4] tools: set pkg-config path when configuring qemu

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH 4/4] tools: set pkg-config path when configuring qemu"): > On 28/02/17 12:08, Ian Jackson wrote: > > Is PKG_CONFIG_PATH used _in addition to_ the built-in paths, or does > > it replace them ? > > It is in addition. Good.

Re: [Xen-devel] [PATCH 2/4] tools: add pkg-config file for libxc

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("[PATCH 2/4] tools: add pkg-config file for libxc"): > When configuring the build of qemu the configure script is building > various test programs to determine the exact version of libxencontrol. > > Instead of a try and error approach needing updates for nearly each > new ve

Re: [Xen-devel] [PATCH 3/4] tools: use a dedicated build directory for qemu

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("[PATCH 3/4] tools: use a dedicated build directory for qemu"): > Instead of using the downloaded git tree as target directory for the > qemu build create a dedicated directory for that purpose. ... why ? Ian. ___ Xen-devel maili

Re: [Xen-devel] [PATCH 1/4] interface: avoid redefinition of __XEN_INTERFACE_VERSION__

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("[PATCH 1/4] interface: avoid redefinition of __XEN_INTERFACE_VERSION__"): > In stubdom environment __XEN_INTERFACE_VERSION__ is sometimes defined > on the command line of the build instruction. This conflicts with > xen-compat.h defining it unconditionally if __XEN__ or __XE

Re: [Xen-devel] [PATCH 4/4] tools: set pkg-config path when configuring qemu

2017-02-28 Thread Ian Jackson
Juergen Gross writes ("[PATCH 4/4] tools: set pkg-config path when configuring qemu"): > When calling configure for qemu provide the local pkg-config directory > in order to let the configure process find the libxenctrl version. Is PKG_CONFIG_PATH used _in addition to_ the built-in paths, or does

Re: [Xen-devel] [PATCH] xl: move some helper functions to xl_utils.c

2017-02-28 Thread Ian Jackson
Wei Liu writes ("[PATCH] xl: move some helper functions to xl_utils.c"): > Move some commonly used functions to a new file. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/2] xl: split out vnc and console related code

2017-02-27 Thread Ian Jackson
er. ... you forgot to remove this from the commit message. With that change, Acked-by: Ian Jackson Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] xl: call libxl_vncviewer_exec in main_vncviewer

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/2] xl: call libxl_vncviewer_exec in main_vncviewer"): > We will need to move main_vncviewer to a different file where it has no > access to the helper vncviewer. Acked-by: Ian Jackson ___ Xen-devel mailin

Re: [Xen-devel] [PATCH 3/3] xl: split out xl_parse.[ch]

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 3/3] xl: split out xl_parse.[ch]"): > Move all parsing code into xl_parse.c. Export the ones needed in > xl_parse.h. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/3] xl: rename cpurange_parse to parse_cpurange

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/3] xl: rename cpurange_parse to parse_cpurange"): > We want to consistently prefix functions to parse input with "parse_". Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org ht

Re: [Xen-devel] [PATCH 2/3] xl: introduce a function to get shutdown action name

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/3] xl: introduce a function to get shutdown action name"): > The array to map libxl_shutdown_action_to_shutdown to string is going to > be moved to a dedicated file. Acked-by: Ian Jackson ___ Xen-devel mailin

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 20/29] xl: split out cd related code"): > On Mon, Feb 27, 2017 at 04:36:16PM +, Ian Jackson wrote: > > Yes, indeed, that was the only reason I didn't ack it. > > Thanks. I want to avoid reposting as much as possible because this >

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 20/29] xl: split out cd related code"): > On Mon, Feb 27, 2017 at 03:56:21PM +, Ian Jackson wrote: > > Wei Liu writes ("[PATCH 20/29] xl: split out cd related code"): > > > Signed-off-by: Wei Liu > > > --- > &

Re: [Xen-devel] [PATCH] libs/devicemodel: free xencall handle in error path in _open()

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH] libs/devicemodel: free xencall handle in error path in _open()"): > Change the allocation to use calloc to get zeroed structure. Free > xencall handler in error path. > > Spotted by Coverity. Acked-by: Ian Jackson _

Re: [Xen-devel] [PATCH 19/29] xl: split out vcpu related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 19/29] xl: split out vcpu related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 15/29] xl: split out network related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 15/29] xl: split out network related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 12/29] xl: split out flask related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 12/29] xl: split out flask related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 18/29] xl: split out pci related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 18/29] xl: split out pci related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 27/29] xl: split out save/restore related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 27/29] xl: split out save/restore related code"): > Add some function declarations to xl.h because they are now needed in > multiple files. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lis

Re: [Xen-devel] [PATCH 21/29] xl: split out memory related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 21/29] xl: split out memory related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 23/29] xl: split out functions to print out information

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 23/29] xl: split out functions to print out information"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 26/29] xl: split out vm lifecycle control functions

2017-02-27 Thread Ian Jackson
vmcontrol.c. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 16/29] xl: split out usb related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 16/29] xl: split out usb related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 11/29] xl: split out cpupool related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 11/29] xl: split out cpupool related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 28/29] xl: split out migration related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 28/29] xl: split out migration related code"): > Include COLO / Remus code because they are built on top of the existing > migration protocol. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lis

Re: [Xen-devel] [PATCH 24/29] xl: split out vnc and console related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 24/29] xl: split out vnc and console related code"): > The new file also contains code for channel, which is just a console > in disguise. > > Replace the call to vncviewer() with libxl_vncviewer_exec() directly in > main_vncviewer. Again, please separate out the non-code-

Re: [Xen-devel] [PATCH 29/29] xl: merge xl_cmdimpl.c into xl.c

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 29/29] xl: merge xl_cmdimpl.c into xl.c"): > After splitting out all the meaty bits, xl_cmdimpl.c doesn't contain > much. Merge the rest into xl.c and delete the file. Acked-by: Ian Jackson ___ Xen-devel m

Re: [Xen-devel] [PATCH 25/29] xl: split out miscellaneous functions

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 25/29] xl: split out miscellaneous functions"): > A collections of functions that don't warrant their own files. > > Moving main_devd there requires lifting do_daemonize to xl_utils.c. Acked-by: Ian Jackson _

Re: [Xen-devel] [PATCH 14/29] xl: split out block related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 14/29] xl: split out block related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 17/29] xl: split out scheduler related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 17/29] xl: split out scheduler related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson BTW, for all of these code motion patches: it would be nice if the comment said `code motion only, apart from the obvious Makefile change'

Re: [Xen-devel] [PATCH 10/29] xl: split out xl_parse.[ch]

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 10/29] xl: split out xl_parse.[ch]"): > Some notable changes other than code movement: > 1. rename cpurange_parse to parse_cpurange; > 2. provide a function to return shutdown action name. Can you split that out so that I can review it separately from the code motion ? Tha

Re: [Xen-devel] [PATCH 20/29] xl: split out cd related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 20/29] xl: split out cd related code"): > Signed-off-by: Wei Liu > --- > tools/xl/Makefile | 2 +- > tools/xl/xl_cd.c | 114 > ++ Would you mind calling this `libxl_cdrom.c' rather than `_cd' ? The latter makes me

Re: [Xen-devel] [PATCH 22/29] xl: split out psr related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 22/29] xl: split out psr related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 13/29] xl: split out vtpm related code

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 13/29] xl: split out vtpm related code"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 07/29] xl: lift a bunch of macros to xl_utils.h

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 07/29] xl: lift a bunch of macros to xl_utils.h"): > We're going to split xl_cmdimpl.c into multiple files. Lift the commonly > used macros to xl_utils.h. Acked-by: Ian Jackson ___ Xen-devel mailing list Xe

Re: [Xen-devel] [PATCH 09/29] xl: split out tmem related code to xl_tmem.c

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 09/29] xl: split out tmem related code to xl_tmem.c"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 06/29] xl: remove trailing spaces in xl_cmdimpl.c

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 06/29] xl: remove trailing spaces in xl_cmdimpl.c"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 02/29] xl: update copyright information

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 02/29] xl: update copyright information"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 01/29] xl: remove accidentally committed hunk from Makefile

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 01/29] xl: remove accidentally committed hunk from Makefile"): > It was never intended to be committed. Lucky the high level Makefile was > correct so it didn't cause us problem when building xl. Acked-by: Ian Jackson __

Re: [Xen-devel] [PATCH 03/29] xl: remove inclusion of libxl_osdeps.h

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 03/29] xl: remove inclusion of libxl_osdeps.h"): > There is no reason for a client to include a private header from libxl. > Remove the inclusion and define _GNU_SOURCE for {v,}asprintf in > xl_cmdimpl.c. Ac

Re: [Xen-devel] [PATCH 04/29] xl: use <> variant to include Xen tools library headers

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 04/29] xl: use <> variant to include Xen tools library headers"): > They should be treated like any other libraries installed on the build > host. Compiler options are set correctly to point to their locations.

Re: [Xen-devel] [PATCH 05/29] xl: generate _paths.h

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 05/29] xl: generate _paths.h"): > It is included by xl.h. Previously it was using _paths.h from some other > place. We'd better generate one for xl as well. Acked-by: Ian Jackson ___ Xen-devel m

Re: [Xen-devel] [PATCH 08/29] xl: move some helper functions to xl_utils.c

2017-02-27 Thread Ian Jackson
Wei Liu writes ("[PATCH 08/29] xl: move some helper functions to xl_utils.c"): > Move some commonly used functions to a new file. Prepend "x" to > function names to stick to consistent naming scheme. The `xfoo' naming scheme is a reference to `xmalloc' et al, which conventionally crash the program

Re: [Xen-devel] [linux-linus test] 106009: regressions - trouble: blocked/broken/fail/pass

2017-02-24 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [Xen-devel] [linux-linus test] 106009: regressions - trouble: blocked/broken/fail/pass"): > Can you change PVH test to use > device_model_version="none" > instead of > pvh=1 I had this conversation with Roger and we seem to have concluded that `pvh=1' should b

[Xen-devel] nobling1 (was Re: [xen-4.8-testing test] 106011: tolerable trouble: blocked/broken/fail/pass - PUSHED)

2017-02-24 Thread Ian Jackson
osstest service owner writes ("[xen-4.8-testing test] 106011: tolerable trouble: blocked/broken/fail/pass - PUSHED"): > flight 106011 xen-4.8-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/106011/ > > Failures :-/ but no regressions. > > Tests which are failing intermitte

Re: [Xen-devel] [linux-linus test] 104684: regressions - FAIL

2017-02-24 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [linux-linus test] 104684: regressions - FAIL"): > This means that the path to the serial is different between 3.16 and > 4.10 and we have no common one. For now, I would revert it. Done. > A per-flight override sounds quite ugly, so I am not sure how to so

Re: [Xen-devel] [PATCH 0/2] tools: split xl into a separate directory

2017-02-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 0/2] tools: split xl into a separate directory"): > On Thu, Feb 23, 2017 at 04:59:34PM +, Wei Liu wrote: > > But I am now very confused how we encode this in our build system. > > Obviously there is already such need. Say, all the tools under misc > > would require l

Re: [Xen-devel] [PATCH] xen-access: request compat devicemodel API

2017-02-23 Thread Ian Jackson
Wei Liu writes ("[PATCH] xen-access: request compat devicemodel API"): > xc_hvm_inject_trap is moved to the new libdevicemodel. Request the > compat layer from libxenctrl for now to make it build again. Acked-by: Ian Jackson ___ Xen-de

Re: [Xen-devel] [PATCH 0/2] tools: split xl into a separate directory

2017-02-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 0/2] tools: split xl into a separate directory"): > On Thu, Feb 23, 2017 at 03:54:02PM +, Ian Jackson wrote: > > No, this is entirely wrong. You will end up running make in > > tools/libxl twice simultaneously. > > Libacpi can be bu

Re: [Xen-devel] [PATCH] libs/devicemodel: initialise op_bufs in xendevicemodel_xcall

2017-02-23 Thread Ian Jackson
Wei Liu writes ("[PATCH] libs/devicemodel: initialise op_bufs in xendevicemodel_xcall"): > To avoid freeing uninitialised buffer when taking the first error exit > path. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lis

Re: [Xen-devel] [PATCH 0/2] tools: split xl into a separate directory

2017-02-23 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 0/2] tools: split xl into a separate directory"): > Basically this needs to be folded into xl/Makefile: > > +# libxenlight should be built before building xl > +.PHONY: libxl > +libxl: > + $(MAKE) -C $(XEN_ROOT)/tools/libxl > +$(XL_OBJS): libxl OMG. > This is in

Re: [Xen-devel] [PATCH] tools/libxendevicemodel: Add headers.chk to .gitignore

2017-02-23 Thread Ian Jackson
Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: Add headers.chk to .gitignore"): > Oops, yes, I missed that. > > Reviewed-by: Paul Durrant Thanks. I have put it all together and pushed the qemu-trad and xen.git parts to the appropriate places. Please let me know if I have messed up

Re: [Xen-devel] [PATCH 0/2] tools: split xl into a separate directory

2017-02-23 Thread Ian Jackson
Wei Liu writes ("[PATCH 0/2] tools: split xl into a separate directory"): > Xl has grown sufficiently large to warrnant its own directory. We also need > clear separation between the client (xl) and library (libxl). This is a fine idea. Both patches, Acked-by: Ian Jacks

[Xen-devel] [PATCH] tools/libxendevicemodel: Add headers.chk to .gitignore

2017-02-23 Thread Ian Jackson
CC: Paul Durrant Signed-off-by: Ian Jackson --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index c8d56d1..7182fe8 100644 --- a/.gitignore +++ b/.gitignore @@ -99,6 +99,7 @@ tools/libs/evtchn/headers.chk tools/libs/gnttab/headers.chk tools/libs/call

Re: [Xen-devel] [PATCH v2 3/5] tools/libxendevicemodel: extract functions and add a compat layer

2017-02-22 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2 3/5] tools/libxendevicemodel: extract functions and add a compat layer"): > On 22/02/17 14:37, Ian Jackson wrote: > > Is the bitmap copied in each dmop call ? > > Yes, and hence... Oh! I had assumed that this wouldn

Re: [Xen-devel] [PATCH v2 3/5] tools/libxendevicemodel: extract functions and add a compat layer

2017-02-22 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2 3/5] tools/libxendevicemodel: extract functions and add a compat layer"): > On 22/02/17 14:20, Ian Jackson wrote: > > As I think we discussed some time last week (?), this function cannot > > be a DMOP. This is because

Re: [Xen-devel] [PATCH v2 5/5] tools/libxendevicemodel: add a call to restrict the handle

2017-02-22 Thread Ian Jackson
Paul Durrant writes ("[PATCH v2 5/5] tools/libxendevicemodel: add a call to restrict the handle"): > My recent patch [1] to the Linux privcmd module introduced a mechanism > to restrict an open file handle to subsequently only accept operations for > a specified domain. Ac

Re: [Xen-devel] [PATCH v2 4/5] tools/libxendevicemodel: introduce a Linux-specific implementation

2017-02-22 Thread Ian Jackson
xendevicemodel to take > advantage of that mechanism if it is implemented in the tools domain > kernel. Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 3/5] tools/libxendevicemodel: extract functions and add a compat layer

2017-02-22 Thread Ian Jackson
Paul Durrant writes ("[PATCH v2 3/5] tools/libxendevicemodel: extract functions and add a compat layer"): > This patch extracts all functions resulting in a dm_op hypercall from > libxenctrl and moves them into libxendevicemodel. It also adds a compat > layer into libxenctrl, which can be selected

Re: [Xen-devel] [PATCH v2 2/5] tools/libxendevicemodel: introduce the new library

2017-02-22 Thread Ian Jackson
Paul Durrant writes ("[PATCH v2 2/5] tools/libxendevicemodel: introduce the new library"): > The new xendevicemodel library is intended to be used by all Xen device > models such that the only hypercall that use will be the dm_op hypercall > added by commit 524a98c2. Ac

Re: [Xen-devel] [PATCH v2 1/5] tools/libxenctrl: fix error check after opening libxenforeignmemory

2017-02-22 Thread Ian Jackson
Paul Durrant writes ("[PATCH v2 1/5] tools/libxenctrl: fix error check after opening libxenforeignmemory"): > Checking the value of xch->xcall is clearly incorrect. The code should be > checking xch->fmem (i.e. the return of the previously called function).

Re: [Xen-devel] [linux-linus test] 104684: regressions - FAIL

2017-02-22 Thread Ian Jackson
Julien Grall writes ("Re: [Xen-devel] [linux-linus test] 104684: regressions - FAIL"): > On 14/02/17 17:42, Wei Liu wrote: > > (test-lab)liuw@osstest:~/testing.git$ ./mg-hosts showprops | grep DTUART | > > grep arndale > > arndale-bluewater XenDTUARTPath /serial@12C2 > > a

<    5   6   7   8   9   10   11   12   13   14   >