Let callers of libxlDomainStart decide when it is appropriate to
acquire a job on the associated virDomainObj.
Signed-off-by: Jim Fehlig
---
Job handling in the migration code is currently broken/incomplete,
so fixing it is deferred to a follow-up series I'm working on.
src/
rs of
libxl_domain_destroy to use the wrapper.
Signed-off-by: Jim Fehlig
---
V3:
Provide a wrapper to unlock, destroy and lock domain instead of
do so at each call site of libxl_domain_destroy.
src/libxl/libxl_domain.c| 29 ++---
src/libxl/libxl_domain.h| 4
Jim Fehlig wrote:
> V2 of a small series to fix issues wrt domain destroy
>
> https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html
>
> Comments from Konrad and Martin are addressed in this version.
>
> Jim Fehlig (3):
> libxl: Move job acquisition in lib
Martin Kletzander wrote:
> On Wed, Apr 01, 2015 at 11:08:54AM -0600, Jim Fehlig wrote:
>> Recent testing on large memory systems revealed a bug in the Xen xl
>> tool's freemem() function. When autoballooning is enabled, freemem()
>> is used to ensure enough memory is a
Wei Liu wrote:
> On Thu, Mar 26, 2015 at 05:07:26PM +, Jan Beulich wrote:
>
>> All,
>>
>> having been released mid January, it is time to get ready for 4.5.1-rc1.
>> Please reply with backport requests which you consider necessary but
>> still missing. Please also be patient with them being
Martin Kletzander wrote:
> On Thu, Mar 26, 2015 at 03:29:51PM -0600, Jim Fehlig wrote:
>> Konrad Rzeszutek Wilk wrote:
>>> On Wed, Mar 25, 2015 at 02:08:35PM -0600, Jim Fehlig wrote:
>>>
>>>> A job should be acquired at the beginning of a domain destroy
&
V2 of a small series to fix issues wrt domain destroy
https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html
Comments from Konrad and Martin are addressed in this version.
Jim Fehlig (3):
libxl: Move job acquisition in libxlDomainStart to callers
libxl: acquire a job when
A job should be acquired at the beginning of a domain destroy operation,
not at the end when cleaning up the domain. Fix two occurrences of this
late job acquisition in the libxl driver. Doing so renders
libxlDomainCleanupJob unused, so it is removed.
Signed-off-by: Jim Fehlig
---
V2:
Don&#
A destroy operation can take considerable time on large memory
domains due to scrubbing the domain' memory. The operation is
running in the context of a job, so unlocking the domain and
allowing query operations is safe.
Signed-off-by: Jim Fehlig
---
V2:
Unchanged
src/libxl/libxl_dom
Let callers of libxlDomainStart decide when it is appropriate to
acquire a job on the associated virDomainObj.
Signed-off-by: Jim Fehlig
---
V2:
Don't call virDomainObjListRemove() on persistent domain
src/libxl/libxl_domain.c | 24 -
src/libxl/libxl_driver.c
Martin Kletzander wrote:
> On Wed, Mar 25, 2015 at 02:08:34PM -0600, Jim Fehlig wrote:
>> Let callers of libxlDomainStart decide when it is appropriate to
>> acquire a job on the associated virDomainObj.
>>
>
> This makes sense, I see many bugs this fixes, but how come
uture, potentially interesting
divergences.
Signed-off-by: Jim Fehlig
---
V3:
Remove unneeded local variable 'ret' in libxlDomainFreeMem.
src/libxl/libxl_domain.c | 49
1 file changed, 20 insertions(+), 29 deletions(-)
diff --git a/src/libxl/l
Martin Kletzander wrote:
> On Tue, Mar 24, 2015 at 02:43:42PM -0600, Jim Fehlig wrote:
>> Recent testing on large memory systems revealed a bug in the Xen xl
>> tool's freemem() function. When autoballooning is enabled, freemem()
>> is used to ensure enough memory is a
Jim Fehlig wrote:
> Konrad Rzeszutek Wilk wrote:
>
>> On Wed, Mar 25, 2015 at 02:08:33PM -0600, Jim Fehlig wrote:
>>
>>
>>> This small series of patches fixes some issues wrt domain destroy in
>>> the libxl driver. The primary motivation f
Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 25, 2015 at 02:08:33PM -0600, Jim Fehlig wrote:
>
>> This small series of patches fixes some issues wrt domain destroy in
>> the libxl driver. The primary motivation for this work is to
>> prevent locking the virDomainObj dur
Ian Campbell wrote:
> On Wed, 2015-03-25 at 14:08 -0600, Jim Fehlig wrote:
>
>> A destroy operation can take considerable time on large memory
>> domains due to scrubbing the domain' memory. The operation is
>> running in the context of a job, so unlocking the
Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 25, 2015 at 02:08:35PM -0600, Jim Fehlig wrote:
>
>> A job should be acquired at the beginning of a domain destroy operation,
>> not at the end when cleaning up the domain. Fix two occurances of this
>> late job acquisition in
Konrad Rzeszutek Wilk wrote:
> If we fail to create the thread we leak the shutdown_info
> structure.
>
Nice catch, thanks! ACK and pushed.
Regards,
Jim
> Signed-off-by: Konrad Rzeszutek Wilk
> ---
> src/libxl/libxl_domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> dif
Ian Campbell wrote:
> On Mon, 2015-02-09 at 11:09 +, Wei Liu wrote:
>
>> Libvirt supports migrating a guest to remote host but not local host.
>>
>
> Jim, is that right?
>
Opps, I missed this mail. Sorry for the delay.
Yes, that is correct
# virsh migrate --live test-pv xen+ssh:/
A job should be acquired at the beginning of a domain destroy operation,
not at the end when cleaning up the domain. Fix two occurances of this
late job acquisition in the libxl driver. Doing so renders
libxlDomainCleanup unused, so it is removed.
Signed-off-by: Jim Fehlig
---
src/libxl
Let callers of libxlDomainStart decide when it is appropriate to
acquire a job on the associated virDomainObj.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 24 --
src/libxl/libxl_driver.c | 53 +++-
2 files changed, 52
d 188e9c54. I'll contact the stable branch maintainers and ask them
to include these commits in the next Xen 4.4.x and 4.5.x releases.
Jim Fehlig (3):
libxl: Move job acquisition in libxlDomainStart to callers
libxl: acquire a job when destroying a domain
libxl: drop virDomainObj lock wh
A destroy operation can take considerable time on large memory
domains due to scrubbing the domain' memory. The operation is
running in the context of a job, so unlocking the domain and
allowing query operations is safe.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 4
Michal Privoznik wrote:
> On 18.02.2015 04:56, Jim Fehlig wrote:
>
>> This series is a follow up to
>>
>> https://www.redhat.com/archives/libvir-list/2015-February/msg00024.html
>>
>> It goes a step further and changes the libxl driver to use one,
>> d
Stefano Stabellini wrote:
> On Mon, 23 Mar 2015, Ian Campbell wrote:
>
>> (just ccing the other tools maintainers, in particular Stefano who knows
>> what this stuff is supposed to do...)
>>
>> On Fri, 2015-03-20 at 17:10 -0600, Jim Fehlig wrote:
>>
uture, potentially interesting
divergences.
Signed-off-by: Jim Fehlig
---
V2: Actually use libxl_wait_for_memory_target(), instead of
libxl_wait_for_free_memory()
src/libxl/libxl_domain.c | 55 +++-
1 file changed, 26 insertions(+), 29 deletions(-)
diff
uture, potentially interesting
divergences.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 57
1 file changed, 28 insertions(+), 29 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 407a9bd..ff78133 100644
---
Ian Campbell wrote:
> On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote:
>
>> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
>> index b6541d4..b43db1a 100644
>> --- a/tools/libxl/libxl.c
>> +++ b/tools/libxl/libxl.c
>> @@ -1481,6 +1481,10 @@
Ian Campbell wrote:
> On Tue, 2015-03-17 at 17:34 +, Wei Liu wrote:
>
>> On Tue, Mar 17, 2015 at 09:30:58AM -0600, Jim Fehlig wrote:
>>
>>> From: Ian Jackson
>>>
>>> Unlock the userdata before we actually call xc_domain_destroy. This
>
Ian Campbell wrote:
> On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote:
>
>> From: Ian Jackson
>>
>> From: Ian Jackson
>>
>> When domain_death_xswatch_callback needed a further call to
>> xc_domain_getinfolist it would restart it with the last do
This is a small series of libxl patches I received off-list from
Ian Jackson. The patches fix a few issues I found when converting
the libvirt libxl driver to use a single libxl_ctx. Patch 2 has
been modified slightly to address off-list comments from Wei Liu.
Ian Jackson (3):
libxl: In domain
From: Ian Jackson
Unlock the userdata before we actually call xc_domain_destroy. This
leaves open the possibility that other libxl callers will see the
half-destroyed domain (with no devices, paused), but this is fine.
Signed-off-by: Ian Jackson
CC: Wei Liu
Reviewed-by: Jim Fehlig
Tested-by
guments to getinfolist.
Signed-off-by: Ian Jackson
Reported-by: Jim Fehlig
Reviewed-by: Jim Fehlig
Tested-by: Jim Fehlig
---
tools/libxl/libxl.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 088786e..e7eb863 10
ckson
Reviewed-by: Jim Fehlig
Tested-by: Jim Fehlig
---
tools/libxl/libxl.c | 57
tools/libxl/libxl_internal.h | 1 +
2 files changed, 53 insertions(+), 5 deletions(-)
diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index b6541d4..b43
Bob Ball wrote:
> For the last few weeks Anthony and I have been working on creating a CI
> environment to run against all OpenStack jobs. We're now in a position where
> we can share the current status, overview of how it works and next steps. We
> actively want to support involvement in this
Ian Campbell wrote:
> On Tue, 2015-03-10 at 17:59 +, xen.org wrote:
>
>> flight 36071 libvirt real [real]
>> http://www.chiark.greenend.org.uk/~xensrcts/logs/36071/
>>
>> Failures :-/ but no regressions.
>>
>> Tests which did not succeed, but are not blocking:
>> test-armhf-armhf-libvirt
Stefano Stabellini wrote:
> Decrement wait_secs only if dom0 is making no progress toward reaching
> the balloon target, otherwise loop again for free.
>
> Signed-off-by: Stefano Stabellini
> Tested-by: Mike Latimer
> ---
> tools/libxl/libxl.c | 29 ++---
> tools/l
Stefano Stabellini wrote:
> On Fri, 6 Mar 2015, Ian Campbell wrote:
>
>> This is missing my point.
>>
>> We need to consider the case of a modified libvirt with the old, broken,
>> libxl too.
>>
>
> For that case, we might want to make sure that the new timeout passed to
> libxl_wait_for_me
Ian Campbell wrote:
> On Mon, 2015-03-02 at 11:14 +, Ian Jackson wrote:
>
>> Jim Fehlig writes ("Re: [Xen-devel] [xen-unstable test] 35257: regressions -
>> FAIL"):
>> ...
>>
>>> In my experience, if ERROR is insufficient,
Ian Campbell wrote:
> On Fri, 2015-02-27 at 10:48 +, Wei Liu wrote:
>
>> On Fri, Feb 27, 2015 at 09:42:29AM +, Ian Campbell wrote:
>>
>>> On Thu, 2015-02-26 at 20:14 +, xen.org wrote:
>>>
flight 35257 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~x
Ian Campbell wrote:
> On Thu, 2015-02-26 at 20:14 +, xen.org wrote:
>
>> flight 35257 xen-unstable real [real]
>> http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>> t
Wei Liu wrote:
> On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote:
>
>> At minimum, libvirt will populate the pdev_path, vdev, backend, and
>> format fields. If backend and format (which, in libvirt-speack
>> correspond to the 'name' and 'type&
Jim Fehlig wrote:
> Anthony PERARD wrote:
>
>> On Mon, Feb 02, 2015 at 05:00:34PM -0700, Jim Fehlig wrote:
>>
>>
>>> This small series fixes some assertions we occasionally see in the
>>> libxl driver when running libvirt-TCK. The assertions we
Change the domain event handler code to use the driver-wide
libxl_ctx instead of the domain-specific one.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/src/libxl/libxl_domain.c b
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 10 --
src/libxl/libxl_driver.c | 11 +++
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 4872abe..0fc03f7 100644
--- a/src/libxl/libxl_domain.c
+++ b
Register a domain event handler with the driver-wide libxl_ctx
during driver initialization.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 21 ++---
src/libxl/libxl_domain.h | 15 +++
src/libxl/libxl_driver.c | 9 +
3 files changed, 26 insertions
This function now only enables domain death events. Simply call
libxl_evenable_domain_death() instead of an unnecessary wrapper.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 32 +++-
src/libxl/libxl_domain.h | 5 -
src/libxl/libxl_driver.c | 5
07e70) at libxl/libxl_driver.c:123
There is no hint in any logs or dmesg suggesting a cause for the stuck
hypercall. Any suggestions for further debugging tips appreciated.
Jim Fehlig (10):
libxl: remove redundant calls to libxl_evdisable_domain_death
libxl: use libxl_ctx passed to libxl
instead of per-domain ctx's.
One downside to using a single libxl_ctx is there are no longer
per-domain log files for log messages emitted by libxl. Messages
for all domains will be sent to /var/log/libvirt/libxl/libxl-driver.log.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c
libxlDomainFreeMem() is only used in libxl_domain.c and thus should
be declared static. While at it, change the signature to take a
libxl_ctx instead of libxlDomainObjPrivatePtr, since only the
libxl_ctx is needed.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 16
ying muliple domains.
There have also been rumors about such deadlocks during parallel OpenStack
Tempest runs.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 234 +--
src/libxl/libxl_driver.c | 201 +++-
Instead of using the libxl_ctx in the libxlDomainObjPrivatePtr,
use the ctx passed to the callback.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index e186c53
The DEBUG log level is very verbose and can quickly fill a
filesystem hosting /var/log/libvirt/libxl/
Signed-off-by: Jim Fehlig
---
Ideally, the log level should match what is configured in libvirtd.conf.
Are the logging knob settings available in the drivers? If not, this
would be a good
Domain death watch is already disabled in libxlDomainCleanup. No
need to disable it a second and third time.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index 21c41d7
Wei Liu wrote:
> On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote:
>
>> Wei Liu writes ("[PATCH 3/3] libxl: libxl__device_from_disk should retrieve
>> backend from xenstore"):
>>
>>> ... if backend is not set by caller.
>>>
>> Acked-by: Ian Jackson
>>
>> as far as it goe
Ian Campbell wrote:
> Jim,
>
> Thought you might like to know that we are now testing actually starting
> a guest with libvirt in osstest and this is the first pass.
>
Nice! I'll keep an eye out for any regressions.
> Currently we don't test migration (which is why that appears to have
> fail
Anthony PERARD wrote:
> On Mon, Feb 02, 2015 at 05:00:34PM -0700, Jim Fehlig wrote:
>
>> This small series fixes some assertions we occasionally see in the
>> libxl driver when running libvirt-TCK. The assertions were due to
>> races between destroying per-domain libxl_
ying muliple domains.
There have also been rumors about such deadlocks during parallel OpenStack
Tempest runs.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 234 +--
src/libxl/libxl_driver.c | 201 +++-
libvirtd.conf, so often missed by
automated test setups that want DEBUG loglevel.
Patch 1 actually fixes the assertions. Patch2 fixes a stupid mistake.
See the commit messages for details.
Jim Fehlig (2):
libxl: fix fd and timer event handling
libxl: Move setup of child processing code to driver
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_domain.c | 10 --
src/libxl/libxl_driver.c | 11 +++
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
index c44799b..b47c1b0 100644
--- a/src/libxl/libxl_domain.c
+++ b
libxl to choose a
suitable backend when not specified, so I think this recommendation
should be symmetrical in the add and remove operations.
Regards,
Jim
>From 48f5dc7b80384538ff343af46379efefe51986be Mon Sep 17 00:00:00 2001
From: Jim Fehlig
Date: Mon, 26 Jan 2015 15:30:20 -0700
Subject:
Hi All,
I've been attempting to revive the libvirt domXML -> libxl_domain_config
tests originally started by Daniel all the way back in May!
https://www.redhat.com/archives/libvir-list/2014-May/msg01102.html
In a reply to patch5 of the series, Ian Campbell noted that the doc
produced by libxl_do
Ian Jackson wrote:
> Jim Fehlig writes ("Re: [PATCH OSSTEST v2 18/18] WIP: libvirt: migration +
> save/restore support."):
>
>> You can get around this by disabling TLS in /etc/libvirt/libvirtd.conf.
>> Then simply use ssh to connect to the dst host, e.g. '
Eric Blake wrote:
> On 01/20/2015 09:09 PM, Jim Fehlig wrote:
>
>> When libvirt is configured --without-xen, building the xlconfigtest
>> fails with
>>
>> CCLD xlconfigtest
>> /usr/lib/gcc/x86_64-linux-gnu/4.7/../../../x86_64-linux-gnu/crt1.o
&g
Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 18/18] WIP: libvirt: migration +
> save/restore support."):
>
>> Note that this remains stubbed out, since making it actually work
>> requires more work (i.e. I need to figure out what is involved, seem
>> to need TLS and a CA etc...)
noticed the bisector finished and flagged this commit
commit 4ed5fb91934cbad53cc4128030869f4b46e0811d
Author: Kiarie Kahurani
Date: Mon Dec 15 21:30:05 2014 -0700
tests: Tests for the xen-xl parser
Add disk and spice config tests for the xen_xl config parser
Signed-off-
roduced in commit 4ed5fb91 by too much copy and paste from
xmconfigtest.
Signed-off-by: Jim Fehlig
---
tests/Makefile.am| 17 -
tests/xlconfigtest.c | 4 ++--
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index b16d3d
from libxl_domain_create_new()
> Ignore empty string that can return libxl_console_get_tty()
>
> Change in V2:
> Adding bug report link.
> Reword the last part of the patch description.
> Cleanup the code.
> Use VIR_FREE before VIR_STRDUP.
> Remove the code from
Eric Blake wrote:
> On 01/14/2015 08:50 AM, Jim Fehlig wrote:
>
>> V5 of xen-xl parser. V4 was close
>>
>> https://www.redhat.com/archives/libvir-list/2015-January/msg00429.html
>>
>> but the tests did not exersice the spice parsing/formatting code.
Eric Blake wrote:
> On 01/13/2015 04:47 PM, Jim Fehlig wrote:
>
>
>>>> +++ b/src/Makefile.am
>>>> @@ -1005,6 +1005,10 @@ XENCONFIG_SOURCES =
>>>> \
>>>>xenconfig/xen_common.c xencon
V5 of xen-xl parser. V4 was close
https://www.redhat.com/archives/libvir-list/2015-January/msg00429.html
but the tests did not exersice the spice parsing/formatting code. It is
now fixed in V5, along with addressing a few V4 comments from eblake.
Jim Fehlig (1):
Introduce support for
From: Kiarie Kahurani
Now that xenconfig supports parsing and formatting Xen's
XL config format, integrate it into the libxl driver's
connectDomainXML{From,To}Native functions.
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
No change from V4.
src/libxl/libxl_dri
only
recently has the corresponding header file been included. A check
for the header is done in configure.ac. If not found, xlu_disk_parse()
is declared externally.
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
V5:
Address a few V4 issues noted by eblake.
configu
From: Kiarie Kahurani
Add disk and spice config tests for the xen_xl config parser
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
V5:
Enable spice test. Fix invalid config in the test data files and
an actual bug in the spice formatting code.
tests/Makefile.am
Eric Blake wrote:
> On 01/13/2015 08:53 AM, Jim Fehlig wrote:
>
>> From: Kiarie Kahurani
>>
>> add tests for the xen_xl config parser
>>
>> Signed-off-by: Kiarie Kahurani
>> Signed-off-by: Jim Fehlig
>> ---
>>
>
Eric Blake wrote:
> On 01/13/2015 08:53 AM, Jim Fehlig wrote:
>
>> Introduce a parser/formatter for the xl config format. Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl. This patch adds support for pars
From: Kiarie Kahurani
add tests for the xen_xl config parser
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
V4:
Only build xlconfigtest when libxl is available.
tests/Makefile.am| 11 ++
tests/testutilsxen.c | 50
tests
From: Kiarie Kahurani
Now that xenconfig supports parsing and formatting Xen's
XL config format, integrate it into the libxl driver's
connectDomainXML{From,To}Native functions.
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
V4:
Note support for new 'xen-xl'
which has simplified the series quite a bit and
eliminates the potential of the copied flex parser diverging from
the canonical source in xen.git.
[1] https://www.redhat.com/archives/libvir-list/2014-December/msg00765.html
[2] http://lists.xen.org/archives/html/xen-devel/2015-01/msg00690.html
Jim
only
recently has the corresponding header file been included. A check
for the header is done in configure.ac. If not found, xlu_disk_parse()
is declared externally.
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
V4:
Use Xen's libxlutil to parse disk strings instead of copyin
Eric Blake wrote:
> On 01/09/2015 10:03 PM, Jim Fehlig wrote:
>
>> Introduce a parser/formatter for the xl config format. Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl. This patch adds support for pars
John Ferlan wrote:
> On 01/10/2015 12:03 AM, Jim Fehlig wrote:
>
>> Introduce a parser/formatter for the xl config format. Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl. This patch adds support for
Eric Blake wrote:
> On 01/12/2015 07:51 AM, John Ferlan wrote:
>
>> On 01/10/2015 12:03 AM, Jim Fehlig wrote:
>>
>>> This reverts commit 2c78051a14acfb7aba078d569b1632dfe0ca0853.
>>>
>>> Conflicts:
>>> src/Makefile.am
>
John Ferlan wrote:
> On 01/10/2015 12:03 AM, Jim Fehlig wrote:
>
>> Introduce a parser/formatter for the xl config format. Since the
>> deprecation of xm/xend, the VM config file format has diverged as
>> new features are added to libxl. This patch adds support for
Ian Campbell wrote:
> On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote:
>
>> The first attempt to implement support for parsing/formatting Xen's
>> xl disk config format copied Xen's flex-based parser into libvirt, which
>> has proved to be challenging in th
This reverts commit cab767831f74ec72809dacd07cb782a88a097f21.
Signed-off-by: Jim Fehlig
---
bootstrap.conf | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 22c1c06..c06ee4c 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -1,6 +1,6
This reverts commit 6b818d3b09f4e74ac2ea1d4020896be1e6871867.
Signed-off-by: Jim Fehlig
---
tests/Makefile.am| 9 +-
tests/testutilsxen.c | 50
tests/testutilsxen.h | 9 +-
tests/xlconfigdata/test-new-disk.cfg | 26
tests
This reverts commit 2c78051a14acfb7aba078d569b1632dfe0ca0853.
Conflicts:
src/Makefile.am
Signed-off-by: Jim Fehlig
---
.gitignore| 1 -
cfg.mk| 3 +-
configure.ac | 1 -
po/POTFILES.in| 1 -
src
This reverts commit 533349ff43ddf091026fbcb0d9a714d9cc570dc7.
Signed-off-by: Jim Fehlig
---
src/Makefile.am | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 2eaaf11..a6ea8e0 100644
--- a/src/Makefile.am
+++ b/src
From: Kiarie Kahurani
Now that xenconfig supports parsing and formatting Xen's
XL config format, integrate it into the libxl driver's
connectDomainXML{From,To}Native functions.
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_dri
From: Kiarie Kahurani
add tests for the xen_xl config parser
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
tests/Makefile.am| 9 +-
tests/testutilsxen.c | 50
tests/testutilsxen.h | 9 +-
tests/xlconfigdata/test
This reverts commit 1b21d300691a78f73d94446616a6d1f9fd88991e.
Conflicts:
src/Makefile.am
Signed-off-by: Jim Fehlig
---
src/Makefile.am | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index aaa5af2..95ba12c 100644
--- a/src
This reverts commit 703ef9667abf016ef1040eac296a81792b366932.
Signed-off-by: Jim Fehlig
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 95ba12c..c7975e5 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1015,7
This reverts commit edacdb3d12256af4f6e31ec65c9dd4797fb3aa0d.
Signed-off-by: Jim Fehlig
---
src/Makefile.am | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index a6ea8e0..850122a 100644
--- a/src
unchanged from patches 3 and 4 in the first attempt.
One upshot of using libxlutil instead of copying the flex source is
removing the potential for source divergence.
Jim Fehlig (10):
Revert "bootstrap.conf: add check for flex"
Revert "src/Makefile: Fix parallel build
orted by the libxl virt driver, only
recently has the corresponding header file been included. A check
for the header is done in configure.ac. If not found, xlu_disk_parse()
is declared externally.
Signed-off-by: Kiarie Kahurani
Signed-off-by: Jim Fehlig
---
configure.ac | 3
This reverts commit e662968fd980158e8f8d8990bb43378dbc3d036a.
Signed-off-by: Jim Fehlig
---
src/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 850122a..aaa5af2 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1015,7
This reverts commit 4f524212ce614e1ca84b34dd8330a48957c8f823.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_driver.c | 32
1 file changed, 8 insertions(+), 24 deletions(-)
diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 4135670..53c87ce
Dario Faggioli wrote:
> On Thu, 2015-01-08 at 14:56 -0700, Jim Fehlig wrote:
>
>> Jim Fehlig wrote:
>>
>>> No, not directly. But I will be doing so now. I should try to revert
>>> all this nonsense and use libxlu before it ends up in the next libvirt
&
Jim Fehlig wrote:
> Jim Fehlig wrote:
>
>> Ian Campbell wrote:
>>
>>
>>
>>> I must confess that I thought you already did use libxlu...
>>>
>>>
>>>
>> No, not directly. But I will be doing so now. I
301 - 400 of 407 matches
Mail list logo
