Re: [Xen-devel] [PATCH] scripts: warn about invalid MAINTAINERS patterns

2017-11-01 Thread Joe Perches
On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote: > > On Nov 1, 2017, at 13:11, Tom Saeger wrote: > > > > On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote: > > > (add mercurial-devel and xen-devel to cc's) > > > > > > O

Re: [Xen-devel] [PATCH v2 1/1] scripts: warn about invalid MAINTAINERS patterns

2017-11-01 Thread Joe Perches
ange the subject if/when you add it to quilt? > Pattern check warnings are shown for "F" and "X" patterns found in > MAINTAINERS file(s) which do not match any files known by git. > > Signed-off-by: Tom Saeger > Cc: Joe Perches Otherwise, Acked-by: Joe Per

Re: [Xen-devel] [PATCH] scripts: warn about invalid MAINTAINERS patterns

2017-11-01 Thread Joe Perches
(add mercurial-devel and xen-devel to cc's) On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > "F" and "X" patterns found in MAINTAINERS file(s). Hey again Tom. About mercurial/hg. While as far as I know there hasn't

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the tip tree

2017-08-31 Thread Joe Perches
On Thu, 2017-08-31 at 11:16 +0200, Ingo Molnar wrote: > * Thomas Gleixner wrote: > Low prio nitpicking, could we please write such table based initializers in a > vertically organized, tabular fashion: > > > + { debug,xen_xendebug, > > true },

Re: [Xen-devel] [PATCH v2] xen/mce: don't issue error message for failed /dev/mcelog registration

2017-06-13 Thread Joe Perches
On Tue, 2017-06-13 at 21:27 +0200, Juergen Gross wrote: > On 13/06/17 18:31, Joe Perches wrote: > > On Tue, 2017-06-13 at 18:13 +0200, Juergen Gross wrote: > > > On 13/06/17 17:20, Ingo Molnar wrote: > > > > * Juergen Gross wrote: > > > > > > >

Re: [Xen-devel] [PATCH v2] xen/mce: don't issue error message for failed /dev/mcelog registration

2017-06-13 Thread Joe Perches
On Tue, 2017-06-13 at 18:13 +0200, Juergen Gross wrote: > On 13/06/17 17:20, Ingo Molnar wrote: > > * Juergen Gross wrote: > > > > > When running under Xen as dom0 /dev/mcelog is being registered by Xen > > > instead of the normal mcelog driver. Avoid an error message being > > > issued by the mc

Re: [Xen-devel] [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote: > On 23 February 2017 at 17:18, Joe Perches wrote: > > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > > > There are ~4300 uses of pr_w

Re: [Xen-devel] [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > There are ~4300 uses of pr_warn and ~250 uses of the older > > pr_warning in the kernel source tree. > > > > Make the use of pr_warn consistent across all

[Xen-devel] [PATCH 09/35] x86: Convert remaining uses of pr_warning to pr_warn

2017-02-16 Thread Joe Perches
line Signed-off-by: Joe Perches --- arch/x86/kernel/amd_gart_64.c | 12 +++-- arch/x86/kernel/apic/apic.c| 46 -- arch/x86/kernel/apic/apic_noop.c | 2 +- arch/x86/kernel/setup_percpu.c | 4 +-- arch/x86/kernel/tboot.c

[Xen-devel] [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-16 Thread Joe Perches
with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. Miscellanea: o Coalesce formats and realign arguments Some files not compiled - no cross-compilers Joe Perches (35): alpha: Convert remaining uses of pr_warning to pr_warn ARM: ep93xx: Convert remaining uses of pr_warning

Re: [Xen-devel] [PATCH] xenbus: Neaten xenbus_va_dev_error

2017-02-08 Thread Joe Perches
On Wed, 2017-02-08 at 12:14 -0500, Boris Ostrovsky wrote: > On 02/08/2017 11:05 AM, Joe Perches wrote: > > On Wed, 2017-02-08 at 10:33 -0500, Boris Ostrovsky wrote: > > > On 02/08/2017 06:33 AM, Joe Perches wrote: > > > > This function error pat

Re: [Xen-devel] [PATCH] xenbus: Neaten xenbus_va_dev_error

2017-02-08 Thread Joe Perches
On Wed, 2017-02-08 at 10:33 -0500, Boris Ostrovsky wrote: > On 02/08/2017 06:33 AM, Joe Perches wrote: > > This function error patch can be simplified, so do so. > > > > Remove fail: label and somewhat obfuscating, used once "error_path" > > function. btw:

[Xen-devel] [PATCH] xenbus: Neaten xenbus_va_dev_error

2017-02-08 Thread Joe Perches
This function error patch can be simplified, so do so. Remove fail: label and somewhat obfuscating, used once "error_path" function. Signed-off-by: Joe Perches --- drivers/xen/xenbus/xenbus_client.c | 39 ++ 1 file changed, 10 insertions(+), 29

Re: [Xen-devel] [PATCH v4 0/3] checkpatch: handling of memory barriers

2016-01-11 Thread Joe Perches
On Mon, 2016-01-11 at 13:00 +0200, Michael S. Tsirkin wrote: > As part of memory barrier cleanup, this patchset > extends checkpatch to make it easier to stop > incorrect memory barrier usage. Thanks Michael. Acked-by: Joe Perches ___

Re: [Xen-devel] [PATCH v3 3/3] checkpatch: add virt barriers

2016-01-10 Thread Joe Perches
On Mon, 2016-01-11 at 09:13 +1100, Julian Calaby wrote: > On Mon, Jan 11, 2016 at 6:31 AM, Michael S. Tsirkin wrote: > > Add virt_ barriers to list of barriers to check for > > presence of a comment. [] > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > > @@ -5133,7 +5133,8 @@ sub

Re: [Xen-devel] [PATCH v2 1/3] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Joe Perches
On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote: > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > > SMP-only barriers were missing in checkpatch.pl > > > > Refactor code slightly to make adding more variants easier. > [] > > diff --git a/s

Re: [Xen-devel] [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h

2016-01-10 Thread Joe Perches
On Sun, 2016-01-10 at 13:57 +0200, Michael S. Tsirkin wrote: > Introduction of __smp barriers cleans up a bunch of duplicate code, but > it gives people an additional handle onto a "new" set of barriers - just > because they're prefixed with __* unfortunately doesn't stop anyone from > using it (as

Re: [Xen-devel] [PATCH v2 1/3] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Joe Perches
On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > SMP-only barriers were missing in checkpatch.pl > > Refactor code slightly to make adding more variants easier. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -5116,7 +5116,25 @@ sub process { >  

Re: [Xen-devel] [PATCH 1/3] checkpatch.pl: add missing memory barriers

2016-01-04 Thread Joe Perches
On Mon, 2016-01-04 at 22:45 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote: > > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > > > SMP-only barriers were missing in checkpatch.pl > > > > > > Refact

Re: [Xen-devel] [PATCH 3/3] checkpatch: add virt barriers

2016-01-04 Thread Joe Perches
On Mon, 2016-01-04 at 23:07 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 04, 2016 at 08:47:53AM -0800, Joe Perches wrote: > > On Mon, 2016-01-04 at 13:37 +0200, Michael S. Tsirkin wrote: > > > Add virt_ barriers to list of barriers to check for > > > presence of a

Re: [Xen-devel] [PATCH 3/3] checkpatch: add virt barriers

2016-01-04 Thread Joe Perches
On Mon, 2016-01-04 at 13:37 +0200, Michael S. Tsirkin wrote: > Add virt_ barriers to list of barriers to check for > presence of a comment. Are these virt_ barriers used anywhere? I see some virtio_ barrier like uses. ___ Xen-devel mailing list Xen-de

Re: [Xen-devel] [PATCH 1/3] checkpatch.pl: add missing memory barriers

2016-01-04 Thread Joe Perches
On Mon, 2016-01-04 at 16:11 +, Russell King - ARM Linux wrote: > On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote: > > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > > > + my $all_barriers = join('|', (@barriers, @smp_barriers))

Re: [Xen-devel] [PATCH 1/3] checkpatch.pl: add missing memory barriers

2016-01-04 Thread Joe Perches
On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > SMP-only barriers were missing in checkpatch.pl > > Refactor code slightly to make adding more variants easier. > > Signed-off-by: Michael S. Tsirkin > --- >  scripts/checkpatch.pl | 9 - >  1 file changed, 8 insertions(+), 1

Re: [Xen-devel] [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

2016-01-02 Thread Joe Perches
On Sat, 2016-01-02 at 18:50 +0100, SF Markus Elfring wrote: > A few update suggestions were taken into account > from static source code analysis. While static analysis can be useful, I don't think these specific conversions are generally useful. Perhaps it would be more useful to convert the str

Re: [Xen-devel] [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-12-07 Thread Joe Perches
On Mon, 2015-12-07 at 17:53 +0100, Michal Marek wrote: > On 2015-12-07 17:33, David Laight wrote: > > From: Michal Marek > > > Sent: 04 December 2015 15:26 > > > Otherwise make tags can't parse them: > > > > > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern > > > "\1"

Re: [Xen-devel] [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-16 Thread Joe Perches
On Wed, 2015-06-17 at 01:29 +0300, Sergei Shtylyov wrote: > Hello. > > On 06/17/2015 01:09 AM, Joe Perches wrote: > > >>> Append 0x to all %x in order to avoid while reading when there is other > >>> decimal value in the log. > > > [] &g

Re: [Xen-devel] [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-16 Thread Joe Perches
On Tue, 2015-06-16 at 23:07 +0300, Sergei Shtylyov wrote: > On 06/16/2015 10:10 PM, Julien Grall wrote: > > Append 0x to all %x in order to avoid while reading when there is other > > decimal value in the log. [] > > @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct > > xenvif_

Re: [Xen-devel] [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-05 Thread Joe Perches
On Fri, 2015-06-05 at 13:34 +0100, Julien Grall wrote: > On 04/06/15 17:25, Joe Perches wrote: > > On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote: > >> On 04/06/15 13:46, David Vrabel wrote: > >>> On 04/06/15 13:45, Julien Grall wrote: > >>>> On

Re: [Xen-devel] [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-04 Thread Joe Perches
On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote: > On 04/06/15 13:46, David Vrabel wrote: > > On 04/06/15 13:45, Julien Grall wrote: > >> On 03/06/15 18:06, Joe Perches wrote: > >>> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: > >>>>

Re: [Xen-devel] [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-03 Thread Joe Perches
On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: > rx->status is an int16_t, print it using %d rather than %u in order to > have a meaningful value when the field is negative. [] > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c [] > @@ -733,7 +733,7 @@ static int xennet_

Re: [Xen-devel] [PATCH] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX

2015-03-31 Thread Joe Perches
On Tue, 2015-03-31 at 16:57 +0200, Roger Pau Monné wrote: > El 31/03/15 a les 23.14, Tao Chen ha escrit: > > Define pr_fmt macro with {xen-blkback: } prefix, then remove all use > > of DRV_PFX in the pr and DPRINTK sentences. It will simplify the code. [] > > diff --git a/drivers/block/xen-blkback/

Re: [Xen-devel] [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Joe Perches
On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote: > #ifdef pr_fmt > #undef pr_fmt > #endif > #define pr_fmt(fmt) "xen-pvscsi: " fmt No, just use add #define pr_fmt(fmt) "xen-pvscsi: " fmt before the first #include. The #ifdef/#undef/#endif isn't necessary. > Then replace all DPRINTK with p

Re: [Xen-devel] [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread Joe Perches
On Wed, 2015-03-04 at 18:32 +, Tao Chen wrote: > Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr > sentences and DPRINTK. > Also fixed up some comments just as eliminate redundant white spaces and > format the code. > These will make the code easier to read. It'd proba

[Xen-devel] [PATCH net-next 06/14] xen: Use eth__addr instead of memset

2015-03-02 Thread Joe Perches
Use the built-in function instead of memset. Signed-off-by: Joe Perches --- drivers/net/xen-netback/interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index f38227a..4ae98e2 100644 --- a

[Xen-devel] [PATCH net-next 00/14] Use eth__addr instead of memset

2015-03-02 Thread Joe Perches
Joe Perches (14): etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code ethernet: Use eth__addr instead of memset net: usb: Use eth__addr instead of memset wireless: Use eth__addr instead of memset netconsole: Use eth__addr instead of memset xen: Use eth__addr instead

[Xen-devel] [PATCH] treewide: Convert clockevents_notify to use int cpu

2014-12-10 Thread Joe Perches
As far as I can tell, there's no value indirecting the cpu passed to this function via a void *. Update all the callers and called functions from within clockevents_notify. Miscellanea: Add pr_fmt and convert one printk(KERN_ERR to pr_err Signed-off-by: Joe Perches --- arch/arm/mach-