Re: [Xen-devel] [PATCH] xen: sched: use default scheduler upon an invalid "sched="

2016-06-17 Thread Jonathan Creekmore
n) pick ARINC653, which is most > likely not what one would expect. > > Go for the default scheduler instead. > > Signed-off-by: Dario Faggioli > --- > Cc: George Dunlap > Cc: Jan Beulich > Cc: Doug Goldstein > Cc: Jonathan Creekmore Reviewed-By: Jonathan Creekmore

Re: [Xen-devel] Problem Reading from XenStore in DomU

2016-05-16 Thread Jonathan Creekmore
Dagaen Golomb writes: > It does, being the custom kernel on version 4.1.0. But Dom0 uses this same > exact kernel and reads/writes just fine! The only solution if this is > indeed the problem appears to be changing the kernel source we build on or > some hacky method such as symlinking /proc/.. t

Re: [Xen-devel] [PATCH v5 2/8] ACPI: add config for BIOS table scan

2016-01-23 Thread Jonathan Creekmore
Shannon Zhao writes: > From: Graeme Gregory > > With the addition of ARM64 that does not have a traditional BIOS to > scan, add a config option which is selected on x86 (ia64 doesn't need > it either, it is EFI/UEFI based system) to do the traditional BIOS > scanning for tables. > > Signed-off-b

Re: [Xen-devel] [PATCH v5 1/8] Kconfig: import kconfig.h from Linux 4.3

2016-01-23 Thread Jonathan Creekmore
Shannon Zhao writes: > From: Shannon Zhao > > To support using CONFIG_ options in C/CPP expressions, import kconfig.h > from the Linux v4.3 tag (commit id > 6a13feb9c82803e2b815eca72fa7a9f5561d7861). > > CC: Doug Goldstein > Signed-off-by: Shannon Zhao > --- > xen/include/xen/config.h | 2 +

Re: [Xen-devel] [PATCH v6 3/5] build: Alloc space for sched list in the link file

2016-01-20 Thread Jonathan Creekmore
> On Jan 15, 2016, at 11:01 AM, Jonathan Creekmore > wrote: > > Creates a section to contain scheduler entry pointers that are gathered > together into an array. This will allow, in a follow-on patch, scheduler > entries to be automatically gathered together into the arr

Re: [Xen-devel] [PATCH v6 1/5] build: Env var to enable expert config options

2016-01-15 Thread Jonathan Creekmore
> On Jan 15, 2016, at 11:20 AM, Jan Beulich wrote: > On 15.01.16 at 18:01, wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -11,6 +11,7 @@ export XEN_DOMAIN ?= $(shell ([ -x /bin/dnsdomainname ] >> && /bin/dnsdomainname) | >> export XEN_BUILD_DATE?= $(shell LC_ALL=C date)

[Xen-devel] [PATCH v6 3/5] build: Alloc space for sched list in the link file

2016-01-15 Thread Jonathan Creekmore
Beulich CC: Andrew Cooper Signed-off-by: Jonathan Creekmore Reviewed-by: Andrew Cooper Reviewed-by: Doug Goldstein Reviewed-by: Konrad Rzeszutek Wilk --- Changed since v4: * Remove defensive check for schedulers since the credit scheduler must always be present Changed since v3: * Add

[Xen-devel] [PATCH v6 5/5] sched: Use the auto-generated list of schedulers

2016-01-15 Thread Jonathan Creekmore
Instead of having a manually-curated list of schedulers, use the array that was auto-generated simply by compiling in the scheduler files as the sole source of truth of the available schedulers. CC: George Dunlap CC: Dario Faggioli Signed-off-by: Jonathan Creekmore Acked-by: Dario Faggioli

[Xen-devel] [PATCH v6 4/5] sched: Register the schedulers into the list

2016-01-15 Thread Jonathan Creekmore
Adds a simple macro to place a pointer to a scheduler into an array section at compile time. Also, goes ahead and generates the array entries with each of the schedulers. CC: George Dunlap CC: Dario Faggioli CC: Josh Whitehead CC: Robert VanVossen Signed-off-by: Jonathan Creekmore Acked-by

[Xen-devel] [PATCH v6 0/5] Allow schedulers to be selectable through Kconfig

2016-01-15 Thread Jonathan Creekmore
the rest of the file * Simplify the calculation of the number of schedulers * Make the scheduler ops structures static to their files Jonathan Creekmore (5): build: Env var to enable expert config options build: Hook the schedulers into Kconfig build: Alloc space for sched list in the

[Xen-devel] [PATCH v6 1/5] build: Env var to enable expert config options

2016-01-15 Thread Jonathan Creekmore
, visible during the Kconfig configuration process, so typical users will never see it nor any of the non-standard configuration options. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein Reviewed-by

[Xen-devel] [PATCH v6 2/5] build: Hook the schedulers into Kconfig

2016-01-15 Thread Jonathan Creekmore
Faggioli Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein --- Changed since v5: * Remove extra defaults for schedulers since credit is always there Changed since v4: * Removed the "if unsure" language * Removed ability to disable the "credit" sched

Re: [Xen-devel] [PATCH v5 2/5] build: Hook the schedulers into Kconfig

2016-01-14 Thread Jonathan Creekmore
Jan Beulich writes: >>>> On 14.01.16 at 17:34, wrote: >> On Thu, 2016-01-14 at 10:23 -0600, Jonathan Creekmore wrote: >>> Jan Beulich writes: >>> >>> > > > > On 14.01.16 at 15:49, wrote: >>> > > --- a/xen/common/Kconfig

Re: [Xen-devel] [PATCH v5 5/5] sched: Use the auto-generated list of schedulers

2016-01-14 Thread Jonathan Creekmore
Jan Beulich writes: On 14.01.16 at 15:49, wrote: >> --- a/xen/common/schedule.c >> +++ b/xen/common/schedule.c >> @@ -64,20 +64,9 @@ static void poll_timer_fn(void *data); >> DEFINE_PER_CPU(struct schedule_data, schedule_data); >> DEFINE_PER_CPU(struct scheduler *, scheduler); >> >> -stat

Re: [Xen-devel] [PATCH v5 2/5] build: Hook the schedulers into Kconfig

2016-01-14 Thread Jonathan Creekmore
Jan Beulich writes: On 14.01.16 at 15:49, wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -51,4 +51,63 @@ config KEXEC >> >>If unsure, say Y. >> >> +# Enable schedulers >> +menu "Schedulers" >> +visible if EXPERT = "y" >> + >> +config SCHED_CREDIT >> +bo

[Xen-devel] [PATCH v5 2/5] build: Hook the schedulers into Kconfig

2016-01-14 Thread Jonathan Creekmore
Dunlap CC: Dario Faggioli Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein --- Changed since v4: * Removed the "if unsure" language * Removed ability to disable the "credit" scheduler * Remove stub vcpu_migration_delay functions since credit cannot be disabl

[Xen-devel] [PATCH v5 3/5] build: Alloc space for sched list in the link file

2016-01-14 Thread Jonathan Creekmore
Beulich CC: Andrew Cooper Signed-off-by: Jonathan Creekmore Reviewed-by: Andrew Cooper Reviewed-by: Doug Goldstein Reviewed-by: Konrad Rzeszutek Wilk --- Changed since v4: * Remove defensive check for schedulers since the credit scheduler must always be present Changed since v3: * Add

[Xen-devel] [PATCH v5 5/5] sched: Use the auto-generated list of schedulers

2016-01-14 Thread Jonathan Creekmore
Instead of having a manually-curated list of schedulers, use the array that was auto-generated simply by compiling in the scheduler files as the sole source of truth of the available schedulers. CC: George Dunlap CC: Dario Faggioli Signed-off-by: Jonathan Creekmore Acked-by: Dario Faggioli

[Xen-devel] [PATCH v5 0/5] Allow schedulers to be selectable through Kconfig

2016-01-14 Thread Jonathan Creekmore
* Removed confusing language from the commit message * Alphabetize the schedulers * rename the __start and __end symbols to better match the rest of the file * Simplify the calculation of the number of schedulers * Make the scheduler ops structures static to their files Jonathan Creekmore (5

[Xen-devel] [PATCH v5 4/5] sched: Register the schedulers into the list

2016-01-14 Thread Jonathan Creekmore
Adds a simple macro to place a pointer to a scheduler into an array section at compile time. Also, goes ahead and generates the array entries with each of the schedulers. CC: George Dunlap CC: Dario Faggioli CC: Josh Whitehead CC: Robert VanVossen Signed-off-by: Jonathan Creekmore Acked-by

[Xen-devel] [PATCH v5 1/5] build: Env var to enable expert config options

2016-01-14 Thread Jonathan Creekmore
, visible during the Kconfig configuration process, so typical users will never see it nor any of the non-standard configuration options. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein Reviewed-by

Re: [Xen-devel] [PATCH v4 2/5] build: Hook the schedulers into Kconfig

2016-01-11 Thread Jonathan Creekmore
Jan Beulich writes: On 08.01.16 at 22:22, wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -51,4 +51,71 @@ config KEXEC >> >>If unsure, say Y. >> >> +# Enable schedulers >> +menu "Schedulers" >> +visible if EXPERT = "y" > > Does "visible if EXPERT" not suffic

Re: [Xen-devel] [PATCH v4 2/5] build: Hook the schedulers into Kconfig

2016-01-09 Thread Jonathan Creekmore
Andrew Cooper writes: > On 09/01/16 17:50, Jonathan Creekmore wrote: >> Andrew Cooper writes: >> >>> On 08/01/16 21:22, Jonathan Creekmore wrote: >>>> +# Enable schedulers >>>> +menu "Schedulers" >>>> + visible if EXPERT

Re: [Xen-devel] [PATCH v4 3/5] build: Alloc space for sched list in the link file

2016-01-09 Thread Jonathan Creekmore
Andrew Cooper writes: > On 08/01/16 21:22, Jonathan Creekmore wrote: >> Creates a section to contain scheduler entry pointers that are gathered >> together into an array. This will allow, in a follow-on patch, scheduler >> entries to be automatically gathered togeth

Re: [Xen-devel] [PATCH v4 5/5] sched: Use the auto-generated list of schedulers

2016-01-09 Thread Jonathan Creekmore
Andrew Cooper writes: > On 08/01/16 21:22, Jonathan Creekmore wrote: >> diff --git a/xen/common/schedule.c b/xen/common/schedule.c >> index 2f98a48..91e53c1 100644 >> --- a/xen/common/schedule.c >> +++ b/xen/common/schedule.c >> @@ -64,20 +64,10 @@ sta

Re: [Xen-devel] [PATCH v4 2/5] build: Hook the schedulers into Kconfig

2016-01-09 Thread Jonathan Creekmore
Andrew Cooper writes: > On 08/01/16 21:22, Jonathan Creekmore wrote: >> +# Enable schedulers >> +menu "Schedulers" >> +visible if EXPERT = "y" >> + >> +config SCHED_CREDIT >> +bool "Credit scheduler support" >> +

[Xen-devel] [PATCH v4 3/5] build: Alloc space for sched list in the link file

2016-01-08 Thread Jonathan Creekmore
Beulich CC: Andrew Cooper Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein --- Changed since v3: * Add defensive check for schedulers in the linker Changed since v1: * rename the __start and __end symbols to better match the rest of the file --- xen/arch/arm/xen.lds.S | 5

[Xen-devel] [PATCH v4 4/5] sched: Register the schedulers into the list

2016-01-08 Thread Jonathan Creekmore
Adds a simple macro to place a pointer to a scheduler into an array section at compile time. Also, goes ahead and generates the array entries with each of the schedulers. CC: George Dunlap CC: Dario Faggioli CC: Josh Whitehead CC: Robert VanVossen Signed-off-by: Jonathan Creekmore Acked-by

[Xen-devel] [PATCH v4 2/5] build: Hook the schedulers into Kconfig

2016-01-08 Thread Jonathan Creekmore
Faggioli Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein --- Changed since v2: * Hid the scheduler menu behind the EXPERT option * Provide static inlines for credit functions that are assumed to be always available * Provide an absolute default of the credit scheduler if

[Xen-devel] [PATCH v4 0/5] Allow schedulers to be selectable through Kconfig

2016-01-08 Thread Jonathan Creekmore
* Alphabetize the schedulers * rename the __start and __end symbols to better match the rest of the file * Simplify the calculation of the number of schedulers * Make the scheduler ops structures static to their files Jonathan Creekmore (5): build: Env var to enable expert config options

[Xen-devel] [PATCH v4 5/5] sched: Use the auto-generated list of schedulers

2016-01-08 Thread Jonathan Creekmore
Instead of having a manually-curated list of schedulers, use the array that was auto-generated simply by compiling in the scheduler files as the sole source of truth of the available schedulers. CC: George Dunlap CC: Dario Faggioli Signed-off-by: Jonathan Creekmore Acked-by: Dario Faggioli

[Xen-devel] [PATCH v4 1/5] build: Env var to enable expert config options

2016-01-08 Thread Jonathan Creekmore
, visible during the Kconfig configuration process, so typical users will never see it nor any of the non-standard configuration options. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein Reviewed-by

Re: [Xen-devel] [PATCH v3 2/5] build: Hook the schedulers into Kconfig

2016-01-08 Thread Jonathan Creekmore
Doug Goldstein writes: > On 1/8/16 10:49 AM, Jan Beulich wrote: > On 08.01.16 at 17:30, wrote: >>> So, based on the Kconfig setup and the linker ASSERT, there should be no >>> way to have a default scheduler that is not in the build. I wish Kconfig >>> allowed you to state that you must have

Re: [Xen-devel] [PATCH v3 2/5] build: Hook the schedulers into Kconfig

2016-01-08 Thread Jonathan Creekmore
Juergen Gross writes: > On 08/01/16 17:02, Jonathan Creekmore wrote: >> >> Andrew Cooper writes: >> >>> On 08/01/16 15:47, Konrad Rzeszutek Wilk wrote: >>>> On Thu, Jan 07, 2016 at 11:29:18AM -0600, Jonathan Creekmore wrote: >>>>> Allow

Re: [Xen-devel] [PATCH v3 2/5] build: Hook the schedulers into Kconfig

2016-01-08 Thread Jonathan Creekmore
Andrew Cooper writes: > On 08/01/16 15:47, Konrad Rzeszutek Wilk wrote: >> On Thu, Jan 07, 2016 at 11:29:18AM -0600, Jonathan Creekmore wrote: >>> Allow the schedulers to be independently enabled or disabled at >>> compile-time. To match existing behavior, all four sch

[Xen-devel] [PATCH v3 4/5] sched: Register the schedulers into the list

2016-01-07 Thread Jonathan Creekmore
Adds a simple macro to place a pointer to a scheduler into an array section at compile time. Also, goes ahead and generates the array entries with each of the schedulers. CC: George Dunlap CC: Dario Faggioli CC: Josh Whitehead CC: Robert VanVossen Signed-off-by: Jonathan Creekmore Acked-by

[Xen-devel] [PATCH v3 2/5] build: Hook the schedulers into Kconfig

2016-01-07 Thread Jonathan Creekmore
Faggioli Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein --- Changed since v2: * Hid the scheduler menu behind the EXPERT option * Provide static inlines for credit functions that are assumed to be always available * Provide an absolute default of the credit scheduler if

[Xen-devel] [PATCH v3 1/5] build: Env var to enable expert config options

2016-01-07 Thread Jonathan Creekmore
, visible during the Kconfig configuration process, so typical users will never see it nor any of the non-standard configuration options. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Jonathan Creekmore Reviewed-by: Doug Goldstein --- xen/Kconfig

[Xen-devel] [PATCH v3 0/5] Allow schedulers to be selectable through Kconfig

2016-01-07 Thread Jonathan Creekmore
better match the rest of the file * Simplify the calculation of the number of schedulers * Make the scheduler ops structures static to their files Jonathan Creekmore (5): build: Env var to enable expert config options build: Hook the schedulers into Kconfig build: Alloc space for sched

[Xen-devel] [PATCH v2 1/4] build: Hook the schedulers into Kconfig

2015-12-18 Thread Jonathan Creekmore
Faggioli Signed-off-by: Jonathan Creekmore Acked-by: Dario Faggioli Reviewed-by: Andrew Cooper --- Changed since v1: * Marked credit2 as EXPERIMENTAL * Removed confusing language from the commit message * Alphabetize the schedulers --- xen/common/Kconfig| 64

[Xen-devel] [PATCH v2 0/4] Allow schedulers to be selectable through Kconfig

2015-12-18 Thread Jonathan Creekmore
* rename the __start and __end symbols to better match the rest of the file * Simplify the calculation of the number of schedulers * Make the scheduler ops structures static to their files Jonathan Creekmore (4): build: Hook the schedulers into Kconfig build: Alloc space for sched list in

[Xen-devel] [PATCH v2 4/4] sched: Use the auto-generated list of schedulers

2015-12-18 Thread Jonathan Creekmore
Instead of having a manually-curated list of schedulers, use the array that was auto-generated simply by compiling in the scheduler files as the sole source of truth of the available schedulers. CC: George Dunlap CC: Dario Faggioli Signed-off-by: Jonathan Creekmore Acked-by: Dario Faggioli

[Xen-devel] [PATCH v2 3/4] sched: Register the schedulers into the list

2015-12-18 Thread Jonathan Creekmore
Adds a simple macro to place a pointer to a scheduler into an array section at compile time. Also, goes ahead and generates the array entries with each of the schedulers. CC: George Dunlap CC: Dario Faggioli CC: Josh Whitehead CC: Robert VanVossen Signed-off-by: Jonathan Creekmore Acked-by

[Xen-devel] [PATCH v2 2/4] build: Alloc space for sched list in the link file

2015-12-18 Thread Jonathan Creekmore
Beulich CC: Andrew Cooper Signed-off-by: Jonathan Creekmore Reviewed-by: Andrew Cooper --- Changed since v1: * rename the __start and __end symbols to better match the rest of the file --- xen/arch/arm/xen.lds.S | 4 xen/arch/x86/xen.lds.S | 4 2 files changed, 8 insertions

Re: [Xen-devel] [PATCH 4/4] sched: Use the auto-generated list of schedulers

2015-12-18 Thread Jonathan Creekmore
> On Dec 18, 2015, at 10:43 AM, Jan Beulich wrote: > On 18.12.15 at 17:00, wrote: >> Jan Beulich writes: >> On 17.12.15 at 21:59, wrote: +extern const struct scheduler *__schedulers_start[], *__schedulers_end[]; +#define NUM_SCHEDULERS >> (((uintptr_t)__schedulers_end-(uint

Re: [Xen-devel] [PATCH 2/4] build: Alloc space for sched list in the link file

2015-12-18 Thread Jonathan Creekmore
> On Dec 18, 2015, at 11:07 AM, Jan Beulich wrote: > >>>> On 18.12.15 at 17:48, wrote: >> On 18/12/15 16:40, Jonathan Creekmore wrote: >>>> On Dec 18, 2015, at 3:01 AM, Andrew Cooper >>>> wrote: >>>> >>>> On 17/12/

Re: [Xen-devel] [PATCH 4/4] sched: Use the auto-generated list of schedulers

2015-12-18 Thread Jonathan Creekmore
Andrew Cooper writes: > On 17/12/2015 20:59, Jonathan Creekmore wrote: >> Instead of having a manually-curated list of schedulers, use the array >> that was auto-generated simply by compiling in the scheduler files as >> the sole source of truth of the available schedul

Re: [Xen-devel] [PATCH 1/4] build: Hook the schedulers into Kconfig

2015-12-18 Thread Jonathan Creekmore
Andrew Cooper writes: > On 17/12/2015 20:59, Jonathan Creekmore wrote: >> Allow the schedulers to be independently enabled or disabled at >> compile-time instead of just allowing the scheduler to be selected on >> the command line. To match existing behavior, all four sched

Re: [Xen-devel] [PATCH 2/4] build: Alloc space for sched list in the link file

2015-12-18 Thread Jonathan Creekmore
> On Dec 18, 2015, at 3:01 AM, Andrew Cooper wrote: > > On 17/12/2015 20:59, Jonathan Creekmore wrote: >> Creates a section to contain scheduler entry pointers that are gathered >> together into an array. This will allow, in a follow-on patch, scheduler >> entries t

Re: [Xen-devel] [PATCH 4/4] sched: Use the auto-generated list of schedulers

2015-12-18 Thread Jonathan Creekmore
Jan Beulich writes: On 17.12.15 at 21:59, wrote: >> +extern const struct scheduler *__schedulers_start[], *__schedulers_end[]; >> +#define NUM_SCHEDULERS >> (((uintptr_t)__schedulers_end-(uintptr_t)__schedulers_start) \ >> +/ sizeof(struct scheduler *)) >> +static c

Re: [Xen-devel] [PATCH 1/4] build: Hook the schedulers into Kconfig

2015-12-17 Thread Jonathan Creekmore
> On Dec 17, 2015, at 7:35 PM, Dario Faggioli wrote: > > On Thu, 2015-12-17 at 14:59 -0600, Jonathan Creekmore wrote: >> Allow the schedulers to be independently enabled or disabled at >> compile-time instead of just allowing the scheduler to be selected on >> the c

[Xen-devel] [PATCH 4/4] sched: Use the auto-generated list of schedulers

2015-12-17 Thread Jonathan Creekmore
Instead of having a manually-curated list of schedulers, use the array that was auto-generated simply by compiling in the scheduler files as the sole source of truth of the available schedulers. CC: George Dunlap CC: Dario Faggioli Signed-off-by: Jonathan Creekmore --- xen/common/schedule.c

[Xen-devel] [PATCH 0/4] Allow schedulers to be selectable through Kconfig

2015-12-17 Thread Jonathan Creekmore
scheduler list from being manually curated into a model where just compiling any schedulers into the hypervisor causes the scheduler list to be built up. Jonathan Creekmore (4): build: Hook the schedulers into Kconfig build: Alloc space for sched list in the link file sched: Register the

[Xen-devel] [PATCH 3/4] sched: Register the schedulers into the list

2015-12-17 Thread Jonathan Creekmore
Adds a simple macro to place a pointer to a scheduler into an array section at compile time. Also, goes ahead and generates the array entries with each of the schedulers. CC: George Dunlap CC: Dario Faggioli CC: Josh Whitehead CC: Robert VanVossen Signed-off-by: Jonathan Creekmore --- xen

[Xen-devel] [PATCH 2/4] build: Alloc space for sched list in the link file

2015-12-17 Thread Jonathan Creekmore
Beulich CC: Andrew Cooper Signed-off-by: Jonathan Creekmore --- xen/arch/arm/xen.lds.S | 4 xen/arch/x86/xen.lds.S | 4 2 files changed, 8 insertions(+) diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S index 0488f37..39a4c86 100644 --- a/xen/arch/arm/xen.lds.S +++ b/xen

[Xen-devel] [PATCH 1/4] build: Hook the schedulers into Kconfig

2015-12-17 Thread Jonathan Creekmore
not currently supported status. CC: George Dunlap CC: Dario Faggioli Signed-off-by: Jonathan Creekmore --- xen/common/Kconfig| 64 +++ xen/common/Makefile | 8 +++ xen/common/schedule.c | 12 -- 3 files changed, 78 insertions

Re: [Xen-devel] [PATCH v2] build: fix clean to remove all .o and .d files

2015-12-02 Thread Jonathan Creekmore
> On Dec 2, 2015, at 9:46 AM, Jan Beulich wrote: > On 02.12.15 at 16:41, wrote: > >>> On Dec 2, 2015, at 9:36 AM, Jan Beulich wrote: >>> >> On 02.12.15 at 16:29, wrote: --- a/xen/Makefile +++ b/xen/Makefile @@ -91,7 +91,8 @@ _clean: delete-unfresh-files $(MAK

Re: [Xen-devel] [PATCH v2] build: fix clean to remove all .o and .d files

2015-12-02 Thread Jonathan Creekmore
> On Dec 2, 2015, at 9:36 AM, Jan Beulich wrote: > On 02.12.15 at 16:29, wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -91,7 +91,8 @@ _clean: delete-unfresh-files >> $(MAKE) -f $(BASEDIR)/Rules.mk -C xsm clean >> $(MAKE) -f $(BASEDIR)/Rules.mk -C crypto clean >> $

[Xen-devel] [PATCH v2] build: fix clean to remove all .o and .d files

2015-12-02 Thread Jonathan Creekmore
behind. This method does not have the same disadvantage. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Jonathan Creekmore --- xen/Makefile | 3 ++- xen/Rules.mk | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/xen

Re: [Xen-devel] [PATCH] build: fix clean rule to cover objects in unvisited subdirs

2015-12-01 Thread Jonathan Creekmore
> On Dec 1, 2015, at 10:07 AM, Jan Beulich wrote: > > For one build run, yes. But then you can (a) build individual object > files and (b) as mentioned above change configuration (implying > that you know what you're doing). Also you could, using the > example above, do a kexec=y build, then a k

Re: [Xen-devel] [PATCH] build: fix clean rule to cover objects in unvisited subdirs

2015-12-01 Thread Jonathan Creekmore
> On Dec 1, 2015, at 6:41 AM, Jan Beulich wrote: > On 30.11.15 at 18:29, wrote: >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -173,7 +173,7 @@ FORCE: >> >> .PHONY: clean >> clean:: $(addprefix _clean_, $(subdir-all)) >> -rm -f *.o *~ core $(DEPS) >> +rm -f *.o *~ core $(DEPS)

[Xen-devel] [PATCH] build: fix clean rule to cover objects in unvisited subdirs

2015-11-30 Thread Jonathan Creekmore
the visited directory. CC: Ian Campbell CC: Ian Jackson CC: Jan Beulich CC: Keir Fraser CC: Tim Deegan Signed-off-by: Jonathan Creekmore --- xen/Rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Rules.mk b/xen/Rules.mk index 02db110..539722f 100644 --- a/xen

Re: [Xen-devel] [PATCH] build: fix dependencies for files compiled from their parent directory

2015-11-30 Thread Jonathan Creekmore
On Wed, Nov 25, 2015 at 10:16 AM, Jan Beulich wrote: > The use of $(basename ...) here was wrong (yet I'm sure I tested it). > > Signed-off-by: Jan Beulich > > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -105,7 +105,7 @@ include Makefile > DEPS = .*.d > define gendep > ifneq ($(1),$(subst

Re: [Xen-devel] [PATCH] build: remove .d files from xen/ on a clean

2015-11-25 Thread Jonathan Creekmore
> On Nov 25, 2015, at 2:58 AM, Jan Beulich wrote: > >>>> On 24.11.15 at 19:19, wrote: > >>> On Nov 24, 2015, at 11:30 AM, Jan Beulich wrote: >>> >>>>>> On 24.11.15 at 18:22, wrote: >>> >>>>> On Nov 24, 2015

Re: [Xen-devel] [PATCH] build: remove .d files from xen/ on a clean

2015-11-24 Thread Jonathan Creekmore
> On Nov 24, 2015, at 11:30 AM, Jan Beulich wrote: > >>>> On 24.11.15 at 18:22, wrote: > >>> On Nov 24, 2015, at 11:16 AM, Jonathan Creekmore >> wrote: >>>> On Nov 24, 2015, at 11:07 AM, Jan Beulich wrote: >>>>>>> O

Re: [Xen-devel] [PATCH] build: remove .d files from xen/ on a clean

2015-11-24 Thread Jonathan Creekmore
> On Nov 24, 2015, at 11:16 AM, Jonathan Creekmore > wrote: > >> >> On Nov 24, 2015, at 11:07 AM, Jan Beulich wrote: >> >>>>> On 24.11.15 at 17:56, wrote: >>> --- a/xen/Makefile >>> +++ b/xen/Makefile >>> @@ -88,7 +88,7 @

Re: [Xen-devel] [PATCH] build: remove .d files from xen/ on a clean

2015-11-24 Thread Jonathan Creekmore
> On Nov 24, 2015, at 11:07 AM, Jan Beulich wrote: > On 24.11.15 at 17:56, wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -88,7 +88,7 @@ _clean: delete-unfresh-files >> $(MAKE) -f $(BASEDIR)/Rules.mk -C xsm clean >> $(MAKE) -f $(BASEDIR)/Rules.mk -C crypto clean >>

[Xen-devel] [PATCH] build: remove .d files from xen/ on a clean

2015-11-24 Thread Jonathan Creekmore
: Jonathan Creekmore --- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/Makefile b/xen/Makefile index c556198..fa9cf0a 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -88,7 +88,7 @@ _clean: delete-unfresh-files $(MAKE) -f $(BASEDIR)/Rules.mk -C xsm clean

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-09-01 Thread Jonathan Creekmore
"Jan Beulich" writes: On 01.09.15 at 16:29, wrote: Which is both appreciated and understandable. I suppose you agree though that if you were to follow the model used for the kexec part, things would quickly become unwieldy. Hence I would strongly suggest considering to introduce Linux'es

[Xen-devel] [PATCH v5] x86: wrap kexec feature with CONFIG_KEXEC

2015-09-01 Thread Jonathan Creekmore
Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore Reviewed-by: Andrew Cooper Acked-by: David Vrabel --- Changed since v4

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-09-01 Thread Jonathan Creekmore
Andrew Cooper writes: On 01/09/15 11:54, Jan Beulich wrote: On 01.09.15 at 12:44, wrote: On 01/09/15 11:36, Ian Campbell wrote: In general (i.e. not 100% consistently, I think) we have tended to avoid making things user-facing compile time options. Many of the existing CONFIG_* and HAVE_*

[Xen-devel] [PATCH v4] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-31 Thread Jonathan Creekmore
Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore --- Changed since v3: * Correct makefile to meet the standards for feature

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-31 Thread Jonathan Creekmore
quot;): On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, concurrent blocking file accesses to a single open file descriptor can cause a deadlock trying to grab the file position lock. If a watch has been se

[Xen-devel] [PATCH v3] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-31 Thread Jonathan Creekmore
Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore --- Changed since v2: * Switch macros over to static inline functions

[Xen-devel] [PATCH v2] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-28 Thread Jonathan Creekmore
Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore --- Changed since v1: * Reorder kexec files to be alphabetical in the

Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Jonathan Creekmore
Ian Jackson writes: Wei Liu writes ("Re: [Xen-devel] [PATCH v2] libxenstore: prefer using the character device"): On Thu, Aug 27, 2015 at 09:04:38AM -0500, Jonathan Creekmore wrote: > With the addition of FMODE_ATOMIC_POS in the Linux 3.14 > kernel, concurrent blocking fi

Re: [Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Jonathan Creekmore
> On Aug 27, 2015, at 10:27 AM, David Vrabel wrote: > > On 27/08/15 15:47, Jonathan Creekmore wrote: >> Add the appropriate #if checks around the kexec code in the x86 codebase >> so that the feature can actually be turned off by the flag instead of >> always re

[Xen-devel] [PATCH] x86: wrap kexec feature with CONFIG_KEXEC

2015-08-27 Thread Jonathan Creekmore
Add the appropriate #if checks around the kexec code in the x86 codebase so that the feature can actually be turned off by the flag instead of always required to be enabled on x86. Signed-off-by: Jonathan Creekmore --- xen/arch/x86/Makefile | 4 ++-- xen/arch/x86/apic.c

[Xen-devel] [PATCH v2] libxenstore: prefer using the character device

2015-08-27 Thread Jonathan Creekmore
: Jonathan Creekmore --- tools/xenstore/xs_lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xenstore/xs_lib.c b/tools/xenstore/xs_lib.c index af4f75a..0c7744e 100644 --- a/tools/xenstore/xs_lib.c +++ b/tools/xenstore/xs_lib.c @@ -81,6 +81,8 @@ const char *xs_domain_dev(void) #if

Re: [Xen-devel] [PATCH] libxenstore: Use poll() with a non-blocking read()

2015-08-18 Thread Jonathan Creekmore
David Vrabel writes: > On 16/08/15 09:59, Ian Campbell wrote: >> On Thu, 2015-08-13 at 16:44 -0500, Jonathan Creekmore wrote: >>> With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, >>> concurrent blocking file accesses to a single open file descriptor can

Re: [Xen-devel] [PATCH] libxenstore: Use poll() with a non-blocking read()

2015-08-16 Thread Jonathan Creekmore
> On Aug 16, 2015, at 1:59 AM, Ian Campbell wrote: > > On Thu, 2015-08-13 at 16:44 -0500, Jonathan Creekmore wrote: >> With the addition of FMODE_ATOMIC_POS in the Linux 3.14 kernel, >> concurrent blocking file accesses to a single open file descriptor can >> cause a

[Xen-devel] [PATCH] libxenstore: Use poll() with a non-blocking read()

2015-08-13 Thread Jonathan Creekmore
other hand, using the poll() API to implement the blocking for the read_all() function prevents the file descriptor from being switched back and forth between blocking and non-blocking modes between two threads. Signed-off-by: Jonathan Creekmore --- tools/xenstore/xs.c | 52

Re: [Xen-devel] [PATCH v2] oxenstored: link in the systemd system library

2015-07-23 Thread Jonathan Creekmore
> On Jul 23, 2015, at 9:00 AM, Ian Campbell wrote: > > On Thu, 2015-07-23 at 08:40 -0500, Jonathan Creekmore wrote: >> If systemd is configured for use AND you are building oxenstored, the >> C >> systemd library must be linked in to the systemd.cxma library. >

[Xen-devel] [PATCH v2] oxenstored: link in the systemd system library

2015-07-23 Thread Jonathan Creekmore
If systemd is configured for use AND you are building oxenstored, the C systemd library must be linked in to the systemd.cxma library. Signed-off-by: Jonathan Creekmore --- Changed since v1: * Link the systemd library in to the systemd.cxma instead of the final binary. --- tools/ocaml

[Xen-devel] [PATCH] oxenstored: link in the systemd system library

2015-07-22 Thread Jonathan Creekmore
If systemd is configured for use AND you are building oxenstored, the C systemd library must be linked in to the oxenstored binary instead of just into the static ocaml stub. Signed-off-by: Jonathan Creekmore --- tools/ocaml/xenstored/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1