Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Jonathan Davies
On 07/04/17 15:21, Juergen Gross wrote: Is the data format of the saved state documented somewhere? I'd appreciate any pointer or (in case there is no such doc) a followup patch to add the documentation. This would help later in case C-xenstored learns restartability, too, and someone would

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Jonathan Davies
On 07/04/17 15:15, Andrew Cooper wrote: On 07/04/17 14:27, Jonathan Davies wrote: With these patches, the state saved on exit contains information about inter-domain connections and active watches, and the contents of the store. Some internal state is not currently preserved over a restart: 1

[Xen-devel] [PATCH 1/5] oxenstored: initialise logging earlier

2017-04-07 Thread Jonathan Davies
Otherwise we miss out on messages from things that try to log earlier in the start-up procedure. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> --- tools/ocaml/xenstored/xenstored.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/ocaml/xen

[Xen-devel] [PATCH 4/5] oxenstored: improve event-channel binding logging

2017-04-07 Thread Jonathan Davies
It's useful to see a bit more detail when an inter-domain event-channel is bound, especially over an oxenstored restart. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> --- tools/ocaml/xenstored/domain.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools

[Xen-devel] [PATCH 2/5] oxenstored: avoid leading slash in paths in saved store state

2017-04-07 Thread Jonathan Davies
aths like [""; "local"; "domain"; "0"] because the name of the root node is "". Change it to generate paths correctly. Furthermore, the function passed to Store.dump_fct would render the node "foo" under the path [] as "//foo"

[Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-07 Thread Jonathan Davies
gs 3. recent transaction history Items 1 and 2 are probably needed for this to be considered fully functional, so fixes for them should follow. But the bugfixes in this series already represent a worthwhile improvement. Jonathan Davies (5): oxenstored: initialise logging earlier oxenstored:

[Xen-devel] [PATCH 5/5] oxenstored: make --restart option best-effort

2017-04-07 Thread Jonathan Davies
the state file.) Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> --- tools/ocaml/xenstored/xenstored.ml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml index 77fd9e3..bb780d0

[Xen-devel] [PATCH 3/5] oxenstored: save remote evtchn port, not local port

2017-04-07 Thread Jonathan Davies
-by: Jonathan Davies <jonathan.dav...@citrix.com> --- tools/ocaml/xenstored/domain.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ocaml/xenstored/domain.ml b/tools/ocaml/xenstored/domain.ml index 4515650..eda2ea9 100644 --- a/tools/ocaml/xenstored/domain.ml +++ b

[Xen-devel] [PATCH] xl cpupool-numa-split: don't try to bring any dom0 vCPUs online

2016-08-12 Thread Jonathan Davies
-off-by: Jonathan Davies <jonathan.dav...@citrix.com> --- tools/libxl/xl_cmdimpl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 7f961e3..d5df20d 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools

[Xen-devel] [PATCH v2] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Jonathan Davies
Commit 363ae55c8 used an OCaml feature called record field punning. This broke the build on compilers prior to OCaml 3.12.0. This patch makes no semantic change but now uses backwards-compatible syntax. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reported-by: Boris Ost

Re: [Xen-devel] [PATCH] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Jonathan Davies
On 30/03/2016 4:54 PM, Boris Ostrovsky wrote: > On 03/30/2016 11:47 AM, Jonathan Davies wrote: > > Commit 363ae55c8 used an OCaml feature called record field punning. > > This broke the build on compilers prior to OCaml 3.12.0. > > > > This patch makes no semantic ch

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-30 Thread Jonathan Davies
On Tue, Mar 29, 2016 at 08:41:54PM +0100, David Scott wrote: > > > On 29 Mar 2016, at 17:38, Wei Liu <wei.l...@citrix.com> wrote: > > > > On Tue, Mar 29, 2016 at 10:08:30AM +0100, Jonathan Davies wrote: > >> On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ost

[Xen-devel] [PATCH] oxenstored: allow compilation prior to OCaml 3.12.0

2016-03-30 Thread Jonathan Davies
Commit 363ae55c8 used an OCaml feature called record field punning. This broke the build on compilers prior to OCaml 3.12.0. This patch makes no semantic change but now uses backwards-compatible syntax. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reviewed-by: Boris Ost

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-29 Thread Jonathan Davies
On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: > On 03/24/2016 06:49 PM, Andrew Cooper wrote: > >On 24/03/2016 22:22, Boris Ostrovsky wrote: > >>On 03/17/2016 01:51 PM, Jonathan Davies wrote: > >>>Encapsulate the request in a recor

[Xen-devel] [PATCH 6/7] oxenstored: replay transaction upon conflict

2016-03-20 Thread Jonathan Davies
-off-by: Dave Scott <d...@recoil.org> Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jon Ludlam <jonathan.lud...@citrix.com> Reviewed-by: Euan Harris <euan.har...@citrix.com> --- tools/ocaml/

[Xen-devel] [PATCH 4/7] oxenstored: keep track of each transaction's operations

2016-03-19 Thread Jonathan Davies
in the retention of only the prior requests. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jon Ludlam <jonathan.lud...@citrix.com> Reviewed-by: Euan Harris <euan.har...@citrix.com> --- tools/o

[Xen-devel] [PATCH 7/7] oxenstored: log request and response during transaction replay

2016-03-19 Thread Jonathan Davies
During a transaction replay, the replayed requests and the new responses are logged in the same way as the original requests and the original responses. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by

[Xen-devel] [PATCH 5/7] oxenstored: move functions that process simple operations

2016-03-19 Thread Jonathan Davies
for processing the rest. This will help allow replay of transactions, allowing us to invoke the functions that process the simple operations as part of the processing of transaction_end. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reviewed-by: Andrew Cooper <andrew.coop...@c

[Xen-devel] [PATCH 0/7] oxenstored: improve transaction conflict handling

2016-03-19 Thread Jonathan Davies
are handled. The first five patches prepare the way by performing some refactoring and addition of infrastructure that allows for transactions to be replayed. The seventh patch adds some extra logging. Jonathan Davies (7): oxenstored: refactor putting response on wire oxenstored: remove some

[Xen-devel] [PATCH 2/7] oxenstored: remove some unused parameters

2016-03-19 Thread Jonathan Davies
Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jon Ludlam <jonathan.lud...@citrix.com> Reviewed-by: Euan Harris <euan.har...@citrix.com> --- tools/ocaml/xenstored/process.ml | 14 +++--

[Xen-devel] [PATCH 1/7] oxenstored: refactor putting response on wire

2016-03-19 Thread Jonathan Davies
called afterwards. This refactoring gives us a chance to store the value of the response, useful for replaying transactions. Signed-off-by: Jonathan Davies <jonathan.dav...@citrix.com> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jon Ludlam <jonathan.lu

Re: [Xen-devel] [PATCH 0/7] oxenstored: improve transaction conflict handling

2016-03-18 Thread Jonathan Davies
On Fri, Mar 18, 2016 at 10:33:35AM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 17, 2016 at 05:51:08PM +0000, Jonathan Davies wrote: > > This patch series makes a substantial improvement to oxenstored's > > transaction > > handling. > > > > The orig

[Xen-devel] [PATCH] oxenstored: Quota.merge: don't assume domain already exists

2015-11-11 Thread Jonathan Davies
Quota.add_entry) needs to be coalesced due to concurrent xenstore activity. This patch handles the merge in the case where mod_quota contains an entry not present in orig_quota (or in dest_quota) by treating that hashtable as having existing value 0. Signed-off-by: Jonathan Davies <jonathan.

Re: [Xen-devel] tcp: refine TSO autosizing causes performance regression on Xen

2015-04-13 Thread Jonathan Davies
On 13/04/15 11:56, George Dunlap wrote: On Thu, Apr 9, 2015 at 5:36 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Thu, 9 Apr 2015, Eric Dumazet wrote: On Thu, 2015-04-09 at 16:46 +0100, Stefano Stabellini wrote: Hi all, I found a performance regression when running

Re: [Xen-devel] [PATCH] xen-netfront: transmit fully GSO-sized packets

2015-03-31 Thread Jonathan Davies
On 30/03/15 14:46, Wei Liu wrote: On Thu, Mar 26, 2015 at 03:08:58PM +, Jonathan Davies wrote: On 26/03/15 12:05, Eric Dumazet wrote: On Thu, 2015-03-26 at 11:13 +, Jonathan Davies wrote: xen-netfront limits transmitted skbs to be at most 44 segments in size. However, GSO permits up

[Xen-devel] [PATCH v2] xen-netfront: transmit fully GSO-sized packets

2015-03-31 Thread Jonathan Davies
MAX_TCP_HEADER as it relates to the size of the whole packet, including the header. Fixes: 9ecd1a75d977 (xen-netfront: reduce gso_max_size to account for max TCP header) Signed-off-by: Jonathan Davies jonathan.dav...@citrix.com --- Changes in v2: - Also correct max mtu in xennet_change_mtu

Re: [Xen-devel] [PATCH RFC] tcp: Allow sk_wmem_alloc to exceed sysctl_tcp_limit_output_bytes

2015-03-27 Thread Jonathan Davies
On 26/03/15 17:14, Eric Dumazet wrote: On Thu, 2015-03-26 at 16:46 +, Jonathan Davies wrote: Network drivers with slow TX completion can experience poor network transmit throughput, limited by hitting the sk_wmem_alloc limit check in tcp_write_xmit. The limit is 128 KB (by default), which

[Xen-devel] [PATCH] xen-netfront: transmit fully GSO-sized packets

2015-03-26 Thread Jonathan Davies
to account for max TCP header) Signed-off-by: Jonathan Davies jonathan.dav...@citrix.com --- drivers/net/xen-netfront.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index e9b960f..fb6e978 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers

[Xen-devel] [PATCH RFC] tcp: Allow sk_wmem_alloc to exceed sysctl_tcp_limit_output_bytes

2015-03-26 Thread Jonathan Davies
using iperf -c ip -i 1 using CentOS 7.0 VM(s) on Citrix XenServer 6.5 on a Dell R730 host with a pair of Xeon E5-2650 v3 CPUs. Fixes: 605ad7f184b6 (tcp: refine TSO autosizing) Signed-off-by: Jonathan Davies jonathan.dav...@citrix.com --- net/ipv4/tcp_output.c | 2 +- 1 file changed, 1 insertion

Re: [Xen-devel] [PATCH] xen-netfront: transmit fully GSO-sized packets

2015-03-26 Thread Jonathan Davies
On 26/03/15 12:05, Eric Dumazet wrote: On Thu, 2015-03-26 at 11:13 +, Jonathan Davies wrote: xen-netfront limits transmitted skbs to be at most 44 segments in size. However, GSO permits up to 65536 bytes, which means a maximum of 45 segments of 1448 bytes each. This slight reduction