Re: [Xen-devel] [PATCH v1 3/3] x86/vvmx: add a shadow vmcs check to vmlaunch

2017-03-16 Thread Krish Sadhukhan
Acknowledging it formally... Reviewed-by: Krish Sadhukhan <krish.sadhuk...@oracle.com> The review was based on Intel SDM chapters 24 and 30. -Krish On 03/16/2017 11:24 AM, Krish Sadhukhan wrote: This one looks good to me. -Krish On 03/13/2017 03:51 AM, Sergey Dyasli wrote: Int

Re: [Xen-devel] [PATCH v1 3/3] x86/vvmx: add a shadow vmcs check to vmlaunch

2017-03-16 Thread Krish Sadhukhan
This one looks good to me. -Krish On 03/13/2017 03:51 AM, Sergey Dyasli wrote: Intel SDM states that if the current VMCS is a shadow VMCS, VMFailInvalid occurs and control passes to the next instruction. Implement such behaviour for nested vmlaunch. Signed-off-by: Sergey Dyasli

Re: [Xen-devel] [PATCH v1 1/3] x86/vvmx: add mov-ss blocking check to vmentry

2017-03-16 Thread Krish Sadhukhan
The Intel SDM also mentions POP-SS. Are you planning to do it via another patch ? Also, I was wondering if it makes more sense to rename the new enum code as VMX_INSN_VMENTRY_BLOCKED since it can then also be used for POP-SS. -Krish On 03/13/2017 03:51 AM, Sergey Dyasli wrote: Intel