87:qmp_handle_error_response: received an
>>>> error message from QMP server: QMP input object member 'id' is unexpected
>>>> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
>>>> to QMP
>>>
>>
>> This is caused
"Daniel P. Berrange" writes:
> On Thu, May 14, 2015 at 12:12:52PM +0100, Stefano Stabellini wrote:
>> On Wed, 13 May 2015, John Snow wrote:
>> > On 05/13/2015 02:15 PM, Stefano Stabellini wrote:
>> > > On Wed, 13 May 2015, Daniel P. Berrange wrote:
>> > >> On Wed, May 13, 2015 at 06:29:46PM +0100
Paolo Bonzini writes:
> On 14/05/2015 14:02, Markus Armbruster wrote:
>> It should certainly be off for pc-q35-2.4 and newer. Real Q35 boards
>> commonly don't have an FDC (depends on the Super I/O chip used).
>>
>> We may want to keep it off for p
Paolo Bonzini writes:
> On 14/05/2015 13:47, Michael S. Tsirkin wrote:
>> > I would be OK with a new property too, as we could set it from
>> > libxl or libvirt. Anybody would be happy to pick this one up or should I
>> > do it?
>>
>> Pls go ahead, I can merge it in the pc tree.
>
> Note that bec
John Snow writes:
> On 05/14/2015 10:07 AM, Michael S. Tsirkin wrote:
>> On Thu, May 14, 2015 at 02:02:04PM +0200, Markus Armbruster wrote:
>>> Correct.
>>>
>>> Here's how I think it should be done:
>>>
>>> * Create a machine option to
Cc: Stefano Stabellini
Cc: xen-de...@lists.xensource.com
Signed-off-by: Markus Armbruster
---
xen-hvm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/xen-hvm.c b/xen-hvm.c
index 3d78a0c..2a93390 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -240,6 +240,7 @@ static void xen_ram_init
Cc: Stefano Stabellini
Cc: xen-de...@lists.xensource.com
Signed-off-by: Markus Armbruster
---
xen-hvm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/xen-hvm.c b/xen-hvm.c
index 3d78a0c..2a93390 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -240,6 +240,7 @@ static void xen_ram_init
Stefano Stabellini writes:
> On Thu, 17 Dec 2015, Markus Armbruster wrote:
>> Cc: Stefano Stabellini
>> Cc: xen-de...@lists.xensource.com
>> Signed-off-by: Markus Armbruster
>> ---
>> xen-hvm.c | 7 +++
>> 1 file changed, 7 insertions(+)
>>
&
Stefano Stabellini writes:
> Add the PV block backend, the Xen mapcache, and hw/i386/xen to the list
> of Xen related files maintained by me.
>
> Signed-off-by: Stefano Stabellini
Reviewed-by: Markus Armbruster
___
Xen-devel mailing li
Markus Armbruster writes:
> Stefano Stabellini writes:
>
>> On Thu, 17 Dec 2015, Markus Armbruster wrote:
>>> Cc: Stefano Stabellini
>>> Cc: xen-de...@lists.xensource.com
>>> Signed-off-by: Markus Armbruster
>>> ---
>>> xen-hvm.c | 7 +
Cc: Stefano Stabellini
Cc: xen-de...@lists.xensource.com
Signed-off-by: Markus Armbruster
Message-Id: <1450370121-5768-14-git-send-email-arm...@redhat.com>
---
xen-hvm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/xen-hvm.c b/xen-hvm.c
index 3d78a0c..2a93390 100644
---
xen_hvm_init() returns -1 without cleaning up on some errors (harmless
long as the caller exit()s on error), dies with hw_error() on others.
hw_error() isn't approprate here. Clean up to exit() on all errors.
Signed-off-by: Markus Armbruster
---
hw/i386/pc_piix.c| 5 ++---
hw/i386/p
xen_ram_alloc() dies with hw_error() on error, even though its caller
ram_block_add() handles errors just fine. Add an Error **errp
parameter and use it.
Leave case RUN_STATE_INMIGRATE alone, because that looks like some
kind of warning.
Signed-off-by: Markus Armbruster
---
exec.c
Compile-tested only.
Please have a close look at xen_ram_alloc() case RUN_STATE_INMIGRATE.
I didn't change it, because I don't understand it. What does the
message mean? Is it informational? Should it be an error?
Programming error?
Markus Armbruster (2):
xen-hvm: Clean up xe
Stefano Stabellini writes:
> On Thu, 14 Jan 2016, Markus Armbruster wrote:
>> xen_ram_alloc() dies with hw_error() on error, even though its caller
>> ram_block_add() handles errors just fine. Add an Error **errp
>> parameter and use it.
>>
>> Leave case RUN_ST
Stefano Stabellini writes:
> Only return true from xen_is_pirq_msi when Xen is enabled: the function
> should never identify an MSI as Xen pirq when not running on Xen.
Is this supposed to fix ivshmem-test with SPEED=slow?
___
Xen-devel mailing list
X
Cc: Stefano Stabellini
Cc: xen-de...@lists.xensource.com
Signed-off-by: Markus Armbruster
---
xen-hvm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/xen-hvm.c b/xen-hvm.c
index 3d78a0c..2a93390 100644
--- a/xen-hvm.c
+++ b/xen-hvm.c
@@ -240,6 +240,7 @@ static void xen_ram_init
Missed in commit d076a2a and commit bd6092e.
Signed-off-by: Markus Armbruster
---
docs/xen-save-devices-state.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/xen-save-devices-state.txt b/docs/xen-save-devices-state.txt
index 92e08db..a72ecc8 100644
--- a/docs/xen
Gerd Hoffmann writes:
> Hi,
>
>> > Hmm, I think the xen core needs better QOM support ...
>> >
>> > struct XenDevice should have a DeviceState element, so it can be used as
>> > device object directly instead of attaching a device object like
>> > this ...
>>
>> Hmm, interesting idea. The dev
Markus Armbruster writes:
> Missed in commit d076a2a and commit bd6092e.
>
> Signed-off-by: Markus Armbruster
Applied to my qapi-next branch, with a cosmetic change to the commit
message.
___
Xen-devel mailing list
Xen-devel@lists.xen.
gned-off-by: Haozhong Zhang
>> > ---
>> > Cc: Markus Armbruster
>>
>> > +++ b/docs/qmp-commands.txt
>> > @@ -3800,3 +3800,39 @@ Example for pc machine type started with
>> > "props": {"core-id": 0, "
Eric Blake writes:
> From: Kővágó, Zoltán
>
> Except qapi-schema.json, this patch was generated by:
>
> find . -name .git -prune -o -type f \! -name '*~' -print0 | \
> xargs -0 sed -i \
> -e 's/NetClientOptionsKind/NetClientDriver/g' \
> -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER
Eric Blake writes:
> Quite a few users of qdict_put() were manually wrapping a
> non-QObject. We can make such call-sites shorter, by providing
> common macros to do the tedious work. Also shorten nearby
> qdict_put_obj(,,QOBJECT()) sequences.
>
> Signed-off-by: Eric Blake
> Reviewed-by: Albert
mu-...@nongnu.org
Cc: Magnus Damm
Cc: Fabien Chouteau
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
Cc: Bastian Koppelmann
Cc: Guan Xuetao
Cc: Max Filippov
Signed-off-by: Markus Armbruster
---
include/sysemu/blockdev.h | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
mu-...@nongnu.org
Cc: Magnus Damm
Cc: Fabien Chouteau
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
Cc: Bastian Koppelmann
Cc: Guan Xuetao
Cc: Max Filippov
Signed-off-by: Markus Armbruster
Acked-By: Artyom Tarasenko
---
include/sysemu/blockdev.h | 9 -
1 file changed, 4 insertions(+)
mu-...@nongnu.org
Cc: Magnus Damm
Cc: Fabien Chouteau
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
Cc: Bastian Koppelmann
Cc: Guan Xuetao
Cc: Max Filippov
Signed-off-by: Markus Armbruster
Acked-By: Artyom Tarasenko
Reviewed-by: Laurent Vivier
Reviewed-by: Thomas Huth
---
include/sysem
mu-...@nongnu.org
Cc: Magnus Damm
Cc: Fabien Chouteau
Cc: Mark Cave-Ayland
Cc: Artyom Tarasenko
Cc: Bastian Koppelmann
Cc: Guan Xuetao
Cc: Max Filippov
Signed-off-by: Markus Armbruster
Acked-By: Artyom Tarasenko
Reviewed-by: Laurent Vivier
Reviewed-by: Thomas Huth
Message-Id: <148
x27;nvdimm', only nvdimm
> devices will be listed.
Basically, the argument provides limited server-side filtering of the
output of query-memory-devices.
> Signed-off-by: Haozhong Zhang
> ---
> Cc: "Dr. David Alan Gilbert"
> Cc: Xiao Guangrong
> Cc: "Michael S.
Eric Blake writes:
> We now have macros in place to make it less verbose to add a scalar
> to QDict and QList, so use them. To make this patch smaller to
> review, a couple of subdirectories were done in earlier patches.
>
> Patch created mechanically via:
> spatch --sp-file scripts/coccinelle
Eric Blake writes:
> Libvirt would like to be able to distinguish between a SHUTDOWN
> event triggered solely by guest request and one triggered by a
> SIGTERM or other action on the host. qemu_kill_report() is
> already able to tell whether a shutdown was triggered by a host
> signal (but NOT b
Eric Blake writes:
> On 04/20/2017 07:09 AM, Daniel P. Berrange wrote:
>
+++ b/qapi/event.json
@@ -10,6 +10,10 @@
# Emitted when the virtual machine has shut down, indicating that qemu is
# about to exit.
#
+# @guest: If true, the shutdown was triggered by a guest
Eric Blake writes:
> On 04/20/2017 06:59 AM, Markus Armbruster wrote:
>
>>
>> No objection to Alistair's idea to turn this into an enumeration.
>
> Question - should the enum be more than just 'guest' and 'host'? For
> example, my p
Stefano Stabellini writes:
> On Mon, 24 Apr 2017, Peter Maydell wrote:
>> On 24 April 2017 at 22:25, Stefano Stabellini wrote:
>> > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h
>> > new file mode 100644
>> > index 000..18f0ec0
>> > --- /dev/null
>> > +++ b/hw/9pfs/xen-9pfs.h
>> > @@
Stefano Stabellini writes:
> On Tue, 25 Apr 2017, Markus Armbruster wrote:
>> Stefano Stabellini writes:
[...]
>> > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h
>> > new file mode 100644
>> > index 000..6e33d77
>> > --- /dev/null
>
Signed-off-by: Eric Blake
> Reviewed-by: Markus Armbruster
>
> ---
> v5: rebase to master (Coccinelle found a couple new spots), squash 3
> patches into 1, adjust R-b to only list Markus (while there were other
> reviews on the pre-squashed patches, Markus was the only one on all
Eric Blake writes:
> We want to track why a guest was shutdown; in particular, being able
> to tell the difference between a guest request (such as ACPI request)
> and host request (such as SIGINT) will prove useful to libvirt.
> Since all requests eventually end up changing shutdown_requested in
"Dr. David Alan Gilbert" writes:
> * Eric Blake (ebl...@redhat.com) wrote:
>> We want to track why a guest was shutdown; in particular, being able
>> to tell the difference between a guest request (such as ACPI request)
>> and host request (such as SIGINT) will prove useful to libvirt.
>> Since a
Eric Blake writes:
> Libvirt would like to be able to distinguish between a SHUTDOWN
> event triggered solely by guest request and one triggered by a
> SIGTERM or other action on the host. While qemu_kill_report() is
> already able to tell whether a shutdown was triggered by a host
> signal (but
Eric Blake writes:
> On 04/28/2017 09:42 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> We want to track why a guest was shutdown; in particular, being able
>>> to tell the difference between a guest request (such as ACPI request)
>>> an
Stefan Hajnoczi writes:
> On Fri, Apr 28, 2017 at 10:33:36AM +0200, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>> > We now have macros in place to make it less verbose to add a scalar
>> > to QDict and QList, so use them. To make this patch sm
Eric Blake writes:
> We want to track why a guest was shutdown; in particular, being able
> to tell the difference between a guest request (such as ACPI request)
> and host request (such as SIGINT) will prove useful to libvirt.
> Since all requests eventually end up changing shutdown_requested in
Alberto Garcia writes:
> On Fri 28 Apr 2017 10:33:36 AM CEST, Markus Armbruster wrote:
>>> v5: rebase to master (Coccinelle found a couple new spots), squash 3
>>> patches into 1, adjust R-b to only list Markus (while there were other
>>> reviews on the pre-squashe
Eric Blake writes:
> On 05/08/2017 01:26 PM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> We want to track why a guest was shutdown; in particular, being able
>>> to tell the difference between a guest request (such as ACPI request)
>>> an
is lets us get rid of the weird #defines for VMRESET_*
> as synonyms for bools.
>
> Signed-off-by: Eric Blake
Reviewed-by: Markus Armbruster
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
;
> -qemu_system_shutdown_request();
> +/* FIXME - store actual reason */
> +qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR);
The temporary replay breakage is no big deal. Still, can we avoid it by
extending replay first, using a dumm
o big deal. Still, can we avoid it by
extending replay first, using a dummy value like
SHUTDOWN_CAUSE_HOST_ERROR until the real cause becomes available? Not
sure it's worth a respin, though.
> break;
> default:
> /* clock, time_t, checkpoint and other events */
[...]
Reviewed-by: Markus Armbruster
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Eric Blake writes:
> On 05/09/2017 06:56 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> Time to wire up all the call sites that request a shutdown or
>>> reset to use the enum added in the previous patch.
>>>
>>> It would h
> Cc: Thomas Huth
> Cc: sstabell...@kernel.org
> Cc: Markus Armbruster ,
> Cc: Marcel Apfelbaum ,
> Cc: Laszlo Ersek
> Acked-by: Juergen Gross
> Acked-by: Marcel Apfelbaum
> Signed-off-by: Eduardo Habkost
> ---
> Changes series v1 -> v2:
> * (New patch added t
line turns
> + that into a shutdown */
> +SHUTDOWN_CAUSE__MAX,
The __ is a bit odd for handwritten code, but it matches QAPI-generated
code. Okay.
> +} ShutdownCause;
>
> void vm_start(void);
> int vm_prepare_start(void);
Reviewed-by: Markus Armbruster
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
>
> ---
> v8: rebase later in series
That turned out nicely. Thanks!
Reviewed-by: Markus Armbruster
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
Ian Jackson writes:
> This allows the caller to specify a uid and gid to use, even if there
> is no corresponding password entry. This will be useful in certain
> Xen configurations.
>
> Signed-off-by: Ian Jackson
[...]
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9f6e2ad..34a5329 1
Ian Jackson writes:
> Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
> -runasid option"):
>> The last thing the QEMU command line needs is more exotic options. Are
>> you sure we need a new one here? Can we make existing -runas ser
Olaf Hering writes:
> On Fri, Jul 28, Eric Blake wrote:
>
>> This version is prone to multiplication overflow (well, maybe not, but
>> you have to audit for that). Wouldn't it be better to use:
>
> What could go wrong?
> qemu will die either way, I think.
An overflow in the size argument of mal
Sorry for the slow response.
Ian Jackson writes:
> This allows the caller to specify a uid and gid to use, even if there
> is no corresponding password entry. This will be useful in certain
> Xen configurations.
>
> Signed-off-by: Ian Jackson
> ---
> v3: Error messages fixed. Thanks to Pe
Ian Jackson writes:
> Hi. Thanks for the (re)-review.
>
> Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new
> -runasid option"):
>> Ian Jackson writes:
>> > +case QEMU_OPTION_runasid:
>> > +errno = 0;
>&g
Juan Quintela writes:
> Alistair Francis wrote:
>> Replace all occurs of __FUNCTION__ except for the check in checkpatch
>> with the non GCC specific __func__.
>>
>> One line in hcd-musb.c was manually tweaked to pass checkpatch.
>>
>> Signed-off-by: Alistair Francis
>> Cc: Gerd Hoffmann
>> Cc
Eric Blake writes:
> On 11/07/2017 04:12 AM, Markus Armbruster wrote:
>> Juan Quintela writes:
>>
>>> Alistair Francis wrote:
>>>> Replace all occurs of __FUNCTION__ except for the check in checkpatch
>>>> with the non GCC specific __func__.
&g
57 matches
Mail list logo
