Re: [Xen-devel] [Qemu-trivial] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Michael Tokarev
11.11.2014 12:23, Chen Gang wrote: > In xen_hvm_change_state_handler(), can pass 'opaque' with type cast to > xen_main_loop_prepare() directly, need not use additional variable for > it. gcc most likely eliminates it anyway, but heck, why not? Applied to -trivial, thank you! /mjt ___

Re: [Xen-devel] [Qemu-trivial] [PATCH trivial] xen-hvm: Remove redandant varialbe 'xstate'

2014-11-11 Thread Michael Tokarev
11.11.2014 17:32, Chen Gang wrote: >> The title of your patch should say 'variable'. > > Oh, yes, thanks. If necessary to send patch v2 for it, please let me > know. Not only 'varialbe', but also 'redandant'. I fixed both on commit, plus fixed grammar in commit message. Thanks, /mjt _

Re: [Xen-devel] [PATCH trivial v2] xen/Makefile.objs: simplify

2016-01-10 Thread Michael Tokarev
29.12.2015 15:39, Cao jin wrote: > merge last two lines, keep alphabetic order. Applied to -trivial, thank you! /mjt ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [Qemu-devel] xen/disk: don't leak stack data via response ring

2017-09-23 Thread Michael Tokarev
28.06.2017 01:04, Stefano Stabellini wrote: > Rather than constructing a local structure instance on the stack, fill > the fields directly on the shared ring, just like other (Linux) > backends do. Build on the fact that all response structure flavors are > actually identical (aside from alignment

Re: [Xen-devel] [Qemu-devel] xen/disk: don't leak stack data via response ring

2017-09-24 Thread Michael Tokarev
23.09.2017 19:05, Michael Tokarev wrote: > 28.06.2017 01:04, Stefano Stabellini wrote: >> Rather than constructing a local structure instance on the stack, fill >> the fields directly on the shared ring, just like other (Linux) >> backends do. Build on the fact that all respo

Re: [Xen-devel] [PATCH v2] hw/display/xenfb.c: Add trace_xenfb_key_event

2017-09-14 Thread Michael Tokarev
23.08.2017 18:27, Liang Yan wrote: > It may be better to add a trace event to monitor the last moment of > a key event from QEMU to guest VM The patch looks okay, hopefully it is also useful - I haven't dealt with xen and with keys it sends to a guest :) Applied to -trivial, thanks! /mjt __