Re: [Xen-devel] [PATCH v1 0/6] libxl: create standalone vkb device

2017-11-20 Thread Oleksandr Grytsov
On Tue, Nov 14, 2017 at 2:39 PM, Oleksandr Grytsov wrote: > On Wed, Nov 1, 2017 at 5:05 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> Changes since initial: >> * add setting backend-type to xenstore >> * add id field to i

Re: [Xen-devel] [PATCH v1 0/5] libxl: add PV sound device

2017-11-20 Thread Oleksandr Grytsov
On Tue, Nov 14, 2017 at 2:38 PM, Oleksandr Grytsov wrote: > On Wed, Nov 1, 2017 at 5:04 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> This patch set adds PV sound device support to xl.cfg and xl. >> See sndif.h for protocol implementa

Re: [Xen-devel] [PATCH v1 0/6] libxl: create standalone vkb device

2017-11-14 Thread Oleksandr Grytsov
On Wed, Nov 1, 2017 at 5:05 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Changes since initial: > * add setting backend-type to xenstore > * add id field to indentify the vkb device on backend side > > Oleksandr Grytsov (6): > libxl: move vkb device

Re: [Xen-devel] [PATCH v1 0/5] libxl: add PV sound device

2017-11-14 Thread Oleksandr Grytsov
On Wed, Nov 1, 2017 at 5:04 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > This patch set adds PV sound device support to xl.cfg and xl. > See sndif.h for protocol implementation details. > > Changes since initial: > * fix code style > * change unique-i

Re: [Xen-devel] [PATCH RFC 3/8] libxl: add backend_features to libxl_device_disk

2017-11-07 Thread Oleksandr Grytsov
th additional parameter (brents). You can add nested entry in libxl__set_xenstore_ as following: flexarray_append(back, "require/feature-persistent", "0"); -- Best Regards, Oleksandr Grytsov. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v1 5/6] xl: add vkb config parser and CLI

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 ++ tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_parse.c| 75 +- tools/xl/xl_parse.h| 2 +- tools/xl/xl_vkb.c | 142

[Xen-devel] [PATCH v1 2/6] libxl: fix vkb XS entry and type

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov vkb has vkbd name in XS. Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_vkb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_vkb.c b/tools/libxl/libxl_vkb.c index 0d01262..ea6fca8 100644 --- a/tools

[Xen-devel] [PATCH v1 4/6] libxl: vkb add list and info functions

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 10 tools/libxl/libxl_types.idl | 11 tools/libxl/libxl_utils.h | 3 ++ tools/libxl/libxl_vkb.c | 129 ++-- 4 files changed, 150 insertions

[Xen-devel] [PATCH v1 0/6] libxl: create standalone vkb device

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Changes since initial: * add setting backend-type to xenstore * add id field to indentify the vkb device on backend side Oleksandr Grytsov (6): libxl: move vkb device to libxl_vkb.c libxl: fix vkb XS entry and type libxl: add backend type and id to vkb libxl

[Xen-devel] [PATCH v1 3/6] libxl: add backend type and id to vkb

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov New field backend_type is added to vkb device in order to have QEMU and user space backend simultaneously. Each vkb backend shall read appropriate XS entry and service only own frontends. Id is a string field which used by the backend to indentify the frontend. Signed

[Xen-devel] [PATCH v1 1/6] libxl: move vkb device to libxl_vkb.c

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Logically it is better to move vkb to separate file as vkb device used not only by vfb and console. Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/Makefile| 1 + tools/libxl/libxl_console.c | 53 - tools

[Xen-devel] [PATCH v1 6/6] docs: add vkb device to xl.cfg and xl

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 28 docs/man/xl.pod.1.in | 22 ++ 2 files changed, 50 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index 4948dd7

[Xen-devel] [PATCH v1 0/5] libxl: add PV sound device

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov This patch set adds PV sound device support to xl.cfg and xl. See sndif.h for protocol implementation details. Changes since initial: * fix code style * change unique-id from int to string (to make id more user readable) Oleksandr Grytsov (5): libxl: add PV sound

[Xen-devel] [PATCH v1 1/5] libxl: add PV sound device

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add PV sound device described in sndif.h Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 14 ++ tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools

[Xen-devel] [PATCH v1 3/5] xl: add PV sound condif parser

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add config parser for virtual sound devices Signed-off-by: Oleksandr Grytsov --- tools/xl/xl_parse.c | 246 tools/xl/xl_parse.h | 1 + 2 files changed, 247 insertions(+) diff --git a/tools/xl/xl_parse.c b/tools/xl

[Xen-devel] [PATCH v1 5/5] docs: add PV sound device config

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Update documentation with virtual sound device Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 150 +++ docs/man/xl.pod.1.in | 30 ++ 2 files changed, 180 insertions(+) diff --git a/docs/man

[Xen-devel] [PATCH v1 4/5] xl: add vsnd CLI commands

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add CLI commands to attach, detach and list virtual sound devices Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 tools/xl/xl_vsnd.c | 203

[Xen-devel] [PATCH v1 2/5] libxl: add vsnd list and info

2017-11-01 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add getting vsnd list amd info API Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 10 ++ tools/libxl/libxl_types.idl | 19 +++ tools/libxl/libxl_utils.h | 3 + tools/libxl/libxl_vsnd.c| 375 +++- 4

Re: [Xen-devel] [PATCH 5/5] docs: add PV sound device config

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 8:00 PM, Marek Marczykowski-Górecki < marma...@invisiblethingslab.com> wrote: > On Mon, Oct 02, 2017 at 12:49:24PM +0300, Oleksandr Grytsov wrote: > > +=item B > > + > > +Short name of the virtual sound card. > > + > > +=item B &g

Re: [Xen-devel] [PATCH 1/5] libxl: add PV sound device

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 7:39 PM, Wei Liu wrote: > On Mon, Oct 02, 2017 at 12:49:20PM +0300, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > Add PV sound device described in sndif.h > > > > Signed-off-by: Oleksandr Grytsov > > [...] > &

Re: [Xen-devel] [PATCH 1/5] libxl: add PV sound device

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 7:39 PM, Wei Liu wrote: > On Mon, Oct 02, 2017 at 12:49:20PM +0300, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > Add PV sound device described in sndif.h > > > > Signed-off-by: Oleksandr Grytsov > > [...] > &

Re: [Xen-devel] [PATCH 3/6] libxl: add backend type to vkb

2017-10-31 Thread Oleksandr Grytsov
On Mon, Oct 30, 2017 at 8:11 PM, Wei Liu wrote: > On Thu, Oct 05, 2017 at 12:07:08PM +0300, Oleksandr Grytsov wrote: > > From: Oleksandr Grytsov > > > > New field backend_type is added to vkb device > > in order to have QEMU and user space backend > > simultaneo

Re: [Xen-devel] [PATCH 0/4] libxl: use libxl__device_kind string to access device

2017-10-30 Thread Oleksandr Grytsov
On Tue, Oct 24, 2017 at 10:41 AM, Oleksandr Grytsov wrote: > On Thu, Oct 5, 2017 at 12:30 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> In current implementation the path of device XS entry is created with >> string from libxl__device_ki

Re: [Xen-devel] [PATCH 0/5] libxl: add PV sound device

2017-10-30 Thread Oleksandr Grytsov
On Tue, Oct 24, 2017 at 10:27 AM, Oleksandr Grytsov wrote: > On Mon, Oct 2, 2017 at 12:49 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> This patch set adds PV sound device support to xl.cfg and xl. >> See sndif.h for protocol implement

Re: [Xen-devel] [PATCH 0/6] libxl: create standalone vkb device

2017-10-30 Thread Oleksandr Grytsov
On Tue, Oct 24, 2017 at 10:40 AM, Oleksandr Grytsov wrote: > On Thu, Oct 5, 2017 at 12:07 PM, Oleksandr Grytsov > wrote: > >> From: Oleksandr Grytsov >> >> Currently vkb device is the part of FB and console. >> In embedded application we use vkb protocol

Re: [Xen-devel] [PATCH 0/4] libxl: use libxl__device_kind string to access device

2017-10-24 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:30 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > In current implementation the path of device XS entry is created with > string from libxl__device_kind enum. But access to the device entry > usually done with hardcoded path. This is sour

Re: [Xen-devel] [PATCH 0/6] libxl: create standalone vkb device

2017-10-24 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:07 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Currently vkb device is the part of FB and console. > In embedded application we use vkb protocol to communicate > with user space backend. For this purpose we need to have > possibility to

Re: [Xen-devel] [PATCH 0/5] libxl: add PV sound device

2017-10-24 Thread Oleksandr Grytsov
On Mon, Oct 2, 2017 at 12:49 PM, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > This patch set adds PV sound device support to xl.cfg and xl. > See sndif.h for protocol implementation details. > > > Oleksandr Grytsov (5): > libxl: add PV sound device > li

Re: [Xen-devel] [PATCH 2/6] libxl: fix vkb XS entry and type

2017-10-05 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:49 PM, Oleksandr Grytsov wrote: > On Thu, Oct 5, 2017 at 12:32 PM, Wei Liu wrote: >> On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote: >>> From: Oleksandr Grytsov >>> >>> vkb has vkbd name in XS. >>> >

Re: [Xen-devel] [PATCH 2/6] libxl: fix vkb XS entry and type

2017-10-05 Thread Oleksandr Grytsov
On Thu, Oct 5, 2017 at 12:32 PM, Wei Liu wrote: > On Thu, Oct 05, 2017 at 12:07:07PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> vkb has vkbd name in XS. >> >> Signed-off-by: Oleksandr Grytsov > > This series won't make it to 4.10

[Xen-devel] [PATCH 4/4] libxl: move ibxl_devid_to_device_... to LIBXL_DEFINE_DEVID_TO_DEVICE

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_internal.h | 38 ++ tools/libxl/libxl_nic.c | 26 +- tools/libxl/libxl_vdispl.c | 35 +-- tools/libxl/libxl_vkb.c

[Xen-devel] [PATCH 3/4] libxl: move libxl__device_from_ to LIBXL_DEFINE_DEVICE_FROM_TYPE

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov LIBXL_DEFINE_DEVICE_FROM_TYPE uses libxl__..._devtype.type to be assigned as device and backend type. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_9pfs.c | 19 +++ tools/libxl/libxl_console.c | 18 +++--- tools/libxl

[Xen-devel] [PATCH 1/4] libxl: use libxl__device_kind to get device XS entry

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov On adding to XS name of device is taken from libxl__device_kind enum. On getting device from XS the name is hardcoded. It leads to potential mistmatch errors. The patch is using libxl__device_kind everywere to have one source of device name. Signed-off-by: Oleksandr

[Xen-devel] [PATCH 0/4] libxl: use libxl__device_kind string to access device

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov In current implementation the path of device XS entry is created with string from libxl__device_kind enum. But access to the device entry usually done with hardcoded path. This is source of potential errors. This patchset changes hardcoded device name in the XS path to

[Xen-devel] [PATCH 2/4] libxl: use libxl__device_kind in LIBXL_DEFINE_UPDATE_DEVID

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Use libxl__..._devtype.type to update device id. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_9pfs.c | 2 +- tools/libxl/libxl_console.c | 2 +- tools/libxl/libxl_device.c | 7 --- tools/libxl/libxl_internal.h | 12 +++- tools/libxl

[Xen-devel] [PATCH 1/6] libxl: move vkb device to libxl_vkb.c

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Logically it is better to move vkb to separate file as vkb device used not only by vfb and console. Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile| 1 + tools/libxl/libxl_console.c | 53 - tools/libxl/libxl_vkb.c

[Xen-devel] [PATCH 4/6] libxl: vkb add list and info functions

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 10 + tools/libxl/libxl_types.idl | 11 + tools/libxl/libxl_utils.h | 3 ++ tools/libxl/libxl_vkb.c | 106 ++-- 4 files changed, 127 insertions

[Xen-devel] [PATCH 0/6] libxl: create standalone vkb device

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Currently vkb device is the part of FB and console. In embedded application we use vkb protocol to communicate with user space backend. For this purpose we need to have possibility to enable vkb device without QEMU, FB etc. This particular issue was already discussed int

[Xen-devel] [PATCH 5/6] xl: add vkb config parser and CLI

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 ++ tools/xl/xl_cmdtable.c | 15 ++ tools/xl/xl_parse.c| 77 +-- tools/xl/xl_parse.h| 2 +- tools/xl/xl_vkb.c | 141

[Xen-devel] [PATCH 2/6] libxl: fix vkb XS entry and type

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov vkb has vkbd name in XS. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_vkb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_vkb.c b/tools/libxl/libxl_vkb.c index 0d01262..ea6fca8 100644 --- a/tools/libxl/libxl_vkb.c

[Xen-devel] [PATCH 3/6] libxl: add backend type to vkb

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov New field backend_type is added to vkb device in order to have QEMU and user space backend simultaneously. Each vkb backend shall read appropriate XS entry and service only own frontends. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_create.c | 4 tools

[Xen-devel] [PATCH 6/6] docs: add vkb device to xl.cfg and xl

2017-10-05 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 24 docs/man/xl.pod.1.in | 22 ++ 2 files changed, 46 insertions(+) diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in index 4948dd7..a9e10aa

Re: [Xen-devel] [PATCH] libxl: fix generating array of enums in getypes.py

2017-10-04 Thread Oleksandr Grytsov
On Mon, Oct 2, 2017 at 4:18 PM, Oleksandr Grytsov wrote: > On Mon, Oct 2, 2017 at 3:02 PM, Wei Liu wrote: >> On Fri, Sep 29, 2017 at 04:49:23PM +0300, Oleksandr Grytsov wrote: >>> From: Oleksandr Grytsov >>> >>> Enum always uses "x" value a

Re: [Xen-devel] [PATCH] libxl: fix generating array of enums in getypes.py

2017-10-02 Thread Oleksandr Grytsov
On Mon, Oct 2, 2017 at 3:02 PM, Wei Liu wrote: > On Fri, Sep 29, 2017 at 04:49:23PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Enum always uses "x" value as input argument. In >> case of enum array "t" argument should be

[Xen-devel] [PATCH 4/5] xl: add vsnd CLI commands

2017-10-02 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add CLI commands to attach, detach and list virtual sound devices Signed-off-by: Oleksandr Grytsov --- tools/xl/Makefile | 2 +- tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 15 tools/xl/xl_vsnd.c | 203

[Xen-devel] [PATCH 2/5] libxl: add vsnd list and info

2017-10-02 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add getting vsnd list amd info API Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 10 ++ tools/libxl/libxl_types.idl | 19 +++ tools/libxl/libxl_utils.h | 3 + tools/libxl/libxl_vsnd.c| 359 +++- 4

[Xen-devel] [PATCH 1/5] libxl: add PV sound device

2017-10-02 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add PV sound device described in sndif.h Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 14 ++ tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools

[Xen-devel] [PATCH 3/5] xl: add PV sound condif parser

2017-10-02 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add config parser for virtual sound devices Signed-off-by: Oleksandr Grytsov --- tools/xl/xl_parse.c | 250 tools/xl/xl_parse.h | 1 + 2 files changed, 251 insertions(+) diff --git a/tools/xl/xl_parse.c b/tools/xl

[Xen-devel] [PATCH 0/5] libxl: add PV sound device

2017-10-02 Thread Oleksandr Grytsov
From: Oleksandr Grytsov This patch set adds PV sound device support to xl.cfg and xl. See sndif.h for protocol implementation details. Oleksandr Grytsov (5): libxl: add PV sound device libxl: add vsnd list and info xl: add PV sound condif parser xl: add vsnd CLI commands docs: add PV

[Xen-devel] [PATCH 5/5] docs: add PV sound device config

2017-10-02 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Update documentation with virtual sound device Signed-off-by: Oleksandr Grytsov --- docs/man/xl.cfg.pod.5.in | 150 +++ docs/man/xl.pod.1.in | 30 ++ 2 files changed, 180 insertions(+) diff --git a/docs/man

[Xen-devel] [PATCH] libxl: fix generating array of enums in getypes.py

2017-09-29 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Enum always uses "x" value as input argument. In case of enum array "t" argument should be passed. Signed-off-by: Oleksandr Grytsov --- tools/libxl/gentypes.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/libxl

[Xen-devel] [PATCH] libxl: fix generating array of enums in getypes.py

2017-09-29 Thread Oleksandr Grytsov
From: Oleksandr Grytsov There is an issue with gentypes.py when using array of enums: for (i=0; (t=libxl__json_array_get(x,i)); i++) { { const char *enum_str; if (!libxl__json_object_is_string(x)) { rc = -1; goto out; } enum_str

Re: [Xen-devel] [PATCH v1] libxl: remove list callback from device framework

2017-09-22 Thread Oleksandr Grytsov
On Fri, Sep 22, 2017 at 5:17 PM, Wei Liu wrote: > On Fri, Sep 22, 2017 at 05:00:44PM +0300, Oleksandr Grytsov wrote: >> On Fri, Sep 22, 2017 at 4:02 PM, Wei Liu wrote: >> > On Fri, Sep 22, 2017 at 03:28:55PM +0300, Oleksandr Grytsov wrote: >> >> From: Oleksandr G

Re: [Xen-devel] [PATCH v1] libxl: remove list callback from device framework

2017-09-22 Thread Oleksandr Grytsov
On Fri, Sep 22, 2017 at 4:02 PM, Wei Liu wrote: > On Fri, Sep 22, 2017 at 03:28:55PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> As we have generic functions to get device list >> (libxl__device_list) no need to have callback in >> the fr

[Xen-devel] [PATCH v1] libxl: provide typedefs for device framework functions

2017-09-22 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Resend Oleksandr Grytsov (1): libxl: remove list callback from device framework tools/libxl/libxl_checkpoint_device.c | 4 ++-- tools/libxl/libxl_colo_save.c | 2 +- tools/libxl/libxl_device.c| 4 ++-- tools/libxl/libxl_disk.c | 24

[Xen-devel] [PATCH v1] libxl: remove list callback from device framework

2017-09-22 Thread Oleksandr Grytsov
From: Oleksandr Grytsov As we have generic functions to get device list (libxl__device_list) no need to have callback in the framework. To resolve issue when XS entry doesn't match device name, device type is extended with field "entry" which keeps XS entry. Signed-off-by: Ol

Re: [Xen-devel] [PATCH v1] libxl: provide typedefs for device framework functions

2017-09-22 Thread Oleksandr Grytsov
On Fri, Sep 22, 2017 at 3:24 PM, Oleksandr Grytsov wrote: > From: Wei Liu > > Use the new typedefs to avoid copy-n-paste everywhere. > > No functional change. > > Signed-off-by: Wei Liu > --- > tools/libxl/libxl_9pfs.c | 6 ++-- > tools/libxl/libxl_conso

[Xen-devel] [PATCH v1] libxl: remove list callback from device framework

2017-09-22 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Rebase Wei Liu (1): libxl: provide typedefs for device framework functions tools/libxl/libxl_9pfs.c | 6 ++-- tools/libxl/libxl_console.c | 6 ++-- tools/libxl/libxl_disk.c | 5 ++-- tools/libxl/libxl_internal.h | 71

[Xen-devel] [PATCH v1] libxl: provide typedefs for device framework functions

2017-09-22 Thread Oleksandr Grytsov
From: Wei Liu Use the new typedefs to avoid copy-n-paste everywhere. No functional change. Signed-off-by: Wei Liu --- tools/libxl/libxl_9pfs.c | 6 ++-- tools/libxl/libxl_console.c | 6 ++-- tools/libxl/libxl_disk.c | 5 ++-- tools/libxl/libxl_internal.h | 71 +

[Xen-devel] [PATCH] remove list callback from device framework

2017-09-22 Thread Oleksandr Grytsov
From: Oleksandr Grytsov We have generic functiont to get/free device list: libxl__device_list and libxl__device_list_free As some devices have different from their name entry in XS (disk -> vbd), getting list function takes XS entry as paramater. This doesn't allow to call libxl__dev

[Xen-devel] [PATCH] libxl: remove list callback from device framework

2017-09-22 Thread Oleksandr Grytsov
From: Oleksandr Grytsov As we have generic functions to get device list (libxl__device_list) no need to have callback in the framework. To resolve issue when XS entry doesn't match device name, device type is extended with field "entry" which keeps XS entry. Signed-off-by: Ol

Re: [Xen-devel] [PATCH] libxl: add back libxl_device_v{k,f}b_add

2017-09-14 Thread Oleksandr Grytsov
On Wed, Sep 13, 2017 at 4:44 PM, Wei Liu wrote: > The two functions, unlike a lot others, were hand-coded. They were > deleted by accident while the device framework was reworked. Add them > back. > > Reported-by: Andrew Cooper > Signed-off-by: Wei Liu > --- > Cc: Ian

Re: [Xen-devel] [PATCH v6 00/13] libxl: add PV display device driver interface

2017-09-13 Thread Oleksandr Grytsov
On Tue, Sep 12, 2017 at 7:22 PM, Wei Liu wrote: > On Tue, Sep 12, 2017 at 04:48:05PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Changes since V4: >> * Change libxl_device_nic_list to libxl__device_list; >> * Move incorrect me

[Xen-devel] [PATCH v6 12/13] libxl: change vtpm to use generec add function

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl.h | 12 +-- tools/libxl/libxl_vtpm.c | 221 +-- tools/xl/xl_vtpm.c | 3 +- 3 files changed, 69 insertions(+), 167 deletions(-) diff --git

[Xen-devel] [PATCH v6 05/13] docs: add PV display driver information

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- docs/man/xl.cfg.pod.5.in | 49 docs/man/xl.pod.1.in | 42 + 2 files changed, 91 insertions(+) diff --git a/docs/man

[Xen-devel] [PATCH v6 08/13] libxl: change vfb to use generec add function

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_console.c | 69 tools/libxl/libxl_create.c | 3 +- tools/libxl/libxl_dm.c | 6 ++-- tools/libxl/libxl_internal.h | 6 +--- 4 files changed

[Xen-devel] [PATCH v6 00/13] libxl: add PV display device driver interface

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Changes since V4: * Change libxl_device_nic_list to libxl__device_list; * Move incorrect memory leak fix to additional patch. Patches on github [1]. [1] https://github.com/al1img/xen/tree/xl-vdispl-v6 Oleksandr Grytsov (13): libxl: add generic function to add

[Xen-devel] [PATCH v6 01/13] libxl: add generic function to add device

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_add to simple write XenStore device conifg and libxl__device_add_async to update domain configuration and write XenStore device config asynchroniously. Almost all devices have similar libxl__device__add function. This generic functions implement same

[Xen-devel] [PATCH v6 11/13] libxl: fix memory leak in libxl__colo_save_setup

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Getting nic list in case userspace proxy is called without freeing. The fix is to use cds->nics to keep nic list. cds->nics will be freed in devices_teardown_cb. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_colo_save.c | 11 ++- 1 file chan

[Xen-devel] [PATCH v6 10/13] libxl: change nic to use generec add function

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 9 +- tools/libxl/libxl_checkpoint_device.c | 9 +- tools/libxl/libxl_colo_save.c | 3 +- tools/libxl/libxl_dm.c| 4 +- tools/libxl/libxl_internal.h

[Xen-devel] [PATCH v6 02/13] libxl: add generic functions to get and free device list

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_list and libxl__device_list_free functions to handle device list using the device framework. Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_device.c | 61 tools/libxl

[Xen-devel] [PATCH v6 06/13] libxl: change p9 to use generec add function

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_9pfs.c | 59 tools/libxl/libxl_create.c | 2 +- tools/libxl/libxl_internal.h | 7 +- 3 files changed, 23 insertions(+), 45 deletions

[Xen-devel] [PATCH v6 04/13] xl: add PV display device commands

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add commands: vdispl-attach, vdispl-list, vdispl-detach and domain config vdispl parser Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/xl/Makefile | 1 + tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 19 ++ tools/xl/xl_parse.c

[Xen-devel] [PATCH v6 03/13] libxl: add vdispl device

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 24 +++ tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_types.idl

[Xen-devel] [PATCH v6 13/13] libxl: remove unneeded DEVICE_ADD macro

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_device.c | 6 ++--- tools/libxl/libxl_disk.c | 5 +++-- tools/libxl/libxl_internal.h | 52 +++- tools/libxl/libxl_pci.c | 3 ++- tools/libxl

[Xen-devel] [PATCH v6 09/13] libxl: change disk to use generic getting list functions

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl.h | 9 +++- tools/libxl/libxl_checkpoint_device.c | 7 ++- tools/libxl/libxl_create.c| 4 +- tools/libxl/libxl_disk.c | 83

[Xen-devel] [PATCH v6 07/13] libxl: change vkb to use generec add function

2017-09-12 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_console.c | 74 +++- tools/libxl/libxl_create.c | 5 +-- tools/libxl/libxl_dm.c | 6 ++-- tools/libxl/libxl_internal.h | 6 +--- 4 files changed

Re: [Xen-devel] [PATCH v5 10/12] libxl: change nic to use generec add function

2017-09-12 Thread Oleksandr Grytsov
On Tue, Sep 12, 2017 at 2:35 PM, Oleksandr Grytsov wrote: > On Tue, Sep 12, 2017 at 2:08 PM, Wei Liu wrote: >> On Tue, Sep 12, 2017 at 11:52:17AM +0100, Wei Liu wrote: >>> On Mon, Sep 11, 2017 at 08:15:00PM +0300, Oleksandr Grytsov wrote: >>> > From: Oleksandr Gryt

Re: [Xen-devel] [PATCH v5 10/12] libxl: change nic to use generec add function

2017-09-12 Thread Oleksandr Grytsov
On Tue, Sep 12, 2017 at 2:08 PM, Wei Liu wrote: > On Tue, Sep 12, 2017 at 11:52:17AM +0100, Wei Liu wrote: >> On Mon, Sep 11, 2017 at 08:15:00PM +0300, Oleksandr Grytsov wrote: >> > From: Oleksandr Grytsov >> > >> > Signed-off-by: Oleksandr Grytsov

Re: [Xen-devel] [alsa-devel] [PATCH RESEND1 00/12] ALSA: vsnd: Add Xen para-virtualized frontend driver

2017-09-12 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 10:24 AM, Clemens Ladisch wrote: > Oleksandr Andrushchenko wrote: We understand that emulated interrupt on the frontend side is completely not acceptable > > Allow me to expand on that: Proper synchronization requires that the > exact position is communicate

[Xen-devel] [PATCH v5 03/12] libxl: add vdispl device

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.h | 24 +++ tools/libxl/libxl_create.c | 1 + tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_types.idl | 36

[Xen-devel] [PATCH v5 11/12] libxl: change vtpm to use generec add function

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl.h | 12 +-- tools/libxl/libxl_vtpm.c | 221 +-- tools/xl/xl_vtpm.c | 3 +- 3 files changed, 69 insertions(+), 167 deletions(-) diff --git

[Xen-devel] [PATCH v5 00/12] libxl: add PV display device driver interface

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Changes since V4: * Use new LIBXL_DEFINE_UPDATE_DEVID for all device types; * Align device setdefault function parameters with set_default device type callback; * revert libxl_mac_to_device_nic to existing implementation; * previous comments are applied

[Xen-devel] [PATCH v5 05/12] docs: add PV display driver information

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- docs/man/xl.cfg.pod.5.in | 49 docs/man/xl.pod.1.in | 42 + 2 files changed, 91 insertions(+) diff --git a/docs/man

[Xen-devel] [PATCH v5 01/12] libxl: add generic function to add device

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_add to simple write XenStore device conifg and libxl__device_add_async to update domain configuration and write XenStore device config asynchroniously. Almost all devices have similar libxl__device__add function. This generic functions implement same

[Xen-devel] [PATCH v5 04/12] xl: add PV display device commands

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add commands: vdispl-attach, vdispl-list, vdispl-detach and domain config vdispl parser Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/xl/Makefile | 1 + tools/xl/xl.h | 3 + tools/xl/xl_cmdtable.c | 19 ++ tools/xl/xl_parse.c

[Xen-devel] [PATCH v5 07/12] libxl: change vkb to use generec add function

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_console.c | 74 +++- tools/libxl/libxl_create.c | 5 +-- tools/libxl/libxl_dm.c | 6 ++-- tools/libxl/libxl_internal.h | 6 +--- 4 files changed, 19 insertions

[Xen-devel] [PATCH v5 10/12] libxl: change nic to use generec add function

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 9 +- tools/libxl/libxl_checkpoint_device.c | 9 +- tools/libxl/libxl_colo_save.c | 4 +- tools/libxl/libxl_dm.c| 4 +- tools/libxl/libxl_internal.h

[Xen-devel] [PATCH v5 08/12] libxl: change vfb to use generec add function

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_console.c | 69 tools/libxl/libxl_create.c | 3 +- tools/libxl/libxl_dm.c | 6 ++-- tools/libxl/libxl_internal.h | 6 +--- 4 files changed

[Xen-devel] [PATCH v5 09/12] libxl: change disk to use generic getting list functions

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl.h | 9 +++- tools/libxl/libxl_checkpoint_device.c | 7 ++- tools/libxl/libxl_create.c| 4 +- tools/libxl/libxl_disk.c | 83 +-- tools

[Xen-devel] [PATCH v5 02/12] libxl: add generic functions to get and free device list

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Add libxl__device_list and libxl__device_list_free functions to handle device list using the device framework. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_device.c | 61 tools/libxl/libxl_internal.h | 8

[Xen-devel] [PATCH v5 06/12] libxl: change p9 to use generec add function

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_9pfs.c | 59 tools/libxl/libxl_create.c | 2 +- tools/libxl/libxl_internal.h | 7 +- 3 files changed, 23 insertions(+), 45 deletions(-) diff --git a/tools

[Xen-devel] [PATCH v5 12/12] libxl: remove unneeded DEVICE_ADD macro

2017-09-11 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Signed-off-by: Oleksandr Grytsov Acked-by: Wei Liu --- tools/libxl/libxl_device.c | 6 ++--- tools/libxl/libxl_disk.c | 5 +++-- tools/libxl/libxl_internal.h | 52 +++- tools/libxl/libxl_pci.c | 3 ++- tools/libxl

Re: [Xen-devel] [PATCH v4 13/13] libxl: make pci and usb setdefault function generic

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:06 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:30PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Due to changes in device framework setdefault function >> should have same format. Otherwise calling devicetype >

Re: [Xen-devel] [PATCH v4 10/13] libxl: change nic to use generec add function

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:03 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:27PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Signed-off-by: Oleksandr Grytsov >> diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c >> index dd07a

Re: [Xen-devel] [PATCH v4 03/13] libxl: add vdispl device

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:04 PM, Wei Liu wrote: > On Tue, Sep 05, 2017 at 01:58:53PM +0100, Ian Jackson wrote: >> Wei Liu writes ("Re: [PATCH v4 03/13] libxl: add vdispl device"): >> > > +rc = snprintf(connector_path, 128, "%s/%d", path, >> > > info->num_connectors); >> >> Why not use GCSPRINT

Re: [Xen-devel] [PATCH v4 02/13] libxl: add generic functions to get and free device list

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 2:51 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:19PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Add libxl__device_list and libxl__device_list_free >> functions to handle device list using the device >> framewor

Re: [Xen-devel] [PATCH v4 01/13] libxl: add generic function to add device

2017-09-06 Thread Oleksandr Grytsov
On Wed, Sep 6, 2017 at 12:36 PM, Wei Liu wrote: > On Tue, Sep 05, 2017 at 07:44:34PM +0300, Oleksandr Grytsov wrote: >> On Tue, Sep 5, 2017 at 2:47 PM, Wei Liu wrote: >> > On Tue, Jul 18, 2017 at 05:25:18PM +0300, Oleksandr Grytsov wrote: >> >> From: Olek

Re: [Xen-devel] [PATCH v4 01/13] libxl: add generic function to add device

2017-09-05 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 2:47 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:18PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Add libxl__device_add to simple write XenStore device conifg >> and libxl__device_add_async to update domain configur

Re: [Xen-devel] [PATCH v4 00/13] libxl: add PV display device driver interface

2017-08-31 Thread Oleksandr Grytsov
On Wed, Aug 30, 2017 at 6:52 PM, Ian Jackson wrote: > Oleksandr Grytsov writes ("Re: [PATCH v4 00/13] libxl: add PV display device > driver interface"): >> On Thu, Aug 17, 2017 at 2:11 PM, Wei Liu wrote: >> > I'm still waiting for the outcome from the othe

  1   2   >