Re: [Xen-devel] [PATCH v7] ns16550: Add support for UART parameters to be specifed with name-value pairs

2017-06-01 Thread Paratey, Swapnil
Should I submit a v8 with the "CONFIG_HAS_PCI" macro specifications for the case statements? I apologize for not trying the build for ARM beforehand. Yes please. ~Andrew Should the contents of "enum serial_param_type" and "static const struct serial_param_var __initconst sp_vars[]" also be

Re: [Xen-devel] [PATCH v7] ns16550: Add support for UART parameters to be specifed with name-value pairs

2017-06-01 Thread Paratey, Swapnil
So you may have noticed that I did commit this, but then I had to revert it again, as it breaks the build on ARM. Didn't you need the change specifically for ARM? If so, how come you didn't build test it there? I would be surprised if this change is necessary for ARM as we don't support

Re: [Xen-devel] [PATCH v3] ns16550-Add-command-line-parsing-adjustments

2017-04-17 Thread Paratey, Swapnil
Hi Jan, I have a question about __initconst that you mentioned. On 4/3/2017 6:55 AM, Jan Beulich wrote: On 31.03.17 at 17:42, wrote: The title needs improvement - it doesn't really reflect what the patch does. Add name=value parsing options for com1 and com2 to

Re: [Xen-devel] [PATCH v3] ns16550-Add-command-line-parsing-adjustments

2017-04-10 Thread Paratey, Swapnil
Hi Jan, Thank you very much for your review comments. I need a few clarifications to move forward. On 4/3/2017 6:55 AM, Jan Beulich wrote: On 31.03.17 at 17:42, wrote: The title needs improvement - it doesn't really reflect what the patch does. I apologize for