On Ma, 2017-10-24 at 13:19 +0300, Petre Pircalabu wrote:
> From: Razvan Cojocaru
>
> For the default EPT view we have xc_set_mem_access_multi(), which
> is able to set an array of pages to an array of access rights with
> a single hypercall. However, this functionality was lacking for the
> altp2m
Hi,
I have encountered the following error while building xen ( staging -
9862926902ba035a3741afdf03da40a4d4b57a6f) :
AR libqemuutil.a
/home/pepi/work/xen/tools/qemu-xen-dir/ui/gtk.c: In function ‘gd_menu_copy’:
/home/pepi/work/xen/tools/qemu-xen-dir/ui/gtk.c:1705:5: error:
‘vte_termin
On Vi, 2017-10-13 at 03:51 -0600, Jan Beulich wrote:
> >
> >
> > +BUILD_BUG_ON(sizeof(struct
> > xen_hvm_altp2m_set_mem_access_multi) <
> > + sizeof(struct
> > compat_hvm_altp2m_set_mem_access_multi));
> What good does this do?
> Sorry, I don't understand how t
On Tue, 2017-10-10 at 06:28 -0600, Jan Beulich wrote:
> > > > +typedef struct xen_hvm_altp2m_set_mem_access_multi
> > +xen_hvm_altp2m_set_mem_access_multi_t;
> > +DEFINE_XEN_GUEST_HANDLE(xen_hvm_altp2m_set_mem_access_multi_t);
>
> Are typedef and handle actually needed anywhere? Otherwise
> pl
On Ma, 2017-10-10 at 06:28 -0600, Jan Beulich wrote:> >
> > >
> > > >
> > > > a.u.set_mem_access_multi.pfn_list,
> > + a.u.set_mem_access_multi.acc
> > ess_list,
> > + a.u.set_mem_access_multi.nr,
> > +
On Lu, 2017-10-09 at 04:36 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 09.10.17 at 12:10, wrote:
> > On Vi, 2017-10-06 at 09:34 -0600, Jan Beulich wrote:
> > >
> > > >
> > > > >
> > > > > >
> > > > > > On 05.10.17 at 17:42, wrote:
> > > > +switch ( a.cmd )
> > > > +{
> >
On Vi, 2017-10-06 at 09:34 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 05.10.17 at 17:42, wrote:
> > @@ -4451,6 +4453,7 @@ static int do_altp2m_op(
> > case HVMOP_altp2m_destroy_p2m:
> > case HVMOP_altp2m_switch_p2m:
> > case HVMOP_altp2m_set_mem_access:
> > +case
On Lu, 2017-10-02 at 15:09 +0100, George Dunlap wrote:
> On 10/02/2017 02:43 PM, George Dunlap wrote:
> >
> > On 09/25/2017 01:03 PM, Petre Pircalabu wrote:
> > >
> > > Enforce the distinction between an instruction not implemented by
> > > the
> > > emulator and the failure to emulate that instr
On Jo, 2017-09-21 at 06:42 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 21.09.17 at 07:12, wrote:
> > --- a/xen/arch/x86/x86_emulate/x86_emulate.c
> > +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
> > @@ -6195,7 +6196,7 @@ x86_emulate(
> > /* vpsll{w,d} $imm8,{x,y}mm,{
On Jo, 2017-09-21 at 06:44 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 21.09.17 at 10:57, wrote:
> > > From: Petre Pircalabu [mailto:ppircal...@bitdefender.com]
> > > Sent: 21 September 2017 06:12
> > > --- a/xen/arch/x86/hvm/vmx/realmode.c
> > > +++ b/xen/arch/x86/hvm/vmx/realmode.c
>
On Thu, 2017-09-21 at 08:53 +, Paul Durrant wrote:
> > }
> > +case X86EMUL_UNIMPLEMENTED:
> > +ASSERT_UNREACHABLE();
> > +/* Fall-through */
>
> Kind of surprised you need the fall-through if you assert the code is
> unreachable... but analysis tools can be a bit temper
On Ma, 2017-09-19 at 09:19 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 12.09.17 at 16:32, wrote:
> > Enforce the distinction between an instruction not implemented by
> > the
> > emulator and the failure to emulate that instruction by defining a
> > new
> > return code, X86EMUL_UNIMPLEM
On Ma, 2017-09-19 at 09:22 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 12.09.17 at 16:32, wrote:
> > --- a/xen/arch/x86/hvm/emulate.c
> > +++ b/xen/arch/x86/hvm/emulate.c
> > @@ -2055,7 +2055,7 @@ int hvm_emulate_one_mmio(unsigned long mfn,
> > unsigned long gla)
> > {
> >
On Jo, 2017-09-07 at 09:08 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 07.09.17 at 16:26, wrote:
> > After discussing with Andrew I'm willing to agree with the changes
> > you do here, with one extra requirement: At least on non-debug
> > builds X86EMUL_UNIMPLEMENTED should always re
On Jo, 2017-09-07 at 17:12 +0100, Ian Jackson wrote:
> Petre Ovidiu PIRCALABU writes ("Re: [PATCH v10 1/3] gitignore: add
> local vimrc files"):
> >
> > On Jo, 2017-09-07 at 15:59 +0100, Wei Liu wrote:
> > >
> > > OOI how does this work?
> ...
&g
On Jo, 2017-09-07 at 15:59 +0100, Wei Liu wrote:
> OOI how does this work?
>
> You put a .vimrc under xen.git?
I haven't added the file to the repository, just to .gitignore in order
to mask it from git. It will help me very much to have it upstream
because right now I have to cherry-pick it each t
Hi Tamas,
There are still some loose ends to tie up, but a soon as I will fix
then I will try to upstream my patch.
Best regards,
Petre
On Mi, 2017-09-06 at 09:12 -0600, Tamas K Lengyel wrote:
> On Wed, Sep 6, 2017 at 7:48 AM, Petre Pircalabu
> wrote:
> >
> > This patchset implements a mechan
Reviewed-by: Petre Pircalabu
On Ma, 2017-09-05 at 09:41 +0100, Andrew Cooper wrote:
> Grp7 is abnormally complicated to decode, even by x86's standards,
> with
> {s,l}msw being the problematic cases.
>
> Previously, any value which fell through the first switch statement
> (looking
> for instruct
On Ma, 2017-09-05 at 09:46 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 05.09.17 at 17:23, wrote:
> > On Lu, 2017-09-04 at 23:42 -0600, Jan Beulich wrote:
> > >
> > > >
> > > > >
> > > > >
> > > > > >
> > > > > >
> > > > > > @@ -5177,7 +5177,7 @@ x86_emulate(
> > > > > >
On Lu, 2017-09-04 at 23:42 -0600, Jan Beulich wrote:
> > >
> > > >
> > > > @@ -5177,7 +5177,7 @@ x86_emulate(
> > > > goto done;
> > > > break;
> > > > default:
> > > > -goto cannot_emulate;
> > > > +goto unimplemented_insn;
> > > While
On Vi, 2017-09-01 at 04:33 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 30.08.17 at 20:57, wrote:
> > --- a/xen/arch/x86/hvm/emulate.c
> > +++ b/xen/arch/x86/hvm/emulate.c
> > @@ -2044,6 +2044,7 @@ int hvm_emulate_one_mmio(unsigned long mfn,
> > unsigned long gla)
> Way earlier in this f
ks,
Petre
From: Jan Beulich
Sent: Tuesday, August 22, 2017 11:09 AM
To: Petre Ovidiu PIRCALABU
Cc: rcojoc...@bitdefender.com; andrew.coop...@citrix.com;
paul.durr...@citrix.com; wei.l...@citrix.com; george.dun...@eu.citrix.com;
ian.jack...@eu.citrix.com; jun.nakaj...
Hi Tamas,
I have corrected it and resent the patch.
Thank-you very much for pointing it out,
Petre
On Ma, 2017-07-11 at 23:41 -0600, Tamas K Lengyel wrote:
> On Tue, Jul 11, 2017 at 8:53 AM, Petre Pircalabu
> wrote:
> >
> > If case of a vm_event with the emulate_flags set, if the
> > instruct
On Lu, 2017-07-10 at 12:30 -0600, Tamas K Lengyel wrote:
> On Mon, Jul 10, 2017 at 11:07 AM, Petre Pircalabu
> wrote:
> >
> > If case of a vm_event with the emulate_flags set, if the
> > instruction
> > cannot be emulated, the monitor should be notified instead of
> > directly
> > injecting a hw e
Hello,
Any comments for this series?
Thanks,
Petre
On Ma, 2017-05-30 at 12:46 +0300, Petre Pircalabu wrote:
> This patchset enables masking the reception of write_ctrlreg events
> depending
> on the value of certain bits in that register.
> The most representative example is filtering out event
25 matches
Mail list logo
