Re: [Xen-devel] [PATCH v3 1/2] efi: Fix allocation problems if ExitBootServices() fails

2015-06-01 Thread Roy Franz
hange looks ok to me, what do you think? Yeah, this should be fine. Most EFI allocations have page-size granularity within the firmware, so there wasn't much point doing something smaller. I haven't actually used firmware that changed the memmap size on ExitBootServices, so that size wa

Re: [Xen-devel] [PATCH 2/4] EFI/early: add /mapbs to map EfiBootServices{Code, Data}

2015-06-10 Thread Roy Franz
On Wed, Jun 10, 2015 at 2:37 AM, Jan Beulich wrote: On 10.06.15 at 11:26, wrote: >> On Wed, 2015-06-10 at 10:15 +0100, Jan Beulich wrote: >>> >>> On 10.06.15 at 10:56, wrote: >>> > On Tue, 2015-06-09 at 14:53 +0100, Jan Beulich wrote: >>> >> From: Konrad Rzeszutek Wilk >>> >> >>> >> To hel

Re: [Xen-devel] [PATCH 2/4] EFI/early: add /mapbs to map EfiBootServices{Code, Data}

2015-06-10 Thread Roy Franz
On Wed, Jun 10, 2015 at 11:12 AM, Andrew Cooper wrote: > On 10/06/15 18:22, Roy Franz wrote: >> >>>> I read it backwards and thought this was currently excluding them like >>>> x86 does. >>>> >>>> Am I correct that the stricter x86

Re: [Xen-devel] [PATCH 2/4] EFI/early: add /mapbs to map EfiBootServices{Code, Data}

2015-06-11 Thread Roy Franz
t treat EfiBootServices{Code,Data} as normal RAM under /mapbs > > Signed-off-by: Jan Beulich > > --- a/xen/arch/arm/efi/efi-boot.h > +++ b/xen/arch/arm/efi/efi-boot.h > @@ -131,9 +131,10 @@ static EFI_STATUS __init efi_process_mem > > for ( Index = 0; Index < (mmap_size

Re: [Xen-devel] [PATCH RFC] EFI: allow retry of ExitBootServices() call

2014-11-14 Thread Roy Franz
should be found as it got added in the 1st pass, > - the various "linux,uefi-*" nodes all got added during the 1st pass > and hence only their contents may get updated. > > Signed-off-by: Jan Beulich Reviewed-by: Roy Franz I built and tested this, however since my firm

Re: [Xen-devel] A few EFI code questions

2014-12-04 Thread Roy Franz
On Thu, Dec 4, 2014 at 1:35 AM, Jan Beulich wrote: On 03.12.14 at 22:02, wrote: >> Hey, >> >> 1) Why is there in EFI code so many functions (e.g. efi_start(), >>efi_arch_edd(), ...) with local variables declared as a static? >>Though some of them have also regular local variables. I

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-02 Thread Roy Franz
On Mon, Mar 2, 2015 at 9:21 AM, Stefano Stabellini wrote: > On Fri, 30 Jan 2015, Daniel Kiper wrote: >> We need more fine grained knowledge about EFI environment and check >> for EFI platform and EFI loader separately to properly support >> multiboot2 protocol. In general Xen loaded by this protoc

Re: [Xen-devel] [PATCH 17/18] x86/efi: create new early memory allocator

2015-03-02 Thread Roy Franz
On Mon, Mar 2, 2015 at 9:23 AM, Jan Beulich wrote: On 30.01.15 at 18:54, wrote: >> --- a/xen/arch/x86/efi/efi-boot.h >> +++ b/xen/arch/x86/efi/efi-boot.h >> @@ -103,9 +103,35 @@ static void __init relocate_trampoline(unsigned long >> phys) >> *(u16 *)(*trampoline_ptr + (long)trampo

Re: [Xen-devel] [PATCH 05/18] efi: split efi_enabled to efi_platform and efi_loader

2015-03-02 Thread Roy Franz
On Mon, Mar 2, 2015 at 10:43 AM, Roy Franz wrote: > On Mon, Mar 2, 2015 at 9:21 AM, Stefano Stabellini > wrote: >> On Fri, 30 Jan 2015, Daniel Kiper wrote: >>> We need more fine grained knowledge about EFI environment and check >>> for EFI platform and EFI loader