Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2015-01-13 Thread Samuel Thibault
Ian Campbell, le Tue 13 Jan 2015 11:01:06 +, a écrit : > Applied, thanks. BTW, it is perhaps worth backporting to previous versions of Xen. Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2015-01-13 Thread Ian Campbell
On Mon, 2014-12-15 at 00:59 +0100, Samuel Thibault wrote: > Martin Lucina, le Thu 11 Dec 2014 13:10:00 +0100, a écrit : > > I've done this in the updated patch, take a look and let me know what you > > think. > > I like that :) > > > From 3880f59159bf0a05b47b6e723091b1e7e4fb6814 Mon Sep 17 00:00:

Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2014-12-15 Thread Martin Lucina
samuel.thiba...@ens-lyon.org said: > > From: Martin Lucina > > Date: Thu, 4 Dec 2014 14:33:53 +0100 > > Subject: [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx > > > > In network_rx() we must push the same amount of requests back onto the > > ring in the second loop that we consu

Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2014-12-14 Thread Samuel Thibault
Martin Lucina, le Thu 11 Dec 2014 13:10:00 +0100, a écrit : > I've done this in the updated patch, take a look and let me know what you > think. I like that :) > From 3880f59159bf0a05b47b6e723091b1e7e4fb6814 Mon Sep 17 00:00:00 2001 > From: Martin Lucina > Date: Thu, 4 Dec 2014 14:33:53 +0100 >

Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2014-12-11 Thread Martin Lucina
mar...@lucina.net said: > Rather, shouldn't the final if() in the loop (where data is sent up) be: > > if(rx->status > NETIF_RSP_NULL) { ... } > > *we can't use NETIF_RSP_OKAY as NETIF_RSP_NULL is defined to be 1 (yuck). > > I don't see any value in keeping the printk(), the netfront driver al

Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2014-12-11 Thread Martin Lucina
Hi Samuel, Comments and updated patch below. samuel.thiba...@ens-lyon.org said: > > -if (rx->flags & NETRXF_extra_info) > > -{ > > -printk("+ we have extras!\n"); > > -continue; > > -} > > - > > - > > -if (rx->status == N

Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2014-12-07 Thread Samuel Thibault
Hello, Martin Lucina, le Thu 04 Dec 2014 14:55:50 +0100, a écrit : > following is a patch against vanilla Mini-OS in upstream xen.git for a > problem we have found in the netfront driver. When subjected to load > network receive would freeze due to the rx ring running out of free > request slots.

[Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

2014-12-04 Thread Martin Lucina
Hi, following is a patch against vanilla Mini-OS in upstream xen.git for a problem we have found in the netfront driver. When subjected to load network receive would freeze due to the rx ring running out of free request slots. With this patch a httpd running on rumprun-xen [1] survives all the lo