Re: [Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Jan Beulich
>>> On 12.04.17 at 05:56, wrote: > On Wed, Apr 12, 2017 at 04:32:06AM -0600, Jan Beulich wrote: > On 12.04.17 at 04:41, wrote: >>> On Wed, Apr 12, 2017 at 02:57:23AM -0600, Jan Beulich wrote: >>> On 12.04.17 at 02:04, wrote: > + * If a caller want an atomic update from the vi

Re: [Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Jan Beulich
>>> On 12.04.17 at 12:58, wrote: > On 12/04/17 09:57, Jan Beulich wrote: > On 12.04.17 at 02:04, wrote: >>> --- a/xen/drivers/passthrough/vtd/intremap.c >>> +++ b/xen/drivers/passthrough/vtd/intremap.c >>> @@ -200,8 +200,9 @@ static void update_irte(struct iommu *iommu, struct >>> iremap_ent

Re: [Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Chao Gao
On Wed, Apr 12, 2017 at 04:32:06AM -0600, Jan Beulich wrote: On 12.04.17 at 04:41, wrote: >> On Wed, Apr 12, 2017 at 02:57:23AM -0600, Jan Beulich wrote: >> On 12.04.17 at 02:04, wrote: + * If a caller want an atomic update from the views of VT-d >>> >>>wants >>> >>>Also wha

Re: [Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Andrew Cooper
On 12/04/17 09:57, Jan Beulich wrote: On 12.04.17 at 02:04, wrote: >> --- a/xen/drivers/passthrough/vtd/intremap.c >> +++ b/xen/drivers/passthrough/vtd/intremap.c >> @@ -200,8 +200,9 @@ static void update_irte(struct iommu *iommu, struct >> iremap_entry *entry, >> else >> { >>

Re: [Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Jan Beulich
>>> On 12.04.17 at 04:41, wrote: > On Wed, Apr 12, 2017 at 02:57:23AM -0600, Jan Beulich wrote: > On 12.04.17 at 02:04, wrote: >>> + * If a caller want an atomic update from the views of VT-d >> >>wants >> >>Also what do you mean by "from the views of VT-d"? > > OK. will fix this too

Re: [Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Chao Gao
On Wed, Apr 12, 2017 at 02:57:23AM -0600, Jan Beulich wrote: On 12.04.17 at 02:04, wrote: >> --- a/xen/drivers/passthrough/vtd/intremap.c >> +++ b/xen/drivers/passthrough/vtd/intremap.c >> @@ -200,8 +200,9 @@ static void update_irte(struct iommu *iommu, struct >> iremap_entry *entry, >>

Re: [Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Jan Beulich
>>> On 12.04.17 at 02:04, wrote: > --- a/xen/drivers/passthrough/vtd/intremap.c > +++ b/xen/drivers/passthrough/vtd/intremap.c > @@ -200,8 +200,9 @@ static void update_irte(struct iommu *iommu, struct > iremap_entry *entry, > else > { > /* > - * If the caller requests a

[Xen-devel] [PATCH] VT-d: correct a comment and remove useless if() statement

2017-04-12 Thread Chao Gao
fix two flaws in the patch (93358e8e VT-d: introduce update_irte to update irte safely). Signed-off-by: Chao Gao --- xen/drivers/passthrough/vtd/intremap.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthroug