Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

>>> On 08.11.17 at 16:44, wrote: > On 11/7/2017 8:40 AM, Jan Beulich wrote: > On 06.11.17 at 18:48, wrote: >>> --- a/Documentation/ABI/testing/sysfs-driver-pciback >>> +++ b/Documentation/ABI/testing/sysfs-driver-pciback >>> @@ -11,3 +11,15

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

Thanks Pasi for your response. Please see below for my comments. On 11/8/2017 11:38 AM, Pasi Kärkkäinen wrote: Hi, On Wed, Nov 08, 2017 at 09:44:48AM -0600, Govinda Tatti wrote: Thanks Jan for your review comments. Please see below for my comments. On 11/7/2017 8:40 AM, Jan Beulich wrote:

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

Hi, On Wed, Nov 08, 2017 at 09:44:48AM -0600, Govinda Tatti wrote: > Thanks Jan for your review comments. Please see below for my comments. > > On 11/7/2017 8:40 AM, Jan Beulich wrote: > On 06.11.17 at 18:48, wrote: > >>---

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

Thanks Jan for your review comments. Please see below for my comments. On 11/7/2017 8:40 AM, Jan Beulich wrote: On 06.11.17 at 18:48, wrote: --- a/Documentation/ABI/testing/sysfs-driver-pciback +++ b/Documentation/ABI/testing/sysfs-driver-pciback @@ -11,3 +11,15 @@

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

On 11/8/2017 9:09 AM, Juergen Gross wrote: On 08/11/17 16:00, Govinda Tatti wrote: Thanks Roger for your review comments. Please see below for my comments. On 11/7/2017 5:21 AM, Roger Pau Monné wrote: On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: +out: +    if (!err) + 

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

On 08/11/17 16:00, Govinda Tatti wrote: > Thanks Roger for your review comments. Please see below for my comments. > > On 11/7/2017 5:21 AM, Roger Pau Monné wrote: >> On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: >>> +out: >>> +    if (!err) >>> +    err = count; >>> + >>> +  

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

Thanks Roger for your review comments. Please see below for my comments. On 11/7/2017 5:21 AM, Roger Pau Monné wrote: On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: The life-cycle of a PCI device in Xen pciback is complex and is constrained by the generic PCI locking mechanism.

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

>>> On 06.11.17 at 18:48, wrote: > --- a/Documentation/ABI/testing/sysfs-driver-pciback > +++ b/Documentation/ABI/testing/sysfs-driver-pciback > @@ -11,3 +11,15 @@ Description: > #echo 00:19.0-E0:2:FF > /sys/bus/pci/drivers/pciback/quirks >

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

On Mon, Nov 06, 2017 at 12:48:42PM -0500, Govinda Tatti wrote: > The life-cycle of a PCI device in Xen pciback is complex and is constrained > by the generic PCI locking mechanism. > > - It starts with the device being bound to us, for which we do a function > reset (done via SysFS so the PCI

[Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

The life-cycle of a PCI device in Xen pciback is complex and is constrained by the generic PCI locking mechanism. - It starts with the device being bound to us, for which we do a function reset (done via SysFS so the PCI lock is held). - If the device is unbound from us, we also do a function