Re: [Xen-devel] [PATCH] XenPvBlk: handle empty cdrom drives

2015-10-21 Thread Stefano Stabellini
I just want to say that this is one of the best reviews I have ever received, very clear and useful. Thanks Laszlo! On Tue, 20 Oct 2015, Laszlo Ersek wrote: > (1) Please make the subject line say: > > OvmfPkg: XenPvBlkDxe: handle empty cdrom drives > > On 10/20/15 17:03, Stefano Stabellini wro

Re: [Xen-devel] [PATCH] XenPvBlk: handle empty cdrom drives

2015-10-20 Thread Laszlo Ersek
(1) Please make the subject line say: OvmfPkg: XenPvBlkDxe: handle empty cdrom drives On 10/20/15 17:03, Stefano Stabellini wrote: > Empty cdroms are not going to connect, avoid waiting for the backend to > switch to state 4, which is never going to happen, and return > EFI_NO_MEDIA instead. (

[Xen-devel] [PATCH] XenPvBlk: handle empty cdrom drives

2015-10-20 Thread Stefano Stabellini
Empty cdroms are not going to connect, avoid waiting for the backend to switch to state 4, which is never going to happen, and return EFI_NO_MEDIA instead. Detect an empty cdrom by looking at the "params" node on xenstore, which is set to "" or "aio:" for empty drives by libxl. Contributed-under: