Re: [Xen-devel] [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported

2014-12-04 Thread Ian Campbell
On Tue, 2014-12-02 at 13:43 -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 02, 2014 at 04:04:44PM +, Wei Liu wrote: > > On Tue, Dec 02, 2014 at 04:18:08PM +0100, Vitaly Kuznetsov wrote: > > > XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has > > > strange interface: i

Re: [Xen-devel] [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported

2014-12-02 Thread Konrad Rzeszutek Wilk
On Tue, Dec 02, 2014 at 04:04:44PM +, Wei Liu wrote: > On Tue, Dec 02, 2014 at 04:18:08PM +0100, Vitaly Kuznetsov wrote: > > XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has > > strange interface: it reports first domain which has domid >= requested > > domid > > so al

Re: [Xen-devel] [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported

2014-12-02 Thread Andrew Cooper
On 02/12/14 15:18, Vitaly Kuznetsov wrote: > XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has > strange interface: it reports first domain which has domid >= requested domid > so all callers are supposed to check that the proper domain(s) was queried > by checking domid. xc

Re: [Xen-devel] [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported

2014-12-02 Thread Wei Liu
On Tue, Dec 02, 2014 at 04:18:08PM +0100, Vitaly Kuznetsov wrote: > XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has > strange interface: it reports first domain which has domid >= requested domid > so all callers are supposed to check that the proper domain(s) was queried

Re: [Xen-devel] [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported

2014-12-02 Thread Don Slutz
On 12/02/14 10:18, Vitaly Kuznetsov wrote: XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has strange interface: it reports first domain which has domid >= requested domid so all callers are supposed to check that the proper domain(s) was queried by checking domid. xc_get_t

[Xen-devel] [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported

2014-12-02 Thread Vitaly Kuznetsov
XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has strange interface: it reports first domain which has domid >= requested domid so all callers are supposed to check that the proper domain(s) was queried by checking domid. xc_get_tot_pages() doesn't do that. In case the reque