Re: [Xen-devel] [PATCH] libxl: Use libxl_strdup instead of strdup on libxl_version_info

2016-01-15 Thread Ian Campbell
On Thu, 2016-01-14 at 22:03 -0500, Konrad Rzeszutek Wilk wrote: > On January 14, 2016 9:33:49 PM EST, Konrad Rzeszutek Wilk acle.com> wrote: > > As the libxl_strdup allows us to unwind and free all > > of the allocations, while strdup requires the callers > > to remember to free

[Xen-devel] [PATCH] libxl: Use libxl_strdup instead of strdup on libxl_version_info

2016-01-14 Thread Konrad Rzeszutek Wilk
As the libxl_strdup allows us to unwind and free all of the allocations, while strdup requires the callers to remember to free (which they didn't seem too). Suggested-by: Wei Liu Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxl/libxl.c | 16

Re: [Xen-devel] [PATCH] libxl: Use libxl_strdup instead of strdup on libxl_version_info

2016-01-14 Thread Konrad Rzeszutek Wilk
On January 14, 2016 9:33:49 PM EST, Konrad Rzeszutek Wilk wrote: >As the libxl_strdup allows us to unwind and free all >of the allocations, while strdup requires the callers >to remember to free (which they didn't seem too). > Gr.. Ignore it pls. I cherry picked it