Re: [Xen-devel] [PATCH] rangeset: has and is functions return boolean

2015-06-09 Thread Jan Beulich
On 09.06.15 at 11:00, ian.campb...@citrix.com wrote: On Tue, 2015-06-09 at 09:47 +0100, Jan Beulich wrote: Additionally rangeset_is_empty()'s sole parameter can be const. Isn't that true of all/most of the others touched here too? (Once the underlying range_* list manipulations are made

[Xen-devel] [PATCH] rangeset: has and is functions return boolean

2015-06-09 Thread Jan Beulich
Additionally rangeset_is_empty()'s sole parameter can be const. Signed-off-by: Jan Beulich jbeul...@suse.com --- a/xen/common/rangeset.c +++ b/xen/common/rangeset.c @@ -248,11 +248,11 @@ int rangeset_remove_range( return rc; } -int rangeset_contains_range( +bool_t

Re: [Xen-devel] [PATCH] rangeset: has and is functions return boolean

2015-06-09 Thread Dario Faggioli
On Tue, 2015-06-09 at 09:47 +0100, Jan Beulich wrote: Additionally rangeset_is_empty()'s sole parameter can be const. Signed-off-by: Jan Beulich jbeul...@suse.com Reviewed-by: Dario Faggioli dario.faggi...@citrix.com Regards, Dario -- This happens because I choose it to happen! (Raistlin

Re: [Xen-devel] [PATCH] rangeset: has and is functions return boolean

2015-06-09 Thread Ian Campbell
On Tue, 2015-06-09 at 09:47 +0100, Jan Beulich wrote: Additionally rangeset_is_empty()'s sole parameter can be const. Isn't that true of all/most of the others touched here too? (Once the underlying range_* list manipulations are made const correct). If you do decide to go further then there is