Re: [Xen-devel] [PATCH] remove dead code from arm/decode.c

2016-12-13 Thread Stefano Stabellini
On Tue, 13 Dec 2016, Julien Grall wrote: > Hi Stefano, > > On 10/12/16 01:31, Stefano Stabellini wrote: > > The rt variable can only be 0 or 7, no need to check if it's 15. > > Be careful, Coverity may point to dead code but it does not mean that deleting > it is the right thing to do. The code w

Re: [Xen-devel] [PATCH] remove dead code from arm/decode.c

2016-12-13 Thread Julien Grall
Hi Stefano, On 10/12/16 01:31, Stefano Stabellini wrote: The rt variable can only be 0 or 7, no need to check if it's 15. Be careful, Coverity may point to dead code but it does not mean that deleting it is the right thing to do. The code which lead to this conclusion may be invalid. In this

[Xen-devel] [PATCH] remove dead code from arm/decode.c

2016-12-09 Thread Stefano Stabellini
The rt variable can only be 0 or 7, no need to check if it's 15. Coverity-ID: 1381835 Signed-off-by: Stefano Stabellini diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c index c6f49a5..decd9dd 100644 --- a/xen/arch/arm/decode.c +++ b/xen/arch/arm/decode.c @@ -58,11 +58,6 @@ static int