Re: [Xen-devel] [PATCH] tools: make FLASK utils build unconditional

2016-01-18 Thread Ian Campbell
On Fri, 2016-01-15 at 19:48 +, Andrew Cooper wrote: > On 15/01/16 17:39, Doug Goldstein wrote: > > The flask utilities only have dependencies on libxc so there's no > > downside to always building it. Distros and projects based on Xen can > > put these in a different package to not install them

Re: [Xen-devel] [PATCH] tools: make FLASK utils build unconditional

2016-01-15 Thread Andrew Cooper
On 15/01/16 17:39, Doug Goldstein wrote: > The flask utilities only have dependencies on libxc so there's no > downside to always building it. Distros and projects based on Xen can > put these in a different package to not install them for all users. > Prior to this change FLASK_ENABLE needed to be

[Xen-devel] [PATCH] tools: make FLASK utils build unconditional

2016-01-15 Thread Doug Goldstein
The flask utilities only have dependencies on libxc so there's no downside to always building it. Distros and projects based on Xen can put these in a different package to not install them for all users. Prior to this change FLASK_ENABLE needed to be set at the top level to build the utilities and

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-12 Thread Wei Liu
On Mon, Jan 11, 2016 at 11:10:35AM -0600, Doug Goldstein wrote: > On 1/11/16 9:19 AM, Wei Liu wrote: > > On Fri, Jan 08, 2016 at 12:49:07PM -0600, Doug Goldstein wrote: > > [...] > >> Ok so I'm at a loss what steps I need to take. I've submitted patches to > >> put the config in /boot so that this

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-11 Thread Doug Goldstein
On 1/11/16 9:19 AM, Wei Liu wrote: > On Fri, Jan 08, 2016 at 12:49:07PM -0600, Doug Goldstein wrote: > [...] >> Ok so I'm at a loss what steps I need to take. I've submitted patches to >> put the config in /boot so that this check can be made but there's a >> disagreement if that's even necessary o

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-11 Thread Wei Liu
On Fri, Jan 08, 2016 at 12:49:07PM -0600, Doug Goldstein wrote: [...] > Ok so I'm at a loss what steps I need to take. I've submitted patches to > put the config in /boot so that this check can be made but there's a > disagreement if that's even necessary or not. > That's a bit unfortunate. :-(

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-08 Thread Doug Goldstein
On 1/5/16 10:42 AM, Wei Liu wrote: > On Tue, Jan 05, 2016 at 04:24:19PM +, Ian Campbell wrote: >> On Tue, 2016-01-05 at 16:13 +, Wei Liu wrote: >>> On Tue, Jan 05, 2016 at 03:36:21PM +, Ian Campbell wrote: On Tue, 2016-01-05 at 14:37 +, Ian Campbell wrote: > > which on

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-05 Thread Ian Campbell
On Tue, 2016-01-05 at 10:34 -0600, Doug Goldstein wrote: > On 1/5/16 10:13 AM, Wei Liu wrote: > > On Tue, Jan 05, 2016 at 03:36:21PM +, Ian Campbell wrote: > > > On Tue, 2016-01-05 at 14:37 +, Ian Campbell wrote: > > > > > > > > which on the basis of this discussion I wasn't expecting. I d

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-05 Thread Wei Liu
On Tue, Jan 05, 2016 at 04:24:19PM +, Ian Campbell wrote: > On Tue, 2016-01-05 at 16:13 +, Wei Liu wrote: > > On Tue, Jan 05, 2016 at 03:36:21PM +, Ian Campbell wrote: > > > On Tue, 2016-01-05 at 14:37 +, Ian Campbell wrote: > > > > > > > > which on the basis of this discussion I w

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-05 Thread Doug Goldstein
On 1/5/16 10:13 AM, Wei Liu wrote: > On Tue, Jan 05, 2016 at 03:36:21PM +, Ian Campbell wrote: >> On Tue, 2016-01-05 at 14:37 +, Ian Campbell wrote: >>> >>> which on the basis of this discussion I wasn't expecting. I didn't see this >>> new file on i686 or ARM*. >>> >>> My baseline is from

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-05 Thread Ian Campbell
On Tue, 2016-01-05 at 16:13 +, Wei Liu wrote: > On Tue, Jan 05, 2016 at 03:36:21PM +, Ian Campbell wrote: > > On Tue, 2016-01-05 at 14:37 +, Ian Campbell wrote: > > > > > > which on the basis of this discussion I wasn't expecting. I didn't > > > see this > > > new file on i686 or ARM*.

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-05 Thread Wei Liu
On Tue, Jan 05, 2016 at 03:36:21PM +, Ian Campbell wrote: > On Tue, 2016-01-05 at 14:37 +, Ian Campbell wrote: > > > > which on the basis of this discussion I wasn't expecting. I didn't see this > > new file on i686 or ARM*. > > > > My baseline is from the last time I committed, which wou

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-05 Thread Ian Campbell
On Tue, 2016-01-05 at 14:37 +, Ian Campbell wrote: > > which on the basis of this discussion I wasn't expecting. I didn't see this > new file on i686 or ARM*. > > My baseline is from the last time I committed, which would be last year, so > maybe something other than my current batch of patch

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-05 Thread Ian Campbell
On Mon, 2016-01-04 at 14:26 +, Wei Liu wrote: > On Mon, Jan 04, 2016 at 08:14:23AM -0600, Doug Goldstein wrote: > > On 1/4/16 6:28 AM, Wei Liu wrote: > > > On Mon, Dec 21, 2015 at 10:46:43PM -0600, Doug Goldstein wrote: > > > > The flask utilities only have dependencies on libxc so there's no >

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-04 Thread Wei Liu
On Mon, Jan 04, 2016 at 08:14:23AM -0600, Doug Goldstein wrote: > On 1/4/16 6:28 AM, Wei Liu wrote: > > On Mon, Dec 21, 2015 at 10:46:43PM -0600, Doug Goldstein wrote: > >> The flask utilities only have dependencies on libxc so there's no > >> downside to always building it. Distros and projects ba

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-04 Thread Doug Goldstein
On 1/4/16 6:28 AM, Wei Liu wrote: > On Mon, Dec 21, 2015 at 10:46:43PM -0600, Doug Goldstein wrote: >> The flask utilities only have dependencies on libxc so there's no >> downside to always building it. Distros and projects based on Xen can >> put these utilities into a different package and not i

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2016-01-04 Thread Wei Liu
On Mon, Dec 21, 2015 at 10:46:43PM -0600, Doug Goldstein wrote: > The flask utilities only have dependencies on libxc so there's no > downside to always building it. Distros and projects based on Xen can > put these utilities into a different package and not install them for > everyone. Prior to th

Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional

2015-12-22 Thread Andrew Cooper
On 22/12/15 04:46, Doug Goldstein wrote: > The flask utilities only have dependencies on libxc so there's no > downside to always building it. Distros and projects based on Xen can > put these utilities into a different package and not install them for > everyone. Prior to this change FLASK_ENABLE

[Xen-devel] [PATCH] tools: make flask utils build unconditional

2015-12-21 Thread Doug Goldstein
The flask utilities only have dependencies on libxc so there's no downside to always building it. Distros and projects based on Xen can put these utilities into a different package and not install them for everyone. Prior to this change FLASK_ENABLE needs to be a top level variable however after th