Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Stefano Stabellini
On Wed, 1 Feb 2017, Jan Beulich wrote: > >>> On 31.01.17 at 20:59, wrote: > > The parameter to compat_dm_op() is a pointer to an array of > > compat_dm_op_buf_t's in guest RAM. > > > > Signed-off-by: Andrew Cooper > > Reviewed-by: Jan Beulich > with one question (see below). > > > What is the

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Andrew Cooper
On 01/02/17 10:46, Jan Beulich wrote: On 31.01.17 at 20:59, wrote: >> What is the pupose of COMPAT_HANDLE_PARAM()? It is a packed structure of one >> and a half pointers, so isn't safe at all for use in the hypercall function >> APIs (depsite its naming making it look deceptively like it is t

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Jan Beulich
>>> On 31.01.17 at 20:59, wrote: > What is the pupose of COMPAT_HANDLE_PARAM()? It is a packed structure of one > and a half pointers, so isn't safe at all for use in the hypercall function > APIs (depsite its naming making it look deceptively like it is the correct > thing to use). Btw, where ar

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Jan Beulich
>>> On 31.01.17 at 20:59, wrote: > The parameter to compat_dm_op() is a pointer to an array of > compat_dm_op_buf_t's in guest RAM. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with one question (see below). > What is the pupose of COMPAT_HANDLE_PARAM()? It is a packed structure

Re: [Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-02-01 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 31 January 2017 19:59 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Paul Durrant ; Ian Jackson > ; Wei Liu > Subject: [PATCH] x86/dmop: Fix compat_dm_op() ABI > > The parameter to compat_dm_op()

[Xen-devel] [PATCH] x86/dmop: Fix compat_dm_op() ABI

2017-01-31 Thread Andrew Cooper
The parameter to compat_dm_op() is a pointer to an array of compat_dm_op_buf_t's in guest RAM. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Paul Durrant CC: Ian Jackson CC: Wei Liu What is the pupose of COMPAT_HANDLE_PARAM()? It is a packed structure of one and a half pointers, so is