Re: [Xen-devel] [PATCH] xen/Coverity: Audit of MISSING_BREAK defects

2015-02-13 Thread Andrew Cooper
On 12/02/15 21:06, Don Koch wrote: On Thu, 12 Feb 2015 20:08:46 + Andrew Cooper andrew.coop...@citrix.com wrote: Coverity uses several heuristics to identify when one case statement legitimately falls through into the next, and a comment as the final item in a case statement is one

Re: [Xen-devel] [PATCH] xen/Coverity: Audit of MISSING_BREAK defects

2015-02-13 Thread Don Koch
On Fri, 13 Feb 2015 11:01:27 + Andrew Cooper andrew.coop...@citrix.com wrote: On 12/02/15 21:06, Don Koch wrote: On Thu, 12 Feb 2015 20:08:46 + Andrew Cooper andrew.coop...@citrix.com wrote: [...] I'm surprised that coverity didn't complain about the fallthrough in the next

[Xen-devel] [PATCH] xen/Coverity: Audit of MISSING_BREAK defects

2015-02-12 Thread Andrew Cooper
Coverity uses several heuristics to identify when one case statement legitimately falls through into the next, and a comment as the final item in a case statement is one heuristic (the assumption being that it is a justification for the fallthrough). Use this to perform an audit of defects and

Re: [Xen-devel] [PATCH] xen/Coverity: Audit of MISSING_BREAK defects

2015-02-12 Thread Don Koch
On Thu, 12 Feb 2015 20:08:46 + Andrew Cooper andrew.coop...@citrix.com wrote: Coverity uses several heuristics to identify when one case statement legitimately falls through into the next, and a comment as the final item in a case statement is one heuristic (the assumption being that it is