Re: [Xen-devel] [PATCH] xen/HVM: Add guarding logic for VMX specific code

2016-08-29 Thread Konrad Rzeszutek Wilk
On Mon, Aug 29, 2016 at 07:01:23AM -0500, Suravee Suthikulpanit wrote: > The struct hvm_domain.vmx is defined in a union along with the svm. > This can causes issue for SVM since this code is used in the common You scared me with the 'can causes'! Digging in the pahole output - it It can't cause

[Xen-devel] [PATCH] xen/HVM: Add guarding logic for VMX specific code

2016-08-29 Thread Suravee Suthikulpanit
The struct hvm_domain.vmx is defined in a union along with the svm. This can causes issue for SVM since this code is used in the common scheduling code for x86. The logic must check for cpu_has_vmx before accessing the hvm_domain.vmx sturcture. Signed-off-by: Suravee Suthikulpanit Cc: Wei Liu Cc