Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-18 Thread Doug Goldstein
On 1/18/17 12:04 PM, Andrew Cooper wrote: > Last time I tried LTO: > > * The GCC build did work, but the net binary was bigger rather than > smaller, and it successfully boot > * The Clang build worked, made a much smaller binary, but due to a clang > bug, "optimised" code into using SSE, and

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-18 Thread Andrew Cooper
On 18/01/17 16:30, Wei Liu wrote: > On Wed, Jan 18, 2017 at 04:21:06PM +, Roger Pau Monné wrote: >> On Wed, Jan 18, 2017 at 11:10:40AM -0500, Konrad Rzeszutek Wilk wrote: >>> On Wed, Jan 18, 2017 at 10:13:34AM +, Roger Pau Monné wrote: On Tue, Jan 17, 2017 at 03:46:30PM -0500, Konrad

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-18 Thread Wei Liu
On Wed, Jan 18, 2017 at 04:21:06PM +, Roger Pau Monné wrote: > On Wed, Jan 18, 2017 at 11:10:40AM -0500, Konrad Rzeszutek Wilk wrote: > > On Wed, Jan 18, 2017 at 10:13:34AM +, Roger Pau Monné wrote: > > > On Tue, Jan 17, 2017 at 03:46:30PM -0500, Konrad Rzeszutek Wilk wrote: > > > > > > Is

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-18 Thread Roger Pau Monné
On Wed, Jan 18, 2017 at 11:10:40AM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Jan 18, 2017 at 10:13:34AM +, Roger Pau Monné wrote: > > On Tue, Jan 17, 2017 at 03:46:30PM -0500, Konrad Rzeszutek Wilk wrote: > > > > > Is this patch of yours that neccessary? Could at least some of the > > > >

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-18 Thread Konrad Rzeszutek Wilk
On Wed, Jan 18, 2017 at 10:13:34AM +, Roger Pau Monné wrote: > On Tue, Jan 17, 2017 at 03:46:30PM -0500, Konrad Rzeszutek Wilk wrote: > > > > Is this patch of yours that neccessary? Could at least some of the > > > > functions still exist? > > > > > > Well. This patch is manually doing what

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-18 Thread Roger Pau Monné
On Tue, Jan 17, 2017 at 03:46:30PM -0500, Konrad Rzeszutek Wilk wrote: > > > Is this patch of yours that neccessary? Could at least some of the > > > functions still exist? > > > > Well. This patch is manually doing what LTO would do automatically when > > it has a cross-translation-unit view of

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-17 Thread Konrad Rzeszutek Wilk
> > Is this patch of yours that neccessary? Could at least some of the > > functions still exist? > > Well. This patch is manually doing what LTO would do automatically when > it has a cross-translation-unit view of things, and come to the > conclusion that in all cases, inlining cross-unit will

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-17 Thread Andrew Cooper
On 17/01/17 19:00, Konrad Rzeszutek Wilk wrote: > On Tue, Jan 17, 2017 at 01:42:54PM -0500, Konrad Rzeszutek Wilk wrote: >> On Tue, Jan 17, 2017 at 06:16:36PM +, Andrew Cooper wrote: >>> On 17/01/17 18:05, Konrad Rzeszutek Wilk wrote: On Mon, Jan 16, 2017 at 01:04:09PM +, Andrew

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-17 Thread Konrad Rzeszutek Wilk
On Tue, Jan 17, 2017 at 01:42:54PM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Jan 17, 2017 at 06:16:36PM +, Andrew Cooper wrote: > > On 17/01/17 18:05, Konrad Rzeszutek Wilk wrote: > > > On Mon, Jan 16, 2017 at 01:04:09PM +, Andrew Cooper wrote: > > >> The chageset/version/compile

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-17 Thread Konrad Rzeszutek Wilk
On Tue, Jan 17, 2017 at 06:16:36PM +, Andrew Cooper wrote: > On 17/01/17 18:05, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 16, 2017 at 01:04:09PM +, Andrew Cooper wrote: > >> The chageset/version/compile information is currently exported as a set of > >> function calls into a separate

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-17 Thread Andrew Cooper
On 17/01/17 18:05, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 16, 2017 at 01:04:09PM +, Andrew Cooper wrote: >> The chageset/version/compile information is currently exported as a set of >> function calls into a separate translation unit, which is inefficient for all >> callers. >> >> Replace

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-17 Thread Konrad Rzeszutek Wilk
On Mon, Jan 16, 2017 at 01:04:09PM +, Andrew Cooper wrote: > The chageset/version/compile information is currently exported as a set of > function calls into a separate translation unit, which is inefficient for all > callers. > > Replace the function calls with externs pointing appropriately

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-16 Thread Doug Goldstein
On 1/16/17 8:04 AM, Andrew Cooper wrote: > The chageset/version/compile information is currently exported as a set of > function calls into a separate translation unit, which is inefficient for all > callers. > > Replace the function calls with externs pointing appropriately into .rodata, > which

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-16 Thread Stefano Stabellini
On Mon, 16 Jan 2017, Andrew Cooper wrote: > The chageset/version/compile information is currently exported as a set of > function calls into a separate translation unit, which is inefficient for all > callers. > > Replace the function calls with externs pointing appropriately into .rodata, >

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-16 Thread Andrew Cooper
On 16/01/17 13:18, Jan Beulich wrote: On 16.01.17 at 14:04, wrote: >> The chageset/version/compile information is currently exported as a set of >> function calls into a separate translation unit, which is inefficient for all >> callers. >> >> Replace the function

Re: [Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-16 Thread Jan Beulich
>>> On 16.01.17 at 14:04, wrote: > The chageset/version/compile information is currently exported as a set of > function calls into a separate translation unit, which is inefficient for all > callers. > > Replace the function calls with externs pointing appropriately

[Xen-devel] [PATCH] xen/common: Drop function calls for Xen compile/version information

2017-01-16 Thread Andrew Cooper
The chageset/version/compile information is currently exported as a set of function calls into a separate translation unit, which is inefficient for all callers. Replace the function calls with externs pointing appropriately into .rodata, which allows all users to generate code referencing the