Re: [Xen-devel] [PATCH] xen/xsm: Annotate xsm_initcall() data as const

2016-06-09 Thread Andrew Cooper
On 09/06/16 15:26, Daniel De Graaf wrote: > On 06/09/2016 05:58 AM, Andrew Cooper wrote: >> Additionally, link it adjacently to the other constant init data. >> >> Signed-off-by: Andrew Cooper > > I think this section can actually be removed instead: it only has > one user, additional users will n

Re: [Xen-devel] [PATCH] xen/xsm: Annotate xsm_initcall() data as const

2016-06-09 Thread Daniel De Graaf
On 06/09/2016 05:58 AM, Andrew Cooper wrote: Additionally, link it adjacently to the other constant init data. Signed-off-by: Andrew Cooper I think this section can actually be removed instead: it only has one user, additional users will need special switching code added anyway, and it should

Re: [Xen-devel] [PATCH] xen/xsm: Annotate xsm_initcall() data as const

2016-06-09 Thread Jan Beulich
>>> On 09.06.16 at 11:58, wrote: > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -51,7 +51,7 @@ typedef void (*xsm_initcall_t)(void); > extern xsm_initcall_t __xsm_initcall_start[], __xsm_initcall_end[]; > > #define xsm_initcall(fn) \ > -static xsm_initcall_t __initcall_##

[Xen-devel] [PATCH] xen/xsm: Annotate xsm_initcall() data as const

2016-06-09 Thread Andrew Cooper
Additionally, link it adjacently to the other constant init data. Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf CC: Jan Beulich CC: Stefano Stabellini CC: Julien Grall --- xen/arch/arm/xen.lds.S | 9 - xen/arch/x86/xen.lds.S | 9 - xen/include/xsm/xsm.h | 2 +- 3 file