Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 13:32 +0100, Julien Grall wrote: > Hi Chris, > > On 17/07/15 21:48, Chris (Christopher) Brand wrote: > > nr_mods is set in add_boot_module() to the number of module > > array elements used. This function also ensures that nr_mods > > never exceeds MAX_MODULES (the size of the

Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-20 Thread Julien Grall
Hi Chris, On 17/07/15 21:48, Chris (Christopher) Brand wrote: > nr_mods is set in add_boot_module() to the number of module > array elements used. This function also ensures that nr_mods > never exceeds MAX_MODULES (the size of the array). When looping > through the array, the correct maximum inde

Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-17 Thread Chris (Christopher) Brand
> It looks like the mail as been sent in HTML. Can you resend it in plain text? Re-sent, hopefully correctly this time. Chris ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-17 Thread Chris (Christopher) Brand
nr_mods is set in add_boot_module() to the number of module array elements used. This function also ensures that nr_mods never exceeds MAX_MODULES (the size of the array). When looping through the array, the correct maximum index is "nr_mods-1", not "nr_mods". If the array is full, using the latter

Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-17 Thread Julien Grall
Hi Christopher, Thank you for the patch. It looks like the mail as been sent in HTML. Can you resend it in plain text? You also need to cc the maintainers of the code you are modifying (I've CCed them this time). You can give a look to [1] to know how to send correctly the patch. On 16/07/15

[Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-16 Thread Chris (Christopher) Brand
nr_mods is set in add_boot_module() to the number of module array elements used. This function also ensures that nr_mods never exceeds MAX_MODULES (the size of the array). When looping through the array, the correct maximum index is "nr_mods-1", not "nr_mods". If the array is full, using the latter