Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-17 Thread Stefano Stabellini
On Thu, 16 Jun 2016, Juergen Gross wrote: > On 16/06/16 15:07, Stefano Stabellini wrote: > > On Thu, 16 Jun 2016, Juergen Gross wrote: > >> On 16/06/16 12:54, Jan Beulich wrote: > >> On 16.06.16 at 12:02, wrote: > In case the word size of the domU and qemu running the qdisk backend >

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Juergen Gross
On 16/06/16 15:07, Stefano Stabellini wrote: > On Thu, 16 Jun 2016, Juergen Gross wrote: >> On 16/06/16 12:54, Jan Beulich wrote: >> On 16.06.16 at 12:02, wrote: In case the word size of the domU and qemu running the qdisk backend differ BLKIF_OP_DISCARD will not work reliably, as th

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Stefano Stabellini
On Thu, 16 Jun 2016, Juergen Gross wrote: > On 16/06/16 12:54, Jan Beulich wrote: > On 16.06.16 at 12:02, wrote: > >> In case the word size of the domU and qemu running the qdisk backend > >> differ BLKIF_OP_DISCARD will not work reliably, as the request > >> structure in the ring have differ

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Paul Durrant
2 > >> To: qemu-de...@nongnu.org; xen-de...@lists.xensource.com > >> Cc: Anthony Perard; Juergen Gross; sstabell...@kernel.org; > >> kra...@redhat.com > >> Subject: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 > >> word size mix > >>

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Juergen Gross
hony Perard; Juergen Gross; sstabell...@kernel.org; >> kra...@redhat.com >> Subject: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 >> word size mix >> >> In case the word size of the domU and qemu running the qdisk backend >> differ BLKIF_OP_DISC

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Paul Durrant
@redhat.com > Subject: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 > word size mix > > In case the word size of the domU and qemu running the qdisk backend > differ BLKIF_OP_DISCARD will not work reliably, as the request > structure in the ring have different layout

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Jan Beulich
>>> On 16.06.16 at 13:04, wrote: > On 16/06/16 12:54, Jan Beulich wrote: > On 16.06.16 at 12:02, wrote: >>> In case the word size of the domU and qemu running the qdisk backend >>> differ BLKIF_OP_DISCARD will not work reliably, as the request >>> structure in the ring have different layouts

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Juergen Gross
On 16/06/16 12:54, Jan Beulich wrote: On 16.06.16 at 12:02, wrote: >> In case the word size of the domU and qemu running the qdisk backend >> differ BLKIF_OP_DISCARD will not work reliably, as the request >> structure in the ring have different layouts for different word size. >> >> Correct t

Re: [Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Jan Beulich
>>> On 16.06.16 at 12:02, wrote: > In case the word size of the domU and qemu running the qdisk backend > differ BLKIF_OP_DISCARD will not work reliably, as the request > structure in the ring have different layouts for different word size. > > Correct this by copying the request structure in cas

[Xen-devel] [PATCH] xen: fix qdisk BLKIF_OP_DISCARD for 32/64 word size mix

2016-06-16 Thread Juergen Gross
In case the word size of the domU and qemu running the qdisk backend differ BLKIF_OP_DISCARD will not work reliably, as the request structure in the ring have different layouts for different word size. Correct this by copying the request structure in case of different word size element by element