Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/7/2016 2:38 PM, Andrew Cooper wrote: On 07/03/16 09:12, Tamas K Lengyel wrote: On Mon, Mar 7, 2016 at 9:22 AM, Corneliu ZUZU > wrote: On 3/3/2016 4:10 PM, Corneliu ZUZU wrote: Then, QUESTIONS (FOR VM-EVENTS &

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 07/03/16 09:12, Tamas K Lengyel wrote: > > > On Mon, Mar 7, 2016 at 9:22 AM, Corneliu ZUZU > wrote: > > On 3/3/2016 4:10 PM, Corneliu ZUZU wrote: > > Then, > QUESTIONS (FOR VM-EVENTS & ARM MAINTAINERS ESPECIALLY): > >

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/7/2016 2:07 PM, Corneliu ZUZU wrote: On 3/7/2016 11:45 AM, Tamas K Lengyel wrote: On Mon, Mar 7, 2016 at 10:31 AM, Corneliu ZUZU > wrote: On 3/7/2016 11:12 AM, Tamas K Lengyel wrote: EPT is not really required for CR3

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/7/2016 11:45 AM, Tamas K Lengyel wrote: On Mon, Mar 7, 2016 at 10:31 AM, Corneliu ZUZU > wrote: On 3/7/2016 11:12 AM, Tamas K Lengyel wrote: EPT is not really required for CR3 monitoring, it just has been the case that

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On Mon, Mar 7, 2016 at 10:31 AM, Corneliu ZUZU wrote: > On 3/7/2016 11:12 AM, Tamas K Lengyel wrote: > > EPT is not really required for CR3 monitoring, it just has been the case > that vm_events have been only implemented for hap-enabled domains. > > > I suppose this is

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/7/2016 11:12 AM, Tamas K Lengyel wrote: EPT is not really required for CR3 monitoring, it just has been the case that vm_events have been only implemented for hap-enabled domains. I suppose this is not valid for vm-events in their entirety, right? I mean it seems to me that @ least for

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On Mon, Mar 7, 2016 at 9:22 AM, Corneliu ZUZU wrote: > On 3/3/2016 4:10 PM, Corneliu ZUZU wrote: > >> Then, >> QUESTIONS (FOR VM-EVENTS & ARM MAINTAINERS ESPECIALLY): >> >> Q1) [...] >> >> Q2) [...] >> >> Q3) [...] >> >> Q4) [...] >> > > Hey all, > > I have a question

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/3/2016 4:10 PM, Corneliu ZUZU wrote: Then, QUESTIONS (FOR VM-EVENTS & ARM MAINTAINERS ESPECIALLY): Q1) [...] Q2) [...] Q3) [...] Q4) [...] Hey all, I have a question relating to this part of code @ vmx_update_guest_cr: if ( paging_mode_hap(v->domain) ) {

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/3/2016 4:10 PM, Corneliu ZUZU wrote: Then, QUESTIONS (FOR VM-EVENTS & ARM MAINTAINERS ESPECIALLY): Q1) [...] Q2) [...] Q3) [...] Q4) [...] JSYK, I've realized I can find the answer for these easily (besides Q2, for which Razvan already gave feedback) with some tests (as soon as I

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

>>> With that said, another thing crossed my mind. Since the DENY flag will >>> be implemented for ARM w/ the next >>> revision and the actual write will be done on the scheduler tail, >>> similarly to X86 ((hvm_do_resume), wouldn't >>> it be good if we separated the code that checks

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/3/2016 8:51 PM, Razvan Cojocaru wrote: On 03/03/2016 08:04 PM, Corneliu ZUZU wrote: On 3/3/2016 6:15 PM, Razvan Cojocaru wrote: On 03/03/2016 04:10 PM, Corneliu ZUZU wrote: Q2) About VM_EVENT_FLAG_DENY Q2.1) Doesn't it require sync = 1 (i.e. the vcpu to be paused) to work?

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 03/03/2016 08:04 PM, Corneliu ZUZU wrote: > On 3/3/2016 6:15 PM, Razvan Cojocaru wrote: >> On 03/03/2016 04:10 PM, Corneliu ZUZU wrote: >>> Q2) About VM_EVENT_FLAG_DENY >>> >>>Q2.1) >>> Doesn't it require sync = 1 (i.e. the vcpu to be paused) to work? >>> If so, shouldn't we call

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/3/2016 6:15 PM, Razvan Cojocaru wrote: On 03/03/2016 04:10 PM, Corneliu ZUZU wrote: Q2) About VM_EVENT_FLAG_DENY Q2.1) Doesn't it require sync = 1 (i.e. the vcpu to be paused) to work? If so, shouldn't we call vm_event_register_write_resume only after checking that

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 03/03/2016 04:10 PM, Corneliu ZUZU wrote: > Q2) About VM_EVENT_FLAG_DENY > > Q2.1) > Doesn't it require sync = 1 (i.e. the vcpu to be paused) to work? > If so, shouldn't we call vm_event_register_write_resume only after > checking > that VM_EVENT_FLAG_VCPU_PAUSED flag is set

Re: [Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

On 3/3/2016 4:10 PM, Corneliu ZUZU wrote: The patch was currently tested on an ARMv8 (CONFIG_ARM_64) machine (after applying a fix I'll send soon). Shannon beat me to it with the fix ;) See "[PATCH] arm/timer: fix panic when booting with DT". Corneliu.

[Xen-devel] [PATCH 0/1] ARM: Implement support for write-ctrlreg vm-events

I've decided to include a cover-letter for this patch to ask for some feedback on a few matters (and also to detail the changes that were done here instead of writing that in the commit message). First, DETAILS OF CHANGES: == Moved to common-side: 1) monitor_ctrlreg_bitmask macro 2)