Re: [Xen-devel] [PATCH 01/10 v2] xen/arm: vpl011: Add pl011 uart emulation in Xen

Hi Julien, +unsigned int vpl011_reg_mask[] = {0xff, 0x, 0x}; >>> >>> >>> >>> This should be static. But I don't get what you need that. In the first >>> version, I suggested to re-purpose vgic_reg*_{extract,update} so we can >>> use >>> it here. It would probably need to be

Re: [Xen-devel] [PATCH 01/10 v2] xen/arm: vpl011: Add pl011 uart emulation in Xen

On 05/05/17 12:18, Bhupinder Thakur wrote: Hi Julien, Hi Bhupinder, + +unsigned int vpl011_reg_mask[] = {0xff, 0x, 0x}; This should be static. But I don't get what you need that. In the first version, I suggested to re-purpose vgic_reg*_{extract,update} so we can use it

Re: [Xen-devel] [PATCH 01/10 v2] xen/arm: vpl011: Add pl011 uart emulation in Xen

Hi Julien, >> + >> +unsigned int vpl011_reg_mask[] = {0xff, 0x, 0x}; > > > This should be static. But I don't get what you need that. In the first > version, I suggested to re-purpose vgic_reg*_{extract,update} so we can use > it here. It would probably need to be renamed to

Re: [Xen-devel] [PATCH 01/10 v2] xen/arm: vpl011: Add pl011 uart emulation in Xen

Hi Bhupinder, On 28/04/17 17:01, Bhupinder Thakur wrote: Add emulation code to emulate read/write access to pl011 registers and pl011 interrupts: - Emulate DR read/write by reading and writing from/to the IN and OUT ring buffers and raising an event to the backend when there is

Re: [Xen-devel] [PATCH 01/10 v2] xen/arm: vpl011: Add pl011 uart emulation in Xen

>>> On 28.04.17 at 18:01, wrote: > xen/arch/arm/Kconfig | 5 + > xen/arch/arm/Makefile| 1 + > xen/arch/arm/vpl011.c| 340 > +++ > xen/include/asm-arm/domain.h | 3 + >

Re: [Xen-devel] [PATCH 01/10 v2] xen/arm: vpl011: Add pl011 uart emulation in Xen

On Fri, 28 Apr 2017, Bhupinder Thakur wrote: > Add emulation code to emulate read/write access to pl011 registers > and pl011 interrupts: > > - Emulate DR read/write by reading and writing from/to the IN > and OUT ring buffers and raising an event to the backend when > there is

[Xen-devel] [PATCH 01/10 v2] xen/arm: vpl011: Add pl011 uart emulation in Xen

Add emulation code to emulate read/write access to pl011 registers and pl011 interrupts: - Emulate DR read/write by reading and writing from/to the IN and OUT ring buffers and raising an event to the backend when there is data in the OUT ring buffer and injecting an interrupt