Re: [Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-09-22 Thread Andrew Cooper
On 22/09/17 16:47, George Dunlap wrote: On Fri, Aug 25, 2017 at 6:37 PM, Andrew Cooper wrote: On 25/08/17 17:43, George Dunlap wrote: You don't need __AFL_INIT if you have __AFL_LOOP. Signed-off-by: George Dunlap Really? Is that covered in any documentation? I got the contrary impression

Re: [Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-09-22 Thread George Dunlap
On Fri, Aug 25, 2017 at 6:37 PM, Andrew Cooper wrote: > On 25/08/17 17:43, George Dunlap wrote: >> You don't need __AFL_INIT if you have __AFL_LOOP. >> >> Signed-off-by: George Dunlap > > Really? Is that covered in any documentation? > > I got the contrary impression from whichever version of AF

Re: [Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-09-14 Thread George Dunlap
Ping? I realize this isn't a major feature but it would be nice to get it in for 4.10. -George On Mon, Aug 28, 2017 at 11:34 AM, George Dunlap wrote: > On 08/25/2017 06:37 PM, Andrew Cooper wrote: >> On 25/08/17 17:43, George Dunlap wrote: >>> You don't need __AFL_INIT if you have __AFL_LOOP.

Re: [Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-08-28 Thread George Dunlap
On 08/25/2017 06:37 PM, Andrew Cooper wrote: > On 25/08/17 17:43, George Dunlap wrote: >> You don't need __AFL_INIT if you have __AFL_LOOP. >> >> Signed-off-by: George Dunlap > > Really? Is that covered in any documentation? > > I got the contrary impression from whichever version of AFL I was

Re: [Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-08-25 Thread Andrew Cooper
On 25/08/17 17:43, George Dunlap wrote: > You don't need __AFL_INIT if you have __AFL_LOOP. > > Signed-off-by: George Dunlap Really? Is that covered in any documentation? I got the contrary impression from whichever version of AFL I was using when I put this in, and a quick look over the afl-fu

[Xen-devel] [PATCH 01/14] fuzz/x86_emulate: Remove redundant AFL hook

2017-08-25 Thread George Dunlap
You don't need __AFL_INIT if you have __AFL_LOOP. Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper CC: Jan Beulich --- tools/fuzz/x86_instruction_emulator/afl-harness.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/fuzz/x86_instruction_emulator/afl-