Re: [Xen-devel] [PATCH 01/17] x86emul: split instruction decoding from execution

2016-09-12 Thread Jan Beulich
>>> On 09.09.16 at 20:35, wrote: > On 08/09/16 14:04, Jan Beulich wrote: >> @@ -607,7 +609,7 @@ do{ asm volatile ( >> }) >> #define truncate_ea(ea) truncate_word((ea), ad_bytes) >> >> -#define mode_64bit() (def_ad_bytes == 8) >> +#define mode_64bit() (ctxt->addr_size == 64) >> >> #define fa

Re: [Xen-devel] [PATCH 01/17] x86emul: split instruction decoding from execution

2016-09-09 Thread Andrew Cooper
On 08/09/16 14:04, Jan Beulich wrote: > This is only the mechanical part, a subsequent patch will make non- > mechanical adjustments to actually do all decoding in this new > function. > > Signed-off-by: Jan Beulich > > --- a/xen/arch/x86/x86_emulate/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate/

[Xen-devel] [PATCH 01/17] x86emul: split instruction decoding from execution

2016-09-08 Thread Jan Beulich
This is only the mechanical part, a subsequent patch will make non- mechanical adjustments to actually do all decoding in this new function. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -48,7 +48,9 @@ /* All operands are