Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-05-03 Thread Julien Grall
Hi Bhupinder, Title: Please avoid the term pfn and use gfn or mfn. On 28/04/17 17:01, Bhupinder Thakur wrote: 1. Add two new domctl API to: - Allocate a new event channel for sending/receiving events to/from Xen. - Map the PFN allocted by the toolstack to be used as IN/OUT ring buffers.

Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-05-02 Thread Jan Beulich
>>> On 02.05.17 at 11:58, wrote: >>> +case XEN_DOMCTL_vuart_op: >>> +ret = -EOPNOTSUPP; >>> +break; >> >> There should be no need for such an addition. > > This check was added to return a failure if user tries to call the > vuart domctl in case of x86 (wrong user configuratio

Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-05-02 Thread Bhupinder Thakur
Hi Jan, >> +case XEN_DOMCTL_vuart_op: >> +ret = -EOPNOTSUPP; >> +break; > > There should be no need for such an addition. This check was added to return a failure if user tries to call the vuart domctl in case of x86 (wrong user configuration). If this check is not there will

Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-05-02 Thread Bhupinder Thakur
Hi Jan, On 2 May 2017 at 13:09, Jan Beulich wrote: On 28.04.17 at 21:23, wrote: >> On Fri, 28 Apr 2017, Bhupinder Thakur wrote: >>> --- a/xen/include/public/domctl.h >>> +++ b/xen/include/public/domctl.h >>> @@ -1138,6 +1138,15 @@ struct xen_domctl_psr_cat_op { >>> uint32_t target;

Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-05-02 Thread Jan Beulich
>>> On 28.04.17 at 18:01, wrote: > --- a/xen/arch/x86/domctl.c > +++ b/xen/arch/x86/domctl.c > @@ -1465,6 +1465,10 @@ long arch_do_domctl( > recalculate_cpuid_policy(d); > break; > > +case XEN_DOMCTL_vuart_op: > +ret = -EOPNOTSUPP; > +break; There should be

Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-05-02 Thread Jan Beulich
>>> On 28.04.17 at 21:23, wrote: > On Fri, 28 Apr 2017, Bhupinder Thakur wrote: >> --- a/xen/include/public/domctl.h >> +++ b/xen/include/public/domctl.h >> @@ -1138,6 +1138,15 @@ struct xen_domctl_psr_cat_op { >> uint32_t target;/* IN */ >> uint64_t data; /* IN/OUT */ >> }; >>

Re: [Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-04-28 Thread Stefano Stabellini
On Fri, 28 Apr 2017, Bhupinder Thakur wrote: > 1. Add two new domctl API to: > - Allocate a new event channel for sending/receiving events to/from Xen. > - Map the PFN allocted by the toolstack to be used as IN/OUT ring buffers. > > Xen will communicate with xenconsole over the ring buffer

[Xen-devel] [PATCH 02/10 v2] xen/arm: vpl011: Add new vuart domctl interface to setup pfn and evtchn

2017-04-28 Thread Bhupinder Thakur
1. Add two new domctl API to: - Allocate a new event channel for sending/receiving events to/from Xen. - Map the PFN allocted by the toolstack to be used as IN/OUT ring buffers. Xen will communicate with xenconsole over the ring buffer and the event channel to transmit and receive pl011 da