Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-22 Thread Stefano Stabellini
On Wed, 22 Mar 2017, Mark Rutland wrote: > On Wed, Mar 22, 2017 at 10:54:11AM -0700, Stefano Stabellini wrote: > > When we receive an SError in Xen, we determine if it should be injected > > into the guest or "handled" in Xen (by "handle" I mean crash the > > system). In case it should be injected

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-22 Thread Mark Rutland
On Wed, Mar 22, 2017 at 10:54:11AM -0700, Stefano Stabellini wrote: > When we receive an SError in Xen, we determine if it should be injected > into the guest or "handled" in Xen (by "handle" I mean crash the > system). In case it should be injected into the guest, we set the > relevant bit in vcpu

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-22 Thread Julien Grall
Hi Stefano, On 22/03/17 17:54, Stefano Stabellini wrote: On Wed, 22 Mar 2017, Marc Zyngier wrote: On 22/03/17 12:45, Mark Rutland wrote: On Wed, Mar 22, 2017 at 12:16:20PM +, Julien Grall wrote: (CC Mark for the TLB question) [Adding Marc since he should understand this better than I do

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-22 Thread Stefano Stabellini
On Wed, 22 Mar 2017, Marc Zyngier wrote: > On 22/03/17 12:45, Mark Rutland wrote: > > On Wed, Mar 22, 2017 at 12:16:20PM +, Julien Grall wrote: > >> (CC Mark for the TLB question) > > > > [Adding Marc since he should understand this better than I do] > > > > I've trimmed a lot of context here

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-22 Thread Marc Zyngier
On 22/03/17 12:45, Mark Rutland wrote: > On Wed, Mar 22, 2017 at 12:16:20PM +, Julien Grall wrote: >> (CC Mark for the TLB question) > > [Adding Marc since he should understand this better than I do] > > I've trimmed a lot of context here, since it wasn't clear if it was > relevant to the que

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-22 Thread Mark Rutland
On Wed, Mar 22, 2017 at 12:16:20PM +, Julien Grall wrote: > (CC Mark for the TLB question) [Adding Marc since he should understand this better than I do] I've trimmed a lot of context here, since it wasn't clear if it was relevant to the question. If there's something I've missed, please poin

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-22 Thread Julien Grall
(CC Mark for the TLB question) Hi Stefano, On 21/03/17 00:31, Stefano Stabellini wrote: On Thu, 16 Mar 2017, Julien Grall wrote: Hi Stefano On 03/16/2017 10:33 PM, Stefano Stabellini wrote: On Wed, 15 Mar 2017, Julien Grall wrote: Hi Wei, On 15/03/17 08:34, Wei Chen wrote: On 2017/3/15 8:

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-20 Thread Stefano Stabellini
On Thu, 16 Mar 2017, Julien Grall wrote: > Hi Stefano > > On 03/16/2017 10:33 PM, Stefano Stabellini wrote: > > On Wed, 15 Mar 2017, Julien Grall wrote: > > > Hi Wei, > > > > > > On 15/03/17 08:34, Wei Chen wrote: > > > > On 2017/3/15 8:25, Stefano Stabellini wrote: > > > > > On Mon, 13 Mar 2017,

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-16 Thread Julien Grall
Hi Stefano On 03/16/2017 10:33 PM, Stefano Stabellini wrote: On Wed, 15 Mar 2017, Julien Grall wrote: Hi Wei, On 15/03/17 08:34, Wei Chen wrote: On 2017/3/15 8:25, Stefano Stabellini wrote: On Mon, 13 Mar 2017, Wei Chen wrote: Different domains may have different HCR_EL2 flags. For example,

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-16 Thread Stefano Stabellini
On Wed, 15 Mar 2017, Julien Grall wrote: > Hi Wei, > > On 15/03/17 08:34, Wei Chen wrote: > > On 2017/3/15 8:25, Stefano Stabellini wrote: > > > On Mon, 13 Mar 2017, Wei Chen wrote: > > > > Different domains may have different HCR_EL2 flags. For example, the > > > > 64-bit domain needs HCR_RW flag

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-16 Thread Wei Chen
Hi Julien, On 2017/3/15 19:12, Julien Grall wrote: > Hi Wei, > > On 15/03/17 08:34, Wei Chen wrote: >> On 2017/3/15 8:25, Stefano Stabellini wrote: >>> On Mon, 13 Mar 2017, Wei Chen wrote: Different domains may have different HCR_EL2 flags. For example, the 64-bit domain needs HCR_RW fla

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-15 Thread Julien Grall
Hi Wei, On 15/03/17 08:34, Wei Chen wrote: On 2017/3/15 8:25, Stefano Stabellini wrote: On Mon, 13 Mar 2017, Wei Chen wrote: Different domains may have different HCR_EL2 flags. For example, the 64-bit domain needs HCR_RW flag but the 32-bit does not need it. So we give each domain a default HC

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-15 Thread Wei Chen
On 2017/3/15 8:25, Stefano Stabellini wrote: > On Mon, 13 Mar 2017, Wei Chen wrote: >> Different domains may have different HCR_EL2 flags. For example, the >> 64-bit domain needs HCR_RW flag but the 32-bit does not need it. So >> we give each domain a default HCR_EL2 value and save it in the VCPU's

Re: [Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-14 Thread Stefano Stabellini
On Mon, 13 Mar 2017, Wei Chen wrote: > Different domains may have different HCR_EL2 flags. For example, the > 64-bit domain needs HCR_RW flag but the 32-bit does not need it. So > we give each domain a default HCR_EL2 value and save it in the VCPU's > context. > > HCR_EL2 register has only one bit

[Xen-devel] [PATCH 02/18] xen/arm: Restore HCR_EL2 register

2017-03-13 Thread Wei Chen
Different domains may have different HCR_EL2 flags. For example, the 64-bit domain needs HCR_RW flag but the 32-bit does not need it. So we give each domain a default HCR_EL2 value and save it in the VCPU's context. HCR_EL2 register has only one bit can be updated automatically without explicit wr