Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-07 Thread Bhupinder Thakur
Hi Stefano, >> >> >> >> > It looks like you are reusing the libxl__device_console_add call >> >> >> >> > for the >> >> >> >> > main PV console for the domain, to also add the vuart nodes to >> >> >> >> > xenstore. >> >> >> >> > >> >> >> >> > I don't think it is a good idea to mix the two. I sugg

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-05 Thread Stefano Stabellini
On Fri, 5 May 2017, Bhupinder Thakur wrote: > Hi Stefano, > > >> >> >> > It looks like you are reusing the libxl__device_console_add call > >> >> >> > for the > >> >> >> > main PV console for the domain, to also add the vuart nodes to > >> >> >> > xenstore. > >> >> >> > > >> >> >> > I don't thin

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-05 Thread Bhupinder Thakur
Hi Stefano, >> >> >> > It looks like you are reusing the libxl__device_console_add call for >> >> >> > the >> >> >> > main PV console for the domain, to also add the vuart nodes to >> >> >> > xenstore. >> >> >> > >> >> >> > I don't think it is a good idea to mix the two. I suggest to >> >> >> >

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-04 Thread Stefano Stabellini
On Fri, 5 May 2017, Bhupinder Thakur wrote: > Hi, > > > >> >> > It looks like you are reusing the libxl__device_console_add call for > >> >> > the > >> >> > main PV console for the domain, to also add the vuart nodes to > >> >> > xenstore. > >> >> > > >> >> > I don't think it is a good idea to

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-04 Thread Bhupinder Thakur
Hi, >> >> > It looks like you are reusing the libxl__device_console_add call for the >> >> > main PV console for the domain, to also add the vuart nodes to xenstore. >> >> > >> >> > I don't think it is a good idea to mix the two. I suggest to introduce a >> >> > new libxl__device call to introduc

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-03 Thread Stefano Stabellini
On Wed, 3 May 2017, Bhupinder Thakur wrote: > Hi, > > >> > It looks like you are reusing the libxl__device_console_add call for the > >> > main PV console for the domain, to also add the vuart nodes to xenstore. > >> > > >> > I don't think it is a good idea to mix the two. I suggest to introduce a

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-03 Thread Bhupinder Thakur
Hi, >> > It looks like you are reusing the libxl__device_console_add call for the >> > main PV console for the domain, to also add the vuart nodes to xenstore. >> > >> > I don't think it is a good idea to mix the two. I suggest to introduce a >> > new libxl__device call to introduce the vuart node

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-01 Thread Stefano Stabellini
On Mon, 1 May 2017, Bhupinder Thakur wrote: > Hi Stefano, > > >> diff --git a/tools/libxl/libxl_console.c b/tools/libxl/libxl_console.c > >> index 446e766..ef3bd44 100644 > >> --- a/tools/libxl/libxl_console.c > >> +++ b/tools/libxl/libxl_console.c > >> @@ -67,6 +67,9 @@ int libxl_console_exec(lib

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-05-01 Thread Bhupinder Thakur
Hi Stefano, >> diff --git a/tools/libxl/libxl_console.c b/tools/libxl/libxl_console.c >> index 446e766..ef3bd44 100644 >> --- a/tools/libxl/libxl_console.c >> +++ b/tools/libxl/libxl_console.c >> @@ -67,6 +67,9 @@ int libxl_console_exec(libxl_ctx *ctx, uint32_t domid, int >> cons_num, >> cas

Re: [Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-04-28 Thread Stefano Stabellini
On Fri, 28 Apr 2017, Bhupinder Thakur wrote: > Add two new parameters to the xen store to be used by xenconsoled: > - newly allocated PFN to be used as IN/OUT ring buffer > - get a new event channel allocated by Xen using a domctl call > > These paramters are added to xenstore only if vuar

[Xen-devel] [PATCH 06/10 v2] xen/arm: vpl011: Add vuart ring-buf and evtchn to xenstore

2017-04-28 Thread Bhupinder Thakur
Add two new parameters to the xen store to be used by xenconsoled: - newly allocated PFN to be used as IN/OUT ring buffer - get a new event channel allocated by Xen using a domctl call These paramters are added to xenstore only if vuart console is enabled by the user. Signed-off-by: Bhupi