Re: [Xen-devel] [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART

2016-09-14 Thread Jan Beulich
>>> On 13.09.16 at 19:35, wrote: > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -1,6 +1,6 @@ > config HAS_NS16550 > - bool > - default y > + bool "NS16550 UART" if EXPERT = "y" This need more adjustment: HAS_* options should never have

Re: [Xen-devel] [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART

2016-09-14 Thread Julien Grall
Hello Derek, On 13/09/16 18:35, Derek Straka wrote: Allows for the conditional inclusion of NS16550 UART driver on the x86 platform rather than having it always enabled. The default configuration for the HAS_NS16550 option remains 'y' on x86, so the behavior out of the box remains unchanged.

Re: [Xen-devel] [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART

2016-09-13 Thread Andrew Cooper
On 13/09/16 18:35, Derek Straka wrote: > Allows for the conditional inclusion of NS16550 UART driver on the x86 > platform > rather than having it always enabled. > > The default configuration for the HAS_NS16550 option remains 'y' on x86, so > the > behavior out of the box remains unchanged.

[Xen-devel] [PATCH 1/2] x86: add a user configurable Kconfig option for the NS16550 UART

2016-09-13 Thread Derek Straka
Allows for the conditional inclusion of NS16550 UART driver on the x86 platform rather than having it always enabled. The default configuration for the HAS_NS16550 option remains 'y' on x86, so the behavior out of the box remains unchanged. The addition of the option allows advanced users to