Re: [Xen-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-09-20 Thread Stefano Stabellini
Ping? On Thu, 7 Sep 2017, Anthony PERARD wrote: > On Mon, Aug 21, 2017 at 04:12:27PM -0700, Stefano Stabellini wrote: > > Anthony, > > > > The code looks good. I tested this patch with Linux guests and seems to > > work OK, can you also confirm? > > I've tested with Linux as well, an HVM guess,

Re: [Xen-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-09-07 Thread Anthony PERARD
On Mon, Aug 21, 2017 at 04:12:27PM -0700, Stefano Stabellini wrote: > Anthony, > > The code looks good. I tested this patch with Linux guests and seems to > work OK, can you also confirm? I've tested with Linux as well, an HVM guess, I did not spot any issue. But, the code compiles with warnings

Re: [Xen-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-08-23 Thread Owen Smith
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 22 August 2017 00:12 > To: Owen Smith > Cc: qemu-de...@nongnu.org; xen-de...@lists.xenproject.org; > sstabell...@kernel.org; Anthony Perard > Subject: Re: [PATCH 1/2 v3] xenfb: Use Input Handlers direc

Re: [Xen-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-08-21 Thread Stefano Stabellini
Anthony, The code looks good. I tested this patch with Linux guests and seems to work OK, can you also confirm? One comment below. On Wed, 26 Jul 2017, Owen Smith wrote: > Avoid the unneccessary calls through the input-legacy.c file by > using the qemu_input_handler_*() calls directly. This did

[Xen-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-07-26 Thread Owen Smith
Avoid the unneccessary calls through the input-legacy.c file by using the qemu_input_handler_*() calls directly. This did require reworking the event and sync handlers and a direct mapping from QEMU's qcodes to linux KEY_* identifiers required by the ring protocol. Removes the scancode2linux mappin