Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-10-02 Thread Jiang, Yunhong
> >> Sent: Tuesday, September 29, 2015 12:59 AM > >> To: xen-devel > >> Cc: George Dunlap; Andrew Cooper; Tian, Kevin; Keir Fraser; Nakajima, Jun > >> Subject: Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU > >> mapping updates > >

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-30 Thread Jan Beulich
George Dunlap; Andrew Cooper; Tian, Kevin; Keir Fraser; Nakajima, Jun >> Subject: Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU >> mapping updates >> >> >>> On 21.09.15 at 16:02, wrote: >> > In the EPT case permission changes should

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-29 Thread Jiang, Yunhong
gt; Subject: Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU > mapping updates > > >>> On 21.09.15 at 16:02, wrote: > > In the EPT case permission changes should also result in updates or > > TLB flushes. > > > > In the NPT case the old MFN

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-29 Thread Wei Liu
On Tue, Sep 29, 2015 at 04:47:00AM -0600, Jan Beulich wrote: > >>> On 23.09.15 at 16:00, wrote: > > On Tue, Sep 22, 2015 at 08:15:39AM -0600, Jan Beulich wrote: > >> >>> On 21.09.15 at 16:02, wrote: > >> > In the EPT case permission changes should also result in updates or > >> > TLB flushes. > >

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-29 Thread Jan Beulich
>>> On 23.09.15 at 16:00, wrote: > On Tue, Sep 22, 2015 at 08:15:39AM -0600, Jan Beulich wrote: >> >>> On 21.09.15 at 16:02, wrote: >> > In the EPT case permission changes should also result in updates or >> > TLB flushes. >> > >> > In the NPT case the old MFN does not depend on the new entry be

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-29 Thread Jan Beulich
>>> On 21.09.15 at 16:02, wrote: > In the EPT case permission changes should also result in updates or > TLB flushes. > > In the NPT case the old MFN does not depend on the new entry being > valid (but solely on the old one), and the need to update or TLB-flush > again also depends on permission

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-29 Thread Jan Beulich
>>> On 28.09.15 at 18:32, wrote: > On 21/09/15 15:02, Jan Beulich wrote: >> In the EPT case permission changes should also result in updates or >> TLB flushes. >> >> In the NPT case the old MFN does not depend on the new entry being >> valid (but solely on the old one), and the need to update or

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-28 Thread George Dunlap
On 28/09/15 17:32, George Dunlap wrote: > On 21/09/15 15:02, Jan Beulich wrote: >> In the EPT case permission changes should also result in updates or >> TLB flushes. >> >> In the NPT case the old MFN does not depend on the new entry being >> valid (but solely on the old one), and the need to updat

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-28 Thread George Dunlap
On 21/09/15 15:02, Jan Beulich wrote: > In the EPT case permission changes should also result in updates or > TLB flushes. > > In the NPT case the old MFN does not depend on the new entry being > valid (but solely on the old one), and the need to update or TLB-flush > again also depends on permiss

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-28 Thread Jan Beulich
>>> On 28.09.15 at 11:06, wrote: On 28.09.15 at 10:55, wrote: >> Acked-by: Kevin Tian > > Thanks, but quite a bit more important would have been a reply > to this > >>>In addition to the fixes here it looks to me as if both EPT and >>>NPT/shadow code lack invalidation of IOMMU side paging

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-28 Thread Jan Beulich
>>> On 28.09.15 at 10:55, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, September 21, 2015 10:03 PM >> >> In the EPT case permission changes should also result in updates or >> TLB flushes. >> >> In the NPT case the old MFN does not depend on the new entry being >> val

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-28 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Monday, September 21, 2015 10:03 PM > > In the EPT case permission changes should also result in updates or > TLB flushes. > > In the NPT case the old MFN does not depend on the new entry being > valid (but solely on the old one), and the nee

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-24 Thread Jan Beulich
>>> On 21.09.15 at 16:02, wrote: > In the EPT case permission changes should also result in updates or > TLB flushes. > > In the NPT case the old MFN does not depend on the new entry being > valid (but solely on the old one), and the need to update or TLB-flush > again also depends on permission

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-23 Thread Wei Liu
On Tue, Sep 22, 2015 at 08:15:39AM -0600, Jan Beulich wrote: > >>> On 21.09.15 at 16:02, wrote: > > In the EPT case permission changes should also result in updates or > > TLB flushes. > > > > In the NPT case the old MFN does not depend on the new entry being > > valid (but solely on the old one)

Re: [Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-22 Thread Jan Beulich
>>> On 21.09.15 at 16:02, wrote: > In the EPT case permission changes should also result in updates or > TLB flushes. > > In the NPT case the old MFN does not depend on the new entry being > valid (but solely on the old one), and the need to update or TLB-flush > again also depends on permission

[Xen-devel] [PATCH 1/3] x86/p2m: tighten conditions of IOMMU mapping updates

2015-09-21 Thread Jan Beulich
In the EPT case permission changes should also result in updates or TLB flushes. In the NPT case the old MFN does not depend on the new entry being valid (but solely on the old one), and the need to update or TLB-flush again also depends on permission changes. In the shadow mode case, iommu_hap_p