Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
On Mon, Dec 19, 2016 at 7:53 PM, Doug Goldstein wrote: > On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: >> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >>> Signed-off-by: Alistair Francis >> >> >> Why? > > *adjusts his distro maintainer hat* It's considered really bad form

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Alistair Francis
On Tue, Dec 20, 2016 at 9:21 AM, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote: >> On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote: >> > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: >> >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wil

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Konrad Rzeszutek Wilk
On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote: > On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote: > > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: > >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: > >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Fr

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Doug Goldstein
On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: Signed-off-by: Alistair Francis >>> >>> >>> Why? >> >

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-20 Thread Konrad Rzeszutek Wilk
On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote: > On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: > > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: > >> Signed-off-by: Alistair Francis > > > > > > Why? > > *adjusts his distro maintainer hat* It's considered

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-19 Thread Doug Goldstein
On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >> Signed-off-by: Alistair Francis > > > Why? *adjusts his distro maintainer hat* It's considered really bad form for upstreams to push -Werror in their projects. However I know

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-19 Thread Alistair Francis
On Sat, Dec 17, 2016 at 7:51 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: >> Signed-off-by: Alistair Francis > > > Why? Hey Konrad, The problem that I have is that we build Xen releases in buildroot. As things change (GCC version usually)

Re: [Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-17 Thread Konrad Rzeszutek Wilk
On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote: > Signed-off-by: Alistair Francis Why? Thanks! > --- > Config.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Config.mk b/Config.mk > index 3ec7367..e3cda81 100644 > --- a/Config.mk > +++ b/Config.mk

[Xen-devel] [PATCH 1/7] Remove hardcoded strict -Werror checking

2016-12-16 Thread Alistair Francis
Signed-off-by: Alistair Francis --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index 3ec7367..e3cda81 100644 --- a/Config.mk +++ b/Config.mk @@ -34,7 +34,7 @@ CONFIG_$(XEN_OS) := y SHELL ?= /bin/sh # Tools to run on system hosting t